Page MenuHomePhabricator
Feed Advanced Search

Dec 14 2015

epriestley updated subscribers of T3554: Implement a `bin/worker kill <criteria>` for batch-flushing tasks from the queue.
Dec 14 2015, 7:19 PM · Restricted Project, Daemons
epriestley closed T7146: Improve administrative UI around backup management, a subtask of T7147: Backup repository data in the Phacility cluster, as Resolved.
Dec 14 2015, 7:17 PM · Phacility
epriestley closed T7146: Improve administrative UI around backup management as Resolved.

This got split out in to a separate tab eventually, and I think is generally in reasonable shape.

Dec 14 2015, 7:17 PM · Phacility
epriestley updated subscribers of T7829: PhabricatorBotFeedNotificationHandler is completely broken and unusable.
Dec 14 2015, 7:01 PM · Conpherence, Phabot
epriestley merged task T6327: Bot feed notify small bugs into T7829: PhabricatorBotFeedNotificationHandler is completely broken and unusable.
Dec 14 2015, 7:01 PM · Chatlog
epriestley updated subscribers of T9825: Remarkup is rendered literally in Diviner.
Dec 14 2015, 7:00 PM · Diviner
epriestley merged task T6310: Parameters description is not Remarkuped into T9825: Remarkup is rendered literally in Diviner.
Dec 14 2015, 7:00 PM · Remarkup, Diviner
epriestley closed T4415: Repair the other half of Project and Revision subscriptions as Wontfix.

This hasn't caused any issues yet and we have no plans to show "stuff you're subscribed to".

Dec 14 2015, 6:49 PM · Projects, Differential
epriestley added a comment to T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.

Haha, okay. Let's just add a link to the transcript.

Dec 14 2015, 6:45 PM · Documentation, Herald
epriestley closed T7399: Fully separate live credentials from development repositories, a subtask of T7400: Deploy real payment credentials in the cluster, as Resolved.
Dec 14 2015, 6:39 PM · Phacility
epriestley closed T7399: Fully separate live credentials from development repositories as Resolved.

I deployed the sbuild and saux tiers after this, and they've been running in production for some time.

Dec 14 2015, 6:39 PM · Phacility
epriestley closed T7399: Fully separate live credentials from development repositories, a subtask of T7163: Convert Phacility file storage to use S3, as Resolved.
Dec 14 2015, 6:39 PM · Files, Phacility
epriestley closed T7399: Fully separate live credentials from development repositories, a subtask of T7401: Make all web hosts use the same SSH host key for VCS SSH traffic, as Resolved.
Dec 14 2015, 6:39 PM · Phacility
epriestley added a comment to T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.

Ah, your underlying issue is difficulty understanding why pushes are rejected?

Dec 14 2015, 6:36 PM · Documentation, Herald
epriestley added a comment to T9890: Version and lock search index rebuilds to reduce the cost of runaway writes.

T6281 is an older task discussing a possible deadlock under concurrency conditions in custom field reindexing. I think the versioning / locking approach above is probably the cleanest approach to resolving that, as well.

Dec 14 2015, 6:25 PM · Search
epriestley updated subscribers of T9890: Version and lock search index rebuilds to reduce the cost of runaway writes.
Dec 14 2015, 6:20 PM · Search
epriestley merged task T6281: Custom Field indexes are rebuilt on every ticket change even if the fields did not into T9890: Version and lock search index rebuilds to reduce the cost of runaway writes.
Dec 14 2015, 6:20 PM · Custom Fields
epriestley closed T6903: Notifications now use WebSockets as Resolved.

This has been in production for quite a while.

Dec 14 2015, 6:19 PM · Support, Notifications
epriestley closed T5574: Add a "dry run" mode for Arcanist as Resolved.

I think the revised version of arc land is about as good as we're likely to get. The new documentation is more clear, and the land operation no longer touches any local branches until the last second (or ever, with --hold), behavior is generally better, we restore the starting state if we fail, and the new output is more clear about what arc land is doing.

Dec 14 2015, 6:11 PM · Arcanist
epriestley updated subscribers of T7961: In Herald, don't offer Fields and Actions from uninstalled applications to users writing rules.

Two aspects here, one or both of which may already be partially or fully implemented:

Dec 14 2015, 5:31 PM · Applications, Herald
epriestley updated subscribers of T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.

First: HeraldTestConsoleController is currently a big mess with a huge instanceof block.

Dec 14 2015, 5:28 PM · Documentation, Herald
epriestley closed T4924: Allow `arc diff` to run the main interactive workflow noninteractively as Invalid.

This feature request doesn't have a use case, which we now require. See Contributing Feature Requests and Describing Root Problems.

Dec 14 2015, 5:08 PM · Arcanist
epriestley closed T3871: Allow creation of reports from custom queries as Resolved.

I'm just going to close this out since I think it's mostly superseded by T5307, which discusses this and other actions which would be nice to take with query result sets.

Dec 14 2015, 4:54 PM · Facts
epriestley added a comment to T6049: Implement Phurl, a URL shortener/bookmarking application.

Out pf curiosity, why not use the ... syntax instead of copy-pasting the full URL?

Dec 14 2015, 4:11 PM · Phurl
epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Unknown Object (Differential Revision).
Dec 14 2015, 2:56 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Unknown Object (Differential Revision).
Dec 14 2015, 2:45 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Unknown Object (Differential Revision).
Dec 14 2015, 2:25 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Unknown Object (Differential Revision).
Dec 14 2015, 2:06 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Unknown Object (Differential Revision).
Dec 14 2015, 1:54 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Unknown Object (Differential Revision).
Dec 14 2015, 1:34 PM · Maniphest, Phame, Owners, Arcanist, Conduit
yelirekim awarded T9980: Give administrators better tools for managing Conduit API changes a Grey Medal token.
Dec 14 2015, 12:50 PM · Conduit
epriestley added a subtask for T9980: Give administrators better tools for managing Conduit API changes: T9755: Have conduit call logs actually log the caller.
Dec 14 2015, 12:00 PM · Conduit
epriestley added a parent task for T9755: Have conduit call logs actually log the caller: T9980: Give administrators better tools for managing Conduit API changes.
Dec 14 2015, 12:00 PM · Conduit
epriestley created T9980: Give administrators better tools for managing Conduit API changes.
Dec 14 2015, 12:00 PM · Conduit
epriestley created T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles).
Dec 14 2015, 11:50 AM · Owners, Files, ApplicationSearch
epriestley added a comment to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes.

Yes, but I have some hesitance around adding "search for a string in another string" fields without building better infrastructure first. There's some discussion in D14411#161139.

Dec 14 2015, 11:04 AM · Maniphest, Phame, Owners, Arcanist, Conduit
michaeloa awarded T4548: Support "Mylyn" Eclipse plugin a Like token.
Dec 14 2015, 9:39 AM · Feature Request, Maniphest
epriestley added a comment to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes.

We don't check that the path actually exists -- you might be searching for a deleted path that used to exist, or the repository might have a million branches and it only exists on one, and you might have a thousand different repositories too.

Dec 14 2015, 12:21 AM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a comment to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes.

That result looks correct to me -- if a package includes "/", that means it includes everything under "/" too. So if you search for /x/y/z.cpp, any package that owns /, /x/, /x/y/ or /x/y/z.cpp will be returned, since any package owning a parent also owns the path itself.

Dec 14 2015, 12:14 AM · Maniphest, Phame, Owners, Arcanist, Conduit

Dec 13 2015

epriestley closed T9978: Allow users to watch repositories as Resolved.

At the moment there is no possibilty to watch a repo

Dec 13 2015, 9:49 PM · Feature Request
epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Unknown Object (Differential Revision).
Dec 13 2015, 6:21 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Unknown Object (Differential Revision).
Dec 13 2015, 6:06 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a comment to T9973: `arc land` detached head state with `--hold`.

Broadly, if you're using arc land --hold <feature> to preview changes, there are three ways to proceed:

Dec 13 2015, 4:43 PM · Arcanist, Bug Report
epriestley added a comment to T9973: `arc land` detached head state with `--hold`.

I'm not open to reverting to the old behavior. The new behavior solves a large number of problems for many users, discussed in T9657.

Dec 13 2015, 4:24 PM · Arcanist, Bug Report
epriestley closed T9973: `arc land` detached head state with `--hold` as Resolved by committing Restricted Diffusion Commit.
Dec 13 2015, 4:19 PM · Arcanist, Bug Report
epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Unknown Object (Differential Revision).
Dec 13 2015, 3:49 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Unknown Object (Differential Revision).
Dec 13 2015, 3:36 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Restricted Differential Revision.
Dec 13 2015, 3:03 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Unknown Object (Differential Revision).
Dec 13 2015, 1:29 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Unknown Object (Differential Revision).
Dec 13 2015, 12:06 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a revision to T9973: `arc land` detached head state with `--hold`: Unknown Object (Differential Revision).
Dec 13 2015, 11:10 AM · Arcanist, Bug Report
epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Unknown Object (Differential Revision).
Dec 13 2015, 10:47 AM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Unknown Object (Differential Revision).
Dec 13 2015, 10:35 AM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley closed T9970: new files are empty for arc diff --create and --update as Resolved by committing Restricted Diffusion Commit.
Dec 13 2015, 10:35 AM · Subversion, Arcanist, Bug Report
epriestley added a comment to T9970: new files are empty for arc diff --create and --update .

Thanks for digging into this! That explanation makes SVN's behavior a lot more reasonable.

Dec 13 2015, 10:27 AM · Subversion, Arcanist, Bug Report
epriestley added a revision to T9970: new files are empty for arc diff --create and --update : Unknown Object (Differential Revision).
Dec 13 2015, 10:22 AM · Subversion, Arcanist, Bug Report
cspeckmim awarded T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads a Love token.
Dec 13 2015, 2:57 AM · Mercurial, Arcanist
Luke081515.2 awarded T9905: Upgrading: ApplicationEditor changes in Maniphest a Like token.
Dec 13 2015, 2:44 AM · Maniphest, Installing & Upgrading
epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Unknown Object (Differential Revision).
Dec 13 2015, 12:36 AM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley triaged T9973: `arc land` detached head state with `--hold` as Wishlist priority.
Dec 13 2015, 12:10 AM · Arcanist, Bug Report
epriestley reopened T9973: `arc land` detached head state with `--hold` as "Open".

Sure. The best "Next Step" is to just run arc land <branch> again without --hold, although we can be explicit about that and fill in branch in case it was run as plain arc land originally.

Dec 13 2015, 12:06 AM · Arcanist, Bug Report

Dec 12 2015

epriestley added a comment to T9972: Profile image from Google not being picked up.

The @local part is because I have cluster.instance configured locally, it's normal for it to not be present on regular installs.

Dec 12 2015, 6:46 PM · Auth, Bug Report
epriestley updated the post content for Blog Post: Development Notes (2015 Week 50).
Dec 12 2015, 6:33 PM
epriestley added a comment to T9972: Profile image from Google not being picked up.

There shouldn't be any caches.

Dec 12 2015, 6:32 PM · Auth, Bug Report
epriestley closed T9973: `arc land` detached head state with `--hold` as Wontfix.
  • We can't give arc land the old behavior without breaking other (more common) use cases.
  • You can push directly from the detached head, per above.
  • arc help land is now more clear that merging takes place in a detached state and local branch references are not updated.
  • arc cleanup (T3277) may eventually make it easier to clean up these branches.
  • It sounds like the old workflow was still fairly labor intensive. Writing a script to help you manage submodules might simplify your workflow overall, as a possible workaround. This script could use slightly lower-level operations than arc land (like git operations and arc amend) to give you more control. arc land does not do anything magical, and is just intended as a convenience wrapper around merging in the most common cases.
Dec 12 2015, 6:30 PM · Arcanist, Bug Report
epriestley added a comment to T9970: new files are empty for arc diff --create and --update .

Yes, 6 months is a huge amount of time in the scale of arc, although that version is probably new enough to have D9921 (although I don't know if July 26 is the changes it actually includes, or just the date someone might have published some earlier version, and have no idea what _2 means).

Dec 12 2015, 5:44 PM · Subversion, Arcanist, Bug Report
epriestley added a revision to T9973: `arc land` detached head state with `--hold`: Unknown Object (Differential Revision).
Dec 12 2015, 5:41 PM · Arcanist, Bug Report
epriestley added a comment to T9973: `arc land` detached head state with `--hold`.

The change is merged into the destination branch, but the branch reference is not updated to point to it. The detached HEAD you end up with is the correct state of a merge between the origin branch and the changes you are landing. The documentation could perhaps be more explicit about this.

Dec 12 2015, 5:32 PM · Arcanist, Bug Report
epriestley added a comment to T9970: new files are empty for arc diff --create and --update .

T5555 and D9921 are earlier similar interactions, where file content could be doubled with newly added directories.

Dec 12 2015, 4:39 PM · Subversion, Arcanist, Bug Report
epriestley added a comment to T9970: new files are empty for arc diff --create and --update .

Can you show me the output of arc version?

Dec 12 2015, 4:35 PM · Subversion, Arcanist, Bug Report
epriestley added a comment to T9972: Profile image from Google not being picked up.

I can't reproduce that. Here's what I did:

Dec 12 2015, 4:33 PM · Auth, Bug Report
epriestley reopened T9972: Profile image from Google not being picked up as "Open".
Dec 12 2015, 4:28 PM · Auth, Bug Report
epriestley added a comment to T9973: `arc land` detached head state with `--hold`.

Why are you using --hold if your next steps are the steps that arc land would take anyway?

Dec 12 2015, 4:27 PM · Arcanist, Bug Report
epriestley added a comment to T9973: `arc land` detached head state with `--hold`.

What do you expect it to do?

Dec 12 2015, 4:21 PM · Arcanist, Bug Report
epriestley added a parent task for T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: T9897: Unbeta Feedback on Phame.
Dec 12 2015, 4:09 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a subtask for T9897: Unbeta Feedback on Phame: T9964: Fill in Conduit support infrastructure for ApplicationEditor changes.
Dec 12 2015, 4:09 PM · Phame
epriestley updated the task description for T9897: Unbeta Feedback on Phame.
Dec 12 2015, 4:08 PM · Phame
epriestley added a comment to T9972: Profile image from Google not being picked up.

This should be fixed in HEAD. Thanks for the exceptionally clear report, and let us know if you run into anything else.

Dec 12 2015, 3:55 PM · Auth, Bug Report
epriestley added a comment to T5591: Add default domain to Google auth.

The onscreen instructions for this adapter in the UI are also a bit out of date because the Google console has been updated since we wrote them. This is probably the next change to touch the provider, and should also look at modernizing the instructions.

Dec 12 2015, 3:55 PM · Restricted Project, Restricted Project, Auth
epriestley added a comment to T9972: Profile image from Google not being picked up.

The UI instructions about navigating the dashboard are also a little out of date since that UI has changed, although I was still mostly able to figure out what they meant. I'll leave a note on T5591 to update them when that gets fixed.

Dec 12 2015, 3:53 PM · Auth, Bug Report
epriestley closed T9972: Profile image from Google not being picked up as Resolved by committing Restricted Diffusion Commit.
Dec 12 2015, 3:52 PM · Auth, Bug Report
epriestley claimed T9972: Profile image from Google not being picked up.
Dec 12 2015, 3:52 PM · Auth, Bug Report
epriestley added a revision to T9972: Profile image from Google not being picked up: Unknown Object (Differential Revision).
Dec 12 2015, 3:52 PM · Auth, Bug Report
epriestley added a comment to T5554: arc fails with svn/git/hg non english locales.

For completeness, T9953 / D14735 cleaned up an obscure rough edge on a narrow range of Git versions.

Dec 12 2015, 1:46 PM · Arcanist
epriestley closed T7345: Install PHPExcel in the cluster as Resolved.

This is deployed and working properly.

Dec 12 2015, 12:36 PM · Phacility
epriestley abandoned D14751: Test 2.
Dec 12 2015, 12:32 PM
epriestley updated subscribers of T3967: Build a 2-up preview mode into the fullscreen Remarkup editor.
Dec 12 2015, 12:17 PM · Remarkup
epriestley merged task T9971: Present Markup Preview in [Edit Project] dialogue for Project Description into T3967: Build a 2-up preview mode into the fullscreen Remarkup editor.
Dec 12 2015, 12:17 PM · Remarkup, Projects, Feature Request
epriestley added a comment to T9970: new files are empty for arc diff --create and --update .

I added some properties:

Dec 12 2015, 12:15 PM · Subversion, Arcanist, Bug Report
epriestley retitled D14751: Test 2 from to Test 2.
Dec 12 2015, 12:14 PM
epriestley added a comment to T9970: new files are empty for arc diff --create and --update .

Yes, we can't help with this without better reproduction steps. In particular, I can't reproduce this. Here's what I did:

Dec 12 2015, 4:41 AM · Subversion, Arcanist, Bug Report
epriestley abandoned D14750: Test.
Dec 12 2015, 4:40 AM
epriestley retitled D14750: Test from to Test.
Dec 12 2015, 4:38 AM
epriestley added a comment to T9897: Unbeta Feedback on Phame.

D14748 should fix the double feed stories.

Dec 12 2015, 2:52 AM · Phame
epriestley updated the task description for T9897: Unbeta Feedback on Phame.
Dec 12 2015, 2:51 AM · Phame
epriestley added a revision to T9360: Unbeta Phame: Unknown Object (Differential Revision).
Dec 12 2015, 2:49 AM · Phame
epriestley added a comment to T9360: Unbeta Phame.

The behavior of TITLE and VISIBILITY are also wrong: they emit the current body text, not the body text at the time the change was made.

Dec 12 2015, 2:49 AM · Phame
epriestley added a comment to T9360: Unbeta Phame.

I think this is happening because both the "Title" and "Body" transactions are emitting text:

Dec 12 2015, 2:44 AM · Phame
epriestley added a comment to T7345: Install PHPExcel in the cluster.

This should be ready to go with the deployment tomorrow:

Dec 12 2015, 2:39 AM · Phacility
epriestley updated the post content for Blog Post: Development Notes (2015 Week 50).
Dec 12 2015, 2:08 AM