Page MenuHomePhabricator
Feed Advanced Search

Nov 26 2015

joshuaspence created T9856: array_diff(): Argument #1 is not an array.
Nov 26 2015, 12:06 AM · Paste, Infrastructure
joshuaspence added a comment to T9855: DifferentialChangesSinceLastUpdateField may fail policy checks and prevent mail from sending.

Some more information:

Nov 26 2015, 12:04 AM · Daemons, Differential
joshuaspence created T9855: DifferentialChangesSinceLastUpdateField may fail policy checks and prevent mail from sending.
Nov 26 2015, 12:00 AM · Daemons, Differential

Nov 25 2015

avivey awarded T9854: Support date/time reformatting in Remarkup a Doubloon token.
Nov 25 2015, 11:00 PM · Contributor Onboarding, Restricted Project, Remarkup
joshuaspence created T9854: Support date/time reformatting in Remarkup.
Nov 25 2015, 10:19 PM · Contributor Onboarding, Restricted Project, Remarkup
joshuaspence added a project to T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events: Maniphest.
Nov 25 2015, 7:07 PM · Modernization, Maniphest
joshuaspence created T9852: Inline comments not appearing in mail.
Nov 25 2015, 6:57 PM · Differential
joshuaspence added a project to T9845: Straighten out addTextSection() / addRemarkupSection() in mail body construction: Differential.
Nov 25 2015, 2:50 AM · Differential

Nov 24 2015

joshuaspence deleted Open Source Students 2013.
Nov 24 2015, 8:58 PM
joshuaspence added a comment to T9773: Unit tests are slow.

Sorry about the delay... here's the trace from running /bin/storage upgrade --namespace testT9773_$RANDOM --force --no-adjust --trace:

Nov 24 2015, 8:46 PM · Infrastructure
joshuaspence edited the content of Starmap.
Nov 24 2015, 7:47 PM
joshuaspence added a comment to T9601: Herald rule not working as expected.

Gah, details of the Herald transcript have already been garbage collected.

Nov 24 2015, 7:32 PM · Herald
joshuaspence added a comment to T6049: Implement Phurl, a URL shortener/bookmarking application.

Out pf curiosity, why not use the @{article:...} syntax instead of copy-pasting the full URL?

Nov 24 2015, 7:25 PM · Phurl
joshuaspence added a revision to T9640: Make Phabricator compatible with PHP7: Unknown Object (Differential Revision).
Nov 24 2015, 7:23 PM · Prioritized, Restricted Project, Infrastructure
joshuaspence added a project to T9839: Support Bitbucket Webhook.: Diffusion.
Nov 24 2015, 7:20 PM · Diffusion
epriestley awarded T9789: Make it easier to write custom transaction types a Piece of Eight token.
Nov 24 2015, 5:26 PM · Modernization, Transactions
joshuaspence added a member for Pholio: joshuaspence.
Nov 24 2015, 10:32 AM
joshuaspence added a member for Ponder: joshuaspence.
Nov 24 2015, 10:32 AM
joshuaspence added a member for Modernization: joshuaspence.
Nov 24 2015, 10:29 AM
joshuaspence added a member for Nuance: joshuaspence.
Nov 24 2015, 10:29 AM
joshuaspence added a member for Documentation: joshuaspence.
Nov 24 2015, 10:01 AM
joshuaspence added a member for Countdown: joshuaspence.
Nov 24 2015, 10:01 AM
joshuaspence added a member for ApplicationEditor: joshuaspence.
Nov 24 2015, 10:00 AM

Nov 23 2015

joshuaspence merged task T9831: Opening Changelog 2015.46 shows a PhutilInvalidState exception into T9829: Exception after Updating Phabricator.
Nov 23 2015, 7:35 PM · Phriction
joshuaspence updated subscribers of T9829: Exception after Updating Phabricator.
Nov 23 2015, 7:35 PM · Phriction
joshuaspence added a project to T9827: Provide a more structured way of interfacing with external linters: Lint.
Nov 23 2015, 7:33 PM · Lint, Arcanist
joshuaspence added a comment to Q175: Should I Reuse Device Keys? (Answer 207).

Just wanted to clarify as I'm not entirely sure that I understand... So we currently have a puppet role named phabricator_worker which runs phd daemons. As a step in our puppet scripts, we basically run /usr/src/phabricator/bin/almanac register --device=worker.phabricator.example.com --private-key=/path/to/private.key.

Nov 23 2015, 2:08 AM

Nov 22 2015

joshuaspence renamed T9826: Phriction saved page is not same as previewing one from phriction saved page is not same as previewing one. to Phriction saved page is not same as previewing one.
Nov 22 2015, 8:17 PM · Phriction
joshuaspence added a comment to T9784: `arc patch`: Directory move in SVN patch workflow is implemented erroneously.

@joshuaspence what do you think about this issue?

Nov 22 2015, 7:18 PM · Subversion, Arcanist
joshuaspence renamed T9819: Allow Phurl URLs to reference objects from allow multiple aliases to a phurl to Allow multiple aliases to a Phurl URL.
Nov 22 2015, 2:34 AM · Restricted Project, Phurl
joshuaspence added a comment to T9825: Remarkup is rendered literally in Diviner.

("No time specified" in Phame is a bit odd too, but I think that's been fixed already)

Nov 22 2015, 2:33 AM · Diviner

Nov 21 2015

joshuaspence added a project to T9824: Daemons and Web Have Different Config does not disappear after a reboot of Deamons: Daemons.
Nov 21 2015, 10:27 PM · Daemons
joshuaspence reopened T9825: Remarkup is rendered literally in Diviner as "Open".

I'm assuming that @terrismotox is just playing around.

Nov 21 2015, 10:25 PM · Diviner
joshuaspence added a project to T9825: Remarkup is rendered literally in Diviner: Remarkup.
Nov 21 2015, 9:46 PM · Diviner
joshuaspence created T9825: Remarkup is rendered literally in Diviner.
Nov 21 2015, 9:46 PM · Diviner

Nov 19 2015

joshuaspence added a revision to T1116: Function __phutil_autoload should probably not throw an exception if it is the only registered autoload function: Unknown Object (Differential Revision).
Nov 19 2015, 7:27 PM · libphutil
joshuaspence added a project to Q223: How to restrict outgoing MySQL ports to specific range: Aphront.
Nov 19 2015, 9:12 AM · Aphront
joshuaspence updated Q223: How to restrict outgoing MySQL ports to specific range from How to restrict outgoing aphrontMySQL ports to specific range to How to restrict outgoing MySQL ports to specific range.
Nov 19 2015, 9:12 AM · Aphront
joshuaspence added Q224: Phabricator development - IDE (Answer 260).
Nov 19 2015, 9:09 AM
joshuaspence added a comment to T9815: Fast repository polling on multiple repositories causes 2Hz polling of remote host.

For what it's worth, we have a very similar setup (40ish repositories in Phabricator, all hosted in Gitlab). We have not observed any performance issues such as those described in this ticket.

Nov 19 2015, 8:15 AM · Diffusion, Daemons
joshuaspence renamed T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier from Begin searching for drydock / harbormaster gremlins which prevent builds from starting properly to Begin searching for Drydock / Harbormaster gremlins which prevent builds from starting properly.
Nov 19 2015, 7:32 AM · Harbormaster, Drydock

Nov 18 2015

joshuaspence updated Q209: Is it possible to update Differential dependencies from Conduit? from Is it possible to update differential dependencies from conduit to Is it possible to update Differential dependencies from Conduit?.
Nov 18 2015, 10:05 PM · Differential
joshuaspence updated the answer details for Q210: Unable to understand who the Author/Commiter is. (Answer 242).
Nov 18 2015, 10:04 PM
joshuaspence added a revision to T992: Send rich HTML mail bodies without impacting reply handling functionality: Unknown Object (Differential Revision).
Nov 18 2015, 8:52 PM · Differential, Mail
joshuaspence awarded T9811: Make it easier to diagnose command failures occurring inside Drydock allocations a Like token.
Nov 18 2015, 7:56 PM · Drydock
joshuaspence awarded T9812: Show SSH diagnostic information in Drydock logs a Like token.
Nov 18 2015, 7:56 PM · Drydock
joshuaspence renamed T9813: "Blocked" filtering: task shows up on both "blocked" and "non-blocked" queries from "blocked" filtering: task shows up on both "blocked" and "non-blocked" queries to "Blocked" filtering: task shows up on both "blocked" and "non-blocked" queries.
Nov 18 2015, 7:55 PM · Maniphest

Nov 17 2015

joshuaspence updated the title for P1892 xhpast_tree.php from untitled to xhpast_tree.php.
Nov 17 2015, 8:29 PM · XHPAST
joshuaspence updated the question details for Q222: Integration with Jira.
Nov 17 2015, 8:10 PM · Doorkeeper
joshuaspence added a project to Q222: Integration with Jira: Doorkeeper.
Nov 17 2015, 8:09 PM · Doorkeeper
joshuaspence added Q222: Integration with Jira (Answer 257).
Nov 17 2015, 8:07 PM
joshuaspence added a comment to Q221: Is that possible to host several phabricators in one single server?.

No, that's not currently possible, but it might be worth filing a Maniphest task for that.

Nov 17 2015, 7:53 PM
joshuaspence renamed T9805: XHProf will not build on PHP7 from XHPAST will not build on PHP7 to XHProf will not build on PHP7.
Nov 17 2015, 7:07 AM · XHProf
joshuaspence added a comment to T9805: XHProf will not build on PHP7.

Oh sorry... I am dumb.

Nov 17 2015, 7:06 AM · XHProf
joshuaspence added a comment to T9805: XHProf will not build on PHP7.

(Assuming you meant XHPAST rather than XHProf)

Nov 17 2015, 7:06 AM · XHProf
joshuaspence renamed T9805: XHProf will not build on PHP7 from XHPROF will not build on PHP7 to XHPAST will not build on PHP7.
Nov 17 2015, 7:05 AM · XHProf

Nov 16 2015

joshuaspence closed T9757: Add subscribers to Herald as Resolved by committing Restricted Diffusion Commit.
Nov 16 2015, 7:27 PM · Herald
joshuaspence renamed T9802: `arc land` continues when the merge fails from arc land continues when the merge fails to `arc land` continues when the merge fails.
Nov 16 2015, 7:16 PM · Arcanist
joshuaspence updated the task description for T9795: Enforce Minimum Required Lint Version.
Nov 16 2015, 7:14 PM · Lint
joshuaspence added a project to T9796: Add linting support for Elixir: Lint.
Nov 16 2015, 7:11 PM · Lint, Arcanist
joshuaspence added a project to T9797: Add unit testing support for Elixir: Unit.
Nov 16 2015, 7:11 PM · Unit, Arcanist
joshuaspence added a project to T9801: Hardcoded timeout in HarbormasterHTTPRequestBuildStepImplementation class: Harbormaster.
Nov 16 2015, 7:08 PM · Harbormaster
joshuaspence added a comment to T9794: You Shall Not Pass: Unknown Object (VOID).

Ah sorry, I thought Almanac wasn't a prototype but Drydock was. I was mistaken though.

Nov 16 2015, 1:01 AM · Almanac

Nov 15 2015

joshuaspence added a comment to T9794: You Shall Not Pass: Unknown Object (VOID).

On another note, why doesn't Almanac use Passphrase for key storage?

Nov 15 2015, 10:21 PM · Almanac
joshuaspence created T9794: You Shall Not Pass: Unknown Object (VOID).
Nov 15 2015, 10:20 PM · Almanac
joshuaspence added a comment to Q221: Is that possible to host several phabricators in one single server?.

Why do you want completely separate installations? From your description, it sounds like you want Spaces instead. Spaces allows you to namespace different parts of Phabricator such that things within the Engineering namespace wouldn't necessarily be accessible to the HR namespace.

Nov 15 2015, 9:06 PM
joshuaspence closed T9131: `arc unit` doesn't output progressive results as Resolved.

Fixed in rARC66ab1c955d27ff7875f62eb51a0bd6c4770a7ae3.

Nov 15 2015, 8:53 PM · Unit, Arcanist
joshuaspence closed T9131: `arc unit` doesn't output progressive results, a subtask of T5568: Support `.arcunit`, similar to `.arclint`, as Resolved.
Nov 15 2015, 8:53 PM · Unit, Arcanist
joshuaspence added a revision to T9131: `arc unit` doesn't output progressive results: Unknown Object (Differential Revision).
Nov 15 2015, 8:26 AM · Unit, Arcanist
joshuaspence added a revision to T9131: `arc unit` doesn't output progressive results: Unknown Object (Differential Revision).
Nov 15 2015, 8:23 AM · Unit, Arcanist
joshuaspence added a revision to T9575: Make Passphrase policies clearer: Unknown Object (Differential Revision).
Nov 15 2015, 2:25 AM · Policy, Passphrase
joshuaspence added a subtask for T992: Send rich HTML mail bodies without impacting reply handling functionality: T9593: Counterexample header is incorrectly colored in email.
Nov 15 2015, 12:20 AM · Mail, Differential
joshuaspence added a parent task for T9593: Counterexample header is incorrectly colored in email: T992: Send rich HTML mail bodies without impacting reply handling functionality.
Nov 15 2015, 12:20 AM · Remarkup, Mail
joshuaspence added a subtask for T992: Send rich HTML mail bodies without impacting reply handling functionality: T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments.
Nov 15 2015, 12:17 AM · Mail, Differential
joshuaspence added a parent task for T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments: T992: Send rich HTML mail bodies without impacting reply handling functionality.
Nov 15 2015, 12:17 AM · Prioritized, Restricted Project, Remarkup, Mail
joshuaspence created T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments.
Nov 15 2015, 12:12 AM · Prioritized, Restricted Project, Remarkup, Mail
joshuaspence created T9789: Make it easier to write custom transaction types.
Nov 15 2015, 12:05 AM · Modernization, Transactions

Nov 14 2015

joshuaspence added a comment to T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor.

Thanks, I spent ~10 minutes on it but couldn't figure it out.

Nov 14 2015, 11:45 PM · ApplicationEditor, Paste
joshuaspence added a comment to T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor.

Actually something weird is going on... I can't edit pastes either, even if the Edit Policy is set to "All Users".

Nov 14 2015, 11:35 PM · ApplicationEditor, Paste
joshuaspence added a comment to T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor.

I'm not sure how to fix this without adding pastePHID to PhabricatorFile, which doesn't feel like the best approach.

Nov 14 2015, 11:33 PM · ApplicationEditor, Paste
joshuaspence added a comment to T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor.

I started looking at this. It seems like the file attached to the Paste has a view policy of no-one, whereas it should probably inherit the view policy of the parent Paste.

Nov 14 2015, 11:28 PM · ApplicationEditor, Paste
joshuaspence created T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor.
Nov 14 2015, 11:26 PM · ApplicationEditor, Paste
joshuaspence updated the task description for T4245: Make repository URIs slightly prettier.
Nov 14 2015, 9:44 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
joshuaspence added a revision to T9762: Removing devices from Almanac services: Unknown Object (Differential Revision).
Nov 14 2015, 10:46 AM · Almanac (v2)
joshuaspence added a revision to T4245: Make repository URIs slightly prettier: Unknown Object (Differential Revision).
Nov 14 2015, 10:38 AM · Prioritized, Diffusion (v3), KDE, Restricted Project

Nov 13 2015

joshuaspence added a comment to T9783: Multiple linters affecting same line, one of which applying autocorrect.

In the general case, this is impossible to resolve. Suppose that you had conflicting linter rules, such as one whiche enforced that files end with a newline character and another which enforces that files do not end with a newline character.

Nov 13 2015, 11:36 PM · Restricted Project, Lint
joshuaspence added a comment to T9773: Unit tests are slow.

MySQL version is 5.6.27-0ubuntu1.

Nov 13 2015, 10:54 PM · Infrastructure
joshuaspence added a comment to T9773: Unit tests are slow.
> time ./bin/storage upgrade --namespace testT9773 --force --no-adjust
Loading quickstart template...
Applying patch 'phabricator:db.xhpast'...
Applying patch 'phabricator:20150906.mailinglist.sql'...
Applying patch 'phabricator:20150930.drydock.log.1.sql'...
Applying patch 'phabricator:20151001.drydock.rname.1.sql'...
Applying patch 'phabricator:20151002.dashboard.status.1.sql'...
Applying patch 'phabricator:20151002.harbormaster.bparam.1.sql'...
Applying patch 'phabricator:20151009.drydock.auth.1.sql'...
Applying patch 'phabricator:20151010.drydock.auth.2.sql'...
Applying patch 'phabricator:20151013.drydock.op.1.sql'...
Applying patch 'phabricator:20151023.harborpolicy.1.sql'...
Applying patch 'phabricator:20151023.harborpolicy.2.php'...
Applying patch 'phabricator:20151023.patchduration.sql'...
Applying patch 'phabricator:20151030.harbormaster.initiator.sql'...
Applying patch 'phabricator:20151106.editengine.1.table.sql'...
Applying patch 'phabricator:20151106.editengine.2.xactions.sql'...
Applying patch 'phabricator:20151106.phame.post.mailkey.1.sql'...
Applying patch 'phabricator:20151106.phame.post.mailkey.2.php'...
Applying patch 'phabricator:20151107.phame.blog.mailkey.1.sql'...
Applying patch 'phabricator:20151107.phame.blog.mailkey.2.php'...
Applying patch 'phabricator:20151108.phame.blog.joinpolicy.sql'...
Applying patch 'phabricator:20151108.xhpast.stderr.sql'...
Applying patch 'phabricator:20151109.phame.post.comments.1.sql'...
Applying patch 'phabricator:20151109.repository.coverage.1.sql'...
Applying patch 'phabricator:20151109.xhpast.db.1.sql'...
Applying patch 'phabricator:20151109.xhpast.db.2.sql'...
Applying patch 'phabricator:20151110.daemonenvhash.sql'...
Storage is up to date. Use 'storage status' for details.
Declining to apply storage adjustments.
Nov 13 2015, 10:52 PM · Infrastructure
joshuaspence added a comment to T4245: Make repository URIs slightly prettier.

This is the only thing that is blocking me from migrating all of our repositories from Gitlab to Phabricator. Is there a clear path forward here? If so, I could potentially work on this.

Nov 13 2015, 10:35 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
joshuaspence added a comment to T9773: Unit tests are slow.

One thing I noticed is that I have a large number of test databases locally.

Nov 13 2015, 11:26 AM · Infrastructure
joshuaspence added a comment to T9773: Unit tests are slow.

Here is a profile from running ManiphestTaskTestCase only (and without coverage): https://secure.phabricator.com/xhprof/profile/PHID-FILE-fkx2c4q3wtfn6cetww6s/

Nov 13 2015, 11:21 AM · Infrastructure
joshuaspence added a comment to T9773: Unit tests are slow.

See https://secure.phabricator.com/xhprof/profile/PHID-FILE-jfpnkcj4lvtjwojxmttl/, which shows the profile from running arc unit --everything.

Nov 13 2015, 11:14 AM · Infrastructure
joshuaspence closed T9778: Allow DarkConsole to be enabled based on policies as Wontfix.

Right, I see. I had darkconsole.always-on enabled.

Nov 13 2015, 11:10 AM · Infrastructure
joshuaspence added a comment to T9778: Allow DarkConsole to be enabled based on policies.

I'm not concern ed from a security point of view... I'd just rather not give people functionality that they don't need. Specifically, I'm sure someone will open DarkConsole by mistake and not know how to close it.

Nov 13 2015, 6:06 AM · Infrastructure
joshuaspence created T9778: Allow DarkConsole to be enabled based on policies.
Nov 13 2015, 4:55 AM · Infrastructure
joshuaspence added a comment to T7053: Restart daemons automagically.

This also seems to work properly on this host, although I hit the "daemons are not running" setup warning once, presumably by racing their restart. If this is an issue we can tweak how that warning works, I think.

Nov 13 2015, 3:43 AM · Daemons
joshuaspence created T9776: Process Herald rules recursively.
Nov 13 2015, 1:21 AM · Herald

Nov 12 2015

joshuaspence added a comment to T9773: Unit tests are slow.

Running on a local MySQL server... I'll try to profile the tests later.

Nov 12 2015, 11:26 PM · Infrastructure
joshuaspence updated Q219: What is the difference between the individual and corporate CLA? from to What is the difference between the individual and corporate CLA?.
Nov 12 2015, 9:22 PM · Phacility
joshuaspence created T9773: Unit tests are slow.
Nov 12 2015, 8:33 PM · Infrastructure