Page MenuHomePhabricator
Create Task
Maniphest T9801

Hardcoded timeout in HarbormasterHTTPRequestBuildStepImplementation class
Closed, WontfixPublic
Actions

Description

HarbormasterHTTPRequestBuildStepImplementation class has hardcoded timeout for HTTP Request execution:
https://github.com/phacility/phabricator/blob/12dd9ec3ff34d0037dacf43ce912b9eaa4a9faff/src/applications/harbormaster/step/HarbormasterHTTPRequestBuildStepImplementation.php#L58

It's very inconvenient for requests that run more than a minute, because builds always marked as failed.
It would be nice if it were possible to configure this parameter.

Event Timeline

reactivemaster created this task.Nov 16 2015, 6:01 PM
reactivemaster updated the task description. (Show Details)
reactivemaster added a subscriber: reactivemaster.
reactivemaster updated the task description. (Show Details)Nov 16 2015, 6:06 PM
epriestley closed this task as Wontfix.Nov 16 2015, 6:17 PM
epriestley claimed this task.
epriestley added a subscriber: epriestley.

Your HTTP request should start a build, it should not wait for the build to complete. See:

https://secure.phabricator.com/book/phabricator/article/harbormaster/

Use harbormaster.sendmessage to report results from an external API after the build completes.

joshuaspence added a project: Harbormaster.Nov 16 2015, 7:08 PM
joshuaspence added a subscriber: joshuaspence.
Phabricator · Built by Phacility