Page MenuHomePhabricator
Feed Advanced Search

Dec 21 2015

epriestley closed T10030: repository.query API should include a projectPHIDs field as Wontfix.

This will be available in a future repository.search method, via T7715. See here for some discussion:

Dec 21 2015, 11:46 PM · Diffusion, Conduit, Feature Request
dereckson added a revision to T10030: repository.query API should include a projectPHIDs field: Unknown Object (Differential Revision).
Dec 21 2015, 4:04 PM · Diffusion, Conduit, Feature Request
dereckson updated the task description for T10030: repository.query API should include a projectPHIDs field.
Dec 21 2015, 3:53 PM · Diffusion, Conduit, Feature Request
dereckson created T10030: repository.query API should include a projectPHIDs field.
Dec 21 2015, 3:22 PM · Diffusion, Conduit, Feature Request
zomaigad added a comment to Q253: Repository pull doesn't work / can't import commit details.

We had only imported one repository when we saw 0.00% progress and nothing but errors on the logs. I'll delete the database and reinstall Phabricator, this time with just our dummy test project to see if it finishes importing.

Dec 21 2015, 11:44 AM · Diffusion
avivey added a comment to Q253: Repository pull doesn't work / can't import commit details.

By importing repositories, you have amassed a large number of commit import tasks. By deleting those repos, you've made all these tasks obsolete, and they will fail in this manner.
Your safest action now it to wait it out; You can increase the number of task-processing daemons by running ./bin/phd launch 4 PhabricatorTaskmasterDaemon, and let them clear out the bad tasks.

Dec 21 2015, 8:25 AM · Diffusion
zomaigad added a comment to Q253: Repository pull doesn't work / can't import commit details.

Indeed, there's nothing there by that ID - but why?

Dec 21 2015, 6:50 AM · Diffusion
hach-que created T10022: The "Add Mirror" button in Diffusion should provide a quick way to create a new SSH credential.
Dec 21 2015, 1:43 AM · Diffusion, Feature Request

Dec 20 2015

avivey added a comment to Q253: Repository pull doesn't work / can't import commit details.

Your SQL is wrong. It should be:

SELECT * FROM phabricator_repository.repository_commit WHERE id == 77039
Dec 20 2015, 6:03 PM · Diffusion
zomaigad added a comment to Q253: Repository pull doesn't work / can't import commit details.

Is the Phabricator query wrong then? I've tried loading the commit data based on the commit "id" value rather than "commitIdentifier" here:

Dec 20 2015, 9:18 AM · Diffusion

Dec 19 2015

chad updated the question details for Q253: Repository pull doesn't work / can't import commit details.
Dec 19 2015, 8:40 PM · Diffusion
avivey added a comment to Q253: Repository pull doesn't work / can't import commit details.

commit_id is the id column, not commitIdentifier column.

Dec 19 2015, 7:55 PM · Diffusion

Dec 18 2015

epriestley added a comment to T4245: Make repository URIs slightly prettier.

There's no technical reason for that, either, although it probably doesn't make sense to raise it in advance of just fixing this properly.

Dec 18 2015, 2:58 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
cburroughs added a comment to T4245: Make repository URIs slightly prettier.

On the flexibility side of this I've managed to run into the 32 character callsign limit. We like long names? ¯\_(ツ)_/¯

Dec 18 2015, 2:57 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
zomaigad updated the question details for Q253: Repository pull doesn't work / can't import commit details.
Dec 18 2015, 9:04 AM · Diffusion
zomaigad updated Q253: Repository pull doesn't work / can't import commit details from Repository pull doesn't work / can't import commit detail to Repository pull doesn't work / can't import commit details.
Dec 18 2015, 9:01 AM · Diffusion
zomaigad updated the question details for Q253: Repository pull doesn't work / can't import commit details.
Dec 18 2015, 8:48 AM · Diffusion
zomaigad changed the visibility for Q253: Repository pull doesn't work / can't import commit details.
Dec 18 2015, 8:48 AM · Diffusion

Dec 17 2015

yelirekim added a revision to T9524: Show aggregate subdirectory coverage in Diffusion browse views: Restricted Differential Revision.
Dec 17 2015, 3:52 AM · Diffusion, Restricted Project

Dec 16 2015

avivey renamed T2815: Render Remarkup files in Diffusion from Render Remarkup filed in Diffusion to Render Remarkup files in Diffusion.
Dec 16 2015, 11:55 PM · Diffusion
avivey renamed T2815: Render Remarkup files in Diffusion from Render reStructuredText in Diffusion to Render Remarkup filed in Diffusion.
Dec 16 2015, 11:28 PM · Diffusion

Dec 14 2015

foven added a comment to T9926: SVN Commit fails, hard to debug.

Just an update:

Dec 14 2015, 8:20 PM · Bug Report (Needs Information), Subversion, Diffusion

Dec 12 2015

chad added a project to T9915: Audit Changes TOC fail redirecting to right subdirectory when clicking on fa-folder-open icon and produces an unhandled exception: Diffusion.
Dec 12 2015, 5:06 PM · Restricted Project, Diffusion, Bug Report
chad added projects to T9926: SVN Commit fails, hard to debug: Diffusion, Subversion.
Dec 12 2015, 5:06 PM · Bug Report (Needs Information), Subversion, Diffusion

Dec 11 2015

• paladox added a comment to T8170: Diffusion -> show raw file doesn't always render text.

Hi this files.viewable-mime-types doesn't seem to apply to desktop since testing using an iPhone 6 plus using safari and using a windows 10, edge and internet explorer the iPhone seems to register files.viewable-mime-types and follows what ever is set in it but on desktop it doesn't since for example going to https://phabricator.wikimedia.org/F3069835 on iPhone and then click download it lets you view the raw without needing to download but doing the same on desktop doesn't it downloads the file instead of viewing the file in raw.

Dec 11 2015, 6:25 PM · Diffusion
epriestley closed T9678: "Argument 1 passed to AphrontView::setUser() must be an instance of PhabricatorUser, null given" on cloning a repository as Invalid.

I can't reproduce this. Here's what I did:

Dec 11 2015, 12:43 PM · Diffusion

Dec 9 2015

lhfcws added a comment to Q206: "Auditors" in commit message cannot trigger audits showing on web ui.

@fanis Thanks for ur reply. It's not the reason of the problem. And it is quite weird that this problem will always exist with my test svn, but with my online svn which supports http it works fine. I don't know if there is something that do not support phabricator+svn solution (each of them works fine before combination) and no people including the contributors are aware of this.

Dec 9 2015, 3:31 PM · Diffusion, Audit
fanis added a comment to Q206: "Auditors" in commit message cannot trigger audits showing on web ui.

I just realized after testing a few versions that the "Auditors: <username>" in the commit message needs to have 1 empty line before it to be triggered. Probably some parsing issue.

Dec 9 2015, 1:36 PM · Diffusion, Audit

Dec 8 2015

epriestley removed a project from T9319: Accessing image file in Diffusion must not generate error (unhandled exception): Conduit.
Dec 8 2015, 10:51 PM · Phacility, Diffusion, Phacility Support
epriestley renamed T1816: Support downloading a compressed working copy (tar/zip) of a repository at a specific commit or tag from Support download tag archive file to Support downloading a compressed working copy (tar/zip) of a repository at a specific commit or tag.
Dec 8 2015, 5:24 PM · Drydock, Diffusion
• paladox added a comment to T9934: Add support for downloading zip files or compressed files.

Well this is a feature request not a bug request. There is no problem. This feature would be really useful for users that want to download the whole repo for reasons a user may want to upload the files to his or her server doing git clone will take a few minutes because what if the user doesn't have any software that uses git to download the repo. It may take longer if the user doesn't know how to use the software and how to use for example git clone.

Dec 8 2015, 5:22 PM · Diffusion, Differential, Feature Request
chad updated subscribers of T9934: Add support for downloading zip files or compressed files.

Hi please support downloading zip files or compressed files in differential and diffusion.

Dec 8 2015, 5:21 PM · Diffusion, Differential, Feature Request
epriestley updated subscribers of T1816: Support downloading a compressed working copy (tar/zip) of a repository at a specific commit or tag.
Dec 8 2015, 5:19 PM · Drydock, Diffusion
epriestley merged task T9934: Add support for downloading zip files or compressed files into T1816: Support downloading a compressed working copy (tar/zip) of a repository at a specific commit or tag.
Dec 8 2015, 5:19 PM · Diffusion, Differential, Feature Request
chad added a comment to T9934: Add support for downloading zip files or compressed files.

More specifically, this request is competing with thousands of other tasks vs. 2 developers. If you can't describe a problem this solves, then we can't give it any priority, and it will sit for many years. It's to your benefit to explain the entire use case to us in a manner which we can understand it's impact on all Phabricator users.

Dec 8 2015, 5:13 PM · Diffusion, Differential, Feature Request
chad added a comment to T9934: Add support for downloading zip files or compressed files.

"Gerrit has it" doesn't describe a problem to us.

Dec 8 2015, 5:10 PM · Diffusion, Differential, Feature Request
• paladox added a comment to T9934: Add support for downloading zip files or compressed files.

Well so that users could just like download zip files not needing to have git or any other program to be able to download the files. Gerrit support this and Wikimedia is moving to phabricator soon.

Dec 8 2015, 5:09 PM · Diffusion, Differential, Feature Request
chad added a comment to T9934: Add support for downloading zip files or compressed files.

See Contributing Feature Requests. We need and want to understand root problems, and don't consider "feature doesn't exist" or "it's something we'd like" a root problem. Specifically in what scenarios are you distributing zip files in a repository why do they need to be downloadable by non-developers?

Dec 8 2015, 5:07 PM · Diffusion, Differential, Feature Request
• paladox added projects to T9934: Add support for downloading zip files or compressed files: Differential, Diffusion.
Dec 8 2015, 4:51 PM · Diffusion, Differential, Feature Request

Dec 6 2015

tycho.tatitscheff added a comment to Q236: Unable to push to hosted repository.

Your welcome.

Dec 6 2015, 8:44 PM · Diffusion
awalGarg closed Q236: Unable to push to hosted repository as obsolete.
Dec 6 2015, 8:22 PM · Diffusion
awalGarg added a comment to Q236: Unable to push to hosted repository.

Ok, I got it working. I'll add a tutorial style answer on another more suitable thread, and I am closing this for now.

Dec 6 2015, 8:02 PM · Diffusion
awalGarg added a comment to Q236: Unable to push to hosted repository.

Ok thanks a lot and sorry for the confusion! I shall start again from scratch, and post my findings here if I manage to run the phabricator's sshd on a custom port.

Dec 6 2015, 6:03 PM · Diffusion
tycho.tatitscheff added a comment to Q236: Unable to push to hosted repository.

So please follow the guide from start again, then i or someone lese will helps debugging the "normal" stuff failing like permission in sudo, or git-executables not in path.

Dec 6 2015, 6:01 PM · Diffusion
tycho.tatitscheff added a comment to Q236: Unable to push to hosted repository.

On http://phabricator.example.com/config/group/diffusion/ theire is all stuff you wanna configure ! In peculiar the ssh-port, the ssh-user ect.

Dec 6 2015, 5:57 PM · Diffusion
awalGarg added a comment to Q236: Unable to push to hosted repository.

Thanks a lot for the elaborate reply! No, it doesn't throw any such error. I get straight shell access to my server.

Dec 6 2015, 5:38 PM · Diffusion
tycho.tatitscheff updated subscribers of Q236: Unable to push to hosted repository.
Dec 6 2015, 5:31 PM · Diffusion
tycho.tatitscheff added a comment to Q236: Unable to push to hosted repository.

because we have tooling which relies on the regular SSHD daemon being available on port 22. And thus, I have to add the remote like above.

Dec 6 2015, 5:14 PM · Diffusion
awalGarg updated Q236: Unable to push to hosted repository from to Unable to push to hosted repository.
Dec 6 2015, 4:41 PM · Diffusion

Dec 5 2015

epriestley closed T8853: Allow "Administrator" to be used in Herald rules for "pusher" as Wontfix.

We haven't seen other requests for this and I think putting administrators in a project and using "Pusher's projects ..." is a pretty reasonable workaround. This can also now reasonably be written as an extension.

Dec 5 2015, 9:16 PM · Diffusion, Herald
epriestley updated subscribers of T5788: Support "Commit is a merge" in Herald "Commit" (post-commit) rules.
Dec 5 2015, 9:11 PM · Diffusion, Herald
epriestley closed T5788: Support "Commit is a merge" in Herald "Commit" (post-commit) rules as Resolved by committing Restricted Diffusion Commit.
Dec 5 2015, 9:08 PM · Diffusion, Herald
epriestley added a revision to T5788: Support "Commit is a merge" in Herald "Commit" (post-commit) rules: Restricted Differential Revision.
Dec 5 2015, 8:58 PM · Diffusion, Herald
epriestley added a project to T5788: Support "Commit is a merge" in Herald "Commit" (post-commit) rules: Diffusion.
Dec 5 2015, 8:57 PM · Diffusion, Herald

Dec 3 2015

CraigBoyd added a comment to Q182: Why git clone return 403 error when through http?.

I am getting the exact same issue.
I am prompted for a user id and password so I use the appropriate ones:
user: user_name_in_phab
password: users_password_in_phab

Dec 3 2015, 10:52 PM · Diffusion, Git

Dec 2 2015

jgelens added a comment to T9639: Unable to push to hosted Mercurial repository over SSH with new upstream bookmark position.
Dec 2 2015, 9:07 PM · Diffusion, Mercurial

Nov 30 2015

epriestley closed T9698: Allow bots to have email addresses assigned to them as Invalid.
  • I believe username association works correctly.
  • Assigning an email is already mandatory when creating a bot:
Nov 30 2015, 4:42 PM · Drydock, People, Diffusion
epriestley moved T1816: Support downloading a compressed working copy (tar/zip) of a repository at a specific commit or tag from Backlog to Future on the Drydock board.
Nov 30 2015, 4:40 PM · Drydock, Diffusion

Nov 29 2015

Ephasme closed T9849: Keep getting 403 error when trying to push to a repository as Invalid.

My bad, I didn't activate the option serving this repository over HTTP!
This wasn't a bug at all it's just I didn't ready the instruction carefully.
I missed this line:

Make sure you've added an SSH public key to your account. You can do this in Settings → SSH Public Keys.

Nov 29 2015, 10:31 AM · Diffusion
chad added a comment to T9849: Keep getting 403 error when trying to push to a repository.

Authentication Failure
This Phabricator install is not configured with any enabled authentication providers which can be used to log in. If you have accidentally locked yourself out by disabling all providers, you can use phabricator/bin/auth recover <username> to recover access to an administrative account.

Nov 29 2015, 1:29 AM · Diffusion
Ephasme added a comment to T9849: Keep getting 403 error when trying to push to a repository.

Voilà ce que j'obtiens en faisant un clone.

Cloning into 'testrepo'...
* Couldn't find host phabricator.vonji.fr in the .netrc file; using defaults
* Hostname was NOT found in DNS cache
*   Trying 62.210.236.42...
* Connected to phabricator.vonji.fr (62.210.236.42) port 80 (#0)
> GET /diffusion/TR/testrepo.git/info/refs?service=git-upload-pack HTTP/1.1
User-Agent: git/1.9.1
Host: phabricator.vonji.fr
Accept: */*
Accept-Encoding: gzip
Pragma: no-cache
Nov 29 2015, 12:45 AM · Diffusion

Nov 27 2015

chad added a project to T9849: Keep getting 403 error when trying to push to a repository: Diffusion.
Nov 27 2015, 4:05 PM · Diffusion
• wqzdz3rhyt82pywy added a comment to T5029: Fill in missing context for low-context diffs against tracked repositories.

In the Google codereview app when it used to be possible to submit a raw diff for submitting code for review, it was quite simple to do that. The main issue is not the revision, the main issue is the path. So simply add a field in the submission form to provide the path to the root of the patch.

Nov 27 2015, 2:06 PM · KDE, Restricted Project, Diffusion, Differential

Nov 26 2015

chad added a comment to T8170: Diffusion -> show raw file doesn't always render text.

Then please follow our bug reporting guide: Contributing Bug Reports

Nov 26 2015, 4:51 PM · Diffusion
• paladox added a comment to T8170: Diffusion -> show raw file doesn't always render text.

I am asking phabricator. Since viewing raw php files doesn't work on deskop or laptop. So I am not sure what to set.

Nov 26 2015, 4:39 PM · Diffusion
chad added a comment to T8170: Diffusion -> show raw file doesn't always render text.

@paladox who are you talking to, specifically, the upstream or Wikimedia?

Nov 26 2015, 4:30 PM · Diffusion
• paladox added a comment to T8170: Diffusion -> show raw file doesn't always render text.

Hi the workaround works for mobile devices not desktops and laptops.

Nov 26 2015, 4:15 PM · Diffusion

Nov 24 2015

joshuaspence added a project to T9839: Support Bitbucket Webhook.: Diffusion.
Nov 24 2015, 7:20 PM · Diffusion
epriestley moved T7789: Support Git Large File Storage from Backlog to Far Future on the Files board.
Nov 24 2015, 5:19 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley removed a project from T9319: Accessing image file in Diffusion must not generate error (unhandled exception): Files.
Nov 24 2015, 4:59 PM · Phacility, Diffusion, Phacility Support

Nov 23 2015

epriestley renamed T9562: Show only the first N branches/tags on commits in Diffusion, with a "Show all..." link from Option to hide the branches and tags for a commit by default to Show only the first N branches/tags on commits in Diffusion, with a "Show all..." link.
Nov 23 2015, 11:00 PM · Diffusion (v3), Restricted Project
epriestley closed T7000: 404 when accessing repo via http as Invalid.

I can not reproduce this. Here's what I did:

Nov 23 2015, 4:14 PM · Diffusion

Nov 19 2015

joshuaspence added a comment to T9815: Fast repository polling on multiple repositories causes 2Hz polling of remote host.

For what it's worth, we have a very similar setup (40ish repositories in Phabricator, all hosted in Gitlab). We have not observed any performance issues such as those described in this ticket.

Nov 19 2015, 8:15 AM · Diffusion, Daemons
epriestley closed T9815: Fast repository polling on multiple repositories causes 2Hz polling of remote host as Invalid.

Since we don't have access to whatever GitLab is measuring, we can't understand this issue in greater detail. Particularly, we can not reproduce the underlying heavy load in a way we can examine. We have not seen similar reports from other users, except @jcarrillo7, who has not filed any details. We have many installs with hundreds of repositories and my expectation is that the operation is cheap, so I suspect this may be an issue unique to GitLab.

Nov 19 2015, 3:32 AM · Diffusion, Daemons
avivey added a comment to T9815: Fast repository polling on multiple repositories causes 2Hz polling of remote host.

Sounds like you could easily fork and change the polling frequency; The calculation is at https://secure.phabricator.com/diffusion/P/browse/master/src/applications/repository/storage/PhabricatorRepository.php$1527, and you can drop it to an hour just by changing that line.

Nov 19 2015, 3:23 AM · Diffusion, Daemons
award added a comment to T9815: Fast repository polling on multiple repositories causes 2Hz polling of remote host.

I am not sure of the underlying implementation of GitLab, but our phabricator instance has been flagged as the #1 user of GitLab resources. Our GitLab instance hosts thousands of repositories, so being the single largest user of GitLab is concerning since we only have ~50 repositories.

Nov 19 2015, 3:04 AM · Diffusion, Daemons
epriestley added a comment to T9815: Fast repository polling on multiple repositories causes 2Hz polling of remote host.

huge amount of traffic

Nov 19 2015, 2:53 AM · Diffusion, Daemons
hach-que added a comment to T9815: Fast repository polling on multiple repositories causes 2Hz polling of remote host.

At that scale, is there any reason to not use Phabricator's repository hosting instead of GitLab? You can mirror repositories from Phabricator to GitLab if you still need some GitLab functionality (see the Mirrors option under Edit Repository).

Nov 19 2015, 2:52 AM · Diffusion, Daemons
award renamed T9815: Fast repository polling on multiple repositories causes 2Hz polling of remote host from Repositories are being polled at 2Hz to Fast repository polling on multiple repositories causes 2Hz polling of remote host.
Nov 19 2015, 2:41 AM · Diffusion, Daemons
award added a comment to T9815: Fast repository polling on multiple repositories causes 2Hz polling of remote host.

Oops! Thats embarrassing. These numbers were gathered from multiple places/multiple people, and mass confusion ensued. The 2Hz number came from the total requests to GitLab instead of requests per repository. Ill update the title/description accordingly.

Nov 19 2015, 2:40 AM · Diffusion, Daemons
epriestley added a comment to T9815: Fast repository polling on multiple repositories causes 2Hz polling of remote host.

I'm not sure I understand your math -- here's what I get:

Nov 19 2015, 2:14 AM · Diffusion, Daemons
award updated subscribers of T9815: Fast repository polling on multiple repositories causes 2Hz polling of remote host.

@epriestley I know you mentioned that a diffusion.looksoon would trigger this, but we have no known users of this command.

Nov 19 2015, 2:08 AM · Diffusion, Daemons
award updated the task description for T9815: Fast repository polling on multiple repositories causes 2Hz polling of remote host.
Nov 19 2015, 2:05 AM · Diffusion, Daemons
award created T9815: Fast repository polling on multiple repositories causes 2Hz polling of remote host.
Nov 19 2015, 2:02 AM · Diffusion, Daemons

Nov 18 2015

leduc removed a revision from T4189: Install commit hooks in hosted repositories: Restricted Differential Revision.
Nov 18 2015, 11:18 AM · Diffusion
chad merged task T9677: Difficulty debugging sudo permissions into T9678: "Argument 1 passed to AphrontView::setUser() must be an instance of PhabricatorUser, null given" on cloning a repository.
Nov 18 2015, 5:58 AM · Diffusion
chad updated subscribers of T9678: "Argument 1 passed to AphrontView::setUser() must be an instance of PhabricatorUser, null given" on cloning a repository.
Nov 18 2015, 5:58 AM · Diffusion

Nov 16 2015

epriestley added a comment to T9798: History icon url in the content browser of diffusion does not include file path.

This should be fixed at HEAD. Let us know if you run into anything else.

Nov 16 2015, 5:04 PM · Diffusion
epriestley closed T9798: History icon url in the content browser of diffusion does not include file path as Resolved by committing Restricted Diffusion Commit.
Nov 16 2015, 5:00 PM · Diffusion
epriestley added a revision to T9798: History icon url in the content browser of diffusion does not include file path: Restricted Differential Revision.
Nov 16 2015, 4:40 PM · Diffusion
epriestley added a comment to T9798: History icon url in the content browser of diffusion does not include file path.

I was able to reproduce this easily by following your instructions. We'll get this fixed. Thanks for the report!

Nov 16 2015, 4:26 PM · Diffusion
epriestley renamed T9798: History icon url in the content browser of diffusion does not include file path from Bug: history icon url in the content browser of diffusion does not include file path to History icon url in the content browser of diffusion does not include file path.
Nov 16 2015, 4:26 PM · Diffusion
dennis created T9798: History icon url in the content browser of diffusion does not include file path.
Nov 16 2015, 10:46 AM · Diffusion

Nov 14 2015

joshuaspence updated the task description for T4245: Make repository URIs slightly prettier.
Nov 14 2015, 9:44 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
avivey added a comment to T4245: Make repository URIs slightly prettier.

This is the only thing that is blocking me from migrating all of our repositories from Gitlab to Phabricator. Is there a clear path forward here? If so, I could potentially work on this.

Nov 14 2015, 8:31 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
joshuaspence added a revision to T4245: Make repository URIs slightly prettier: Restricted Differential Revision.
Nov 14 2015, 10:38 AM · Prioritized, Diffusion (v3), KDE, Restricted Project

Nov 13 2015

joshuaspence added a comment to T4245: Make repository URIs slightly prettier.

This is the only thing that is blocking me from migrating all of our repositories from Gitlab to Phabricator. Is there a clear path forward here? If so, I could potentially work on this.

Nov 13 2015, 10:35 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
chad closed T9301: 403 when trying to HTTP pull from Inactive repositoy as Wontfix.

No real consensus here, so not worth pursing any changes in the upstream.

Nov 13 2015, 6:27 PM · Diffusion
chad closed Q218: cannot ssh. permission denied. as resolved.
Nov 13 2015, 4:21 PM · Diffusion, Setup
chad added projects to Q218: cannot ssh. permission denied.: Setup, Diffusion.
Nov 13 2015, 4:20 PM · Diffusion, Setup