This worked before. I guess it was broken with recent changes to how diffusion urls are parsed to create nicer 404 pages for non-existing commits. But maybe I'm completely wrong.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jan 26 2015
Jan 25 2015
Jan 23 2015
Even after I logout and login again no matter what commit I try to edit I will always seeing edit for for that 1st commit.
Jan 22 2015
Jan 21 2015
I don't want to create an audit. Just browse.
T5722 miiight be what you're looking for?
We much prefer problems over solutions when filing feature requests, here specifically we have a number of tasks for 'grouping commits for audit' that might serve your intended purpose. If you can tell us more your desired goal, we might already have such a task.
Yeah, understood, certainly wasn't suggesting that this be a priority.
In the screenshot provided, all the commits I see have all the context I need to make sense of them. I can further click on them for additional context. There is the callsign, the message, and if a project is tagged, it should show up as well. That is currently all the information we intend to provide against all three VCS we provide support for.
Problem: items don't always show enough context to make sense of them from feeds. Example in screenshot.
The issue I'm having is exemplified in the attached screenshot.
Please see https://secure.phabricator.com/book/phabcontrib/article/feature_requests/ regarding requesting features here. Mostly, we just need to know the problem you are having, ie, 'when I read my feed, the message isn't helpful since I don't know X, Y, or Z'. Based on you wanting additional context for a commit, T6973 seemed correct.
Hmmm, based on what you merged this with, I don't think you quite understood what I was saying.
Jan 20 2015
If you have pressing questions, IRC is the best place to converse with other installs/admins. We're not likely to pursue this level of documentation for some time. irc://chat.freenode.net/phabricator
Jan 18 2015
Jan 16 2015
Jan 15 2015
Sure. We could change this, but currently we never auto-inherit projects. For example:
- revisions don't auto-inherit repository projects;
- Phriction pages don't auto-inherit parent projects;
- blocked tasks don't auto-inherit projects of blockers;
- revisions and mocks don't auto-inherit task projects;
- Almanac devices don't auto-inherit service projects.
In all these cases, I think the rule is correct. I'm inclined to think it's the correct rule for Diffusion, too -- although changing the rule would be fine for #phacility on this instance, I don't think a repository project tag necessarily applies to all commits.
Currently, I have my projects/repositories associated in a one-to-one
relationship. However, I would like to be able to possibly have a
many-to-many relationship, which would make the most sense to me on a
branch level.
I think the object herald rule would be reasonable. I can also imagine a use-case like the 'cowboy commits' rule on this install, bur where i don't wanna go as far as triggering an audit for every commit. Or grouping commits to project by the files touched for example.
Using project inheritance from the repo automatically would probably be wrong in a lot of cases.
Right, that's my understanding as well. For me, being able to go to the #phacility feed and understand everything that happened yesterday or anyday, is useful. My expectation as a user is a project feed is the main activity feed filtered just on that project, not just explicit things.
You'd see commits associated with #phacility explicitly, and changes to repositories associated with #phacilty, but commits do not currently automatically inherit the projects of their repository.
Correct. If I specify a project hashtag, then a commit shows in the
project's feed. I'd like all commits for a given repository and branch
to be automatically associated to the project such that if I view the
commit in Diffusion that the project is listed under Projects and so
that if I view the project the commits appear in that project's feed
automatically.
T2628: Add project tags to Pholio, Ponder, Differential, and other applications is somewhat related
You'd see commits associated with #phacility explicitly, and changes to repositories associated with #phacilty, but commits do not currently automatically inherit the projects of their repository.
(I also thought there was an existing task for this, but I haven't been able to find it).
I would assume a 'Feed' of activity for a Project should include anything associated, so in https://secure.phabricator.com/project/feed/40/ I only see Maniphest Tasks, not (also) commits to repositories associated to #phacility
I suppose what he's trying to achieve is to see all commits related to a project in the projects feed. (we spoke in irc)
Herald (and/or Diffusion and/or Projects) does not give me the ability to automatically associate every commit in a particular repository on a particular branch to a particular Phabricator project.
Not likely worth spending resources on .
Thanks!
Herald generally doesn't seem like the right solution, that is Herald is "watch for danger!!!!". I think there are tasks floating around to improve project feeds but I'll have to dig around.
Jan 13 2015
Many thanks for knocking this one out. Pulled as well, and it fixed both our impacted repos.
Was stuck with this same problem, just pulled the latest changes and can now report that it's working fine. Thanks!
I still have the issue, even when upgrading Phabricator.
Jan 12 2015
Thanks for the report!
Works perfectly.
Repros, patching incoming...
lol, thanks for the tag
Jan 9 2015
The PhabricatorAuditEditor in PhabricatorRepositoryCommitHeraldWorker should probably have both:
Jan 8 2015
There's no server detection. (Just to clarify as I get confused here -- the Phabricator server uses the SVN client to get information from some other SVN server.) Theoretically, we can get away without server detection persay since the SVN clients are supposed to clearly indicate that problem and Phabricator doesn't offer SVN-based hosting, so the admin must be doing that too...? (Hand-waving... hi!)
@btrahan, I think you added client detection of 'bad vcs clients', does that include server versions as well?