Page MenuHomePhabricator

Cannot import commit into Diffusion
Closed, InvalidPublic

Description

We got into a strange error where a commit got stuck in Importing state but no daemons are running it.

So I ran ./scripts/repository/reparse.php rCODE13457799218436ecef3a6315f34bf7fd0f6a2ea4 --message --force-local to understand the error and added print_r and debug_print_backtrace to get a better view of the error. It seems that we expect an object plus an action and we have an array that does not have the getHashType property.

#0  mpull(Array ([0] => Array ([0] => hgcm,[1] => 13457799218436ecef3a6315f34bf7fd0f6a2ea4)), getHashType) called at [/home/phabricator/www/phabricator/src/applications/diffusion/query/lowlevel/DiffusionLowLevelCommitFieldsQuery.php:74]
#1  DiffusionLowLevelCommitFieldsQuery->executeQuery() called at [/home/phabricator/www/phabricator/src/applications/diffusion/query/lowlevel/DiffusionLowLevelQuery.php:23]
#2  DiffusionLowLevelQuery->execute() called at [/home/phabricator/www/phabricator/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php:61]
#3  PhabricatorRepositoryCommitMessageParserWorker->updateCommitData(DiffusionCommitRef Object ([] => Fix CRMInfoAlerts tests

freezegun does not work on setUp methods in the version we currently use.,[] => Mr Rowls,[] => mr.rowls@elastichosts.com,[] => ,[] => ,[] => Array ([0] => DiffusionCommitHash Object ([] => hgcm,[] => 13457799218436ecef3a6315f34bf7fd0f6a2ea4)))) called at [/home/phabricator/www/phabricator/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryMercurialCommitMessageParserWorker.php:15]
#4  PhabricatorRepositoryMercurialCommitMessageParserWorker->parseCommit(PhabricatorRepository Object ([] => Code,[] => CODE,[] => ,[] => PHID-PROJ-xyq7s3u37r4vmlykxzis,[] => admin,[] => users,[] => hg,[] => Array ([importing] => ,[tracking-enabled] => 1,[local-path] => /home/phabricator/repo/CODE/,[remote-uri] => ssh://hg@elastichosts.com/code,[description] => ),[] => PHID-CDTL-mqc42kgsxyj5zgwgah4f,[] => <attachable>,[] => <attachable>,[] => <attachable>,[] => ,[] => ,[] => 8,[] => PHID-REPO-qafsil52b72qrqhp662a,[] => 1415816103,[] => 1415897139), PhabricatorRepositoryCommit Object ([] => 8,[] => PHID-CMIT-wfxoxhbdo5eu3e3h7dwd,[] => 13457799218436ecef3a6315f34bf7fd0f6a2ea4,[] => 1422001484,[] => e4mwjvi5x4p7abx7zhl4,[] => ,[] => 0,[] => ,[] => 1024,[] => <attachable>,[] => <attachable>,[] => <attachable>,[] => <attachable>,[] => ,[] => ,[] => 10644,[] => ,[] => )) called at [/home/phabricator/www/phabricator/src/applications/repository/worker/PhabricatorRepositoryCommitParserWorker.php:44]
#5  PhabricatorRepositoryCommitParserWorker->doWork() called at [/home/phabricator/www/phabricator/src/infrastructure/daemon/workers/PhabricatorWorker.php:87]
#6  PhabricatorWorker->executeTask() called at [/home/phabricator/www/phabricator/scripts/repository/reparse.php:281]
Array
(
    [0] => hgcm
    [1] => 13457799218436ecef3a6315f34bf7fd0f6a2ea4
)
PHP Fatal error:  Call to a member function getHashType() on a non-object in /home/phabricator/www/libphutil/src/utils/utils.php on line 114

Fatal error: Call to a member function getHashType() on a non-object in /home/phabricator/www/libphutil/src/utils/utils.php on line 114

Thanks

Event Timeline

elastinuno raised the priority of this task from to Needs Triage.
elastinuno updated the task description. (Show Details)
elastinuno added a subscriber: elastinuno.

Seems like D10746 might have resolved this with T6395. Let us know if you're up to date or not, along with any other information you can think of that will let us reproduce this.

Your right. I should have done an upgrade before anything else.
That patch solves the issue.

Thank you.

btrahan claimed this task.