Page MenuHomePhabricator
Create Task
Maniphest T7011

Edit Commit feature in Diffusion edits the wrong commit
Closed, ResolvedPublic
Actions

Description

Navigating to a Diffusion commit, and selecting the option to edit that commit, can in some circumstances bring you to the edit page for a descendant of that commit.

To reproduce:
Create a Diffusion repository. Make two commits directly via git, (...a1) and (...b2). b2 is HEAD and a1 is its parent.
Navigate to /r....a1. Select "Edit Commit". Note that the browser navigates to /diffusion/.../commit/...a1/edit/
But the breadcrumbs show <Diffusion Icon> -> <Repo Name> -> ...b2. Editing the fields and hitting save does indeed modify ...b2, not ...a1 as expected.

Revisions and Commits

rP Phabricator
D11473rP30eea5e93680 Resolve an issue with Diffusion URI parsing ignoring some information

Related Objects

Duplicates Merged Here
T7017: Unable to edit a commit

Event Timeline

epkugelmass created this task.Jan 22 2015, 9:00 PM
epkugelmass raised the priority of this task from to Needs Triage.
epkugelmass updated the task description. (Show Details)
epkugelmass added a project: Diffusion.
epkugelmass added a subscriber: epkugelmass.
epriestley merged a task: T7017: Unable to edit a commit.Jan 23 2015, 11:33 AM
epriestley added a subscriber: aik099.
aik099 added a comment.Jan 23 2015, 11:38 AM

This worked before. I guess it was broken with recent changes to how diffusion urls are parsed to create nicer 404 pages for non-existing commits. But maybe I'm completely wrong.

epriestley added a revision: D11473: Resolve an issue with Diffusion URI parsing ignoring some information.Jan 23 2015, 11:39 AM
epriestley closed this task as Resolved by committing rP30eea5e93680: Resolve an issue with Diffusion URI parsing ignoring some information.Jan 23 2015, 4:36 PM
epriestley added a commit: rP30eea5e93680: Resolve an issue with Diffusion URI parsing ignoring some information.
Phabricator · Built by Phacility