Page MenuHomePhabricator
Feed Advanced Search

Jan 28 2015

chad added projects to T7066: Phriction documents looks horrible on Firefox: Phriction, PHUI.
Jan 28 2015, 4:34 PM · PHUI, Phriction

Jan 21 2015

chad renamed T7005: Find somewhat simple way to have Phriction be a part of new Projects layout from Find somewhat simple way to have 'Phriction' be a part of new Projects layout to Find somewhat simple way to have Phriction be a part of new Projects layout.
Jan 21 2015, 10:40 PM · FreeBSD, Phriction, Projects
chad created T7005: Find somewhat simple way to have Phriction be a part of new Projects layout.
Jan 21 2015, 10:40 PM · FreeBSD, Phriction, Projects

Jan 19 2015

chad closed T6963: Phriction action menu doesn't display on mobile as Resolved by committing Restricted Diffusion Commit.
Jan 19 2015, 8:42 PM · Phriction, PHUI
chad merged task T6988: Feature req - Support to export a Phriction document into Restricted Maniphest Task.
Jan 19 2015, 5:49 PM · Phriction
• kamalchandra created T6988: Feature req - Support to export a Phriction document.
Jan 19 2015, 5:46 PM · Phriction

Jan 17 2015

chad added a revision to T6963: Phriction action menu doesn't display on mobile: Restricted Differential Revision.
Jan 17 2015, 4:54 PM · Phriction, PHUI

Jan 13 2015

chad created T6963: Phriction action menu doesn't display on mobile.
Jan 13 2015, 7:32 PM · Phriction, PHUI
qgil added a comment to T4768: Phabricator silently overwrites concurrent changes (no conflict detection).

I have edited the description in order to bring Maniphest in, as discussed above. In Wikimedia we are finding ourselves in this problem too often.

Jan 13 2015, 8:00 AM · Restricted Project, ApplicationEditor, Wikimedia, Maniphest, Phriction
qgil renamed T4768: Phabricator silently overwrites concurrent changes (no conflict detection) from Warn/merge if document is edited while editing to Phabricator silently overwrites concurrent changes (no conflict detection).
Jan 13 2015, 7:59 AM · Restricted Project, ApplicationEditor, Wikimedia, Maniphest, Phriction

Jan 9 2015

Krenair added a comment to T4768: Phabricator silently overwrites concurrent changes (no conflict detection).

Yeah I wasn't sure whether to generalise this or open a new task. In BZ we'd have to open new bugs, but here we can just add extra projects... :)

Jan 9 2015, 9:44 PM · Restricted Project, ApplicationEditor, Wikimedia, Maniphest, Phriction
chad added a comment to T4768: Phabricator silently overwrites concurrent changes (no conflict detection).

This task I believe is specifically for Phriction, but maybe it is generalizable.

Jan 9 2015, 9:15 PM · Restricted Project, ApplicationEditor, Wikimedia, Maniphest, Phriction
Krenair added a project to T4768: Phabricator silently overwrites concurrent changes (no conflict detection): Wikimedia.

We ( Wikimedia ) see this problem (lack of conflict detection) often in Maniphest, but it probably applies to more than just these two projects... See https://phabricator.wikimedia.org/T78236

Jan 9 2015, 9:11 PM · Restricted Project, ApplicationEditor, Wikimedia, Maniphest, Phriction

Jan 6 2015

epriestley closed T337: Add a Rich Text editor to Phriction as Wontfix.

We've improved Remarkup and added "assist" buttons, similar to sites like GitHub, StackOverflow, and Quora. This seems generally satisfactory. We have no plans to pursue full WYSIWYG at this time.

Jan 6 2015, 12:48 AM · Phriction

Dec 12 2014

epriestley merged task T6744: "View Wiki" link in Projects even when Phriction is not installed into T6581: 'view wiki' link now shows up for projects even if Phriction is uninstalled.
Dec 12 2014, 11:24 PM · Wikimedia, Phriction, Projects
epriestley closed T6744: "View Wiki" link in Projects even when Phriction is not installed as Resolved.

This was resolved by rPedf8822.

Dec 12 2014, 11:24 PM · Wikimedia, Phriction, Projects
qgil moved T6744: "View Wiki" link in Projects even when Phriction is not installed from Backlog to Important on the Wikimedia board.
Dec 12 2014, 11:21 PM · Wikimedia, Phriction, Projects
qgil created T6744: "View Wiki" link in Projects even when Phriction is not installed.
Dec 12 2014, 11:21 PM · Wikimedia, Phriction, Projects
btrahan closed T6651: Wiki allows creation of document under empty root, but then won't save it as Resolved.

Closed by commit rP905fc217b80c.

Dec 12 2014, 7:35 PM · Phriction
btrahan closed T6682: Exception when moving wiki document as Resolved.

Closed by commit rP905fc217b80c.

Dec 12 2014, 7:35 PM · Phriction

Dec 11 2014

btrahan triaged T6682: Exception when moving wiki document as Low priority.
Dec 11 2014, 9:57 PM · Phriction
btrahan triaged T6651: Wiki allows creation of document under empty root, but then won't save it as Low priority.
Dec 11 2014, 9:57 PM · Phriction
btrahan added a revision to T6651: Wiki allows creation of document under empty root, but then won't save it: Restricted Differential Revision.
Dec 11 2014, 9:45 PM · Phriction
btrahan added a revision to T6682: Exception when moving wiki document: Restricted Differential Revision.
Dec 11 2014, 9:45 PM · Phriction

Dec 9 2014

chad closed T6715: Phriction Feature Request: enable comments to wiki page as Wontfix.

We don't plan on pursuing this outside of the inline comments task.

Dec 9 2014, 3:53 AM · Phriction
calfzhou created T6715: Phriction Feature Request: enable comments to wiki page.
Dec 9 2014, 3:18 AM · Phriction
calfzhou added a comment to T1894: Support commenting on Phriction documents.

How about add normal comments first? Allows other users (with or without edit access) leave comments below the wiki content.

Dec 9 2014, 2:47 AM · Restricted Project, Restricted Project, Phriction

Dec 4 2014

btrahan claimed T6682: Exception when moving wiki document.

I think this is related to T6651 in that this operation doesn't behave nicely if there's no hierarchy already.

Dec 4 2014, 6:06 PM · Phriction
btrahan claimed T6651: Wiki allows creation of document under empty root, but then won't save it.
Dec 4 2014, 6:06 PM · Phriction
magnetik added a comment to T6682: Exception when moving wiki document.

BUT, moving the document to /w/stacks/ does work

Dec 4 2014, 7:26 AM · Phriction
magnetik added a comment to T6682: Exception when moving wiki document.

The file is : /w/memo/aws/stacks/Stacks
Trying to move to: /w/aws/stacks/

Dec 4 2014, 7:24 AM · Phriction

Dec 3 2014

btrahan added a project to T6682: Exception when moving wiki document: Phriction.

I also can't reproduce. I made this structure

Dec 3 2014, 11:09 PM · Phriction

Dec 2 2014

epriestley added a comment to T6651: Wiki allows creation of document under empty root, but then won't save it.

I think in the general case (creating x/y/z/ when x/ exists but x/y/ does not) auto-stubbing the parents would be reasonable (that is, create x/y/ as a stub with implied permissions, by copying the permissions of x/). If we require x/y/ to exist and make the user go create it, they can still get back to the same state by deleting it later, so we aren't guarding against an invalid state. I'm not sure how useful it really is to create x/y/z/ when no x/y/ exists, but permitting it doesn't seem totally unreasonable.

Dec 2 2014, 12:00 AM · Phriction

Dec 1 2014

btrahan added a comment to T6651: Wiki allows creation of document under empty root, but then won't save it.

This kind of butts up against T6496. Post T6496, if the user wants to make some

Dec 1 2014, 11:27 PM · Phriction
epriestley added a comment to T6651: Wiki allows creation of document under empty root, but then won't save it.

I think it would also be acceptable to require creation of a root document as the first document, if that's an easier fix. Not sure if it would end up being a weird special case, but it might reduce surprises down the road (where a root document is created and has sweeping policy effects).

Dec 1 2014, 9:30 PM · Phriction

Nov 26 2014

btrahan added a comment to T6651: Wiki allows creation of document under empty root, but then won't save it.

The fix should basically stub all the documents out all the way to the root.

Nov 26 2014, 5:28 PM · Phriction
epriestley updated subscribers of T6651: Wiki allows creation of document under empty root, but then won't save it.
Nov 26 2014, 2:41 PM · Phriction
• bitglue updated the task description for T6651: Wiki allows creation of document under empty root, but then won't save it.
Nov 26 2014, 2:31 PM · Phriction
• bitglue created T6651: Wiki allows creation of document under empty root, but then won't save it.
Nov 26 2014, 2:30 PM · Phriction

Nov 22 2014

epriestley closed T6613: Maniphest link in phriction is not working. as Resolved.
Nov 22 2014, 3:27 PM · Phriction
seungrye created T6613: Maniphest link in phriction is not working..
Nov 22 2014, 1:47 PM · Phriction

Nov 21 2014

chad triaged T6610: Support per-section-editing in Phriction wiki as Wishlist priority.
Nov 21 2014, 2:53 PM · Phriction
cburroughs added a comment to T6609: Support math (LaTeX) equation in Remarkup.

This would be cooler as a general remarkup feature instead of just Phriction.

Nov 21 2014, 1:24 PM · Restricted Project, Remarkup
calfzhou updated subscribers of T6610: Support per-section-editing in Phriction wiki.
Nov 21 2014, 8:26 AM · Phriction
calfzhou created T6610: Support per-section-editing in Phriction wiki.
Nov 21 2014, 8:21 AM · Phriction
calfzhou created T6609: Support math (LaTeX) equation in Remarkup.
Nov 21 2014, 7:55 AM · Restricted Project, Remarkup
calfzhou added a comment to T1894: Support commenting on Phriction documents.

inline-comment is really a good feature to have.

Nov 21 2014, 6:36 AM · Restricted Project, Restricted Project, Phriction

Nov 14 2014

btrahan closed T6472: Phriction update emails no longer provide link to diff as Resolved.

Closed by commit rPb85283105ece.

Nov 14 2014, 12:54 AM · Transactions, Phriction
btrahan added a revision to T6472: Phriction update emails no longer provide link to diff: Restricted Differential Revision.
Nov 14 2014, 12:52 AM · Transactions, Phriction

Nov 13 2014

btrahan closed T6542: The view wiki item disappeared in head as Wontfix.
Nov 13 2014, 3:20 PM · Phriction
• philippe.jadin reopened T6542: The view wiki item disappeared in head as "Open".
Nov 13 2014, 9:43 AM · Phriction
• philippe.jadin added a comment to T6542: The view wiki item disappeared in head.

This is a regression imvho. Instead of 1:1, do many to many.

Nov 13 2014, 9:42 AM · Phriction

Nov 12 2014

btrahan added a comment to T6542: The view wiki item disappeared in head.

As you've guessed, the expectations around the automagicalness of the wiki <--> project link were hard to get right technically. Additionally, said automagicalness was considered too rigid by some, particularly as policy controls have become available throughout Phabricator.

Nov 12 2014, 11:03 PM · Phriction
• philippe.jadin added a comment to T6542: The view wiki item disappeared in head.

A more integrated wiki is very interesting. Why did you remove this feature?

Nov 12 2014, 8:30 PM · Phriction
btrahan closed T6542: The view wiki item disappeared in head as Wontfix.

This change was intentional.

Nov 12 2014, 8:21 PM · Phriction
• philippe.jadin created T6542: The view wiki item disappeared in head.
Nov 12 2014, 8:19 PM · Phriction
epriestley closed T5492: Make wiki move dialog more intuitive and validate input as Resolved.

Closed by commit rP120a7d916447.

Nov 12 2014, 3:04 PM · Phriction
btrahan closed T6530: Unable to edit any Phriction documents as Resolved.

This is most definitely fixed at HEAD. Please do let us know if thats not working for you.

Nov 12 2014, 2:58 PM · Phriction
epriestley added a comment to T5492: Make wiki move dialog more intuitive and validate input.

D10838 does not specifically handle the URI case as a special case, but it removes the misleading UI (which prompted you to enter a "URI"), provides more hints about expected format, and will prompt you to confirm before we use a modified form of what you entered (URIs hit this prompt, although mostly by accident). I think this should be sufficient to reduce confusion.

Nov 12 2014, 2:30 PM · Phriction
epriestley added a revision to T5492: Make wiki move dialog more intuitive and validate input: Restricted Differential Revision.
Nov 12 2014, 2:22 PM · Phriction
epriestley claimed T5492: Make wiki move dialog more intuitive and validate input.
Nov 12 2014, 1:13 PM · Phriction
epriestley removed a project from T5410: Make wiki creation dialog more user friendly: Badge Awarded.
Nov 12 2014, 1:11 PM · Phriction
epriestley added a comment to T6530: Unable to edit any Phriction documents.

Yeah, I suspect this is fixed at HEAD.

Nov 12 2014, 12:33 PM · Phriction
hach-que added a comment to T6530: Unable to edit any Phriction documents.

Won't be able to re-upgrade and test that commit for another 10 hours or so as we're in the middle of migrating Harbormaster build logs for the utf8mb process (I moved the table and wrote a script to migrate the logs while Phabricator is online). Will try tomorrow.

Nov 12 2014, 6:35 AM · Phriction
chad added a comment to T6530: Unable to edit any Phriction documents.

99bcf06 fixed a number of Phriction queries

Nov 12 2014, 6:20 AM · Phriction
chad added a comment to T6530: Unable to edit any Phriction documents.

I am not able to repro at HEAD. Can you update and report back?

Nov 12 2014, 6:16 AM · Phriction
hach-que added a comment to T6530: Unable to edit any Phriction documents.

For some weird reason, the behaviour is:

Nov 12 2014, 6:07 AM · Phriction
hach-que created T6530: Unable to edit any Phriction documents.
Nov 12 2014, 6:05 AM · Phriction
epriestley closed T4666: Support Herald in Phriction as Resolved.

Closed by commit rP8e1a4eef0400.

Nov 12 2014, 2:29 AM · Phriction, Herald
btrahan closed T6527: On a totally empty Phriction wiki, default page shows "Unknown Object (????)" as policy as Resolved.

Closed by commit rP36c46d80f5a0.

Nov 12 2014, 2:16 AM · Policy, Phriction
epriestley added a comment to T6527: On a totally empty Phriction wiki, default page shows "Unknown Object (????)" as policy.

Ah, that makes sense.

Nov 12 2014, 2:15 AM · Policy, Phriction
btrahan added a revision to T6527: On a totally empty Phriction wiki, default page shows "Unknown Object (????)" as policy: Restricted Differential Revision.
Nov 12 2014, 2:15 AM · Policy, Phriction
btrahan added a comment to T6527: On a totally empty Phriction wiki, default page shows "Unknown Object (????)" as policy.

This repros at any new page, e.g. https://secure.phabricator.com/w/asdsadsadsadasd/

Nov 12 2014, 2:14 AM · Policy, Phriction
btrahan claimed T6527: On a totally empty Phriction wiki, default page shows "Unknown Object (????)" as policy.
Nov 12 2014, 2:06 AM · Policy, Phriction
epriestley created T6527: On a totally empty Phriction wiki, default page shows "Unknown Object (????)" as policy.
Nov 12 2014, 1:51 AM · Policy, Phriction

Nov 11 2014

btrahan moved T5492: Make wiki move dialog more intuitive and validate input from Backlog to Needs A Guide on the Badge Awarded board.
Nov 11 2014, 11:24 PM · Phriction
btrahan closed T6506: Phriction - some weird project ties remain as Resolved.

Closed by commit rPb462a80cca31.

Nov 11 2014, 9:45 PM · Phriction
btrahan added a revision to T6506: Phriction - some weird project ties remain: Restricted Differential Revision.
Nov 11 2014, 9:41 PM · Phriction
btrahan added a revision to T6506: Phriction - some weird project ties remain: Restricted Differential Revision.
Nov 11 2014, 9:25 PM · Phriction
btrahan closed T6495: Phriction document titles are visible even if you can't see the document as Resolved.

Closed by commit rP9252d2a579e3.

Nov 11 2014, 9:18 PM · Policy, Phriction
lpriestley added a revision to T4666: Support Herald in Phriction: Restricted Differential Revision.
Nov 11 2014, 7:28 PM · Phriction, Herald
epriestley updated subscribers of T6506: Phriction - some weird project ties remain.

https://github.com/phacility/phabricator/issues/759 notes a documentation issue too, although maybe @chad wants to steal some internet points.

Nov 11 2014, 3:40 AM · Phriction

Nov 9 2014

btrahan created T6506: Phriction - some weird project ties remain.
Nov 9 2014, 2:41 AM · Phriction
btrahan added a revision to T6495: Phriction document titles are visible even if you can't see the document: Restricted Differential Revision.
Nov 9 2014, 2:41 AM · Policy, Phriction
btrahan closed T6496: Phriction should check for edit permissions on x/y/ before letting you create x/y/z/ as Resolved.

Closed by commit rP6f971a0fc4d8.

Nov 9 2014, 2:12 AM · Policy, Phriction

Nov 8 2014

btrahan closed T5642: Add Phriction to the list of apps in settings/panel/emailpreferences/ as Resolved.
Nov 8 2014, 8:16 PM · Phriction
epriestley assigned T4666: Support Herald in Phriction to lpriestley.

Herald allows users to write rules which react to changes in objects they care about (for example, by notifying the user of the change). We'd like to support Phriction (the wiki) in Herald, so users can easily monitor changes to wiki pages. (One example use case is that I'd personally like to be notified about any edit to any wiki page on this install).

Nov 8 2014, 1:08 PM · Phriction, Herald
epriestley added a comment to T6004: When moving a wiki page with subpages prompt to also move subpages.

Also relevant, T5166 discusses a UI + infrastructure approach to letting long-running workflows (e.g., batch edit 1K tasks, move 1K documents) run through the web UI.

Nov 8 2014, 12:26 PM · Phriction
btrahan lowered the priority of T3975: Add the ability to show Google Docs in Remarkup from Low to Wishlist.
Nov 8 2014, 8:00 AM · Remarkup
btrahan added a comment to T6004: When moving a wiki page with subpages prompt to also move subpages.

From T2685, a more complete spec from epriestley:

Nov 8 2014, 7:59 AM · Phriction
btrahan updated subscribers of T6004: When moving a wiki page with subpages prompt to also move subpages.
Nov 8 2014, 7:58 AM · Phriction
btrahan closed T5389: Moving a wiki doc to the automatic location of a project page might not work properly as Resolved.

The magical projects stuff is gone. Any legacy documents have the project policy, and then otherwise folks can create documents whereever policy allows. See T4029 for details.

Nov 8 2014, 7:56 AM · Phriction, Projects
btrahan closed T4923: Renaming a project causes its "subdocuments" to become inaccessible as Resolved.

I can't find any sort of bug here anymore.

Nov 8 2014, 7:53 AM · Phriction
btrahan added a revision to T6496: Phriction should check for edit permissions on x/y/ before letting you create x/y/z/: Restricted Differential Revision.
Nov 8 2014, 6:47 AM · Policy, Phriction
btrahan closed T6497: PhrictionDocumentQuery still has a project-respecting hunk of code as Resolved.

Closed by commit rPb655699a6cfb.

Nov 8 2014, 6:34 AM · Policy, Phriction
epriestley added a comment to T6495: Phriction document titles are visible even if you can't see the document.

To see x/y/z/ you have to be able to see x/ and x/y/, so it should be moot I think.

Nov 8 2014, 3:03 AM · Policy, Phriction
btrahan added a comment to T6495: Phriction document titles are visible even if you can't see the document.

Implementation wise, I think the handle fix is the way to go, mainly because....

Nov 8 2014, 2:20 AM · Policy, Phriction
btrahan claimed T6496: Phriction should check for edit permissions on x/y/ before letting you create x/y/z/.
Nov 8 2014, 2:13 AM · Policy, Phriction
btrahan added a revision to T6497: PhrictionDocumentQuery still has a project-respecting hunk of code : Restricted Differential Revision.
Nov 8 2014, 2:11 AM · Policy, Phriction
epriestley added a comment to T4029: Support policies on Phriction wiki articles.

For anyone waiting on this with bated breath, there are a couple of minor followups in T6495, T6496, and T6497 to iron out some details.

Nov 8 2014, 12:45 AM · Support Impact, Phriction