Page MenuHomePhabricator
Create Task
Maniphest T6530

Unable to edit any Phriction documents
Closed, ResolvedPublic
Actions

Description

After upgrading to 95df771, we can no longer seem to edit any Phriction documents. The "Edit Document" link appears, but when clicking edit a 404 is shown.

Related Objects

Event Timeline

hach-que created this task.Nov 12 2014, 6:05 AM
hach-que assigned this task to epriestley.
hach-que raised the priority of this task from to Needs Triage.
hach-que updated the task description. (Show Details)
hach-que added a project: Phriction.
hach-que added a subscriber: hach-que.

For some weird reason, the behaviour is:

  • When editing a top level document with no children, I get a 404.
  • When editing a top level document with children, I get the edit page of the first child.
chad added a subscriber: chad.Nov 12 2014, 6:16 AM

I am not able to repro at HEAD. Can you update and report back?

chad added a comment.Nov 12 2014, 6:20 AM

99bcf06 fixed a number of Phriction queries

hach-que added a comment.Nov 12 2014, 6:35 AM

Won't be able to re-upgrade and test that commit for another 10 hours or so as we're in the middle of migrating Harbormaster build logs for the utf8mb process (I moved the table and wrote a script to migrate the logs while Phabricator is online). Will try tomorrow.

epriestley added a comment.Nov 12 2014, 12:33 PM

Yeah, I suspect this is fixed at HEAD.

We were accidentally selecting all columns from a JOIN, but some were ambiguous, so we'd get back a Document which had its id field populated with the id from the wrong table in some cases. Then "Edit" would point at a meaningless (404 or unrelated) ID.

btrahan closed this task as Resolved.Nov 12 2014, 2:58 PM
btrahan added a subscriber: btrahan.

This is most definitely fixed at HEAD. Please do let us know if thats not working for you.

Phabricator · Built by Phacility