Page MenuHomePhabricator

Phriction documents looks horrible on Firefox
Closed, ResolvedPublic

Assigned To
None
Authored By
skibbipl
Jan 28 2015, 10:46 AM
Referenced Files
F277552: Firefox35.png
Jan 28 2015, 8:49 PM
F277554: Midori058.png
Jan 28 2015, 8:49 PM
F277490: Screen_Shot_2015-01-28_at_9.22.17_AM.png
Jan 28 2015, 5:26 PM
F277493: Screen_Shot_2015-01-28_at_9.22.25_AM.png
Jan 28 2015, 5:26 PM
F277495: Screen_Shot_2015-01-28_at_9.22.56_AM.png
Jan 28 2015, 5:26 PM
F277313: good.png
Jan 28 2015, 10:46 AM
F277307: bad.png
Jan 28 2015, 10:46 AM

Description

Hello,
Phriction documents look horrible on my firefox. I checked the css and it seems Phabricator uses SourceSansPro font for rendering the text. But it seems it uses old version. I redowloaded the files from google and font rendering is looking perfect.
This is how documentation looks with old font:

bad.png (468×803 px, 46 KB)

After update it looks like this (my phabricator instance):

good.png (331×849 px, 21 KB)

Please update SourceSansPro font and include Latin Extended charset (if possible)

Regards

Event Timeline

skibbipl raised the priority of this task from to Needs Triage.
skibbipl updated the task description. (Show Details)
skibbipl added a subscriber: skibbipl.

Can you be more specific for which version of Firefox/OS and which SourceSansPro you used. We prefer to be able to test and know we resolved a bug. Thanks!

Looks like adding extended triples the file size. Is extended required by you?

If you could provide a testable Phriction document on this install, that would be very helpful.

I'm not able to find a reproducible case here, I tested current Firefox (35) in Mac, Windows, and Linux:

Screen_Shot_2015-01-28_at_9.22.17_AM.png (2×2 px, 614 KB)

Screen_Shot_2015-01-28_at_9.22.25_AM.png (2×3 px, 1 MB)

Screen_Shot_2015-01-28_at_9.22.56_AM.png (2×2 px, 214 KB)

Hey @chad - Latin Extended would be useful for anybody in central/eastern europe. It does make font bigger, but some DO need it (and it may look horrible without it). My install also looks fine, so maybe I simply have good set of fonts already present on my system and Firefox selects proper ones?

As for testing Latin Extended, try placing following text anywhere and see if any character looks off:

"Zażółcić gęślą jaźń" "Żąć gęś łań, Róź?", "Żąć gęś łań, Jóź?", "Żąć gęś łań? Wóź!" - For PL characters
Nechť již hříšné saxofony ďáblů rozzvučí síň úděsnými tóny waltzu, tanga a quickstepu. - For CZ characters
Jámbor célú, öv ügyű ex-qwan ki dó-s főz, puhít - For HU characters...

Please use following as a test page: https://secure.phabricator.com/w/test_page/pangrams/

I built a version of "everything" Source Sans as a woff2 file in my sandbox, I just can't seem to find a place where it actually fixes anything. I did something similar to my local sandbox like you're Phriction document.

I don't mind committing the woff2 files, but it'd be nice to prove it fixes something. :)

Well, mine install + This one looks ok. On firefox at least.

This is Firefox 35 + Gentoo linux updated ~24h ago:

Firefox35.png (1×986 px, 115 KB)

Here's Somewhat off in Midori 0.5.8

Midori058.png (1×952 px, 98 KB)

And that's all browsers I have here. So... Needs more reports?

Latin Extended according to Adobe:

Welsh, archaic Danish and Esperanto.

You can see if D11545 renders any better or not, not sure I see a difference.

Firefox doesn't officially support woff2 (http://caniuse.com/#feat=woff2) but this is a step to supporting more languages on some browsers. I'll continue to look into building more support (we really like Source Sans).

In T7066#93467, @chad wrote:

Latin Extended according to Adobe:

Welsh, archaic Danish and Esperanto.

That's actually ASCII + ISO-8859-1. Extended latin alphabets need characters in ISO-8859-2..15

So - How about Latin Extended according to Unicode? Latin Extended-A (fixes almost all latin based alphabets) + Latin Extended-B (fixes every tiny Slovenian/Croatian/Romanian diacritic)...

Or maybe (if font file size is issue) give users option to use Latin (default) or compile whole font configured for their use?

In T7066#93472, @chad wrote:

Firefox doesn't officially support woff2 (http://caniuse.com/#feat=woff2) but this is a step to supporting more languages on some browsers. I'll continue to look into building more support (we really like Source Sans).

It looks like Woff2 will land in 36. it's working for 35 behind preference wall:
https://developer.mozilla.org/en-US/docs/Web/Guide/WOFF

@chad
Thanks for adding latin extended font. And my firefox supports woff2 already (I use this version).
And the font rendering issue is only reproducible on my laptop, currenty I work on my normal computer and phirction looks fine. My laptop has Windows 8.1 x64 Polish version. Perhaps the issue is triggered by language settings. Anyway I hope updated woff2 fonts to solve the issue. Currently I use this fonts on my local instance (woff, not woff2):
http://fonts.googleapis.com/css?family=Source+Sans+Pro:400,700&subset=latin,latin-ext
Also the issue is not reproducible on IE.

We are likely to move Conpherence to Source Sans as well, so shoring up any issues will be important.