Even with OAuth, you still can't make AJAX requests to Conduit from client-side JavaScript, right? Is the idea that the backend code uses OAuth to talk to Conduit on a user's behalf?

Think I got through the easy ones without any issues. I suspect admin and secure may be a little more involved so I'm going to leave the cat in the bag for the moment.

I'm going to stop/start at least some of these now.

See PHI757. Leaving inline comments on the right hand side of files not touched by diff B in an interdiff between A and B raises an error.

I'm going to push this out to next week since D19586 probably has a few minor issues with it and it's close to the release cut. It adds a lot of new policy checks which weren't explicit before, so I'd guess it may cause a few improper policy errors on things which are actually allowed. I caught a bunch of them (like "Mute Thread") but probably didn't get every single one.

These are actually removed in 2018 Week 33. See T13186 for a small amount of followup and discussion, although there isn't too much new information beyond what's here.

Oh, right, "meetings". I've heard of those!

In T13062#235217, @epriestley wrote:

This is also showing up in initial email, which is silly and pointless.

I'm touching some adjacent code for a "Disable User" permission in T13164.

Hahah you beat me to it!

I think T13183 is the exact same hosts. :)

In T13185#240300, @epriestley wrote:

Same as T13183?

Same as T13183?

The root use case here was a desire for a better sense of how often certain rules were firing, and we improved the push logs instead to address this more directly (D19555, D19556, D19557).

I did rebuild-identities on every instance

The "activity" migration went to production just now. I expect all production instances just bailed out, since I ran rebuild-identities some time ago, but I'll verify that:

I believe this was fixed by D17558 and discussed in T11050.

Somewhat related:

T13182 was a resurgence of this exact issue, but I'm currently banking on the fix being a move to Ubuntu 16 with T13076 before this breaks again, given that it was stable for ~18 months.

That appears to have fixed it, so this was just T12171-redux.