Page MenuHomePhabricator
Feed Advanced Search

May 20 2017

epriestley merged task T12736: Missing function function_exists check leads to uncaught exception into T12570: Installs without `gd` are unable to reach the setup warning telling them to install `gd`.
May 20 2017, 11:00 AM · Bug Report
mydeveloperday updated the task description for T12736: Missing function function_exists check leads to uncaught exception.
May 20 2017, 8:50 AM · Bug Report
mydeveloperday updated the task description for T12736: Missing function function_exists check leads to uncaught exception.
May 20 2017, 8:49 AM · Bug Report
mydeveloperday created T12736: Missing function function_exists check leads to uncaught exception.
May 20 2017, 8:48 AM · Bug Report
chad added a revision to T12735: InvalidArgumentException when viewing a room you haven't joined from Safari: Restricted Differential Revision.
May 20 2017, 4:42 AM · Bug Report
chad closed T12728: Newly created Phriction document doesn't appear in hierarchy as Resolved.
May 20 2017, 2:50 AM · Phriction, Bug Report

May 19 2017

chad added a comment to T12735: InvalidArgumentException when viewing a room you haven't joined from Safari.

It's inconsistent because you need to be watching a room and someone has to post a message (in order to trigger a sound). Thanks for the report!

May 19 2017, 11:46 PM · Bug Report
chaseh created T12735: InvalidArgumentException when viewing a room you haven't joined from Safari.
May 19 2017, 11:28 PM · Bug Report
chad added a comment to T12728: Newly created Phriction document doesn't appear in hierarchy.

No this is good, master gets promoted weekly, so this is a bug in master that will be promoted unless we fix it.

May 19 2017, 4:09 PM · Phriction, Bug Report
cspeckmim added a comment to T12726: Errors when trying to create a diff with arcanist.

Any weird environment variables defined on those workstations? Also add --trace to the arc diff command might give more details

May 19 2017, 3:01 PM · Mercurial, Differential, Arcanist, Bug Report
franjesus added a comment to T12726: Errors when trying to create a diff with arcanist.

Just tried it, didn't help :(

May 19 2017, 2:48 PM · Mercurial, Differential, Arcanist, Bug Report
mcorteel added a comment to T12728: Newly created Phriction document doesn't appear in hierarchy.

And by doing that, I realize that I have been keeping up with master instead of stable like an (oh, there's no donkey emoji, too bad...).
So it's fixed... Sorry!

May 19 2017, 1:59 PM · Phriction, Bug Report
chad claimed T12728: Newly created Phriction document doesn't appear in hierarchy.
May 19 2017, 1:59 PM · Phriction, Bug Report
mcorteel added a comment to T12728: Newly created Phriction document doesn't appear in hierarchy.

Sorry, it completely slipped my mind!

May 19 2017, 1:54 PM · Phriction, Bug Report
epriestley added a comment to T12729: CLI scripts do not detect execution with bad SAPI binary (like `fcgi` instead of `cli` under cPanel).

Your system has php-fcgi installed on the CLI (note cgi-fcgi in the output). This is incorrect. Replace this binary with a php-cli SAPI binary.

May 19 2017, 12:34 PM · Setup
atul.agrawal9911 updated the task description for T12729: CLI scripts do not detect execution with bad SAPI binary (like `fcgi` instead of `cli` under cPanel).
May 19 2017, 12:28 PM · Setup
atul.agrawal9911 added a comment to T12729: CLI scripts do not detect execution with bad SAPI binary (like `fcgi` instead of `cli` under cPanel).
ea-php-cli Copyright 2016 cPanel, Inc.
PHP 5.6.30 (cgi-fcgi) (built: May 17 2017 20:27:47)
Copyright (c) 1997-2016 The PHP Group
Zend Engine v2.6.0, Copyright (c) 1998-2016 Zend Technologies
    with the ionCube PHP Loader v4.7.5, Copyright (c) 2002-2014, by ionCube Ltd., and
    with Zend OPcache v7.0.6-dev, Copyright (c) 1999-2016, by Zend Technologies
May 19 2017, 12:27 PM · Setup
cspeckmim added a comment to T12726: Errors when trying to create a diff with arcanist.

What if you disable the extdiff extension? The documentation doesn't mention modifying regular diff output but probably worth trying.

May 19 2017, 12:21 PM · Mercurial, Differential, Arcanist, Bug Report
epriestley added a comment to T12728: Newly created Phriction document doesn't appear in hierarchy.

How could we make it more clear that we require version information for bug reports? Here's how we currently communicate this, but it seems like it didn't work well in this case. Is there a way we could improve this or make it more clear?

May 19 2017, 12:13 PM · Phriction, Bug Report
epriestley added a comment to T12729: CLI scripts do not detect execution with bad SAPI binary (like `fcgi` instead of `cli` under cPanel).

Can you show me the output of this command?

May 19 2017, 12:08 PM · Setup
franjesus added a comment to T12726: Errors when trying to create a diff with arcanist.

We have installed mercurial 3.9.2 both in the server and client, in fact we downgraded the client mercurial from 4.1 to 3.9.2 to match the versions, but nothing changed. The version of arcanist is 3c4735795a29 (pre-last commit) and phabricator is at ef839192aa5a (from Tuesday).

May 19 2017, 9:56 AM · Mercurial, Differential, Arcanist, Bug Report
atul.agrawal9911 created T12729: CLI scripts do not detect execution with bad SAPI binary (like `fcgi` instead of `cli` under cPanel).
May 19 2017, 9:52 AM · Setup
mcorteel added a comment to T12728: Newly created Phriction document doesn't appear in hierarchy.

I have been updating the DB manually to set status back to 0 as a workaround for now. But you could probably see how this affects our workflow!

May 19 2017, 9:19 AM · Phriction, Bug Report
mcorteel created T12728: Newly created Phriction document doesn't appear in hierarchy.
May 19 2017, 9:17 AM · Phriction, Bug Report

May 18 2017

• Ondrej created T12727: Mail handler unable to parse e-mail from MS Outlook 12, Failed to JSON encode value.
May 18 2017, 8:18 PM · Bug Report
cspeckmim added a project to T12726: Errors when trying to create a diff with arcanist: Mercurial.

Please identify the versions of mercurial used on client/server, also the version of Phabricator in use. If you're on an older version of Phabricator it's possible that upgrading may resolve the issue.

May 18 2017, 5:57 PM · Mercurial, Differential, Arcanist, Bug Report
chad updated subscribers of T12726: Errors when trying to create a diff with arcanist.

I don't personally, since I neither use hg or windows, but maybe @cspeckmim from the community has some suggestions.

May 18 2017, 4:11 PM · Mercurial, Differential, Arcanist, Bug Report
franjesus added a comment to T12726: Errors when trying to create a diff with arcanist.

I tried to reproduce with other users, on the same phabricator install but there is only one user with a particular windows setup (that has nothing different from other users except for his particular windows machine) that is experiencing this problem. I tried following the stack trace and adding some error_log's on the php. But my php knowledge is close to zero. In any case something like this:

May 18 2017, 3:59 PM · Mercurial, Differential, Arcanist, Bug Report
chad closed T12726: Errors when trying to create a diff with arcanist as Invalid.

Please read and follow Contributing Bug Reports.

May 18 2017, 3:44 PM · Mercurial, Differential, Arcanist, Bug Report
franjesus created T12726: Errors when trying to create a diff with arcanist.
May 18 2017, 3:23 PM · Mercurial, Differential, Arcanist, Bug Report
avivey closed T12279: Timezone Asia/Jerusalem incorrectly listed under UTC-0 as Resolved.

We need a "Resolved: Ghosts" status.

May 18 2017, 6:49 AM · Bug Report

May 17 2017

amckinley created T12723: A failure to upload a file in the Pholio Mock editor doesn't dismiss the "Uploading..." UI.
May 17 2017, 11:20 PM · Pholio, Bug Report
zhiyuchen updated the task description for T12722: Auto-resolve with "Fix: T..." commit message should not reopen a closed bug.
May 17 2017, 6:56 PM · Bug Report (Needs Information)
zhiyuchen updated the task description for T12722: Auto-resolve with "Fix: T..." commit message should not reopen a closed bug.
May 17 2017, 6:56 PM · Bug Report (Needs Information)
chad added a comment to T12722: Auto-resolve with "Fix: T..." commit message should not reopen a closed bug.

(Offhand this sounds expected)

May 17 2017, 6:44 PM · Bug Report (Needs Information)
chad added a comment to T12722: Auto-resolve with "Fix: T..." commit message should not reopen a closed bug.

Bug reports require version information, and repeatable, detailed reproduction information. Please!

May 17 2017, 6:42 PM · Bug Report (Needs Information)
zhiyuchen updated the task description for T12722: Auto-resolve with "Fix: T..." commit message should not reopen a closed bug.
May 17 2017, 6:35 PM · Bug Report (Needs Information)
zhiyuchen created T12722: Auto-resolve with "Fix: T..." commit message should not reopen a closed bug.
May 17 2017, 6:34 PM · Bug Report (Needs Information)
zhiyuchen added a comment to T12280: mov and m4v videos don't play .

@epriestley I see, tried the same steps and it doesn't play directly within chrome. Thanks for investigating.

May 17 2017, 6:23 PM · Bug Report
chad added a comment to T12280: mov and m4v videos don't play .

I can't play it in Chrome in any circumstance.

May 17 2017, 6:22 PM · Bug Report
epriestley added a comment to T12280: mov and m4v videos don't play .

I can not play the .mov file in Chrome no matter what I try:

May 17 2017, 6:20 PM · Bug Report
zhiyuchen added a comment to T12280: mov and m4v videos don't play .

@chad The first video still doesn't play in Chrome (Version 58.0.3029.110 (64-bit); seems working in FF and safari now.

May 17 2017, 6:16 PM · Bug Report
chad added a comment to T12280: mov and m4v videos don't play .
May 17 2017, 6:15 PM · Bug Report
zhiyuchen added a comment to T12280: mov and m4v videos don't play .

This is what I see in chrome (Version 58.0.3029.110 (64-bit))

image.png (678×1 px, 65 KB)

May 17 2017, 6:13 PM · Bug Report
epriestley added a comment to T12280: mov and m4v videos don't play .

Here's a screenshot of this working correctly for me in Safari:

May 17 2017, 6:12 PM · Bug Report
zhiyuchen added a comment to T12279: Timezone Asia/Jerusalem incorrectly listed under UTC-0.

@avivey I no longer run into this problem, please feel free to close this bug.

May 17 2017, 6:11 PM · Bug Report
zhiyuchen added a comment to T12280: mov and m4v videos don't play .

@epriestley not sure if the current phabricator install has been upgraded to lastest code that contains this fix yet, but the first video included in this bug which is a mov file still doesn't play. If I download it, it works, so the mov file itself is working.

May 17 2017, 6:09 PM · Bug Report
mpadourek added a comment to T12721: arc land failed with error #1, Already on 'branch-name'.

While it would have saved me some time and some wondering if this kind of error message would have been in place I agree, it would ideally be in git. I'll see if there is anything about that on the git front.

May 17 2017, 5:01 PM · Bug Report
epriestley added a comment to T12721: arc land failed with error #1, Already on 'branch-name'.

We could say "checkout failed, you might have a bad hook" but I'd want to wait for more users to run into this first, and maybe try to pursue a fix in git with the upstream.

May 17 2017, 4:48 PM · Bug Report
epriestley closed T12721: arc land failed with error #1, Already on 'branch-name' as Invalid.

There doesn't appear to be any reasonable way for us to perform something like git checkout --skip-hooks, and I think we shouldn't even if we could.

May 17 2017, 4:47 PM · Bug Report
mpadourek added a comment to T12721: arc land failed with error #1, Already on 'branch-name'.

Ha yeah that is interesting

May 17 2017, 4:43 PM · Bug Report
epriestley added a comment to T12721: arc land failed with error #1, Already on 'branch-name'.

Can you show me the output of these commands?

May 17 2017, 4:38 PM · Bug Report
mpadourek created T12721: arc land failed with error #1, Already on 'branch-name'.
May 17 2017, 4:29 PM · Bug Report
ernie updated the task description for T12718: Local email validation with apostrophe.
May 17 2017, 2:25 PM · Bug Report
epriestley closed T12719: Query: Active Repository shows wrong HEAD commit as Invalid.

This is a productive environment, so I could not test to reproduce it and I don't know how can I reproduce it.

May 17 2017, 11:02 AM · Bug Report
QuietJoon updated the task description for T12719: Query: Active Repository shows wrong HEAD commit.
May 17 2017, 7:23 AM · Bug Report
QuietJoon updated the task description for T12719: Query: Active Repository shows wrong HEAD commit.
May 17 2017, 7:21 AM · Bug Report
QuietJoon updated the task description for T12719: Query: Active Repository shows wrong HEAD commit.
May 17 2017, 7:18 AM · Bug Report
QuietJoon created T12719: Query: Active Repository shows wrong HEAD commit.
May 17 2017, 7:17 AM · Bug Report
ernie added a comment to T12718: Local email validation with apostrophe.

Okay, but just to point out: having an apostrophe in one's name is not that exotic...

  • O'Brien
  • O'Connor
  • D'Angelo
  • O'Dowd
  • O'Malley
  • O'Hara
  • D'Arcy
  • D'Addario

So someone could quite conceivably have Chris.O'Dowd@BBC.co.uk or something like that.
Anyway, if anyone's looking for how to get around this in the future, an alternate solution to changing PhabricatorUserEmail.php would be to go into the DB phabricator_user, in table user_email, and change it directly in there, thus bypassing validation.
If you did want to change the code, though, look into http://php.net/manual/en/filter.examples.validation.php - FILTER_VALIDATE_EMAIL and FILTER_SANITIZE_EMAIL.

May 17 2017, 4:22 AM · Bug Report
epriestley changed the status of T12718: Local email validation with apostrophe from Duplicate to Wontfix.

Per T12359, we aren't interested in supporting technically-deliverable-but-bizzarely-exotic addresses in the upstream. Feel free to fork to support this kind of address.

May 17 2017, 3:55 AM · Bug Report
epriestley merged T12718: Local email validation with apostrophe into T12359: Registration does not accept valid email addresses.
May 17 2017, 3:54 AM · Bug Report
epriestley merged task T12718: Local email validation with apostrophe into T12359: Registration does not accept valid email addresses.
May 17 2017, 3:54 AM · Bug Report
ernie updated the task description for T12718: Local email validation with apostrophe.
May 17 2017, 3:45 AM · Bug Report
ernie created T12718: Local email validation with apostrophe.
May 17 2017, 3:28 AM · Bug Report

May 16 2017

epriestley closed T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately as Resolved by committing Restricted Diffusion Commit.
May 16 2017, 6:10 PM · Inline Comments, Differential, Bug Report
epriestley closed T11784: Differential "stick to the comment area" and "jump to anchor" scroll behaviors interact destructively while loading content as Resolved by committing Restricted Diffusion Commit.
May 16 2017, 6:06 PM · Inline Comments, Differential, Bug Report
epriestley added a revision to T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately: Restricted Differential Revision.
May 16 2017, 6:06 PM · Inline Comments, Differential, Bug Report
epriestley renamed T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately from Jumping to an inline comment via URL anchor should highlight it with the keyboard focus reticle to Jumping to an reply inline comment via URL anchor should highlight the comment node accurately.
May 16 2017, 5:39 PM · Inline Comments, Differential, Bug Report
epriestley added a comment to T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately.

I'm inclined not to actually pursue the autofocus approach I was considering before, at least until we get a better read on whether click-to-select is a good behavior or not. Instead, I'm just going to fiddle with the UI a bit to fix the alignment issue. The new hidden inline state has some similar alignment issues.

May 16 2017, 5:38 PM · Inline Comments, Differential, Bug Report
epriestley added a revision to T11784: Differential "stick to the comment area" and "jump to anchor" scroll behaviors interact destructively while loading content: Restricted Differential Revision.
May 16 2017, 5:21 PM · Inline Comments, Differential, Bug Report
epriestley closed T12153: 'Show Hidden Comments' bubble does not fit in margin next to line numbers >1000 as Resolved by committing Restricted Diffusion Commit.
May 16 2017, 1:20 PM · Inline Comments, Differential, Bug Report
epriestley added a comment to T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL.

That's partly because "\n" isn't a newline in bash:

May 16 2017, 12:58 PM · Bug Report
reet- added a comment to T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL.

Yes, the behavior depends on the shell. I was using bash.

May 16 2017, 12:56 PM · Bug Report
sgielen added a comment to T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL.

Ah, I see that it works differently in other shells. The above output was from zsh. In bash, indeed all output is written to the file:

May 16 2017, 12:52 PM · Bug Report
sgielen added a comment to T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL.

It shows no output because there are no warnings. If you replace phabricator/bin/storage dump with a command that does give various formats of warnings on stderr, you see that it works:

$ sh -c 'echo "output1"; echo "error\nwarning\nerror2" 1>&2; echo "output2"' >foo.txt 2> >(grep -v warning)
error
error2
$ cat foo.txt
output1
output2
May 16 2017, 12:47 PM · Bug Report
reet- added a comment to T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL.

I'm not sure this works as expected.

May 16 2017, 12:36 PM · Bug Report
sgielen added a comment to T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL.

I used the subshell redirection trick as mentioned by @epriestley to hide this warning from our cron output as well:

May 16 2017, 11:43 AM · Bug Report
wjiang added a comment to T12716: PHPCompatibility lint rule can't handle namespaced class/function name..
In T12716#223717, @chad wrote:

I assume this is T4334

May 16 2017, 3:03 AM · Bug Report
chad added a comment to T12716: PHPCompatibility lint rule can't handle namespaced class/function name..

I assume this is T4334

May 16 2017, 2:27 AM · Bug Report
wjiang updated the task description for T12716: PHPCompatibility lint rule can't handle namespaced class/function name..
May 16 2017, 2:07 AM · Bug Report
wjiang created T12716: PHPCompatibility lint rule can't handle namespaced class/function name..
May 16 2017, 2:06 AM · Bug Report

May 15 2017

chad renamed T12714: `differential.createcomment` can race automatic revision closure from differential.createcomment can race automatic revision closure to `differential.createcomment` can race automatic revision closure.
May 15 2017, 6:27 PM · Transactions, Bug Report, Restricted Project
chad added a comment to T12714: `differential.createcomment` can race automatic revision closure.

uuuuuuuuuuuuuugh

May 15 2017, 5:38 PM · Transactions, Bug Report, Restricted Project
chad renamed T12714: `differential.createcomment` can race automatic revision closure from `differential.createcomment` can race automatic revision closure to differential.createcomment can race automatic revision closure.
May 15 2017, 5:38 PM · Transactions, Bug Report, Restricted Project
epriestley removed a project from T12714: `differential.createcomment` can race automatic revision closure: EditEngine.
May 15 2017, 5:10 PM · Transactions, Bug Report, Restricted Project
epriestley added a project to T12714: `differential.createcomment` can race automatic revision closure: EditEngine.
May 15 2017, 5:10 PM · Transactions, Bug Report, Restricted Project
epriestley added a project to T12714: `differential.createcomment` can race automatic revision closure: Transactions.
May 15 2017, 5:10 PM · Transactions, Bug Report, Restricted Project
epriestley created T12714: `differential.createcomment` can race automatic revision closure.
May 15 2017, 5:09 PM · Transactions, Bug Report, Restricted Project
chad closed T12713: Can't view user profiles as Resolved by committing Restricted Diffusion Commit.
May 15 2017, 4:05 PM · Bug Report
chad added a revision to T12713: Can't view user profiles: Restricted Differential Revision.
May 15 2017, 3:59 PM · Bug Report
epriestley reassigned T12713: Can't view user profiles from epriestley to chad.
May 15 2017, 3:48 PM · Bug Report
epriestley added a comment to T12713: Can't view user profiles.

Go for it, a couple emails came in that I'm still digging through. Thanks!

May 15 2017, 3:47 PM · Bug Report
chad added a comment to T12713: Can't view user profiles.

Do you have this or should I snipe? I'm home now.

May 15 2017, 3:47 PM · Bug Report
epriestley added a comment to T12455: Tag order on tasks matters for subprojects and milestones.

We currently (at least, in theory) prevent this situation from ever occurring by preventing simultaneous tagging with both "Warp Drive > Thermocoupling" and "Warp Drive > Milestone 1". Since a task can not appear in both a milestone and subproject of a particular parent task, users can never be faced with the opportunity to perform a destructive drag operation.

May 15 2017, 3:39 PM · Bug Report
epriestley claimed T12713: Can't view user profiles.
May 15 2017, 3:31 PM · Bug Report
Luke081515.2 created T12713: Can't view user profiles.
May 15 2017, 3:15 PM · Bug Report
eliaspro added a comment to T12455: Tag order on tasks matters for subprojects and milestones.

Okay. When a task is in "Warp Drive > Thermocoupling" and "Warp Drive > Milestone 1", and you view the "Warp Drive" board and drag the task from "Milestone 1" to "Backlog", what do you expect to happen to the projecs the task is tagged with?

May 15 2017, 3:11 PM · Bug Report
epriestley added a comment to T12455: Tag order on tasks matters for subprojects and milestones.

Okay. When a task is in "Warp Drive > Thermocoupling" and "Warp Drive > Milestone 1", and you view the "Warp Drive" board and drag the task from "Milestone 1" to "Backlog", what do you expect to happen to the projecs the task is tagged with?

May 15 2017, 2:52 PM · Bug Report
eliaspro added a comment to T12455: Tag order on tasks matters for subprojects and milestones.

Do you expect a task to be able to be tagged with "Warp Drive" and also simultaneously tagged with subproject "Warp Drive > Thermocoupling"?

No, Thermocoupling alone is enough, as it implies it's part of Warp Drive.

Do you expect a task to be able to be tagged with "Warp Drive" and also simultaneously tagged with milestone "Warp Drive > Milestone 1"?

No, Milestone 1 alone is enough, as it implies it's part of Warp Drive

May 15 2017, 2:50 PM · Bug Report