Page MenuHomePhabricator
Feed Advanced Search

Mar 9 2017

epriestley added a comment to T12373: Support macros in Phame.

https://secure.phabricator.com/source/phabricator/browse/master/src/infrastructure/markup/PhabricatorMarkupEngine.php;4c7d464f8bf2627ef7455596fde2ae5667e67a57$356

Mar 9 2017, 3:27 PM · Macros, Phame, Bug Report
epriestley updated subscribers of T12373: Support macros in Phame.

Macros are disabled in Phame posts, via markup engine. This originated in D2202.

Mar 9 2017, 3:27 PM · Macros, Phame, Bug Report
epriestley claimed T12378: "This task has been locked" on all logged out tasks.

I think the way the view gets built is a little odd and I didn't get the logic quite right. Definitely a bug, thanks.

Mar 9 2017, 3:16 PM · Maniphest, EditEngine

Mar 8 2017

epriestley added a comment to T9430: "Needs Audit" no longer excludes author commits.

The general headers/sections are mostly scripted now so they should be fairly consistent, but I'm still editing the actual markup at the end of the day.

Mar 8 2017, 11:04 PM · Restricted Project, Restricted Project, Audit
epriestley updated the task description for T12371: Support `viewerprojects()` and implement `viewerpackages()` for "Auditors" in Diffusion.
Mar 8 2017, 10:57 PM · Restricted Project, Audit, Differential
epriestley updated the task description for T12371: Support `viewerprojects()` and implement `viewerpackages()` for "Auditors" in Diffusion.
Mar 8 2017, 10:57 PM · Restricted Project, Audit, Differential
epriestley created T12371: Support `viewerprojects()` and implement `viewerpackages()` for "Auditors" in Diffusion.
Mar 8 2017, 10:56 PM · Restricted Project, Audit, Differential
epriestley added a comment to T9430: "Needs Audit" no longer excludes author commits.

I think we currently get about equal amounts of "your changelogs should be more detailed" and "your changelogs have too much irrelevant stuff" feedback so I'll take that feedback under consideration but don't plan to make changes unless the overall balance of feedback shifts substantially in one direction.

Mar 8 2017, 10:55 PM · Restricted Project, Restricted Project, Audit
epriestley added a comment to T9430: "Needs Audit" no longer excludes author commits.

We support viewerprojects() elsewhere but it isn't currently a component of the "Auditors" datasource. See also T9362#207080. I'll file a version of T9362 for the "Auditors" field.

Mar 8 2017, 10:49 PM · Restricted Project, Restricted Project, Audit
epriestley added a project to T12368: better support for "raw" patches, in particular corresponding to uncommitted changes?: KDE.
Mar 8 2017, 6:36 PM · KDE, Feature Request (Needs Information)
epriestley merged T12368: better support for "raw" patches, in particular corresponding to uncommitted changes? into T5029: Fill in missing context for low-context diffs against tracked repositories.
Mar 8 2017, 6:36 PM · KDE, Restricted Project, Diffusion, Differential
epriestley merged task T12368: better support for "raw" patches, in particular corresponding to uncommitted changes? into T5029: Fill in missing context for low-context diffs against tracked repositories.
Mar 8 2017, 6:36 PM · KDE, Feature Request (Needs Information)
epriestley updated subscribers of T12368: better support for "raw" patches, in particular corresponding to uncommitted changes?.

I'm going to merge this into T5029. This is an extremely low priority for this upstream because this workflow is virtually unheard of among full-time software development professionals (see "Target Audience" in Contributing Feature Requests) because it is inherently error-prone.

Mar 8 2017, 6:35 PM · KDE, Feature Request (Needs Information)
epriestley added a comment to T12368: better support for "raw" patches, in particular corresponding to uncommitted changes?.

How do you make guarantee that unrelated, simultaneous, uncommitted changes in the same working copy do not interfere with each other?

Mar 8 2017, 5:18 PM · KDE, Feature Request (Needs Information)
Croakx awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Mar 8 2017, 2:44 PM · Workboards (v3), Restricted Project
epriestley added a comment to T12355: Daemons are having a rough time starting on `admin`.

I haven't been able to reproduce this locally by artificially making services unavailable or connections fail. Debugging this in production will require momentary service interruptions on admin until I can narrow things down so I'm going to wait until off-peak to poke at it.

Mar 8 2017, 12:00 AM · Phacility, Daemons, Ops

Mar 7 2017

epriestley added a comment to T12365: Daemon never recovers with Git commit parsing task, but manually reparsing succeeds.

There isn't enough information here for us to reproduce this, or even begin.

Mar 7 2017, 4:12 PM · Daemons, Bug Report

Mar 6 2017

epriestley closed T12359: Registration does not accept valid email addresses as Wontfix.

You can adjust the validation here:

Mar 6 2017, 8:24 PM · Bug Report
epriestley added a comment to T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages.

I think that's right, yes.

Mar 6 2017, 5:28 PM · Installing & Upgrading, Differential
epriestley added a comment to T12337: Provide conduit access to related tasks and in particular 'mentions'.

Users do count, but I thiiiiiink user mentions are a special kind of mention because they have more complicated rules and you can't read them with edge.search today. T4654 discusses better rules around "notify me when I'm mentioned"; there are some related Conpherence-specific tasks too.

Mar 6 2017, 5:23 PM · Feature Request
epriestley closed T12358: Not secure generating as Invalid.

Sometimes, Apache is configured with a rule which prevents any access to any URL which contains /..

Mar 6 2017, 5:15 PM · Bug Report

Mar 5 2017

epriestley accepted D17468: Remove the the duplicate words.

courageous 🎆

Mar 5 2017, 6:12 PM
epriestley added a comment to T10319: Generate unique? profile images for each new user.

I dropped the cache, looks like they're working.

Mar 5 2017, 5:01 PM · Feature Request, People
epriestley added a comment to T12355: Daemons are having a rough time starting on `admin`.

Specifically, I suspect it won't affect repo because db restarts separately, so the database won't be unavailable when daemons on repo restart.

Mar 5 2017, 12:32 PM · Phacility, Daemons, Ops
epriestley added a comment to T12355: Daemons are having a rough time starting on `admin`.

It looks like this might be an issue with MySQL not being available yet when the daemons start. The deployment script restarts MySQL, then immediately restarts the daemons, and a bunch of this stuff is ending up in the log in the 1-2 seconds after the restart:

Mar 5 2017, 12:32 PM · Phacility, Daemons, Ops
epriestley added a project to T12355: Daemons are having a rough time starting on `admin`: Phacility.
Mar 5 2017, 12:24 PM · Phacility, Daemons, Ops
epriestley created T12355: Daemons are having a rough time starting on `admin`.
Mar 5 2017, 12:24 PM · Phacility, Daemons, Ops
epriestley added a comment to T12353: Convert PhabricatorSearchDocumentQuery to cursor based paging.

I believe that's unavoidable with offset-based paging (the solution is to switch to cursor-based paging, but I think we can't do that for fulltext).

Mar 5 2017, 12:18 PM · Elasticsearch, Wikimedia, Search
epriestley edited the content of 2017 Week 9 (Early March).
Mar 5 2017, 2:34 AM
epriestley added a comment to T10319: Generate unique? profile images for each new user.

🍞 🐦

Mar 5 2017, 12:30 AM · Feature Request, People
epriestley added a comment to T10319: Generate unique? profile images for each new user.

fancy 👑

Mar 5 2017, 12:30 AM · Feature Request, People
epriestley added a comment to T10319: Generate unique? profile images for each new user.

I think bin/cache purge --purge-user will do it (but for every user). There's no way to do it for just one user, I don't think.

Mar 5 2017, 12:22 AM · Feature Request, People
epriestley edited the content of Changelog.
Mar 5 2017, 12:19 AM
epriestley created 2017 Week 9 (Early March).
Mar 5 2017, 12:18 AM
epriestley added a comment to T12337: Provide conduit access to related tasks and in particular 'mentions'.

I've implemented a new edge.search API method. This method generally works similarly to other *.search API methods:

Mar 5 2017, 12:04 AM · Feature Request

Mar 4 2017

epriestley added a revision to T12337: Provide conduit access to related tasks and in particular 'mentions': Unknown Object (Differential Revision).
Mar 4 2017, 11:25 PM · Feature Request
epriestley added a comment to T12351: diviner generate book failed.

This should now be fixed in HEAD of master. Thanks for the report!

Mar 4 2017, 6:27 PM · Bug Report
epriestley added a revision to T2794: Implement Phage (like Hypershell): Unknown Object (Differential Revision).
Mar 4 2017, 6:11 PM · Phage, Infrastructure
epriestley closed T12351: diviner generate book failed as Resolved by committing Restricted Diffusion Commit.
Mar 4 2017, 5:54 PM · Bug Report
epriestley added a revision to T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges: Unknown Object (Differential Revision).
Mar 4 2017, 5:54 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
epriestley added a revision to T12337: Provide conduit access to related tasks and in particular 'mentions': Unknown Object (Differential Revision).
Mar 4 2017, 5:53 PM · Feature Request
epriestley added a revision to T12335: Ability to lock a task to prevent further edits: Unknown Object (Differential Revision).
Mar 4 2017, 4:07 PM · Maniphest, Feature Request
epriestley added a comment to T12350: Add support for "Plan Changes" as a condition for Differential Revision in Herald.

Here's the intended behavior from the source:

Mar 4 2017, 3:28 PM · Feature Request
epriestley added a revision to T12351: diviner generate book failed: Unknown Object (Differential Revision).
Mar 4 2017, 3:17 PM · Bug Report
epriestley added a comment to T12350: Add support for "Plan Changes" as a condition for Differential Revision in Herald.

The build system should be able to call Phabricator via Conduit and ask for revision status today if you want a short-term fix.

Mar 4 2017, 3:13 PM · Feature Request
epriestley added a comment to T12349: The language stanza in a code block shouldn't be indexed..

Hrrm, it looks like my reply to your email bounced. Short answer is that we don't offer anything special for academic or open source right now. We'd like to in the future, but are focusing on building our core business first.

Mar 4 2017, 12:10 PM · Bug Report
epriestley added a comment to T12353: Convert PhabricatorSearchDocumentQuery to cursor based paging.

(That is, the expected failure mode of this query when it fails to scale is "silently return an incomplete result set", not "be really slow".)

Mar 4 2017, 11:51 AM · Elasticsearch, Wikimedia, Search
epriestley added a comment to T12353: Convert PhabricatorSearchDocumentQuery to cursor based paging.

To start with here, let's identify exactly what's slow? It's not clear to me from the downstream task unless I'm just misreading, and not evident to me from reasoning about the behavior of this query. This query strategy is fundamentally not scalable, but I would not expect it to be slow unless the ElasticSearch query is slow.

Mar 4 2017, 11:48 AM · Elasticsearch, Wikimedia, Search
epriestley closed T12354: testing as Invalid.
Mar 4 2017, 11:43 AM · Feature Request
epriestley added a comment to T12353: Convert PhabricatorSearchDocumentQuery to cursor based paging.

The results are ordered by "match strength", but this is computed at runtime and isn't unique to each result: we can't start with the 100th result and use it to build any sort of clause like WHERE rank > 12345 that starts on the 101st result.

Mar 4 2017, 11:34 AM · Elasticsearch, Wikimedia, Search
epriestley closed T12352: Table of conent should be visible in beginning of the page as Invalid.

Sorry, this isn't a feature request we can accept. See Support Resources for help understanding what kind of support is available, and Contributing Feature Requests for help with feature requests.

Mar 4 2017, 11:11 AM · Phriction, Feature Request
epriestley merged T12350: Add support for "Plan Changes" as a condition for Differential Revision in Herald into T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.
Mar 4 2017, 11:10 AM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley merged task T12350: Add support for "Plan Changes" as a condition for Differential Revision in Herald into T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.
Mar 4 2017, 11:10 AM · Feature Request
epriestley added a comment to T12350: Add support for "Plan Changes" as a condition for Differential Revision in Herald.

See T10109. I'm going to merge this into T2543.

Mar 4 2017, 11:10 AM · Feature Request
epriestley added a comment to T12350: Add support for "Plan Changes" as a condition for Differential Revision in Herald.

You've personally observed a build trigger as the result of a user choosing "Plan Changes"?

Mar 4 2017, 4:48 AM · Feature Request
epriestley closed T12349: The language stanza in a code block shouldn't be indexed. as Wontfix.

The document contains "bash". This behavior seems correct to me.

Mar 4 2017, 3:53 AM · Bug Report
groenroos awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Mar 4 2017, 3:30 AM · Workboards (v3), Restricted Project

Mar 3 2017

epriestley added a revision to T12313: Cloudflare leaked all HTTPS traffic on the internet into public caches ("Cloudbleed"): Unknown Object (Differential Revision).
Mar 3 2017, 10:22 PM · Guides, Security
epriestley added a comment to T12347: "Make Editable" for any (non-task) form causes exception: "Unable to resolve method 'newEditEngineSubtypeMap'.".

This should be resolved at HEAD of master, thanks for the report!

Mar 3 2017, 9:45 PM · EditEngine, Bug Report
epriestley closed T12347: "Make Editable" for any (non-task) form causes exception: "Unable to resolve method 'newEditEngineSubtypeMap'." as Resolved by committing Restricted Diffusion Commit.
Mar 3 2017, 9:44 PM · EditEngine, Bug Report
epriestley added a revision to T12314: Support formal task subtypes (like "bug" vs "feature"): Unknown Object (Differential Revision).
Mar 3 2017, 9:43 PM · EditEngine, Maniphest, Custom Fields, Feature Request
epriestley added a revision to T12347: "Make Editable" for any (non-task) form causes exception: "Unable to resolve method 'newEditEngineSubtypeMap'.": Unknown Object (Differential Revision).
Mar 3 2017, 9:43 PM · EditEngine, Bug Report
epriestley added a comment to T10319: Generate unique? profile images for each new user.

Something like:

Mar 3 2017, 7:37 PM · Feature Request, People
epriestley closed T12346: `repository list-paths` reports non-existing path as Resolved.
Mar 3 2017, 4:38 PM · Bug Report
epriestley merged T12345: Links in titles into T8845: Headings which resolve with markup become an `X` in Table of Contents on Wiki.
Mar 3 2017, 1:24 PM · libphutil, Remarkup
epriestley merged task T12345: Links in titles into T8845: Headings which resolve with markup become an `X` in Table of Contents on Wiki.
Mar 3 2017, 1:24 PM · Phriction, Bug Report
epriestley added a comment to T12335: Ability to lock a task to prevent further edits.

We've implemented a basic version of this, roughly along the lines of the recommendation above. Here's how it works:

Mar 3 2017, 1:23 AM · Maniphest, Feature Request
epriestley closed T11207: User can change properties on the task, even when not having edit policy rights as Resolved by committing Restricted Diffusion Commit.
Mar 3 2017, 12:57 AM · Restricted Project, Policy, Bug Report

Mar 2 2017

epriestley added a comment to T12341: Set cursor default focus to input field when selecting "Other Project" from access policy dropdown.

(I think I've used this workflow fewer than 5 times outside of testing, and although similar workflows like "Award Badge" and "Add Project Members" have the same issue, I think they're similarly rare.)

Mar 2 2017, 9:49 PM · Feature Request (Needs Information)
epriestley added a comment to T12341: Set cursor default focus to input field when selecting "Other Project" from access policy dropdown.

This is also nontrivial: when we display a dialog, we already attempt to focus the first input. But the first input here is a tokenizer, not a real input, and naively focusing it fails because it hasn't activated or rendered yet.

Mar 2 2017, 9:48 PM · Feature Request (Needs Information)
epriestley added a revision to T12335: Ability to lock a task to prevent further edits: Restricted Differential Revision.
Mar 2 2017, 9:27 PM · Maniphest, Feature Request
epriestley added a comment to T11207: User can change properties on the task, even when not having edit policy rights.

D17452 marks this as resolved and makes these changes:

Mar 2 2017, 8:38 PM · Restricted Project, Policy, Bug Report
epriestley added a revision to T11207: User can change properties on the task, even when not having edit policy rights: Unknown Object (Differential Revision).
Mar 2 2017, 8:33 PM · Restricted Project, Policy, Bug Report
epriestley added a revision to T12335: Ability to lock a task to prevent further edits: Unknown Object (Differential Revision).
Mar 2 2017, 8:33 PM · Maniphest, Feature Request
epriestley added a comment to T12314: Support formal task subtypes (like "bug" vs "feature").

A basic version of this is now available in HEAD of master. Here's a walkthrough of what we've implemented and a discussion of some areas where we'd like feedback.

Mar 2 2017, 7:19 PM · EditEngine, Maniphest, Custom Fields, Feature Request
epriestley closed T12313: Cloudflare leaked all HTTPS traffic on the internet into public caches ("Cloudbleed") as Resolved.

Closing this since there doesn't seem to be any thing left that's actionable for us.

Mar 2 2017, 5:29 PM · Guides, Security
jasongilanfarr awarded T731: Allow revisions to have alternate acceptance conditions a Like token.
Mar 2 2017, 4:11 PM · Restricted Project, Restricted Project, Differential
epriestley added a revision to T12314: Support formal task subtypes (like "bug" vs "feature"): Unknown Object (Differential Revision).
Mar 2 2017, 1:09 PM · EditEngine, Maniphest, Custom Fields, Feature Request
epriestley merged T12340: Exclude refs/pull/* from being tracked in observed repo into T11314: Observe Mode + GitHub has weird mail interactions due to pull request refs.
Mar 2 2017, 2:51 AM · Diffusion (v3), Restricted Project, Mail, Haskell.org, Bug Report
epriestley merged task T12340: Exclude refs/pull/* from being tracked in observed repo into T11314: Observe Mode + GitHub has weird mail interactions due to pull request refs.
Mar 2 2017, 2:51 AM · Diffusion, Feature Request
epriestley added a revision to T6064: One-Click Add Task on Workboard Columns: Unknown Object (Differential Revision).
Mar 2 2017, 1:17 AM · Restricted Project, Workboards
epriestley added a revision to T11580: Tasks created from workboards frequently have to be edited to add properties common to all tasks on the workboard: Unknown Object (Differential Revision).
Mar 2 2017, 1:17 AM · Workboards, EditEngine, Projects, Feature Request
epriestley added a revision to T12314: Support formal task subtypes (like "bug" vs "feature"): Unknown Object (Differential Revision).
Mar 2 2017, 1:17 AM · EditEngine, Maniphest, Custom Fields, Feature Request
epriestley added a revision to T12314: Support formal task subtypes (like "bug" vs "feature"): Unknown Object (Differential Revision).
Mar 2 2017, 1:04 AM · EditEngine, Maniphest, Custom Fields, Feature Request
epriestley added a revision to T12314: Support formal task subtypes (like "bug" vs "feature"): Unknown Object (Differential Revision).
Mar 2 2017, 12:52 AM · EditEngine, Maniphest, Custom Fields, Feature Request
epriestley added a revision to T12314: Support formal task subtypes (like "bug" vs "feature"): Unknown Object (Differential Revision).
Mar 2 2017, 12:40 AM · EditEngine, Maniphest, Custom Fields, Feature Request
epriestley added a revision to T12314: Support formal task subtypes (like "bug" vs "feature"): Unknown Object (Differential Revision).
Mar 2 2017, 12:08 AM · EditEngine, Maniphest, Custom Fields, Feature Request

Mar 1 2017

epriestley added a revision to T12314: Support formal task subtypes (like "bug" vs "feature"): Unknown Object (Differential Revision).
Mar 1 2017, 11:42 PM · EditEngine, Maniphest, Custom Fields, Feature Request
epriestley added a revision to T12314: Support formal task subtypes (like "bug" vs "feature"): Unknown Object (Differential Revision).
Mar 1 2017, 11:24 PM · EditEngine, Maniphest, Custom Fields, Feature Request
epriestley added a revision to T12314: Support formal task subtypes (like "bug" vs "feature"): Unknown Object (Differential Revision).
Mar 1 2017, 11:01 PM · EditEngine, Maniphest, Custom Fields, Feature Request
epriestley added a comment to T12174: Home Menu Errata.

That's the default behavior, and you can achieve it by deleting "Name":

Mar 1 2017, 10:47 PM · Dashboards (v2), Profile Menu Item
epriestley added a comment to T12334: Arc land is not enforcing Herald Rule.

You can set history.immutable to true in your repository to prevent arc from performing mutation operations (amends, squash-merges).

Mar 1 2017, 10:30 PM · Bug Report
mavit awarded T8783: Unprototype Nuance (v1) a Like token.
Mar 1 2017, 5:04 PM · Nuance, Restricted Project
epriestley added a comment to T10319: Generate unique? profile images for each new user.

(And, if our behavior is "confusing fatal", that could prevent new installs from getting far enough to even see the setup warning saying "install gd".)

Mar 1 2017, 5:00 PM · Feature Request, People
epriestley added a comment to T10319: Generate unique? profile images for each new user.

I think all the other requirements are usually builtin (we "require" them only because it's possible to remove them, and some distros occasionally do for kind-of-maybe-questionable reasons) but I think it's basically like requiring your car to have tires.

Mar 1 2017, 4:58 PM · Feature Request, People
epriestley added a comment to T12337: Provide conduit access to related tasks and in particular 'mentions'.

This runs into T5873, which is a large task. The very short version is:

Mar 1 2017, 4:44 PM · Feature Request
epriestley added a comment to T10319: Generate unique? profile images for each new user.

I think the NUX case is fairly tricky. I need to look at the code, but I'm thinking something like:

Mar 1 2017, 4:31 PM · Feature Request, People
epriestley closed T12288: Phabricator OAuth 2.0 initiating SSO login from a Third Party website as Wontfix.

Cool, sounds good.

Mar 1 2017, 4:02 PM · Auth, Feature Request
epriestley added a comment to T12288: Phabricator OAuth 2.0 initiating SSO login from a Third Party website.

In my experience, it is very unusual for organizations to have multiple distinct internal groups with different identity providers. Normally, organizations which value SSO and identity management consolidate identities under a single provider, because that avoids problems like this, greatly simplifies identity management, and doesn't require other pieces of software to support multiple providers.

Mar 1 2017, 3:11 PM · Auth, Feature Request
epriestley added a comment to T12288: Phabricator OAuth 2.0 initiating SSO login from a Third Party website.

Why are you sharing an instance between two separate groups with separate identity providers?

Mar 1 2017, 2:33 PM · Auth, Feature Request