Page MenuHomePhabricator
Feed Advanced Search

Jan 7 2017

• sshannin added a comment to T11992: daemon hits policy exception repeatedly.

I did some further digging and made a little progress

Jan 7 2017, 6:06 PM · Daemons, Policy, Bug Report

Jan 6 2017

csilvers closed T12073: Phabricator does not change status to accepted if you comment when you accept as Resolved.

n/m, I see this was fixed today with https://secure.phabricator.com/rP1f2306999bb599bcedc0c4bfff2f2b3aade58630

Jan 6 2017, 12:50 AM · Differential, Bug Report
epriestley added a comment to T12073: Phabricator does not change status to accepted if you comment when you accept.

I think this should be fixed by D17146, which landed a few hours ago. Presumably you're running some ancient stone-age version of Phabricator that's 6 or more hours old?

Jan 6 2017, 12:46 AM · Differential, Bug Report
csilvers added a comment to T12073: Phabricator does not change status to accepted if you comment when you accept.

download.png (4×1 px, 844 KB)

Jan 6 2017, 12:45 AM · Differential, Bug Report
csilvers added a comment to T12073: Phabricator does not change status to accepted if you comment when you accept.

Jan 6 2017, 12:44 AM · Differential, Bug Report
csilvers created T12073: Phabricator does not change status to accepted if you comment when you accept.
Jan 6 2017, 12:40 AM · Differential, Bug Report
epriestley added a comment to T10687: jx-tooltip does whatever it feels like.

I think I got all of these, but yell if you catch any more.

Jan 6 2017, 12:27 AM · PHUI, Bug Report
epriestley closed T10687: jx-tooltip does whatever it feels like as Resolved by committing Restricted Diffusion Commit.
Jan 6 2017, 12:03 AM · PHUI, Bug Report
epriestley closed T12064: Tooltip for "Preview" in comment box overflows horizontally as Resolved by committing Restricted Diffusion Commit.
Jan 6 2017, 12:03 AM · Bug Report

Jan 5 2017

epriestley added a comment to T12070: phd no longer recognizes PHABRICATOR_ENV?.

This should do it:

Jan 5 2017, 11:10 PM · Daemons, Bug Report
ftdysa added a comment to T12070: phd no longer recognizes PHABRICATOR_ENV?.

Yep, here is the default value on all the installs of PHP I've done from source:

Jan 5 2017, 11:02 PM · Daemons, Bug Report
csilvers added a comment to T12070: phd no longer recognizes PHABRICATOR_ENV?.

Am glad to get ahead of it. What's the exact incantation we need to put into our php.ini?

Jan 5 2017, 11:01 PM · Daemons, Bug Report
epriestley added a comment to T12070: phd no longer recognizes PHABRICATOR_ENV?.

(After T12071 we will almost certainly require "E", so you could get ahead of that now.)

Jan 5 2017, 10:54 PM · Daemons, Bug Report
epriestley added a comment to T12070: phd no longer recognizes PHABRICATOR_ENV?.

Actually, it looks like PHP defaults to "EGPCS" but ships with config files that use "GPCS" (??? why would you do this ???), so this is probably not something that got changed or configured intentionally or accidentally.

Jan 5 2017, 10:53 PM · Daemons, Bug Report
epriestley closed T12070: phd no longer recognizes PHABRICATOR_ENV? as Resolved by committing Restricted Diffusion Commit.
Jan 5 2017, 10:48 PM · Daemons, Bug Report
epriestley added a comment to T12070: phd no longer recognizes PHABRICATOR_ENV?.

Perfect, thanks! That's what I expected, so D17148 should resolve this. Alternatively, setting that value to "EGPCS" (without upgrading, just restarting the daemons) should also resolve this.

Jan 5 2017, 10:48 PM · Daemons, Bug Report
csilvers added a comment to T12070: phd no longer recognizes PHABRICATOR_ENV?.
ubuntu@phabricator:~$ php -i | grep variables_order
variables_order => GPCS => GPCS
Jan 5 2017, 10:46 PM · Daemons, Bug Report
epriestley added a comment to T12069: `arc diff --reviewers` inserts reviewers twice..

I believe this is now fixed at HEAD of master. You should be able to pick up the change with arc upgrade now (if you run master) or in about 36 hours (if you run stable).

Jan 5 2017, 10:36 PM · Arcanist, Bug Report
epriestley closed T12069: `arc diff --reviewers` inserts reviewers twice. as Resolved by committing Restricted Diffusion Commit.
Jan 5 2017, 10:35 PM · Arcanist, Bug Report
epriestley added a revision to T12070: phd no longer recognizes PHABRICATOR_ENV?: Restricted Differential Revision.
Jan 5 2017, 10:33 PM · Daemons, Bug Report
epriestley added a parent task for T11940: Commit hooks in hosted Git repositories fail under Git 2.11.0: T12071: Require "E" be defined in variables_order so $_ENV is correctly populated.
Jan 5 2017, 10:30 PM · Bug Report
epriestley added a parent task for T12070: phd no longer recognizes PHABRICATOR_ENV?: T12071: Require "E" be defined in variables_order so $_ENV is correctly populated.
Jan 5 2017, 10:27 PM · Daemons, Bug Report
epriestley added a comment to T12070: phd no longer recognizes PHABRICATOR_ENV?.

While I'm chasing this down, can you show me the output of this command?

Jan 5 2017, 10:26 PM · Daemons, Bug Report
epriestley added a comment to T12070: phd no longer recognizes PHABRICATOR_ENV?.

This is an unintended side effect of D17100 but resolution isn't straightforward.

Jan 5 2017, 10:14 PM · Daemons, Bug Report
csilvers created T12070: phd no longer recognizes PHABRICATOR_ENV?.
Jan 5 2017, 10:02 PM · Daemons, Bug Report
epriestley added a revision to T12069: `arc diff --reviewers` inserts reviewers twice.: Restricted Differential Revision.
Jan 5 2017, 10:01 PM · Arcanist, Bug Report
epriestley added a comment to T12069: `arc diff --reviewers` inserts reviewers twice..

This is D17122 interacting with some extremely high-quality code in arc.

Jan 5 2017, 9:56 PM · Arcanist, Bug Report
csilvers created T12069: `arc diff --reviewers` inserts reviewers twice..
Jan 5 2017, 9:50 PM · Arcanist, Bug Report
epriestley closed T12068: Inbound Emails View Mail Body shows the wrong command as Resolved by committing Restricted Diffusion Commit.
Jan 5 2017, 4:59 PM · Bug Report
epriestley closed T12067: Inbound Email Reply-to not set correctly as Invalid.

This is far afield from an actionable bug report.

Jan 5 2017, 4:58 PM · Bug Report
epriestley added a revision to T10687: jx-tooltip does whatever it feels like: Restricted Differential Revision.
Jan 5 2017, 4:53 PM · PHUI, Bug Report
epriestley added a revision to T12064: Tooltip for "Preview" in comment box overflows horizontally: Restricted Differential Revision.
Jan 5 2017, 4:53 PM · Bug Report
pouyana added a comment to T12067: Inbound Email Reply-to not set correctly.

Yeah, There is no postfix, but my distro (SUSE Linux Enterprise) sendmail is a postfix variant. I have to match your sendmail config to my postfix. The last part was done with the help of canonical which is wrong way to do it probably. If it is too much work to debug this just drop it. It seems to be a very special case of configuration, server variant.

Jan 5 2017, 4:42 PM · Bug Report
epriestley added a comment to T12067: Inbound Email Reply-to not set correctly.

Using postfix instead of sendmail

Jan 5 2017, 4:21 PM · Bug Report
pouyana updated the task description for T12067: Inbound Email Reply-to not set correctly.
Jan 5 2017, 3:58 PM · Bug Report
pouyana added a comment to T12067: Inbound Email Reply-to not set correctly.

Sorry for the typos :D, Step by Step Guide:
Follow this: https://secure.phabricator.com/book/phabricator/article/configuring_inbound_email/#local-mta-installing-mai (Local MTA Section)

Jan 5 2017, 3:58 PM · Bug Report
pouyana renamed T12067: Inbound Email Reply-to not set correctly from Inbound Email Replay-to not set correctly to Inbound Email Reply-to not set correctly.
Jan 5 2017, 3:54 PM · Bug Report
epriestley added a comment to T12068: Inbound Emails View Mail Body shows the wrong command.

We could possibly remove it entirely since I think it isn't useful for 99% of users, but D17144 just fixes the command.

Jan 5 2017, 3:40 PM · Bug Report
epriestley added a revision to T12068: Inbound Emails View Mail Body shows the wrong command: Restricted Differential Revision.
Jan 5 2017, 3:40 PM · Bug Report
chad added a comment to T12068: Inbound Emails View Mail Body shows the wrong command.

Funny, never knew we put that text in that drop down.

Jan 5 2017, 3:39 PM · Bug Report
epriestley claimed T12068: Inbound Emails View Mail Body shows the wrong command.
Jan 5 2017, 3:38 PM · Bug Report
pouyana added a comment to T12068: Inbound Emails View Mail Body shows the wrong command.

Sorry, Step By Step Guide:

Jan 5 2017, 3:37 PM · Bug Report
chad added a comment to T12068: Inbound Emails View Mail Body shows the wrong command.

Please read Contributing Bug Reports carefully, specifically we require a complete, easy to follow and under.stand, set of steps to reproduce the problem.

Jan 5 2017, 3:30 PM · Bug Report
chad added a comment to T12067: Inbound Email Reply-to not set correctly.

Please read Contributing Bug Reports carefully, specifically we require a complete, easy to follow and under.stand, set of steps to reproduce the problem. I also don't understand what you're saying the bug in Phabricator is.

Jan 5 2017, 3:30 PM · Bug Report
pouyana added a comment to T12067: Inbound Email Reply-to not set correctly.

So, just some insight, I use postfix as mail server and for catch all mail (@domain) I used the canonical approach. This results the error above. Using virtual as described here will solve this problem.

Jan 5 2017, 2:33 PM · Bug Report
pouyana created T12068: Inbound Emails View Mail Body shows the wrong command.
Jan 5 2017, 2:02 PM · Bug Report
pouyana renamed T12067: Inbound Email Reply-to not set correctly from Inbound Email ReplayTo not set correctly to Inbound Email Replay-to not set correctly.
Jan 5 2017, 1:52 PM · Bug Report
pouyana created T12067: Inbound Email Reply-to not set correctly.
Jan 5 2017, 1:52 PM · Bug Report
chad added a comment to T12064: Tooltip for "Preview" in comment box overflows horizontally.

On my laptop it triggers either to the right of the preview icon or to the bottom, on my desktop, it does top, and gets jittery.

Jan 5 2017, 3:23 AM · Bug Report
epriestley added a comment to T12064: Tooltip for "Preview" in comment box overflows horizontally.

I think this really is the same as T10687, but the jittery bad degenerate behavior is only when a scrollbar gets added, so probably laptop + mouse works to repro but not laptop + touchpad?

Jan 5 2017, 3:21 AM · Bug Report
epriestley added a comment to T12065: Can't close actions in Maniphest.

Thanks for the excellent bug report with high-quality reproduction steps. Your clear, thorough reproduction steps made fixing this issue extremely easy!

Jan 5 2017, 3:17 AM · Bug Report
epriestley closed T12065: Can't close actions in Maniphest as Resolved by committing Restricted Diffusion Commit.
Jan 5 2017, 3:17 AM · Bug Report
epriestley added a revision to T12065: Can't close actions in Maniphest: Restricted Differential Revision.
Jan 5 2017, 3:15 AM · Bug Report
chad added a comment to T12065: Can't close actions in Maniphest.

Cry in vain this step is optional.

Jan 5 2017, 3:11 AM · Bug Report
epriestley claimed T12065: Can't close actions in Maniphest.
Jan 5 2017, 3:11 AM · Bug Report
chad created T12065: Can't close actions in Maniphest.
Jan 5 2017, 3:10 AM · Bug Report
chad updated the task description for T12064: Tooltip for "Preview" in comment box overflows horizontally.
Jan 5 2017, 3:00 AM · Bug Report
chad updated the task description for T12064: Tooltip for "Preview" in comment box overflows horizontally.
Jan 5 2017, 2:10 AM · Bug Report
chad updated the task description for T12064: Tooltip for "Preview" in comment box overflows horizontally.
Jan 5 2017, 2:09 AM · Bug Report
chad reopened T12064: Tooltip for "Preview" in comment box overflows horizontally as "Open".

Actually, this is a haunt mode bug, I'll update the description with a full set of reproducible steps.

Jan 5 2017, 2:07 AM · Bug Report
chad merged task T12064: Tooltip for "Preview" in comment box overflows horizontally into T10687: jx-tooltip does whatever it feels like.
Jan 5 2017, 2:01 AM · Bug Report
chad merged T12064: Tooltip for "Preview" in comment box overflows horizontally into T10687: jx-tooltip does whatever it feels like.
Jan 5 2017, 2:01 AM · PHUI, Bug Report
diagramatics created T12064: Tooltip for "Preview" in comment box overflows horizontally.
Jan 5 2017, 1:08 AM · Bug Report

Jan 4 2017

epriestley added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

Chrome upstream has patched this, now:

Jan 4 2017, 9:31 PM · Bug Report
epriestley closed T12058: url rewriting 302 redirects do not respect custom port as Resolved by committing Restricted Diffusion Commit.
Jan 4 2017, 2:55 PM · Bug Report
epriestley closed T12056: Searching for symbol / filename "PhabricatorProfilePanel" does not list commit when this symbol / file was removed as Wontfix.

This is working as intended.

Jan 4 2017, 2:54 PM · Bug Report
urzds added a comment to T12056: Searching for symbol / filename "PhabricatorProfilePanel" does not list commit when this symbol / file was removed.

I just tried it on GitHub an see that you're right. I guess this finally shifts this task into the feature request area, for which I would like to present the root cause: What I actually tried to achieve, when searching for for "PhabricatorProfilePanel", was to figure out in which commit this symbol got removed from Phabricator, so as to know how to change my extension's code (T10308#205605) to make it work with current Phabricator.

Jan 4 2017, 11:36 AM · Bug Report

Jan 3 2017

cspeckmim added a comment to T10382: Transaction abort when pushing via SSH to a Mercurial repository.

@jeremy.norris - You should be able to push if you use a mercurial client 3.4 or below. What I did is download the hg-3.4 sources and do make local, then moved the renamed binary into my path (/usr/local/bin/ I think), and I use hg-3.4 push -r master when pushing.

Jan 3 2017, 10:05 PM · Mercurial, Bug Report
jeremy.norris added a comment to T10382: Transaction abort when pushing via SSH to a Mercurial repository.

So reading through all of this, am I understanding correctly that Phabricator and Mercurial > 3.4 aren't compatible with each other? I've spent the past couple days attempting to push an existing repository with a few thousand changesets into a Phabricator hosted instance to no avail (using mercurial 4.0.1 for both the client and server).

Jan 3 2017, 9:56 PM · Mercurial, Bug Report
epriestley added a comment to T12058: url rewriting 302 redirects do not respect custom port.

I was able to reproduce this at HEAD and D17134 should fix it, but please make sure future issues you report are against upstream code -- not forked local code -- and that your install is up to date. Many issues are already fixed by the time they are reported, and we are powerless to troubleshoot issues with local code even if we wanted to.

Jan 3 2017, 5:57 PM · Bug Report
epriestley claimed T12058: url rewriting 302 redirects do not respect custom port.
Jan 3 2017, 5:55 PM · Bug Report
epriestley added a revision to T12058: url rewriting 302 redirects do not respect custom port: Restricted Differential Revision.
Jan 3 2017, 5:54 PM · Bug Report
rabahmeradi added a comment to T12058: url rewriting 302 redirects do not respect custom port.

Have you forked phabricator ? Your commit sha (901e3051351dec3c041c683b6d1e718e587e2b4b) is not recognized in this install.

Jan 3 2017, 5:31 PM · Bug Report
danielberger created T12058: url rewriting 302 redirects do not respect custom port.
Jan 3 2017, 4:51 PM · Bug Report
epriestley added a comment to T12057: Cannot reduce the number of lines using backticks and lines=2.

Specifically, the limit is enforced here. You could remove this limit locally if you are not concerned about the usability of the result:

Jan 3 2017, 4:01 PM · Bug Report
epriestley closed T12057: Cannot reduce the number of lines using backticks and lines=2 as Invalid.

This is not a bug. The element has a minimum height because viewing or selecting text from a tiny element would create usability issues: imagine trying to select 30 lines from the middle of a 100-line block with lines=2.

Jan 3 2017, 3:56 PM · Bug Report
magnetik updated the task description for T12057: Cannot reduce the number of lines using backticks and lines=2.
Jan 3 2017, 3:45 PM · Bug Report
magnetik created T12057: Cannot reduce the number of lines using backticks and lines=2.
Jan 3 2017, 3:21 PM · Bug Report
chad added a comment to T12056: Searching for symbol / filename "PhabricatorProfilePanel" does not list commit when this symbol / file was removed.

GitHub returns no results as well, which aligns with my expectation. Do you have an example piece of software that does work like this?

Jan 3 2017, 3:07 PM · Bug Report
urzds added a comment to T11907: `arc feature D123` does not checkout branch for revision D123.

Somewhat related to T4706.

Jan 3 2017, 12:16 PM · Restricted Project, Arcanist, Bug Report
urzds created T12056: Searching for symbol / filename "PhabricatorProfilePanel" does not list commit when this symbol / file was removed.
Jan 3 2017, 12:04 PM · Bug Report

Jan 2 2017

chad merged task T12055: Passphrase uses "edit" permission to decide who can see the secret, not the "visible" permission into T4721: Improve user-facing documentation for Passphrase.
Jan 2 2017, 5:38 PM · Bug Report
allixsenos created T12055: Passphrase uses "edit" permission to decide who can see the secret, not the "visible" permission.
Jan 2 2017, 5:26 PM · Bug Report
joshuaspence added projects to T11953: Herald rule for commits on autoclose branch didn't trigger when a commit was first pushed to a branch, then to master (fast-forward): Diffusion, Herald.
Jan 2 2017, 10:26 AM · Diffusion, Herald, Bug Report
chad added a comment to T11085: Prevent users from generating an ambiguous commit message by editing revisions with the web UI.

I think we'd have to build another Remarkup rendering target to accomplish that (sending sanitized text-only emails, for example). I also believe we do no policy checks in Remarkup (which is cached).

Jan 2 2017, 3:46 AM · Prioritized, Restricted Project, Arcanist, Bug Report
joshuaspence added a comment to T11085: Prevent users from generating an ambiguous commit message by editing revisions with the web UI.

You're watching #twitter.

Jan 2 2017, 1:42 AM · Prioritized, Restricted Project, Arcanist, Bug Report

Jan 1 2017

epriestley closed T11344: Differential commit message parser immediately rejects objects the user can't see, but Herald can put them there as Resolved by committing Restricted Diffusion Commit.
Jan 1 2017, 5:56 PM · Restricted Project, Differential, Arcanist, Bug Report
epriestley closed T10312: Always interpret the first line of commit messages as a title, even if it begins with a recognized label like "Test Plan:" as Resolved by committing Restricted Diffusion Commit.
Jan 1 2017, 5:56 PM · Restricted Project, Diffusion, Differential, Arcanist, Bug Report
epriestley renamed T11344: Differential commit message parser immediately rejects objects the user can't see, but Herald can put them there from differential.parsecommitmessage error parsing restricted projects to Differential commit message parser immediately rejects objects the user can't see, but Herald can put them there.
Jan 1 2017, 5:07 PM · Restricted Project, Differential, Arcanist, Bug Report
epriestley added a revision to T11344: Differential commit message parser immediately rejects objects the user can't see, but Herald can put them there: Restricted Differential Revision.
Jan 1 2017, 5:05 PM · Restricted Project, Differential, Arcanist, Bug Report
epriestley added a revision to T10312: Always interpret the first line of commit messages as a title, even if it begins with a recognized label like "Test Plan:": Restricted Differential Revision.
Jan 1 2017, 4:30 PM · Restricted Project, Diffusion, Differential, Arcanist, Bug Report

Dec 31 2016

epriestley closed T10323: "Action With No Effect" when marking inline comments as done as Resolved by committing Restricted Diffusion Commit.
Dec 31 2016, 6:12 PM · Restricted Project, Restricted Project, Bug Report, Differential
epriestley added a revision to T10323: "Action With No Effect" when marking inline comments as done: Restricted Differential Revision.
Dec 31 2016, 5:59 PM · Restricted Project, Restricted Project, Bug Report, Differential
chad added a comment to T12053: Arcanist tries to parse phpunit output in the test plan as another test plan field.

Maybe similar to T10312 as well... If we see a test plan, skip the next one?

Dec 31 2016, 4:32 AM · Arcanist, Bug Report
chad merged task T12053: Arcanist tries to parse phpunit output in the test plan as another test plan field into T6050: Improve error message / UX when fields are specified twice in revision information.
Dec 31 2016, 4:30 AM · Arcanist, Bug Report
chad added a comment to T12053: Arcanist tries to parse phpunit output in the test plan as another test plan field.

Expected, though it's going to take me a while to find the dupe.

Dec 31 2016, 4:27 AM · Arcanist, Bug Report
dereckson renamed T12053: Arcanist tries to parse phpunit output in the test plan as another test plan field from Arcanist tries to parse phpunit output in the test plan as to Arcanist tries to parse phpunit output in the test plan as another test plan field.
Dec 31 2016, 3:30 AM · Arcanist, Bug Report
dereckson updated the task description for T12053: Arcanist tries to parse phpunit output in the test plan as another test plan field.
Dec 31 2016, 3:30 AM · Arcanist, Bug Report
dereckson updated the task description for T12053: Arcanist tries to parse phpunit output in the test plan as another test plan field.
Dec 31 2016, 3:29 AM · Arcanist, Bug Report
dereckson updated the task description for T12053: Arcanist tries to parse phpunit output in the test plan as another test plan field.
Dec 31 2016, 3:29 AM · Arcanist, Bug Report