@chad, it looks like we're just using the browser's default outline for buttons.

Okay, it does look invisible in Firefox. Is Firefox the browser you're using?

I can't reproduce tab order differing from visual order, either.

I can't reproduce this:

I would remove the idea of a "global dashboard" as distinct from "top dashboard" -- we just look through both sections and pick the first dashboard we see, if any exist.

Also, maybe a good way to start is to do this:

(I guess a bad argument for having hard-coded home is that you can uninstall Dashboards. We could make it a mandatory app, though.)

That is, if you delete all of the dashboards from the menu that's fine, you just get hard-coded home.

Oh, my suggestion is this:

I think the short technical path forward is:

Well I'm planning to make you build everything so we can do whatever you want, pretty much.

If you are not an administrator and create a task with THE FAX SUPPORT NUMBER THAT SHALL NOT BE NAMED in the title or body, you will now be immediately logged out of all your sessions and your task will be quarantined.

Sorry, had to drop the pup off at pup daycare.

The solution that I think is most promising is this:

sorry phone

I don't think there's any reason that model can't work, it just feels really weird/inconsistent to me and not necessary, since I don't think there's any real value in retaining "install dashboard" or having a single magic home dashboard.

Also, is Dashboards going to get a second action so you have this choice when viewing a dashboard?

Okay, but I can end up with two different dashboard menu items which look the same, work the same, but are edited in completely different ways through entirely separate applications?

Also, if the user can't reorder, rename or remove Home, how do we figure out where it goes if they edit their menu and reorganize all the items (e.g., add three copies of their profile, all at the bottom of their favorites)?

If we retain "Install Dashboard", there are also two different ways to install a dashboard: to install a default dashboard, you go to Dashboards > blah blah > Install Dashboard. To install a second dashboard that you just want to be able to switch to, you go to "Customize Favorites > New Dashboard > ...". Seems potentially simpler to throw away "install dashboard" completely and just work like more like searches do.

If I install a custom personal dashboard, my personal dashboard becomes Home, replacing the existing "Home" link, and I can't get back to the global home?

I think we now test everything we've seen except RocketLoader (which is hard to test and hasn't come up too much recently) and not serving .whatever paths (which we've only ever seen one instance of, and which is also somewhat hard to test). I'm going to consider this resolved for now until we see more issues.

That's similar but not directly related.

(Since we no longer have labels, can users add labels if they want?)

So they can remove "Home" and have no way to return to the install's default dashboard, and everyone has their own personal copy of "Home"?

That's correct. I'm not sure what's going wrong. My guesses are the crazy stuff you might expect like:

If you have project "AAA" with milestone "BBB", which renders as "AAA (BBB)" in the UI:

Actually, I think the issue @jcox reported and the downstream issue (https://phabricator.wikimedia.org/T152726) may not quite be the same.

I'm going to close this as resolved because we now have a setup check for it and haven't seen any more Apache version issues since this report (more than two years).

I'm going to close this since it isn't reproducible (e.g., the link above works fine) and I'm fairly confident that this is a configuration problem in how you've adjusted nginx to work, deviating from the upstream instructions.

It's also safe to cherry-pick whatever D17012 lands as and then reindex to pick this up immediately without doing a full upgrade.

For best results (or maybe "any results"), run this command after upgrading past D17012:

The "Public" vs "All Users" stuff is sort of a confusing behavior on our part (the workflow is what set "Public", which doesn't really make sense given the rest of your config) but I think it's largely mooted by the fix in D17011, and to be more clear about it we'd have to make this one particular file magical somehow (we can't choose either "users" or "public" as the policy unambiguously, because the install may change the value of policy.allow-public later without also updating the logo).

No problem -- we gave you a false start in Q528 and this behavior is pretty hard to guess at if you don't know the internals.

Specifically, this is the PHID you're looking for in the UI:

If you do this:

When you say "fail hard", you specifically mean that you get an exception message beginning with this text?

(Actually, I'm just going to respect the file policy but ignore policy failures.)

Here are more reliable reproduction steps:

I can't reproduce this. Here's what I did:

I'm going to attempt to reproduce this as written, but I will be shocked if these steps work to reproduce the issue you describe.

This search UI also needs to be updated:

My only (mild) concern with this is that object types may become slightly ambiguous in some contexts: currently, icons are (at least mostly) unique across object types. A tag icon or a briefcase icon is always a project. A calendar icon or a cocktail glass is always an event.

Does an administrator have two "Customize Menu..." links? Or does their link at the top also let them customize the global stuff?

I'm probably going to change this to repository and accept an ID, PHID, short name, or callsign, as all the Phabricator-side web/CLI stuff now does.

You can use bin/storage upgrade --apply phabricator:2016... to reapply a specific patch explicitly, even if it has previously been marked as applied. You can get the full names of patches from bin/storage status.

I expect our forking to be much lighter-weight than GitHub's (ideally, I'd like it to work something like git push whatever/branch creates a fork called "whatever"), forking is just a familiar metaphor.

I love it it is very good

Yeah, I don't particularly like "Global" (too technical) or "Favorites" (feels very Windows 98 to me: "My Documents", "My Computer" -- "Favorites" isn't as bad, but "My Thing" has always felt weirdly condescending to me).

• H140
• {H140}
• H141
• H141 force chad

everything will be OK :)

Relatively little doom appears to have befallen us.

This hasn't seen action in two years and a lot of the surrounding code has changed since then. If it's still an issue, please file a new bug report with reproduction steps demonstrating how to break an object so it doesn't index properly.

Maybe we can start with an "Add to homepage" action from Dashboards and see if we need the grouping/label? It gets tricky if you add two, we create a group, you reorganize one, you rename the label, you change your language, and you add another. Now we have to guess whether your "El Dashboardoes" label is a group of dashboards or not.