Page MenuHomePhabricator
Feed Advanced Search

Nov 16 2016

epriestley closed T7643: Improve prose diffs (was: description changes don't generate usable diffs) as Resolved.
  • D16853 tweaked one issue that I caught.
  • T11881 is a followup for restoring code diffs in a small set of scenarios.
  • I haven't seen other issues for a while, so I'm going to consider this resolved until they crop up. If you do run into cases where the new algorithm isn't doing a great job, let us know.
Nov 16 2016, 5:17 PM · Prioritized, Transactions
epriestley added a revision to T11044: Support partitioning application databases across multiple database hosts: Restricted Differential Revision.
Nov 16 2016, 1:17 AM · Clusters, Prioritized

Nov 15 2016

epriestley closed T11809: Calendar v1 Errata Mark II, a subtask of T7924: Unprototype Calendar (v1), as Resolved.
Nov 15 2016, 9:44 PM · Restricted Project, Prioritized, Calendar

Nov 14 2016

epriestley added a revision to T11355: Build a flexible revision lookup API in Arcanist: Restricted Differential Revision.
Nov 14 2016, 10:16 PM · Restricted Project, Prioritized, Arcanist
epriestley added a subtask for T11114: Move Differential to EditEngine: T7657: Reviewer changes across `arc diff --update` and web UI are not merged constructively.
Nov 14 2016, 5:59 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley moved T4706: Maybe make `arc land D123` go look up the branch? from Backlog to vNext on the Arcanist board.
Nov 14 2016, 5:46 PM · Prioritized, Restricted Project, Arcanist
epriestley moved T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD` from Backlog to vNext on the Arcanist board.
Nov 14 2016, 5:34 PM · Arcanist, Prioritized, Restricted Project, Feature Request
epriestley added a project to T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD`: Arcanist.
Nov 14 2016, 5:34 PM · Arcanist, Prioritized, Restricted Project, Feature Request
20after4 added a comment to T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier.

Now that this has been deployed for a while, I'm curious if there's any feedback about it? Specifically:

  • Does this approach generally seem like it's a reasonable solution to the problem (if not in its current form, in some similar form which handles these issues more gracefully)? Or are we not really in the right ballpark?
Nov 14 2016, 7:48 AM · Restricted Project, Design, Typeahead, Prioritized, Wikimedia

Nov 13 2016

epriestley added a revision to T7643: Improve prose diffs (was: description changes don't generate usable diffs): Restricted Differential Revision.
Nov 13 2016, 10:05 PM · Prioritized, Transactions
epriestley added a comment to T4245: Make repository URIs slightly prettier.

It's entirely possible I missed some things in supporting the 25,000 different URI forms we now support, but just file a new issue if you run into anything since this task is now 200 years old with seventy pages of unrelated disucssion.

Nov 13 2016, 8:48 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley closed T4245: Make repository URIs slightly prettier as Resolved by committing Restricted Diffusion Commit.
Nov 13 2016, 8:42 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley moved T4245: Make repository URIs slightly prettier from Backlog to The Queue on the Prioritized board.
Nov 13 2016, 8:29 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a revision to T4245: Make repository URIs slightly prettier: Restricted Differential Revision.
Nov 13 2016, 8:02 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a comment to T11044: Support partitioning application databases across multiple database hosts.

D16115 + D16847 + D16848 make these changes:

Nov 13 2016, 12:48 AM · Clusters, Prioritized

Nov 12 2016

epriestley added a revision to T11044: Support partitioning application databases across multiple database hosts: Restricted Differential Revision.
Nov 12 2016, 8:05 PM · Clusters, Prioritized
epriestley added a revision to T11044: Support partitioning application databases across multiple database hosts: Restricted Differential Revision.
Nov 12 2016, 5:27 PM · Clusters, Prioritized
epriestley closed T11085: Prevent users from generating an ambiguous commit message by editing revisions with the web UI as Resolved.

I think that will prevent these edits from occurring by accident via the web UI. Yell if you manage to trick it or it causes any weird stuff.

Nov 12 2016, 4:06 PM · Prioritized, Restricted Project, Arcanist, Bug Report
epriestley added a revision to T11085: Prevent users from generating an ambiguous commit message by editing revisions with the web UI: Restricted Differential Revision.
Nov 12 2016, 3:14 PM · Prioritized, Restricted Project, Arcanist, Bug Report

Nov 11 2016

epriestley merged T11837: Phabricator sometimes sends mail that it shouldn't into T10448: Modularize mail tags.
Nov 11 2016, 8:25 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request

Nov 10 2016

epriestley moved T7643: Improve prose diffs (was: description changes don't generate usable diffs) from The Queue to Paused on the Prioritized board.

I believe this is now in reasonable shape, in the sense that the overwhelming majority of prose inputs I'm aware of produce reasonable, human-readable diffs. They aren't perfect in all cases and aren't necessarily the diffs that a human would produce, but they're useful and fairly sensible.

Nov 10 2016, 8:57 PM · Prioritized, Transactions
chad added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

unit tests ftw

Nov 10 2016, 8:49 PM · Prioritized, Transactions
epriestley added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

That seemed to just work? Slightly disconcerting.

Nov 10 2016, 8:42 PM · Prioritized, Transactions
epriestley added a revision to T7643: Improve prose diffs (was: description changes don't generate usable diffs): Restricted Differential Revision.
Nov 10 2016, 8:36 PM · Prioritized, Transactions
jcox added a comment to T11845: Media with "autoplay" should possibly not autoplay in news feed.

Pretty sure this works as intended

Nov 10 2016, 8:08 PM · Prioritized, Remarkup
epriestley added a comment to T11845: Media with "autoplay" should possibly not autoplay in news feed.

Look at how much engagement we're generating!

Nov 10 2016, 8:05 PM · Prioritized, Remarkup
chad added a comment to T11845: Media with "autoplay" should possibly not autoplay in news feed.

comments

Nov 10 2016, 8:05 PM · Prioritized, Remarkup
chad added a comment to T11845: Media with "autoplay" should possibly not autoplay in news feed.

more

Nov 10 2016, 8:05 PM · Prioritized, Remarkup
chad added a comment to T11845: Media with "autoplay" should possibly not autoplay in news feed.

need

Nov 10 2016, 8:05 PM · Prioritized, Remarkup
chad added a comment to T11845: Media with "autoplay" should possibly not autoplay in news feed.

still

Nov 10 2016, 8:05 PM · Prioritized, Remarkup
epriestley added a comment to T11845: Media with "autoplay" should possibly not autoplay in news feed.

I would edit my comment to put a paragraph of text above the autoplay audio, but newsfeed caches the old comment. :3

Nov 10 2016, 8:04 PM · Prioritized, Remarkup
epriestley added a comment to T11845: Media with "autoplay" should possibly not autoplay in news feed.

I think we can safely conclude that autoplay audio in feed is an effective mechanism for disseminating important information.

Nov 10 2016, 8:04 PM · Prioritized, Remarkup
chad moved T11845: Media with "autoplay" should possibly not autoplay in news feed from Backlog to Rugged Terrain on the Prioritized board.
Nov 10 2016, 8:04 PM · Prioritized, Remarkup
chad added a project to T11845: Media with "autoplay" should possibly not autoplay in news feed: Prioritized.
Nov 10 2016, 8:03 PM · Prioritized, Remarkup
epriestley added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

We still do a pretty questionable job on the first case in T7643#180264, where a comma is removed from the middle of a sentence.

Nov 10 2016, 7:36 PM · Prioritized, Transactions
chad added a comment to T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier.

I suppose an alternate path is to enable Dashboards on Project homepages, and you can embed your project wiki or text panel for a really cool long description and information.

Nov 10 2016, 6:23 PM · Restricted Project, Design, Typeahead, Prioritized, Wikimedia
epriestley added a comment to T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier.

Would you fill out at least, like, 5 of them?

Nov 10 2016, 6:21 PM · Restricted Project, Design, Typeahead, Prioritized, Wikimedia
chad added a comment to T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier.

Hovercards, Search, Browse, etc. It could get used.

Nov 10 2016, 6:20 PM · Restricted Project, Design, Typeahead, Prioritized, Wikimedia
chad added a comment to T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier.

We could call it "Search Description" so it feels clear that it only displays in some UIs.

Nov 10 2016, 6:19 PM · Restricted Project, Design, Typeahead, Prioritized, Wikimedia
epriestley added a comment to T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier.

Yeah, I think it's pretty reasonable if people would actually fill it out. We could surface it in a few other places too (e.g., /projects/) without fallback. It just seems like there's a decent chance no one will ever fill it out and it will sort of just be cluttering up the UI. But the cost on our side is pretty small, so if some people claim that they'd probably want to fill it out I'm happy to move forward with it.

Nov 10 2016, 6:18 PM · Restricted Project, Design, Typeahead, Prioritized, Wikimedia
chad added a comment to T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier.

Provide an alternate, text-only field for "Project summary in typehaead results." which users only enter text into, so we don't have to worry about remarkup.

Nov 10 2016, 6:10 PM · Restricted Project, Design, Typeahead, Prioritized, Wikimedia
epriestley moved T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier from The Queue to Paused on the Prioritized board.

For reference, here's the current state of "discovery" downstream:

Nov 10 2016, 5:49 PM · Restricted Project, Design, Typeahead, Prioritized, Wikimedia
epriestley claimed T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches.
Nov 10 2016, 5:13 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
epriestley moved T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches from The Queue to Paused on the Prioritized board.

I believe this is now resolved, in the sense that I expect all specific, reproducible examples I'm aware of function in a way consistent with user expectation. In particular:

Nov 10 2016, 5:06 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
epriestley added a revision to T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches: Restricted Differential Revision.
Nov 10 2016, 4:37 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
epriestley added a comment to T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches.

I have some possible approaches for cheating on the "more than 100 results" case, but I think we ultimately need to put the prefix paging rule on the server side, so we return all prefix matches and then all content matches. That's kind of a big mess, but all the ways we can cheat will break down at some point (e.g., when you have 100 "wikidata" projects that are alphabetically earlier than "wikidata") so I think it's not avoidable.

Nov 10 2016, 2:58 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
epriestley moved T5267: Localize Phabricator from The Queue to Paused on the Prioritized board.

Pausing this from our perspective since we're waiting on guidance to move forward.

Nov 10 2016, 2:39 PM · Prioritized, Localization
epriestley added a parent task for T11050: Allow resigning from a review you are not directly responsible for: T10967: Move Differential reviewers back to a dedicated database storage table.
Nov 10 2016, 2:34 PM · Prioritized, Restricted Project, Differential, Feature Request

Nov 8 2016

epriestley added a revision to T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches: Restricted Differential Revision.
Nov 8 2016, 7:40 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
epriestley added a comment to T5267: Localize Phabricator.

Sounds good, thanks!

Nov 8 2016, 5:42 PM · Prioritized, Localization
Nikerabbit added a comment to T5267: Localize Phabricator.

In other words is your array syntax always messagekey[gender][plural] or could it also be messagekey[plural][plural] depending on the variables?

We support unlimited gender/plural variants in any order. We have a number of strings like this:

Nov 8 2016, 5:41 PM · Prioritized, Localization
epriestley added a revision to T5267: Localize Phabricator: Restricted Differential Revision.
Nov 8 2016, 4:43 PM · Prioritized, Localization
epriestley added a revision to T5267: Localize Phabricator: Restricted Differential Revision.
Nov 8 2016, 4:43 PM · Prioritized, Localization
epriestley added a comment to T5267: Localize Phabricator.

%s cannot be repeated as far as I know.

Nov 8 2016, 4:32 PM · Prioritized, Localization
epriestley added a revision to T5267: Localize Phabricator: Restricted Differential Revision.
Nov 8 2016, 4:16 PM · Prioritized, Localization
Nikerabbit added a comment to T5267: Localize Phabricator.

When multiple variants exist, should we export a nested structure like this?

[...]

Nov 8 2016, 3:56 PM · Prioritized, Localization
epriestley added a revision to T5267: Localize Phabricator: Restricted Differential Revision.
Nov 8 2016, 3:31 PM · Prioritized, Localization
epriestley added a comment to T5267: Localize Phabricator.
"aBmeIEk": {
    "one": "%s star",
    "other": "%s stars"
},
Nov 8 2016, 3:22 PM · Prioritized, Localization
Nikerabbit added a comment to T5267: Localize Phabricator.

Variables such as $1 are not part of the spec, and it makes no difference to us if you use %s instead. So unless this conversion is required by your system, you can drop it.

At least some translators are likely familiar with $1, {{GENDER:$1|X|Y}}, and so on, right? And you have documentation on this syntax to help translators who aren't familiar with it learn it?

Nov 8 2016, 3:03 PM · Prioritized, Localization
epriestley added a revision to T5267: Localize Phabricator: Restricted Differential Revision.
Nov 8 2016, 2:50 PM · Prioritized, Localization
epriestley added a comment to T5267: Localize Phabricator.

Here are the current internal data formats:

Nov 8 2016, 2:21 PM · Prioritized, Localization
epriestley added a comment to T5267: Localize Phabricator.

Variables such as $1 are not part of the spec, and it makes no difference to us if you use %s instead. So unless this conversion is required by your system, you can drop it.

Nov 8 2016, 1:58 PM · Prioritized, Localization
Nikerabbit added a comment to T5267: Localize Phabricator.

Some of the terms that I use below (e.g. outdated) are explained in https://www.mediawiki.org/wiki/Help:Extension:Translate/Glossary

Nov 8 2016, 9:35 AM · Prioritized, Localization

Nov 7 2016

epriestley updated the task description for T7643: Improve prose diffs (was: description changes don't generate usable diffs).
Nov 7 2016, 11:09 PM · Prioritized, Transactions
epriestley added a revision to T7643: Improve prose diffs (was: description changes don't generate usable diffs): Restricted Differential Revision.
Nov 7 2016, 10:44 PM · Prioritized, Transactions
epriestley added a revision to T7643: Improve prose diffs (was: description changes don't generate usable diffs): Restricted Differential Revision.
Nov 7 2016, 7:39 PM · Prioritized, Transactions
epriestley added a revision to T7643: Improve prose diffs (was: description changes don't generate usable diffs): Restricted Differential Revision.
Nov 7 2016, 7:23 PM · Prioritized, Transactions
epriestley added a revision to T4788: Allow "Edit Dependencies" both ways (blocking and depending): Restricted Differential Revision.
Nov 7 2016, 7:08 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
epriestley added a comment to T5267: Localize Phabricator.

The rTRANSLATEWIKI repository is now available. Here is an example of the en.json MediaWiki-style JSON string file we currently generate:

Nov 7 2016, 4:03 PM · Prioritized, Localization
epriestley added a comment to T5267: Localize Phabricator.

I don't know what this means. $ in the string contents isn't anything special for translatewiki.net.

Nov 7 2016, 2:51 PM · Prioritized, Localization
Nikerabbit added a comment to T5267: Localize Phabricator.
  • When exporting, I don't know how to escape $ for Translatewiki (this affects ~10 strings).
Nov 7 2016, 2:20 PM · Prioritized, Localization
nemobis added a comment to T5267: Localize Phabricator.

Likewise, when importing, I don't know how to unescape $.

Nov 7 2016, 10:18 AM · Prioritized, Localization

Nov 6 2016

epriestley added a comment to T5267: Localize Phabricator.

The technical definition of "Limited" is that it has fewer than 512 strings, including 0 strings.

Nov 6 2016, 10:31 PM · Prioritized, Localization
MZMcBride added a comment to T5267: Localize Phabricator.
  • Did you notice that "Spanish (Spain)" was under the "Limited Translations" heading, instead of the "Translations" heading?
Nov 6 2016, 10:10 PM · Prioritized, Localization
epriestley added a comment to T5267: Localize Phabricator.

I think D16810 should get this started, at least. Known technical issues:

Nov 6 2016, 9:40 PM · Prioritized, Localization
epriestley added a revision to T5267: Localize Phabricator: Restricted Differential Revision.
Nov 6 2016, 9:27 PM · Prioritized, Localization
epriestley merged T11825: Prose diffs unusable for changes with large blocks of unmodified text into T7643: Improve prose diffs (was: description changes don't generate usable diffs).
Nov 6 2016, 9:08 PM · Prioritized, Transactions
epriestley added a revision to T5267: Localize Phabricator: Restricted Differential Revision.
Nov 6 2016, 7:20 PM · Prioritized, Localization
epriestley added a revision to T5267: Localize Phabricator: Restricted Differential Revision.
Nov 6 2016, 6:49 PM · Prioritized, Localization
epriestley added a comment to T5267: Localize Phabricator.

@MZMcBride, couple of questions so we can improve this:

Nov 6 2016, 5:31 PM · Prioritized, Localization
epriestley added a revision to T5267: Localize Phabricator: Restricted Differential Revision.
Nov 6 2016, 5:16 PM · Prioritized, Localization
epriestley closed T4788: Allow "Edit Dependencies" both ways (blocking and depending) as Resolved by committing Restricted Diffusion Commit.
Nov 6 2016, 5:05 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
epriestley added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

I've marked D16806 as resolving this. Once that lands, here's the state of the world in terms of how the product works:

Nov 6 2016, 5:05 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
epriestley added a revision to T4788: Allow "Edit Dependencies" both ways (blocking and depending): Restricted Differential Revision.
Nov 6 2016, 4:14 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia

Nov 1 2016

epriestley added a subtask for T7924: Unprototype Calendar (v1): T11809: Calendar v1 Errata Mark II.
Nov 1 2016, 9:31 PM · Restricted Project, Prioritized, Calendar
sgrimm added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

I'm specifically interested in the arc diff --try part of this and would want that to be the configurable as the default behavior. For an installation that's using things like CircleCI integration to run tests asynchronously on a build server, it seems very plausible that reviewers will sometimes fail to notice that tests haven't finished running yet, which will lead to people landing broken code.

Nov 1 2016, 8:23 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley closed T7931: Create Calendar triggers which notify users before meetings, a subtask of T7924: Unprototype Calendar (v1), as Resolved.
Nov 1 2016, 5:47 PM · Restricted Project, Prioritized, Calendar

Oct 31 2016

epriestley claimed T7924: Unprototype Calendar (v1).
Oct 31 2016, 6:22 PM · Restricted Project, Prioritized, Calendar
epriestley closed T11326: Improve Calendar v1 Design/UI/UX, a subtask of T7924: Unprototype Calendar (v1), as Resolved.
Oct 31 2016, 6:21 PM · Restricted Project, Prioritized, Calendar

Oct 30 2016

epriestley closed T10747: Import and export ICS from Calendar as Resolved.

Duplicate thing filed in T11800.

Oct 30 2016, 5:45 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T10747: Import and export ICS from Calendar.

I'm going to file the duplicate import thing as a separate task since it probably won't come up for a while and close this out.

Oct 30 2016, 5:43 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T10747: Import and export ICS from Calendar.

(Google API integration is covered by T2334 -- you can already interact with Google Calendar via ICS files, but that will add support for using the API instead.)

Oct 30 2016, 4:29 PM · Restricted Project, Prioritized, Calendar
epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 30 2016, 4:21 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Restricted Differential Revision.
Oct 30 2016, 4:13 PM · Restricted Project, Prioritized, Calendar
epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 30 2016, 3:45 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T10747: Import and export ICS from Calendar.

The Gmail/ICS integration seems to actually work OK in practice, here's an event from this install working (modulo some stuff like us not exporting a host/organizer yet):

Oct 30 2016, 3:45 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Restricted Differential Revision.
Oct 30 2016, 3:22 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Restricted Differential Revision.
Oct 30 2016, 3:14 PM · Restricted Project, Prioritized, Calendar
chad added a comment to T5267: Localize Phabricator.

I would subscribe to the Paste, and spend 20 seconds updating the file if it changes. Like I mentioned before, this task has already been prioritized and we're not going to work on it until other things in the prioritization queue have been completed. I think self-maintaining is a reasonable work-around.

Oct 30 2016, 7:27 AM · Prioritized, Localization
MZMcBride added a comment to T5267: Localize Phabricator.

It looks like T10814, specifically T10814#170824, provide some useful info. Thank you for that link!

Oct 30 2016, 4:40 AM · Prioritized, Localization