Page MenuHomePhabricator
Feed Advanced Search

Nov 15 2016

epriestley added a revision to T11866: PhabricatorRepository->generateURI() has bad call to getPathURI() with missing argument: Restricted Differential Revision.
Nov 15 2016, 2:53 PM · Diffusion, Bug Report
chr86 added a comment to T11866: PhabricatorRepository->generateURI() has bad call to getPathURI() with missing argument.

We have the same issue after the last update and we usually update once a week. I can confirm that the issue happens with any commit to a SVN repository that you want to view via Audit. Git commits display fine.
Might this be related to the change "Old", "New" and "Diff" tabs in the web UI from your latest changelog?

Nov 15 2016, 1:53 PM · Diffusion, Bug Report
djeauh updated the task description for T11866: PhabricatorRepository->generateURI() has bad call to getPathURI() with missing argument.
Nov 15 2016, 8:57 AM · Diffusion, Bug Report
djeauh updated the task description for T11866: PhabricatorRepository->generateURI() has bad call to getPathURI() with missing argument.
Nov 15 2016, 8:56 AM · Diffusion, Bug Report
djeauh updated the task description for T11866: PhabricatorRepository->generateURI() has bad call to getPathURI() with missing argument.
Nov 15 2016, 8:55 AM · Diffusion, Bug Report
djeauh created T11866: PhabricatorRepository->generateURI() has bad call to getPathURI() with missing argument.
Nov 15 2016, 8:53 AM · Diffusion, Bug Report
chad merged task T11862: Makefile syntax highlighting isn't auto-detected into T3626: Detection of language for some file types isn't good.
Nov 15 2016, 2:22 AM · Bug Report
samking created T11862: Makefile syntax highlighting isn't auto-detected.
Nov 15 2016, 2:11 AM · Bug Report
chad merged T11861: Restricted objects/related actions should not be visible to users into T10745: Emails are sent out about restricted changes.
Nov 15 2016, 1:52 AM · Restricted Project, Bug Report

Nov 14 2016

epriestley moved T10675: Pytest engine should not execute "coverage" if --no-coverage flag is provided. from Backlog to Unit/Lint Bindings on the Arcanist board.
Nov 14 2016, 5:48 PM · Unit, Arcanist, Bug Report
epriestley moved T10818: Lint errors about filenames, which do not include any source context, render with awkward whitespace from Backlog to vNext on the Arcanist board.
Nov 14 2016, 5:48 PM · Arcanist, Bug Report
epriestley moved T11344: Differential commit message parser immediately rejects objects the user can't see, but Herald can put them there from Backlog to vNext on the Arcanist board.
Nov 14 2016, 5:48 PM · Restricted Project, Differential, Arcanist, Bug Report
epriestley moved T11635: tagging a differential revision with a milestone breaks `arc diff` from Backlog to vNext on the Arcanist board.
Nov 14 2016, 5:48 PM · Restricted Project, Arcanist, Bug Report
epriestley renamed T10818: Lint errors about filenames, which do not include any source context, render with awkward whitespace from Blank lines placement in output of arc lint is confusing to Lint errors about filenames, which do not include any source context, render with awkward whitespace.
Nov 14 2016, 5:48 PM · Arcanist, Bug Report
epriestley moved T10881: git diff parsing fails with --submodule=log from Backlog to vNext on the Arcanist board.
Nov 14 2016, 5:47 PM · Contributor Onboarding, Arcanist, Bug Report
epriestley moved T11178: Some linters fail without a pathway forward if the PHP "xml" extension is not installed from Backlog to Unit/Lint Bindings on the Arcanist board.
Nov 14 2016, 5:47 PM · Lint, Arcanist, Bug Report
epriestley moved T11479: ArcanistUnitTestEngine->shouldEchoTestResults() logic inverted from Backlog to Unit/Lint Bindings on the Arcanist board.
Nov 14 2016, 5:47 PM · Arcanist, Bug Report
chad closed T11858: How to turn back to default homepage as Invalid.
Nov 14 2016, 3:15 PM · Bug Report
tonyhsu created T11858: How to turn back to default homepage.
Nov 14 2016, 10:10 AM · Bug Report
epriestley added a comment to T11841: Unhandled Exception ("AphrontSchemaQueryException") after upgrade.

See Restarting Phabricator for detailed instructions on how to restart Phabricator after an upgrade.

Nov 14 2016, 12:18 AM · Bug Report

Nov 13 2016

francois added a comment to T11841: Unhandled Exception ("AphrontSchemaQueryException") after upgrade.

Hit by the exact same issue of Unknown column 'event.dateFrom' in 'order clause', and arrived here through search. In hope this helps somebody else, here's how I fixed it.

Nov 13 2016, 11:57 PM · Bug Report

Nov 12 2016

epriestley closed T11085: Prevent users from generating an ambiguous commit message by editing revisions with the web UI as Resolved.

I think that will prevent these edits from occurring by accident via the web UI. Yell if you manage to trick it or it causes any weird stuff.

Nov 12 2016, 4:06 PM · Prioritized, Restricted Project, Arcanist, Bug Report
epriestley added a revision to T11085: Prevent users from generating an ambiguous commit message by editing revisions with the web UI: Restricted Differential Revision.
Nov 12 2016, 3:14 PM · Prioritized, Restricted Project, Arcanist, Bug Report

Nov 11 2016

epriestley renamed T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled from Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() to Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.
Nov 11 2016, 9:43 PM · Quicksand, Bug Report
epriestley closed T11853: Caching inside the policy filter may cause policy filtering to occur on a partial representation of a project as Resolved by committing Restricted Diffusion Commit.
Nov 11 2016, 9:42 PM · Policy, Bug Report
epriestley added a comment to T11849: Commit is no longer reachable.

This is way outside the realm of an upstreamable bug report with reproduction steps, but run this again:

Nov 11 2016, 9:41 PM · Bug Report (Needs Information)
epriestley added a revision to T11853: Caching inside the policy filter may cause policy filtering to occur on a partial representation of a project: Restricted Differential Revision.
Nov 11 2016, 9:31 PM · Policy, Bug Report
epriestley added a revision to T11853: Caching inside the policy filter may cause policy filtering to occur on a partial representation of a project: Restricted Differential Revision.
Nov 11 2016, 9:28 PM · Policy, Bug Report
epriestley claimed T11853: Caching inside the policy filter may cause policy filtering to occur on a partial representation of a project.
Nov 11 2016, 9:15 PM · Policy, Bug Report
epriestley renamed T11853: Caching inside the policy filter may cause policy filtering to occur on a partial representation of a project from Cannot view or unlock a subproject to Caching inside the policy filter may cause policy filtering to occur on a partial representation of a project.
Nov 11 2016, 9:15 PM · Policy, Bug Report
epriestley added a comment to T11853: Caching inside the policy filter may cause policy filtering to occur on a partial representation of a project.

Here's the raw data from that install:

Nov 11 2016, 8:31 PM · Policy, Bug Report
epriestley merged task T11837: Phabricator sometimes sends mail that it shouldn't into T10448: Modularize mail tags.
Nov 11 2016, 8:25 PM · Bug Report
epriestley added a comment to T11837: Phabricator sometimes sends mail that it shouldn't.

Dragging a card on a workboard while in a priority-ordered view changes the global priority (see T8135). Mail tags in "other" groups are arbitrary, unclear, and going away (see T10448). I'm going to merge this into T10448.

Nov 11 2016, 8:24 PM · Bug Report
adampaetznick added a comment to T11853: Caching inside the policy filter may cause policy filtering to occur on a partial representation of a project.

I was able to reproduce in this test instance. There is a parent project called Parent, and two subprojects: Sub1 and Sub2. Sub2 produces the error.

Nov 11 2016, 7:09 PM · Policy, Bug Report
chad added a comment to T11853: Caching inside the policy filter may cause policy filtering to occur on a partial representation of a project.

Sounds similar to T10779

Nov 11 2016, 6:58 PM · Policy, Bug Report
avivey added a comment to T11853: Caching inside the policy filter may cause policy filtering to occur on a partial representation of a project.

I can't reproduce this. Can you create a test instance in Phacility and reproduce this there?

Nov 11 2016, 6:23 PM · Policy, Bug Report
adampaetznick added a comment to T11853: Caching inside the policy filter may cause policy filtering to occur on a partial representation of a project.

Versions:

  • phabricator 111c63955155046bbd57c3836c78d460ebe13dfb (Sat, Nov 5)
  • arcanist e17fe43ca3fe6dc6dd0b5ce056f56310ea1d3d51 (Fri, Oct 21)
  • phutil 40e473e057885dab5de4fb42901f7fff2d340a6a (Sat, Nov 5)
Nov 11 2016, 6:18 PM · Policy, Bug Report
adampaetznick created T11853: Caching inside the policy filter may cause policy filtering to occur on a partial representation of a project.
Nov 11 2016, 6:15 PM · Policy, Bug Report
• hamipl created T11850: Pholio Mockups Image Uploads stops uploading.
Nov 11 2016, 1:25 PM · Bug Report (Needs Information)
isfs updated the task description for T11837: Phabricator sometimes sends mail that it shouldn't.
Nov 11 2016, 12:59 AM · Bug Report
isfs added a comment to T11837: Phabricator sometimes sends mail that it shouldn't.

Thanks for that confirmation. I like the look of your code comment: "Possibly we should white-list this kind of mail and deny all other types of mail." I'll create an enhancement request task related to that.

Nov 11 2016, 12:59 AM · Bug Report

Nov 10 2016

epriestley added a comment to T11837: Phabricator sometimes sends mail that it shouldn't.

is Phab supposed to send email to users who are unverified?

Nov 10 2016, 11:42 PM · Bug Report
isfs added a comment to T11837: Phabricator sometimes sends mail that it shouldn't.

Re scenario 1, I found another way to investigate it rather than digging up old logs. Question, though: is Phab supposed to send email to users who are unverified? Looking at mail logs, it seems one of our most recently added users was sent quite a lot of mail, perhaps all mail they would ordinarily get, prior to verification. If Phab is supposed to send mail to unverified users, then this would be an enhancement request which I could submit with a proper description of the use case. If not, I can investigate how to reproduce the behaviour.

Nov 10 2016, 11:31 PM · Bug Report
avivey added a comment to T11849: Commit is no longer reachable.

Most of the work is disk/DB bound, so not having a high cpu load makes sense. That said, processing a lot of tasks will take a while.
When a task fails in an unexpected way, the daemon thread backs-off for a while, so it takes much longer to fail a task than to complete it; Unless most of the commits are failing, it should speed up at some point.
These tasks are also lower-priority than Herald and Publish tasks, which is why those get executed before these; Once these tasks are out of the queue, expect work to happen faster on the commit parsing tasks.

Nov 10 2016, 11:25 PM · Bug Report (Needs Information)
jsturgeon added a comment to T11849: Commit is no longer reachable.

First, thank you for taking the time to answer...

Nov 10 2016, 11:20 PM · Bug Report (Needs Information)
avivey added a comment to T11849: Commit is no longer reachable.

Are the daemons doing anything? Are any tasks, at all, getting done? Are some tasks failing?

Nov 10 2016, 11:16 PM · Bug Report (Needs Information)
jsturgeon added a comment to T11849: Commit is no longer reachable.

Sorry, I should have been more clear..

Nov 10 2016, 11:15 PM · Bug Report (Needs Information)
avivey added a comment to T11849: Commit is no longer reachable.

./bin/phd start will start all the right daemons. Look in the Daemons app in the web interface to see what's going on.

Nov 10 2016, 11:11 PM · Bug Report (Needs Information)
jsturgeon added a comment to T11849: Commit is no longer reachable.

Nope, phd is definitely *not* making any progress on the PhabricatorRepositoryGitCommitMessageParserWorker queued tasks I'm stumped. When I run this:

Nov 10 2016, 11:10 PM · Bug Report (Needs Information)
jsturgeon added a comment to T11849: Commit is no longer reachable.

Yes.. interesting, I had not considered that. I'll re-activate the repo

Nov 10 2016, 11:03 PM · Bug Report (Needs Information)
avivey added a comment to T11849: Commit is no longer reachable.

are the daemons running? You might need to activate the repository for the commits to be parsed.

Nov 10 2016, 11:02 PM · Bug Report (Needs Information)
jsturgeon added a comment to T11849: Commit is no longer reachable.

One other thing that I should note, these commits are all in a repository that is no longer active. (if that matters)

Nov 10 2016, 11:01 PM · Bug Report (Needs Information)
jsturgeon added a comment to T11849: Commit is no longer reachable.

OK, Here's the issue (from what I can tell)
PhabricatorRepositoryGitCommitMessageParserWorker has a count of 105,000 in the queue, but for some reason those commits are not getting parsed. I don't want to 're-queue' them by removing the --force-local, because (according to the help) that will duplicate the work that is already queued. How can I get phd to start working on those commits?

Nov 10 2016, 11:00 PM · Bug Report (Needs Information)
jsturgeon added a comment to T11849: Commit is no longer reachable.

Will try.. Thank you.

Nov 10 2016, 10:50 PM · Bug Report (Needs Information)
avivey added a comment to T11849: Commit is no longer reachable.

I believe that if you drop --force-local, the reparse code will schedule the reparse to run using the daemons, which should fail to parse this commit and continue to the next one.

Nov 10 2016, 10:50 PM · Bug Report (Needs Information)
avivey added a comment to T11849: Commit is no longer reachable.

The task for parsing this commit should auto-cancel because it encountered a PhabricatorWorkerPermanentFailureException. In this case, you're manually re-parsing it, but it shouldn't be happening automatically.

Nov 10 2016, 10:48 PM · Bug Report (Needs Information)
jsturgeon added a comment to T11849: Commit is no longer reachable.

What can I do next to get the commit parser to stop trying to parse this.

Nov 10 2016, 10:47 PM · Bug Report (Needs Information)
isfs added a comment to T11837: Phabricator sometimes sends mail that it shouldn't.

Related thought: I wonder how the sticky task order fares when a task is on multiple workboards; since the subpriority seems to be a task parameter, not a workboard card parameter, I guess moving it on one workboard may clobber its position on another; quite possibly not a problem in practice.

Nov 10 2016, 10:41 PM · Bug Report
avivey added a comment to T11849: Commit is no longer reachable.

What's unclear?

Nov 10 2016, 10:37 PM · Bug Report (Needs Information)
chad reopened T11837: Phabricator sometimes sends mail that it shouldn't as "Open".
Nov 10 2016, 10:34 PM · Bug Report
chad added a comment to T11837: Phabricator sometimes sends mail that it shouldn't.

Hmm yeah, we record where in the workboard card is in the list, sticky. We could probably ignore that transaction.

Nov 10 2016, 10:31 PM · Bug Report
isfs added a comment to T11837: Phabricator sometimes sends mail that it shouldn't.

OK. The type of the other transaction is subpriority. From the database:

Nov 10 2016, 10:29 PM · Bug Report
jsturgeon created T11849: Commit is no longer reachable.
Nov 10 2016, 10:24 PM · Bug Report (Needs Information)
isfs added a comment to T11837: Phabricator sometimes sends mail that it shouldn't.

Initialisation doesn't seem to fit the pattern, as I would have expected an earlier column change to trigger it if that would. There are also over a dozen transactions on the timeline of this task before the section I pasted here, including comments (one deleted; I wonder if that's relevant), column changes, reassignments, and status changes.

Nov 10 2016, 10:06 PM · Bug Report
chad added a comment to T11837: Phabricator sometimes sends mail that it shouldn't.

There might be some crazy edge case of empty custom field that was previously hidden in a custom form and is being initialized for the first time, but not generating a visible transaction, so is getting lumped under "other". Hard to say, I can't really recreate how this might happen. Do you have "other" email sent to "on" but everything else "off" ? Knowing those would be important in a reproduction case as well.

Nov 10 2016, 9:52 PM · Bug Report
isfs added a comment to T11837: Phabricator sometimes sends mail that it shouldn't.

Yes, both. I don't see how either of those could be involved with a column change, though, could it? Changes to our custom field do show on the timeline, too, but nothing is showing here.

Nov 10 2016, 9:50 PM · Bug Report
chad added a comment to T11837: Phabricator sometimes sends mail that it shouldn't.

Do you have custom fields or custom forms?

Nov 10 2016, 9:39 PM · Bug Report
isfs updated the task description for T11837: Phabricator sometimes sends mail that it shouldn't.
Nov 10 2016, 9:21 PM · Bug Report
isfs changed the status of T11837: Phabricator sometimes sends mail that it shouldn't from Resolved to Invalid.

I wouldn't call this resolved. Invalid may be most relevant, as with no STR, we can't confirm or action this.

Nov 10 2016, 9:21 PM · Bug Report
avivey added a project to T10405: Phabricator should generally work properly even if "gd" is not installed: Setup.
Nov 10 2016, 9:17 PM · Setup, Restricted Project
epriestley added a comment to T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.
Nov 10 2016, 7:47 PM · Quicksand, Bug Report
jcox added a comment to T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.

{auto-playing-audio WilhelmScream.mp3}

Nov 10 2016, 7:43 PM · Quicksand, Bug Report
epriestley added a project to T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled: Quicksand.

Welcome to the wonderful, spooky world of Quicksand.

Nov 10 2016, 7:41 PM · Quicksand, Bug Report
jcox added a comment to T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.

Yes I did have the persistent chat pane open. Also can't seem to repro without it.

Nov 10 2016, 7:41 PM · Quicksand, Bug Report
chad added a comment to T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.

Quicksand

Nov 10 2016, 7:39 PM · Quicksand, Bug Report
epriestley added a comment to T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.

Do you have the persistent chat pane open?

Nov 10 2016, 7:22 PM · Quicksand, Bug Report
epriestley closed T11839: Invalid translation for diffusion.uri.edit display as Resolved by committing Restricted Diffusion Commit.
Nov 10 2016, 4:55 PM · Bug Report
jcox added a comment to T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.

The other errors that appear in DarkConsole:

pasted_file (276×920 px, 79 KB)

Nov 10 2016, 3:32 PM · Quicksand, Bug Report
jcox created T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.
Nov 10 2016, 3:28 PM · Quicksand, Bug Report
epriestley claimed T11839: Invalid translation for diffusion.uri.edit display.

D16837 should clean this up. Thanks for the thorough report!

Nov 10 2016, 2:21 PM · Bug Report
epriestley added a revision to T11839: Invalid translation for diffusion.uri.edit display: Restricted Differential Revision.
Nov 10 2016, 2:21 PM · Bug Report
TiTi added a comment to T11539: Phabricator Mercurial Repo “too many files open” error.

Just had this issue today on our mercurial repository. Exact same exception when executing ./bin/repository update --trace <repository>
I've managed to solve it.

Nov 10 2016, 2:01 PM · Bug Report
chad closed T11841: Unhandled Exception ("AphrontSchemaQueryException") after upgrade as Resolved.
Nov 10 2016, 6:11 AM · Bug Report
constantx added a comment to T11841: Unhandled Exception ("AphrontSchemaQueryException") after upgrade.

ah, seems like a restart of apache fixed it.

Nov 10 2016, 6:08 AM · Bug Report
constantx created T11841: Unhandled Exception ("AphrontSchemaQueryException") after upgrade.
Nov 10 2016, 6:02 AM · Bug Report
chad added a comment to T11840: All the Phabricator commands cannot run under server SUSE Enterprise 11 SP4.

(Please ask general admin questions like this in Ponder).

Nov 10 2016, 4:15 AM · Setup, Bug Report
chad closed T11840: All the Phabricator commands cannot run under server SUSE Enterprise 11 SP4 as Invalid.

We unfortunately do not take installation questions as bug reports. We're happy to assist with our Phacility Consulting if you need or use Support Resources.

Nov 10 2016, 4:14 AM · Setup, Bug Report
avivey added a comment to T11840: All the Phabricator commands cannot run under server SUSE Enterprise 11 SP4.

In the phabricator directory, what does file bin/config say?

Nov 10 2016, 4:11 AM · Setup, Bug Report
gshe created T11840: All the Phabricator commands cannot run under server SUSE Enterprise 11 SP4.
Nov 10 2016, 4:09 AM · Setup, Bug Report
lewellyn updated the task description for T11839: Invalid translation for diffusion.uri.edit display.
Nov 10 2016, 2:36 AM · Bug Report
lewellyn updated the task description for T11839: Invalid translation for diffusion.uri.edit display.
Nov 10 2016, 2:35 AM · Bug Report
lewellyn created T11839: Invalid translation for diffusion.uri.edit display.
Nov 10 2016, 2:34 AM · Bug Report
epriestley closed T11833: "parent"/"child" relationship for Revisions is confusing as Wontfix.

I'm happy to change this if anyone comes up with good alternate wording, but I think this might be about the best we can do.

Nov 10 2016, 12:55 AM · Differential, Bug Report
avivey closed T11792: Remove "No Highlighting" mode from Diffusion as Resolved by committing Restricted Diffusion Commit.
Nov 10 2016, 12:40 AM · Diffusion, Bug Report
avivey added a revision to T11792: Remove "No Highlighting" mode from Diffusion: Restricted Differential Revision.
Nov 10 2016, 12:33 AM · Diffusion, Bug Report

Nov 9 2016

epriestley added a revision to T11836: Calendar Imports have the correct policy, but that policy is unclear: Restricted Differential Revision.
Nov 9 2016, 8:17 PM · Calendar
chad closed T11838: libphutil made call to undefined function id(), fataling on Windows as Resolved.

whew! good to hear.

Nov 9 2016, 6:06 PM · Bug Report
cxzzero added a comment to T11838: libphutil made call to undefined function id(), fataling on Windows.

Definitely there was a problem with the installation, for some reason the files got corrupted and downloading a fresh installation solved the problem.

Nov 9 2016, 5:56 PM · Bug Report
epriestley renamed T11836: Calendar Imports have the correct policy, but that policy is unclear from Calendar Imports have the wrong policy set to Calendar Imports have the correct policy, but that policy is unclear.
Nov 9 2016, 5:39 PM · Calendar
cxzzero added a comment to T11838: libphutil made call to undefined function id(), fataling on Windows.

Thanks chad. I will check if there is a problem with the installation and let you know.

Nov 9 2016, 5:18 PM · Bug Report