Page MenuHomePhabricator
Feed Advanced Search

Sep 27 2016

epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 27 2016, 11:30 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 27 2016, 11:20 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 27 2016, 10:52 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 27 2016, 10:41 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 27 2016, 10:32 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 27 2016, 6:41 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T4190: Rebuild remarkup image proxying.

(I'll follow up on this once I have a chance to bang on it a bit, but I want to try to finish up the RRULE stuff while it's still somewhat fresh in my mind.)

Sep 27 2016, 5:03 PM · Contributor Onboarding, Remarkup
epriestley closed T11524: Import-time diff generation fails for particular commits in cluster mode as Resolved.

This went out a while ago and I confirmed the fix in production.

Sep 27 2016, 4:43 PM · Phacility, Clusters, Daemons, Diffusion
epriestley closed T11650: Owners does not assign as reviewer if an Owners package with the same path has been archived as Resolved.

I'm going to presume we got this, but reopen or yell if you're still seeing issues on the new code.

Sep 27 2016, 4:38 PM · Restricted Project, Bug Report
epriestley closed T11703: Floating point issue on points on workboards as Resolved by committing Restricted Diffusion Commit.
Sep 27 2016, 4:36 PM · Workboards, Bug Report
epriestley moved T11661: Change PhabricatorPhurlURLViewController to use EditEngine for commenting from Backlog to Basic on the Contributor Onboarding board.
Sep 27 2016, 4:35 PM · Contributor Onboarding, Modernization
epriestley added a project to T11661: Change PhabricatorPhurlURLViewController to use EditEngine for commenting: Contributor Onboarding.
Sep 27 2016, 4:35 PM · Contributor Onboarding, Modernization
epriestley edited projects for T11692: Open differential submission and public view, added: Bug Report (Needs Information); removed Bug Report.
Sep 27 2016, 4:33 PM · Differential, Bug Report (Needs Information)
epriestley claimed T11703: Floating point issue on points on workboards.
Sep 27 2016, 4:32 PM · Workboards, Bug Report
epriestley added a comment to T11703: Floating point issue on points on workboards.

Thanks for the report! The detailed reproduction instructions were very helpful in resolving this.

Sep 27 2016, 4:32 PM · Workboards, Bug Report
epriestley added a revision to T11703: Floating point issue on points on workboards: Unknown Object (Differential Revision).
Sep 27 2016, 4:31 PM · Workboards, Bug Report
epriestley added a comment to T11217: Make Tokens modular / real application.

I'm also not sure if we can use SVG as a data: URL in CSS. It probably should work, but if it doesn't we'll have to rasterize (and, I guess, serve 5+ different sizes to every user).

Sep 27 2016, 4:18 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
epriestley added a comment to T11217: Make Tokens modular / real application.

Alright -- we can have bin/celerity map rasterize SVG into arbitrary sizes if I'm not comfortable serving SVG directly from Celerity.

Sep 27 2016, 4:17 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
epriestley moved T10715: Badge name on badge cards should be a link to the badge page from Backlog to Basic on the Contributor Onboarding board.
Sep 27 2016, 4:12 PM · Contributor Onboarding, Badges
epriestley reassigned T10715: Badge name on badge cards should be a link to the badge page from lpriestley to jcox.
  • Create a badge.
  • Award it to a user.
  • Visit their profile page.
  • On the profile page, the badge title should link to the badge detail page (currently: no way to get to the badge detail page).
Sep 27 2016, 4:11 PM · Contributor Onboarding, Badges
epriestley moved T9063: Conduit application search from Backlog to Basic on the Contributor Onboarding board.
Sep 27 2016, 4:08 PM · Contributor Onboarding, Restricted Project, Conduit
epriestley reassigned T9063: Conduit application search from joshuaspence to jcox.

I'm not really sure this is actually useful given that every method is now named <application>.whatever and you can search by substring.

Sep 27 2016, 4:08 PM · Contributor Onboarding, Restricted Project, Conduit
epriestley added a comment to T11217: Make Tokens modular / real application.

(That will give us slightly bad scale-downs on 1X screens, but I bet they're not worse than scaling down an SVG would be.)

Sep 27 2016, 4:05 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
epriestley added a comment to T11217: Make Tokens modular / real application.

I think we can just do 2x in all cases for these, if that's reasonable?

Sep 27 2016, 4:04 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
epriestley assigned T11217: Make Tokens modular / real application to jcox.

This one is a little scattered, so let me know where I can fill in any gaps. Most of the details are in D16178.

Sep 27 2016, 3:59 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
epriestley moved T11701: Add a lint rule for `if (CONSTANT) { ... }` from Backlog to Ready on the Contributor Onboarding board.
Sep 27 2016, 3:57 PM · Contributor Onboarding, Infrastructure, Arcanist, Lint
epriestley added a project to T11701: Add a lint rule for `if (CONSTANT) { ... }`: Contributor Onboarding.
Sep 27 2016, 3:57 PM · Contributor Onboarding, Infrastructure, Arcanist, Lint
epriestley moved T11217: Make Tokens modular / real application from Backlog to Intermediate on the Contributor Onboarding board.
Sep 27 2016, 3:47 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
epriestley reassigned T10681: Add Phurl Conduit API methods from lpriestley to jcox.
Sep 27 2016, 3:46 PM · Contributor Onboarding, Restricted Project, Conduit, Phurl
epriestley moved T10681: Add Phurl Conduit API methods from Backlog to Intermediate on the Contributor Onboarding board.
Sep 27 2016, 3:46 PM · Contributor Onboarding, Restricted Project, Conduit, Phurl

Sep 26 2016

epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 26 2016, 10:50 PM · Restricted Project, Prioritized, Calendar
epriestley created T11701: Add a lint rule for `if (CONSTANT) { ... }`.
Sep 26 2016, 3:12 PM · Contributor Onboarding, Infrastructure, Arcanist, Lint
epriestley added a comment to T11693: Make drydock command interfaces accessible via SSH workflows.

Do you have any use cases which are not approximately some flavor of:

Sep 26 2016, 1:31 PM · Restricted Project, Drydock
epriestley added a comment to T8135: drag & drop on a workboard sorted by priority behavior is surprising.

I mean, it's probably not worse-worse, and but it feels like trading one kind of confusion for possibly-moderately-less-confusion more than putting a reasonable stopgap behavior in place until we can fix it properly.

Sep 26 2016, 1:25 PM · Restricted Project, Workboards (v3), Restricted Project
epriestley added a comment to T8135: drag & drop on a workboard sorted by priority behavior is surprising.

Oh. To me, that's sort of worse? You end up with "Sort by priority" and your tasks aren't actually sorted by priority if you've moved them between columns, and jump around if you reload, and other users won't see the same ordering if they're trying to follow along in a presentation or whatever.

Sep 26 2016, 1:23 PM · Restricted Project, Workboards (v3), Restricted Project
epriestley added a comment to T8135: drag & drop on a workboard sorted by priority behavior is surprising.

Sorry, I think I'm still not understanding. When the column is grouped by priority, I still expect the auto-reprioritize behavior to work more or less as it does today: if you drag a task into the "High" group, it will change to "High" priority. I don't think we can avoid that without greater confusion.

Sep 26 2016, 1:20 PM · Restricted Project, Workboards (v3), Restricted Project
epriestley added a comment to T8135: drag & drop on a workboard sorted by priority behavior is surprising.

@chad Oh, maybe I'm misunderstanding. What are you proposing, specifically?

Sep 26 2016, 1:11 PM · Restricted Project, Workboards (v3), Restricted Project
epriestley added a comment to T8135: drag & drop on a workboard sorted by priority behavior is surprising.

I think of T10333 and what remains here as mostly the same task -- I don't plan to make sorting and grouping separate (offhand, I can't come up with much of a good reason to group + sort, and if we did support that it would recreate a small version of this problem within groups).

Sep 26 2016, 1:08 PM · Restricted Project, Workboards (v3), Restricted Project

Sep 24 2016

epriestley edited the content of 2016 Week 39 (Late September).
Sep 24 2016, 1:14 PM
epriestley closed T11695: Observer URI fails to clone as Resolved.

iiam

Sep 24 2016, 1:11 PM · Bug Report
epriestley added a comment to T11695: Observer URI fails to clone.

How can I reproduce this locally? See Providing Reproduction Steps for help on providing reproduction steps.

Sep 24 2016, 12:35 PM · Bug Report
epriestley edited the content of Changelog.
Sep 24 2016, 12:55 AM
epriestley created 2016 Week 39 (Late September).
Sep 24 2016, 12:54 AM
epriestley added a comment to T11692: Open differential submission and public view.

To accept this report, we need reproduction instructions we can follow to reproduce the issue locally. See Providing Reproduction Steps for details.

Sep 24 2016, 12:43 AM · Differential, Bug Report (Needs Information)

Sep 23 2016

epriestley added a revision to T11672: Evaluate persistent connections from HTTP contexts: Unknown Object (Differential Revision).
Sep 23 2016, 7:40 PM · Restricted Project, Performance, Clusters, Database
epriestley reopened T11672: Evaluate persistent connections from HTTP contexts as "Open".
Sep 23 2016, 7:37 PM · Restricted Project, Performance, Clusters, Database
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 23 2016, 6:56 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T11691: arc diff with untracked directory complains about every single file in that directory.

I think this is entirely reasonable.

Sep 23 2016, 5:56 PM · FreeBSD, Restricted Project, Arcanist, Bug Report
epriestley triaged T11691: arc diff with untracked directory complains about every single file in that directory as Normal priority.
Sep 23 2016, 5:51 PM · FreeBSD, Restricted Project, Arcanist, Bug Report
epriestley added a comment to T4190: Rebuild remarkup image proxying.

To actually add a remarkup rule, the basics are simple:

Sep 23 2016, 1:28 PM · Contributor Onboarding, Remarkup

Sep 22 2016

epriestley closed T11679: Phragment has invalid (non-UTF8) title glyph as Resolved by committing Restricted Diffusion Commit.
Sep 22 2016, 10:13 PM · Contributor Onboarding, Phragment, Bug Report
epriestley reopened T9896: make images from comments visible in email as "Open".

I think this didn't actually get handled in T10262, but should be doable now.

Sep 22 2016, 10:12 PM · Restricted Project, Remarkup, Mail
epriestley renamed T11670: Automate more of the migration process for moving instances across shards in the Phacility cluster from Move instances across shards in the Phacility cluster to Automate more of the migration process for moving instances across shards in the Phacility cluster.
Sep 22 2016, 10:09 PM · Ops, Phacility
epriestley moved T11670: Automate more of the migration process for moving instances across shards in the Phacility cluster from Backlog to Do Eventually on the Phacility board.
Sep 22 2016, 10:09 PM · Ops, Phacility
epriestley claimed T11679: Phragment has invalid (non-UTF8) title glyph.
Sep 22 2016, 10:08 PM · Contributor Onboarding, Phragment, Bug Report
epriestley added a revision to T11679: Phragment has invalid (non-UTF8) title glyph: Unknown Object (Differential Revision).
Sep 22 2016, 10:08 PM · Contributor Onboarding, Phragment, Bug Report
epriestley added a comment to T11679: Phragment has invalid (non-UTF8) title glyph.

Unicode has a page of heiroglyphs but they don't seem to be supported yet on OSX.

Sep 22 2016, 10:04 PM · Contributor Onboarding, Phragment, Bug Report
epriestley added a comment to T11623: Make Conpherence send text with bare return key, like a chatroom.

This is probably 5 minutes of work, I am just incredibly unreliable.

Sep 22 2016, 10:01 PM · Conpherence (v4)
epriestley closed T11682: Numbered lists are overzealous as Wontfix.

Actually, I don't think we can really style the numbers of a numbered list independently of the rest of the list. They aren't directly addressable with CSS and the approaches I've found for doing it rely on using counter(...), which I think is unreasonably complex for this use case:

Sep 22 2016, 9:57 PM · Bug Report
epriestley closed T11685: Phurl "Shorten a URL" 404s as Resolved by committing Restricted Diffusion Commit.
Sep 22 2016, 9:45 PM · Phurl, Bug Report
epriestley added a revision to T11685: Phurl "Shorten a URL" 404s: Unknown Object (Differential Revision).
Sep 22 2016, 9:41 PM · Phurl, Bug Report
epriestley closed T11683: Attempt to connect to phabricator@p:127.0.0.1 failed with error #1040: Too many connections. as Resolved by committing Restricted Diffusion Commit.
Sep 22 2016, 8:09 PM · Bug Report
epriestley added a revision to T11683: Attempt to connect to phabricator@p:127.0.0.1 failed with error #1040: Too many connections.: Unknown Object (Differential Revision).
Sep 22 2016, 7:39 PM · Bug Report
epriestley added a comment to T11686: Differentials for new files.

I can't reproduce this. Here's a diff with a new file:

Sep 22 2016, 7:22 PM · Feature Request
epriestley added a project to T11685: Phurl "Shorten a URL" 404s: Phurl.
Sep 22 2016, 5:12 PM · Phurl, Bug Report
epriestley added a comment to T11685: Phurl "Shorten a URL" 404s.

Ah! Thanks, we'll get this fixed.

Sep 22 2016, 5:12 PM · Phurl, Bug Report
epriestley reopened T11685: Phurl "Shorten a URL" 404s as "Open".
Sep 22 2016, 5:12 PM · Phurl, Bug Report
epriestley closed T11685: Phurl "Shorten a URL" 404s as Invalid.

See Contributing Bug Reports if this is intended to be a bug report.

Sep 22 2016, 5:11 PM · Phurl, Bug Report
dzahn awarded T11675: "Text" type custom field in Maniphest not displayed in Maniphest Advanced Search form a Love token.
Sep 22 2016, 2:45 PM · Custom Fields, Maniphest, Bug Report
epriestley added a comment to T11683: Attempt to connect to phabricator@p:127.0.0.1 failed with error #1040: Too many connections..

Does raising max_connections in /etc/my.cnf (or similar) and restarting MySQL resolve this?

Sep 22 2016, 1:28 PM · Bug Report
epriestley added a comment to T11682: Numbered lists are overzealous.

GitHub also does this:

Sep 22 2016, 12:11 PM · Bug Report
epriestley added a comment to T11683: Attempt to connect to phabricator@p:127.0.0.1 failed with error #1040: Too many connections..

We made one change recently (T11672) but that should cause us to use fewer connections.

Sep 22 2016, 12:00 PM · Bug Report
epriestley closed T11680: Why not use indentation for TASK GRAPH? as Invalid.

Please see Contributing Feature Requests for help filing feature requests. Thanks!

Sep 22 2016, 3:10 AM · Feature Request
epriestley added a comment to T11675: "Text" type custom field in Maniphest not displayed in Maniphest Advanced Search form.

This should now just work without any changes at HEAD of master. Let us know if you're still seeing issues after updating.

Sep 22 2016, 1:24 AM · Custom Fields, Maniphest, Bug Report
epriestley added a comment to T11676: For task with many dependencies, cannot scroll horizontally in Task Graph for certain widths (overflow is clipped).

I think this should work better at HEAD of master now -- let us know if you're still seeing issues after updating. Thanks for the report!

Sep 22 2016, 1:23 AM · Maniphest, Bug Report
epriestley closed T11676: For task with many dependencies, cannot scroll horizontally in Task Graph for certain widths (overflow is clipped) as Resolved by committing Restricted Diffusion Commit.
Sep 22 2016, 1:22 AM · Maniphest, Bug Report

Sep 21 2016

epriestley closed T11677: Queue tasks from importing repositories at a lower priority level as Resolved by committing Restricted Diffusion Commit.
Sep 21 2016, 11:41 PM · Diffusion, Daemons
epriestley closed T11675: "Text" type custom field in Maniphest not displayed in Maniphest Advanced Search form as Resolved by committing Restricted Diffusion Commit.
Sep 21 2016, 11:39 PM · Custom Fields, Maniphest, Bug Report
epriestley added a revision to T11677: Queue tasks from importing repositories at a lower priority level: Unknown Object (Differential Revision).
Sep 21 2016, 10:38 PM · Diffusion, Daemons
epriestley claimed T11675: "Text" type custom field in Maniphest not displayed in Maniphest Advanced Search form.
Sep 21 2016, 10:07 PM · Custom Fields, Maniphest, Bug Report
epriestley claimed T11676: For task with many dependencies, cannot scroll horizontally in Task Graph for certain widths (overflow is clipped).
Sep 21 2016, 10:06 PM · Maniphest, Bug Report
epriestley closed T11678: Inline images from emails sent from Outlook are not correctly attached to Maniphest Tasks as Resolved.

Presuming resolved by D16584. Thanks!

Sep 21 2016, 10:06 PM · Bug Report
epriestley closed T11672: Evaluate persistent connections from HTTP contexts as Resolved.
Sep 21 2016, 9:47 PM · Restricted Project, Performance, Clusters, Database
epriestley added a comment to T11672: Evaluate persistent connections from HTTP contexts.

I've banged on this a reasonable amount locally without issues and the originating instance reports that this seems to have calmed things down in production with these patches, so it seems like this pretty much just worked.

Sep 21 2016, 9:47 PM · Restricted Project, Performance, Clusters, Database
epriestley added a revision to T11676: For task with many dependencies, cannot scroll horizontally in Task Graph for certain widths (overflow is clipped): Restricted Differential Revision.
Sep 21 2016, 9:45 PM · Maniphest, Bug Report
epriestley added a revision to T11675: "Text" type custom field in Maniphest not displayed in Maniphest Advanced Search form: Unknown Object (Differential Revision).
Sep 21 2016, 9:35 PM · Custom Fields, Maniphest, Bug Report
epriestley added a comment to T11675: "Text" type custom field in Maniphest not displayed in Maniphest Advanced Search form.

There's a bunch of other Herald stuff we already do for this field so I'm just undoing the change from D14766, at least until someone complains that this field type isn't using the search logic they expect.

Sep 21 2016, 9:34 PM · Custom Fields, Maniphest, Bug Report
epriestley added a comment to T11678: Inline images from emails sent from Outlook are not correctly attached to Maniphest Tasks.

Yeah, go ahead and submit a patch. Thanks!

Sep 21 2016, 9:28 PM · Bug Report
epriestley added a comment to T7916: Can't paste images from clipboard in Firefox / Safari.

I can't reproduce this in Chrome (OS X, Version 53.0.2785.116 (64-bit)) so it may be a behavioral change in Chrome.

Sep 21 2016, 7:57 PM · Restricted Project, Firefox, Safari, PHUI
epriestley triaged T11679: Phragment has invalid (non-UTF8) title glyph as Wishlist priority.
Sep 21 2016, 5:57 PM · Contributor Onboarding, Phragment, Bug Report
epriestley renamed T11679: Phragment has invalid (non-UTF8) title glyph from Phragment on secure.phabricator.com crashes to Phragment has invalid (non-UTF8) title glyph.
Sep 21 2016, 5:57 PM · Contributor Onboarding, Phragment, Bug Report
epriestley moved T11679: Phragment has invalid (non-UTF8) title glyph from Backlog to Ready on the Contributor Onboarding board.
Sep 21 2016, 5:56 PM · Contributor Onboarding, Phragment, Bug Report
epriestley added a project to T11679: Phragment has invalid (non-UTF8) title glyph: Contributor Onboarding.

To fix:

Sep 21 2016, 5:56 PM · Contributor Onboarding, Phragment, Bug Report
epriestley updated subscribers of T11679: Phragment has invalid (non-UTF8) title glyph.

We don't normally accept bug reports on prototype applications (see Prototype) but this is a one-line fix.

Sep 21 2016, 5:48 PM · Contributor Onboarding, Phragment, Bug Report
epriestley moved T11667: Default global syntax.filemap sets default filetypes to JavaScript for JSON configurations from Backlog to Ready on the Contributor Onboarding board.
Sep 21 2016, 5:01 PM · Contributor Onboarding, Bug Report
epriestley added a project to T11667: Default global syntax.filemap sets default filetypes to JavaScript for JSON configurations: Contributor Onboarding.

To fix this:

Sep 21 2016, 5:01 PM · Contributor Onboarding, Bug Report
epriestley closed T11668: Herald editing view show unknown error as Invalid.

This isn't a bug in Phabricator, then. Please review Contributing Bug Reports and Support Resources carefully for details on what we provide support with.

Sep 21 2016, 3:40 PM · Bug Report (Needs Information)
epriestley added a comment to T4190: Rebuild remarkup image proxying.

On the cache:

Sep 21 2016, 3:38 PM · Contributor Onboarding, Remarkup
epriestley created T11677: Queue tasks from importing repositories at a lower priority level.
Sep 21 2016, 2:54 PM · Diffusion, Daemons
epriestley added a comment to T11676: For task with many dependencies, cannot scroll horizontally in Task Graph for certain widths (overflow is clipped).

I think this is the CSS that tries to cut off the titles interacting weirdly with other table CSS.

Sep 21 2016, 2:37 PM · Maniphest, Bug Report