Page MenuHomePhabricator
Create Task
Maniphest T11703

Floating point issue on points on workboards
Closed, ResolvedPublic
Actions

Description

Sorry for not providing much info before.

Phabricator has a floating point issue when adding up decimal task points.

I can reproduce this by putting tasks with the following point values (in this order) on a single workboard:
0.1, 0.25, 0.25, 0.5, 0.1

The total shows up as:

pasted_file (54×310 px, 2 KB)

Maybe should just find whatever the longest decimal component in the list is and round to that.

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit

Event Timeline

rbalik created this task.Sep 26 2016, 9:01 PM
chad added a subscriber: chad.Sep 26 2016, 9:34 PM

Thanks!

epriestley added a revision: Restricted Differential Revision.Sep 27 2016, 4:31 PM
epriestley added a subscriber: epriestley.Sep 27 2016, 4:32 PM

Thanks for the report! The detailed reproduction instructions were very helpful in resolving this.

I believe D16601 should fix it, using the approach you suggest (rounding to the most-precise value's precision) which seems like a reasonable approach to me.

epriestley claimed this task.Sep 27 2016, 4:32 PM
epriestley triaged this task as Normal priority.
epriestley added a project: Workboards.
Herald added a subscriber: eadler. · View Herald TranscriptSep 27 2016, 4:32 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Sep 27 2016, 4:36 PM
epriestley added a commit: Restricted Diffusion Commit.
Phabricator · Built by Phacility