Page MenuHomePhabricator

Differentials for new files
Closed, InvalidPublic

Description

example_diff.png (544×1 px, 106 KB)

Whenever a new file is added, Phabricator shows nothing initially, and has a hyperlink to "Show File Contents".

When you show the file contents, it shows a side by side "diff", where the contents are identical (no differences).

The 1st issue is this is unnecessary clicking. I want to review all new *code* going into the project, and it makes no difference whatsoever whether that new code was put into an existing file or put into a new file. I still want to look it over. In other words, the differential should show it by default, not hide it by default.

The 2nd issue is the side by side "diff" with identical contents is pointless, and wastes a lot of screen real estate. If there is a new file added, and therefore no previous revision of the file to compare its contents against, then the web page should only show the contents of that file *once*.

Event Timeline

• richjahn updated the task description. (Show Details)
• richjahn updated the task description. (Show Details)
• richjahn updated the task description. (Show Details)

I can't reproduce this. Here's a diff with a new file:

https://secure.phabricator.com/differential/diff/39924/

Here's what I see:

Screen Shot 2016-09-22 at 12.21.37 PM.png (209×917 px, 18 KB)

(This appears to be what you describe as your desired behavior.)

Thanks for the quick reply. It seems to be an issue with an internal script here, not Phabricator itself, so you can disregard.

chad added a subscriber: chad.

Thanks!