Page MenuHomePhabricator

Phragment has invalid (non-UTF8) title glyph
Closed, ResolvedPublic

Description

Steps to reproduce:
go to: https://secure.phabricator.com/phragment/

see:

<body class="unhandled-exception"><div class="unhandled-exception-detail"><h1 class="unhandled-exception-title">Exception</h1><div class="unhandled-exception-body">Failed to JSON encode value (#5: Malformed UTF-8 characters, possibly incorrectly encoded): Dictionary value at key &quot;durable-column &gt; 0 &gt; quicksandConfig &gt; title&quot; is not valid UTF8, and cannot be JSON encoded: �&amp;� Browse Fragments.</div></div></body>

Related Objects

Event Timeline

We don't normally accept bug reports on prototype applications (see Prototype) but this is a one-line fix.

PhabricatorPhragmentApplication->getTitleGlyph() is not a valid UTF8 character. I'm not sure what it's supposed to be.

public function getTitleGlyph() {
  return "\xE2\x26\xB6";
}

It was introduced in D7726 without discussion.

@hach-que, do you remember what the intent was?

To fix:

  • Select any valid UTF8 character not in use by another application (one which suits your fancy, or perhaps one discussed below by the time this task is started).
  • Replace PhabricatorPhragmentApplication->getTitleGlyph() with that character.

To verify:

  • Load /phragment/, observe glyph in page title (this depends on preferences, and you must enable prototype applications).
epriestley renamed this task from Phragment on secure.phabricator.com crashes to Phragment has invalid (non-UTF8) title glyph.Sep 21 2016, 5:56 PM
epriestley triaged this task as Wishlist priority.
epriestley moved this task from Backlog to Ready on the Contributor Onboarding board.

Pretty sure it was copy pasted from something else at the time; I don't believe I would have actually picked a glyph.

Unicode has a page of heiroglyphs but they don't seem to be supported yet on OSX.

But some day it will be possible to type a little picture of a duck! Computers have truly enriched our lives.