Page MenuHomePhabricator
Feed Advanced Search

Jul 2 2016

epriestley added a comment to T11261: Simplify Dashboard Panel Layouts.

When you're editing a homepage dashboard, just having a spacer bar there for the applications menu might help make it more clear that 66/33 is better in a lot of cases than 50/50 -- currently, you can't see what stuff will really look like until you're already done and installed.

Jul 2 2016, 6:33 PM · Dashboards
epriestley added a comment to T11261: Simplify Dashboard Panel Layouts.

wow pretty sure I even picked numbers that add up to 100%

Jul 2 2016, 6:32 PM · Dashboards
epriestley added a comment to T11261: Simplify Dashboard Panel Layouts.

I definitely think we should skip the 3-column versions for now, I don't think we've seen any kind of need for them in practice. We could look at it again after Facts since I think some of these weirder things could make more sense on standalone dashboards, the app just isn't powerful enough yet for that to be paritcularly useful.

Jul 2 2016, 6:32 PM · Dashboards
epriestley added a comment to T11261: Simplify Dashboard Panel Layouts.

Do you think 50/50 and 33/66 are always bad even for standalone (not-on-homepage) dashboards? e.g., if we had a "Phacility Metrics" dashboard in the future after Facts, a 50/50 of a "Users" column and "Revenue" column or whatever could never be a useful way to present the information?

Jul 2 2016, 6:22 PM · Dashboards
epriestley added a comment to T11261: Simplify Dashboard Panel Layouts.

Haha, that's probably T10612.

Jul 2 2016, 6:16 PM · Dashboards
epriestley added a comment to T11261: Simplify Dashboard Panel Layouts.

Why do you think installs (offhand: Babel, WMF) are picking 1/2 + 1/2 if they're strictly worse than 2/3 + 1/3?

Jul 2 2016, 6:05 PM · Dashboards
epriestley triaged T11260: Deactivate "Adjust timezone" when user setting is UTC as Wishlist priority.

You're the only user we're currently aware of who wants to use the software like this, so I don't plan to address this use case at this time.

Jul 2 2016, 5:03 PM · User Preferences
epriestley added a comment to T11260: Deactivate "Adjust timezone" when user setting is UTC.

But when I am looking at my calendar app, I want to see local times, for whatever timezone I am in.

Jul 2 2016, 4:50 PM · User Preferences
epriestley added a comment to T11259: UNRECOVERABLE FATAL ERROR after upgrading to 2016 Week 27.

they won't not exist

Jul 2 2016, 4:41 PM · Bug Report
epriestley added a comment to T11259: UNRECOVERABLE FATAL ERROR after upgrading to 2016 Week 27.

"Ignored" in the sense of: no publishing, no herald rules, no audit triggers. Not, like, "they won't not exist".

Jul 2 2016, 4:41 PM · Bug Report
epriestley added a comment to T11259: UNRECOVERABLE FATAL ERROR after upgrading to 2016 Week 27.

Only that any legitimate commits pushed until things catch up will also be ignored. The repository will automatically leave the mode once everything finishes.

Jul 2 2016, 4:40 PM · Bug Report
epriestley added a comment to T11259: UNRECOVERABLE FATAL ERROR after upgrading to 2016 Week 27.

There was a relatively recent change to make Phabricator discover commits which are only reachable from tags and refs. As it discovers these commits, it will treat them like new commits and publish feed stories about them. This is a one-time event, but a few installs have a lot of tag-reachable commits for whatever reason. You can find a bit more discussion in T11188, and details about the change in T9028 and T6878.

Jul 2 2016, 4:35 PM · Bug Report
epriestley added a comment to T7916: Can't paste images from clipboard in Firefox / Safari.

This doesn't appear to even to be possible in Firefox. Here's a simple example:

Jul 2 2016, 4:31 PM · Restricted Project, Firefox, Safari, PHUI
epriestley closed T11259: UNRECOVERABLE FATAL ERROR after upgrading to 2016 Week 27 as Resolved.

Oh, or Apache.

Jul 2 2016, 4:27 PM · Bug Report
epriestley added a comment to T11259: UNRECOVERABLE FATAL ERROR after upgrading to 2016 Week 27.

Also likely fixed by restarting PHP-FPM, that method is defined here:

Jul 2 2016, 4:26 PM · Bug Report
epriestley added a comment to T11259: UNRECOVERABLE FATAL ERROR after upgrading to 2016 Week 27.

Did you restart everything after upgrading? See Restarting Phabricator.

Jul 2 2016, 4:25 PM · Bug Report
epriestley added a comment to T7916: Can't paste images from clipboard in Firefox / Safari.

From the Firefox bug and this linked one:

Jul 2 2016, 3:44 PM · Restricted Project, Firefox, Safari, PHUI
epriestley closed T9028: Phabricator handles commits which are published and later deleted poorly as Resolved.

This appears to be stable, and is now accounted for.

Jul 2 2016, 3:24 PM · Restricted Project, Prioritized, Audit, Restricted Project
epriestley closed T11098: Feedback and Errata for Global Settings as Resolved.

This seem quiet and is now accounted for.

Jul 2 2016, 3:22 PM · Prioritized, Restricted Project, User Preferences
epriestley closed T3025: Detect when browser and account timezone settings differ and prompt user to reconcile them as Resolved.

This appears functional and is now accounted for.

Jul 2 2016, 3:18 PM · Prioritized, Restricted Project, User Preferences
epriestley closed T10431: Allow arc alias to read aliases from system configuration file as Resolved.

Haven't seen issues; now accounted for.

Jul 2 2016, 3:15 PM · Prioritized, Restricted Project, Arcanist, Feature Request
epriestley closed T10785: Allow custom third-party auth providers to implement autologin as Resolved.

The upstream part of this is working in production, and this is now accounted for.

Jul 2 2016, 3:13 PM · Prioritized, Auth, Restricted Project, Feature Request
epriestley closed T10227: Provide an extension point for HTTP behaviors (proxies, SSL trust) as Resolved.

We haven't seen issues with this and it's now accounted for (I believe it's also in production).

Jul 2 2016, 3:10 PM · Prioritized, Restricted Project, Feature Request
epriestley removed a project from T7441: Support OAuth providers in the cluster: Prioritized.

A substantial number of users have linked Google accounts in production and we haven't heard about any issues, so I think that aspect of things is in good shape.

Jul 2 2016, 3:04 PM · Auth, Phacility
epriestley closed T11140: Support at-rest encryption in Files as Resolved.

This is accounted for and we haven't run into any issues upstream with it in production after using it for about two weeks, but let us know if anyone runs into issues deploying it.

Jul 2 2016, 3:02 PM · Prioritized, Files
epriestley added a comment to T11257: HTML in Diffusion not escaped in certain circumstances.

For reference, @Danny_B filed a copy of this on HackerOne here so I could award a bounty for it:

Jul 2 2016, 2:50 PM · Security, Wikimedia, Diffusion, Bug Report
epriestley added a comment to T11257: HTML in Diffusion not escaped in certain circumstances.

Also worth noting is that Content Security Policy (T4340) would have prevented this. CSP is obviously worth implementing, but I believe the last attack it would have prevented was D4534 in January 2013, so it's hard to prioritize if it only defuses one attack every 3-4 years.

Jul 2 2016, 2:49 PM · Security, Wikimedia, Diffusion, Bug Report
epriestley added a comment to T11256: Plan how to split apart instance permissions.

Instances currently have two capabilities:

Jul 2 2016, 2:33 PM · Phacility
epriestley added a revision to T11256: Plan how to split apart instance permissions: Unknown Object (Differential Revision).
Jul 2 2016, 2:13 PM · Phacility
epriestley added a comment to T11257: HTML in Diffusion not escaped in certain circumstances.

The Phacility cluster has been patched.

Jul 2 2016, 1:12 PM · Security, Wikimedia, Diffusion, Bug Report
epriestley edited the content of 2016 Week 27 (Very Early July).
Jul 2 2016, 12:30 PM
epriestley added a comment to T11257: HTML in Diffusion not escaped in certain circumstances.

In the future, please report security issues via HackerOne:

Jul 2 2016, 12:27 PM · Security, Wikimedia, Diffusion, Bug Report
epriestley claimed T11257: HTML in Diffusion not escaped in certain circumstances.
Jul 2 2016, 12:27 PM · Security, Wikimedia, Diffusion, Bug Report
epriestley closed T11257: HTML in Diffusion not escaped in certain circumstances as Resolved by committing Restricted Diffusion Commit.
Jul 2 2016, 12:18 PM · Security, Wikimedia, Diffusion, Bug Report
epriestley closed T11258: Push to Remote repository instead of Mirror - How to sync 2 remotes using Phabricator Diffusion as Wontfix.

This is impossible.

Jul 2 2016, 11:59 AM · Diffusion, Feature Request

Jul 1 2016

epriestley edited the content of Changelog.
Jul 1 2016, 11:41 PM
epriestley created 2016 Week 27 (Very Early July).
Jul 1 2016, 11:41 PM
epriestley added a comment to T9741: Default Edit Policy for Differential.

See also T10215.

Jul 1 2016, 10:58 PM · Differential
epriestley added a comment to T9741: Default Edit Policy for Differential.

https://secure.phabricator.com/book/phabcontrib/article/feature_requests/#hypotheticals

Jul 1 2016, 10:57 PM · Differential
epriestley added a comment to T11237: Mobile action menus are "undefined".

Truly our most useful project.

Jul 1 2016, 10:22 PM · Chad's House, Mobile, Safari, Bug Report
epriestley added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

A few tasks (like T2637) are still drawing crazily enormous trees. I think our tasks are especially highly-connected and 97% of what I've looked at seems reasonable, so this might not be much of an issue for other installs, but I think we definitely need some kind of behavior where we hide the more distant parts of the tree once it gets too big.

Jul 1 2016, 10:15 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
epriestley added a comment to T10855: Allow external systems to edit the content of dashboard panels so they can publish information.

parrot

Jul 1 2016, 10:07 PM · Dashboards, Restricted Project, Conduit, Feature Request
epriestley created T11256: Plan how to split apart instance permissions.
Jul 1 2016, 10:03 PM · Phacility
epriestley added a comment to T11255: make it possible to turn any image in a review (any file) into a mock.

Some earlier discussion in T3612.

Jul 1 2016, 9:39 PM · Restricted Project, Pholio, Feature Request
epriestley added a project to T7916: Can't paste images from clipboard in Firefox / Safari: Prioritized.
Jul 1 2016, 9:35 PM · Restricted Project, Firefox, Safari, PHUI
epriestley added a revision to T4788: Allow "Edit Dependencies" both ways (blocking and depending): Unknown Object (Differential Revision).
Jul 1 2016, 8:32 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
d.maznekov awarded T4207: Implement (tree) subtasks, as distinct from (graph) task dependencies a Mountain of Wealth token.
Jul 1 2016, 8:22 PM · Maniphest
epriestley claimed T4788: Allow "Edit Dependencies" both ways (blocking and depending).
Jul 1 2016, 8:12 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
epriestley added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

@avivey Do you have any ideas on how to make that more clear? I'm imagining it will probably be obvious on real data when you know what the tasks are and you'll get used to it pretty quickly, but maybe not.

Jul 1 2016, 8:12 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
epriestley closed T8152: Allow Batch Edit of Blocking Task Field as Resolved.

This is now available as "Edit Parent Tasks".

Jul 1 2016, 8:08 PM · Maniphest
epriestley closed T8152: Allow Batch Edit of Blocking Task Field, a subtask of T10005: Implement an ApplicationEditor-based Bulk Editor, as Resolved.
Jul 1 2016, 8:08 PM · ApplicationEditor
epriestley closed T8152: Allow Batch Edit of Blocking Task Field, a subtask of T10034: Plan the future of Maniphest task relationships, as Resolved.
Jul 1 2016, 8:08 PM · Maniphest
epriestley closed T5450: Add support for adding / removing dependent tasks when batch editing tasks as Wontfix.

We haven't seen more requests for this in nearly two years, and the use case isn't really clear to me since you've always been able to edit many dependencies at once from a task. After recent work in T4788, you can edit them in both directions, too.

Jul 1 2016, 8:08 PM · Maniphest
epriestley closed T5450: Add support for adding / removing dependent tasks when batch editing tasks, a subtask of T10034: Plan the future of Maniphest task relationships, as Wontfix.
Jul 1 2016, 8:07 PM · Maniphest
epriestley closed T5450: Add support for adding / removing dependent tasks when batch editing tasks, a subtask of T10005: Implement an ApplicationEditor-based Bulk Editor, as Wontfix.
Jul 1 2016, 8:07 PM · ApplicationEditor
chad awarded T4207: Implement (tree) subtasks, as distinct from (graph) task dependencies a Mountain of Wealth token.
Jul 1 2016, 8:06 PM · Maniphest
epriestley closed T4207: Implement (tree) subtasks, as distinct from (graph) task dependencies as Resolved.

We now render dependency graphs, as on this task:

Jul 1 2016, 8:01 PM · Maniphest
epriestley closed T4207: Implement (tree) subtasks, as distinct from (graph) task dependencies, a subtask of T10034: Plan the future of Maniphest task relationships, as Resolved.
Jul 1 2016, 8:01 PM · Maniphest
epriestley closed T4207: Implement (tree) subtasks, as distinct from (graph) task dependencies, a subtask of T10387: Create UI for visual (drag and drop) rearranging of task hierarchy, as Resolved.
Jul 1 2016, 8:01 PM · Feature Request
epriestley added a revision to T4788: Allow "Edit Dependencies" both ways (blocking and depending): Unknown Object (Differential Revision).
Jul 1 2016, 7:55 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
epriestley added a comment to T8389: Allow arbitrary email addresses to be CC'd on Phacility billing emails.

From elsewhere, it would also be nice if this tokenizer highlighted instance members of instances associated with the billing account. There isn't a straightforward way to determine which "joe" or whatever is correct right now that works better than "ask Joe what his account name is".

Jul 1 2016, 7:42 PM · Phortune, Phacility
epriestley merged task T11253: Make it possible to paste images into T7916: Can't paste images from clipboard in Firefox / Safari.
Jul 1 2016, 7:19 PM · Restricted Project, Remarkup, Pholio, Feature Request
epriestley merged T11253: Make it possible to paste images into T7916: Can't paste images from clipboard in Firefox / Safari.
Jul 1 2016, 7:19 PM · Restricted Project, Firefox, Safari, PHUI
epriestley added a parent task for T11254: Provide a way for quick revert of all activities of the most recent task editor.: T10215: Provide tools to combat and recover from abuse.
Jul 1 2016, 7:18 PM · Abuse, Maniphest, Wikimedia, Feature Request
epriestley added a subtask for T10215: Provide tools to combat and recover from abuse: T11254: Provide a way for quick revert of all activities of the most recent task editor..
Jul 1 2016, 7:18 PM · Abuse
epriestley added a comment to T11252: Provide better control over mixing denial of access to users in the default space.

You can use project.edit to add members, roughly:

Jul 1 2016, 7:14 PM · Feature Request
epriestley closed T11252: Provide better control over mixing denial of access to users in the default space as Resolved.

Cool -- I'd expect that to work in most situations. Let us know if you run into anything else weird.

Jul 1 2016, 7:04 PM · Feature Request
epriestley added a comment to T11252: Provide better control over mixing denial of access to users in the default space.

I might not have read things carefully enough, but can you just add all the FTEs to "#yesrepo" and then use a positive policy to control access to Diffusion?

Jul 1 2016, 6:58 PM · Feature Request
epriestley added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

Seems kinda good now? Could maybe use some style/layout tweaks on the table (I'd like resolved tasks to be more obvious, for example), but that graph seems like it's actually pretty good/useful to me at first glance. Need to poke around more.

Jul 1 2016, 6:51 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
epriestley added a revision to T4788: Allow "Edit Dependencies" both ways (blocking and depending): Unknown Object (Differential Revision).
Jul 1 2016, 6:41 PM · Prioritized, FreeBSD, User Delight, Wikimedia, Maniphest
epriestley added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

Looks like I didn't think that one through very well.

Jul 1 2016, 6:19 PM · Prioritized, FreeBSD, User Delight, Wikimedia, Maniphest
epriestley added a revision to T4788: Allow "Edit Dependencies" both ways (blocking and depending): Unknown Object (Differential Revision).
Jul 1 2016, 5:11 PM · Prioritized, FreeBSD, User Delight, Wikimedia, Maniphest
yelirekim awarded T11217: Make Tokens modular / real application a Like token.
Jul 1 2016, 4:59 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
chad awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a The World Burns token.
Jul 1 2016, 4:25 PM · Workboards (v3), Restricted Project
epriestley added a revision to T4788: Allow "Edit Dependencies" both ways (blocking and depending): Unknown Object (Differential Revision).
Jul 1 2016, 3:52 PM · Prioritized, FreeBSD, User Delight, Wikimedia, Maniphest
epriestley added a revision to T4788: Allow "Edit Dependencies" both ways (blocking and depending): Unknown Object (Differential Revision).
Jul 1 2016, 3:10 PM · Prioritized, FreeBSD, User Delight, Wikimedia, Maniphest
chad awarded P1997 undo_transactions.php a Baby Tequila token.
Jul 1 2016, 2:55 PM
epriestley added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

I'm pretty tempted to try using the "graph trace" interface to show task graphs. My major concern is that it task dependency graphs tend to be fairly wide and shallow (one task has many dependencies) while commit/revision graphs tend to be narrow and deep (long chains of dependencies). The element isn't as good at showing wide, shallow graphs. If a task has ten subtasks, we'll get a graph like this:

Jul 1 2016, 2:39 PM · Prioritized, FreeBSD, User Delight, Wikimedia, Maniphest
epriestley closed T11249: Request to add Traditional Chinese locale as Resolved by committing Restricted Diffusion Commit.
Jul 1 2016, 2:16 PM · Localization, Feature Request
epriestley added a comment to T11250: New Herald rule: "Differential revision accepted by".

The downside of this was that it caused a flood of notifications to go to the supervisors

Jul 1 2016, 2:09 PM · Feature Request
epriestley added a revision to T11249: Request to add Traditional Chinese locale: Unknown Object (Differential Revision).
Jul 1 2016, 1:30 PM · Localization, Feature Request
epriestley added a comment to P1997 undo_transactions.php.
IMPORTANT: There is no guarantee this works properly, especially if any amount of time has passed since the script was written. This scripts is NOT maintained by the upstream. Run at your own risk!
Jul 1 2016, 12:56 PM
epriestley changed the visibility for P1997 undo_transactions.php.
Jul 1 2016, 12:49 PM
epriestley created P1997 undo_transactions.php.
Jul 1 2016, 12:47 PM
epriestley added a comment to T11246: Commit stuck importing on Phacility.

Looks like it imported before I got to it. Still seeing an issue?

Jul 1 2016, 1:48 AM · Bug Report
epriestley added a comment to T11245: Diffusion commit history displays inconsistent results after migrating repo off of cluster service.

(I also added you to Community, granting you tremendous new power to tidy up around here.)

Jul 1 2016, 1:11 AM · Bug Report
epriestley added a member for Community: timhirsh.
Jul 1 2016, 1:10 AM
epriestley closed T11245: Diffusion commit history displays inconsistent results after migrating repo off of cluster service as Resolved.

Ah! That makes sense. Originally we were more strict about which repositories we would update (which would have caught this) but this created some worse/more-confusing effects in the "enroll" direction (see T10940).

Jul 1 2016, 1:10 AM · Bug Report
epriestley added a revision to T10628: Merge "Local Commits" and "Open Revisions Affecting These Files" into tabs on "Revision Update History" in Differential: Unknown Object (Differential Revision).
Jul 1 2016, 12:17 AM · Restricted Project, Differential
epriestley added a revision to T10628: Merge "Local Commits" and "Open Revisions Affecting These Files" into tabs on "Revision Update History" in Differential: Unknown Object (Differential Revision).
Jul 1 2016, 12:01 AM · Restricted Project, Differential

Jun 30 2016

epriestley added a revision to T10628: Merge "Local Commits" and "Open Revisions Affecting These Files" into tabs on "Revision Update History" in Differential: Restricted Differential Revision.
Jun 30 2016, 11:44 PM · Restricted Project, Differential
epriestley added a comment to T11245: Diffusion commit history displays inconsistent results after migrating repo off of cluster service.

You can also check Request → Machine in DarkConsole to see which host served things, if the Load Balancer / web node thing might be part of the explanation.

Jun 30 2016, 11:42 PM · Bug Report
epriestley added a comment to T11245: Diffusion commit history displays inconsistent results after migrating repo off of cluster service.

(When I toggle between cluster/no-cluster locally with --service / --remove-service, everything appears to be working properly, although I didn't precisely reproduce your setup.)

Jun 30 2016, 11:39 PM · Bug Report
epriestley added a comment to T11245: Diffusion commit history displays inconsistent results after migrating repo off of cluster service.

Just to rule this out, are repo001 and repo002 also web nodes which may receive traffic directly? That is, could this be explained this way?

Jun 30 2016, 11:37 PM · Bug Report
epriestley added a revision to T10628: Merge "Local Commits" and "Open Revisions Affecting These Files" into tabs on "Revision Update History" in Differential: Unknown Object (Differential Revision).
Jun 30 2016, 11:11 PM · Restricted Project, Differential
epriestley added a revision to T10628: Merge "Local Commits" and "Open Revisions Affecting These Files" into tabs on "Revision Update History" in Differential: Unknown Object (Differential Revision).
Jun 30 2016, 11:01 PM · Restricted Project, Differential
epriestley added a comment to T11244: Identify additional tokens to add to Phabricator.

I think only frogs are allowed to be memes.

Jun 30 2016, 9:11 PM · Celerity, Tokens
epriestley added a comment to T11244: Identify additional tokens to add to Phabricator.

I wish :(

Jun 30 2016, 9:11 PM · Celerity, Tokens
epriestley added a comment to T11244: Identify additional tokens to add to Phabricator.
  • 🐗 For when something is boring.
Jun 30 2016, 9:06 PM · Celerity, Tokens
epriestley added a comment to T11242: MIME type detection does not run on files large enough to activate the chunking engine.

Thanks for the report! The primary issue should be resolved at HEAD of master, and promote to stable within about 48 hours.

Jun 30 2016, 9:05 PM · Files, Bug Report