I don't think there's anything actionable remaining here that isn't covered elsewhere.

This has been live for some time and appears to have resolved the problems.

This has been live for some time now.

D16045 reduced this to one query. We can cache it more aggressively and amortize the cost to 0 queries, but I'll leave that for T11096. This is no longer wildly out of line in terms of cost/value.

Ah, thanks. We actually have a lot more of those than I realized.

• Settings → Create Global Defaults as an administrator to set global defaults.
• T11098 for feedback or bugs.

This is the UI you saw, right? Is there any way we could make this more clear?

Sorry for the delay, we're mostly Pacific Time here so this was filed around 3AM for us.

I think this has never worked -- nothing actually reads this preference. This makes converting it for T4103 a little tricky.

• I nuked the corp and clb devices and DNS, and updated the documentation.
• I aligned reserved instances with actual usage after changes.
• I also added secure002 to plb001 (the phurl.io LB).

I think this is live now. I'm going to complete the rest of the deploy and then button up the AWS stuff, but yell if it's horribly broken or whatever.

T11092 has a lot of discussion, but D16031 will almost certainly prevent this from doing damage. It does not fix the underlying Quicksand issue, but you should get an immediate error instead of confusing/spooky behavior/apparent data loss.

Assuming D16031 is a common element, you can identify all comments with inconsistent state like this:

It's not permanent, but this sequence would cause the problem:

Is he 100% sure he has never touched the \ key on his keyboard to bring up the chat sidebar?

I was able to reproduce some flavor of this for inline comments with Quicksand enabled (i.e., the persistent Conpherence chat sidebar open). That's probably T8852, but I expect it to be specific to Quicksand / client-side JS state and impossible to hit without pressing the \ key to open the chat column. I should be able to fix this, but I can't repro it without opening the column.

There's no possible way that PDF is about inline comments, I think? How do inline comments appear on different reviews which presumably have different files? Or did they happen to affect the same files?

Particularly useful, then, would be to find these inlines in the database and figure out what happened to them.

Haha, okay. I may be headed down the wrong path -- T5031 is almost certainly not related here, because the draft system and EditEngine don't interact directly with inline comments. This is almost certainly also not Quicksand-related either if the inlines appear correctly originally (Quicksand could potentially mangle request in-flight).

Oh, are "comments" in this description inline comments, versus blocks of comment text?

We can blindly move Differential to EditEngine, which may fix this indirectly, but this is a large amount of work.

Although I'm not sure this has the same root cause as T8852, I can't reproduce that either.

Here's how I attempted to reproduce this:

When the Conpherence column is open, it activates a completely separate browsing mode (Quicksand) where all navigations occur over Ajax. This is expected to have weird bugs associated with it, but this mode is not active if the column is not open. If the users this is affecting have never opened the chat column, I suspect this is not the same as T8852.

In particular, T182 discusses a desired "chain of custody" workflow where the merge/promote flow happens on the server.

We can only move forward with complete reproduction steps that allow us to reproduce this problem in a local environment.

None of those screenshots demonstrate inconsistencies on their own.

Okay. I can't reproduce that. Here's what I did.

The "Inline Comments" section shows new inline comments. It does not show inlines marked "Done".

Here's at least one specific reproduction case which still isn't working well:

To summarize the above: if there are two renames, the first one loses information if we don't include the old and new name. Current behavior: