Page MenuHomePhabricator
Create Task
Maniphest T8852

Comments attaching to wrong diff with chat column open
Closed, DuplicatePublic
Actions

Description

Not the greatest repro steps, but here's the basic setup:

  • A user was navigating around various pages with column open
  • On D1234, left comments and requested changes
  • D1234 correctly changed to status to requires changes, but comment was missing
  • Back on main dashboard, noticed that another diff D1232 had yellow bubble indicating unsubmitted comments
  • It ended up being the comment that he intended to leave on D1234. It's now showing up as an unsubmitted comment D1232 instead. In the preview at the bottom, the comment is noted as "Not Visible"

We have noticed this happene twice now on our install (to a different user each time). Empirically, it seems to be correlated to the chat column being open.

Related Objects

Event Timeline

• sshannin created this task.Jul 15 2015, 5:14 PM
• sshannin raised the priority of this task from to Needs Triage.
• sshannin updated the task description. (Show Details)
• sshannin added projects: Differential, Conpherence.
• sshannin added a subscriber: • sshannin.
chad added a project: Quicksand.Jul 15 2015, 5:29 PM
joshuaspence added a subscriber: joshuaspence.Aug 29 2015, 9:56 AM
bjshively mentioned this in T11092: Review comments lost or posted to wrong diff.Jun 3 2016, 6:14 PM
epriestley closed this task as a duplicate of T11092: Review comments lost or posted to wrong diff.Jun 3 2016, 7:00 PM
Herald added a subscriber: eadler. · View Herald TranscriptJun 3 2016, 7:00 PM
epriestley added a subscriber: epriestley.Jun 3 2016, 8:48 PM

T11092 has a lot of discussion, but D16031 will almost certainly prevent this from doing damage. It does not fix the underlying Quicksand issue, but you should get an immediate error instead of confusing/spooky behavior/apparent data loss.

epriestley mentioned this in T11093: DifferentialInlineCommentEditor retains state across Quicksand requests.Jun 3 2016, 9:06 PM
Phabricator · Built by Phacility