Page MenuHomePhabricator
Feed Advanced Search

May 15 2016

epriestley added a comment to T10939: Support for OWNERS files.

Collecting some additional dashboard cases from stuff merged into T4144:

May 15 2016, 4:36 PM · Prioritized, Restricted Project, Owners

May 14 2016

epriestley merged T10970: Merge Task As Duplicate into T7820: Add "Closed, Duplicate" option to Status Action in Maniphest.
May 14 2016, 12:30 PM · Restricted Project, User Delight, Maniphest
epriestley merged task T10970: Merge Task As Duplicate into T7820: Add "Closed, Duplicate" option to Status Action in Maniphest.
May 14 2016, 12:30 PM · Feature Request
epriestley added a comment to T10939: Support for OWNERS files.

Packages can now be reviewers. They work very similarly to project reviewers. They can be added via the web UI or Herald. They can also be added via the CLI (by typing O123 as a reviewer or subscriber) but this isn't very convenient and I don't expect users to manually add them very often / ever.

May 14 2016, 1:02 AM · Prioritized, Restricted Project, Owners
epriestley closed T9491: When packages are archived, packages shouldn't be listed as auditor as Resolved.

Archived packages are no longer added as auditors to new commits after D15907 by the "Auditing Enabled" setting.

May 14 2016, 12:36 AM · Restricted Project, Owners
epriestley closed T1258: Add an "Automatically CC Owners on Differential Revisions" checkbox to Owners as Resolved.
May 14 2016, 12:32 AM · Restricted Project, Owners
epriestley changed the status of T8887: Allow owners packages to add blocking reviewers from Duplicate to Resolved by committing Restricted Diffusion Commit.
May 14 2016, 12:22 AM · Haskell.org, Restricted Project, Owners
epriestley closed T7834: Package owners doesn't get mail after a commit triggers an audit as Resolved by committing Restricted Diffusion Commit.
May 14 2016, 12:19 AM · Restricted Project, Audit, Herald

May 13 2016

epriestley edited the content of Changelog.
May 13 2016, 10:54 PM
epriestley created 2016 Week 20 (Mid May).
May 13 2016, 10:54 PM
epriestley created T10968: File write failure during daemon operations caused daemons to populate a few too many diffs.
May 13 2016, 10:29 PM · Files, Differential, Diffusion, Daemons
epriestley added a comment to T1279: Show per-reviewer status in Differential revision reviewer list.

Hi @msatish! Please see Planning for help understanding planning and prioritization. Thanks!

May 13 2016, 9:21 PM · Restricted Project, Differential
epriestley added a comment to T10939: Support for OWNERS files.

Pretty sure D15918 is the right/expected rule: if you're an owner of "CSS" and "CSS" is set to "Auto Review: Review Changes (Blocking)", it doesn't trigger for your revisions: you don't need someone else who owns CSS to unblock your changes. Let me know if that defies expectations.

May 13 2016, 6:53 PM · Prioritized, Restricted Project, Owners
epriestley added a revision to T10939: Support for OWNERS files: Unknown Object (Differential Revision).
May 13 2016, 6:49 PM · Prioritized, Restricted Project, Owners
epriestley added a revision to T10939: Support for OWNERS files: Unknown Object (Differential Revision).
May 13 2016, 6:35 PM · Prioritized, Restricted Project, Owners
epriestley added a revision to T8887: Allow owners packages to add blocking reviewers: Unknown Object (Differential Revision).
May 13 2016, 6:30 PM · Haskell.org, Restricted Project, Owners
epriestley added a revision to T10939: Support for OWNERS files: Unknown Object (Differential Revision).
May 13 2016, 6:30 PM · Prioritized, Restricted Project, Owners
epriestley merged task T10430: Differential HTML emails should use fixed width font for the commit details section into T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments.
May 13 2016, 6:26 PM · Mail, Differential, Restricted Project, Feature Request
epriestley merged T10430: Differential HTML emails should use fixed width font for the commit details section into T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments.
May 13 2016, 6:26 PM · Prioritized, Restricted Project, Remarkup, Mail
epriestley created T10967: Move Differential reviewers back to a dedicated database storage table.
May 13 2016, 6:15 PM · Restricted Project, Infrastructure, Differential
epriestley added a revision to T10939: Support for OWNERS files: Unknown Object (Differential Revision).
May 13 2016, 6:01 PM · Prioritized, Restricted Project, Owners
epriestley added a revision to T8887: Allow owners packages to add blocking reviewers: Unknown Object (Differential Revision).
May 13 2016, 6:01 PM · Haskell.org, Restricted Project, Owners
epriestley added a revision to T10939: Support for OWNERS files: Unknown Object (Differential Revision).
May 13 2016, 5:54 PM · Prioritized, Restricted Project, Owners
epriestley added a revision to T10939: Support for OWNERS files: Unknown Object (Differential Revision).
May 13 2016, 5:45 PM · Prioritized, Restricted Project, Owners
epriestley added a revision to T7834: Package owners doesn't get mail after a commit triggers an audit: Unknown Object (Differential Revision).
May 13 2016, 5:41 PM · Restricted Project, Audit, Herald
epriestley added a revision to T10939: Support for OWNERS files: Unknown Object (Differential Revision).
May 13 2016, 5:41 PM · Prioritized, Restricted Project, Owners
epriestley added a comment to T7148: Allow users to export their data from Phacility.

This has been slightly streamlined, modern flow is to dump first:

May 13 2016, 4:19 PM · Phacility
epriestley added a revision to T10939: Support for OWNERS files: Unknown Object (Differential Revision).
May 13 2016, 3:14 PM · Prioritized, Restricted Project, Owners
epriestley added a revision to T10939: Support for OWNERS files: Unknown Object (Differential Revision).
May 13 2016, 2:43 PM · Prioritized, Restricted Project, Owners
epriestley edited the content of Object Name Prefixes / Monograms.
May 13 2016, 2:32 PM
epriestley edited the content of Object Name Prefixes / Monograms.
May 13 2016, 2:32 PM
epriestley added a revision to T10939: Support for OWNERS files: Unknown Object (Differential Revision).
May 13 2016, 2:31 PM · Prioritized, Restricted Project, Owners
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 13 2016, 1:49 PM · Diffusion (v3)
epriestley added a comment to T10939: Support for OWNERS files.

I mostly have T8887 working, but there's currently no way for a package to be rendered unambiguously in Reviewers: ... or Subscribers: ... from the command line in a plain text commit message, so this may be a little more involved than I'd hoped. Everything works fine until you try to interact with a revision that has package relationships, then you get into trouble:

May 13 2016, 1:44 PM · Prioritized, Restricted Project, Owners
epriestley added a revision to T10939: Support for OWNERS files: Unknown Object (Differential Revision).
May 13 2016, 12:50 PM · Prioritized, Restricted Project, Owners
epriestley created T10964: When a branch in Diffusion is not tracked, the UI should be explicit about it.
May 13 2016, 12:40 PM · Diffusion
epriestley merged T10962: Click to upload files in addition to drag and drop in all places where files can be uploaded into T5187: Make "Upload File" dialog have a vanilla file upload control.
May 13 2016, 12:07 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley merged task T10962: Click to upload files in addition to drag and drop in all places where files can be uploaded into T5187: Make "Upload File" dialog have a vanilla file upload control.
May 13 2016, 12:06 PM · Feature Request
epriestley closed T10963: libphutil/src/internationalization/PhutilTranslator.php:chooseVariant() hardcodes locales as Invalid.

This isn't a bug, the block has a performance-motivated explanation in a TODO comment above it:

May 13 2016, 12:06 PM · Bug Report
epriestley created T10961: JIRA instructions are a bit out of date with modern JIRA.
May 13 2016, 3:20 AM · Auth, Documentation
epriestley added a comment to T4292: Implement repository replication.

T10940 should be resolved now, D15903 should resolve lock granularity.

May 13 2016, 12:27 AM · Restricted Project, Diffusion
epriestley merged task T10960: Allow people to quote others at calendar like at maniphest into T9275: Move Calendar to EditEngine.
May 13 2016, 12:19 AM · Calendar, Feature Request
epriestley merged T10960: Allow people to quote others at calendar like at maniphest into T9275: Move Calendar to EditEngine.
May 13 2016, 12:19 AM · ApplicationEditor, Policy, Calendar
epriestley added a comment to T10960: Allow people to quote others at calendar like at maniphest.

I'm going to merge this into T9275, which will solve this automatically.

May 13 2016, 12:19 AM · Calendar, Feature Request
epriestley added a revision to T10959: Hard-coded diff line height interacts poorly with large custom font sizes: Unknown Object (Differential Revision).
May 13 2016, 12:03 AM · Differential

May 12 2016

epriestley added a revision to T10959: Hard-coded diff line height interacts poorly with large custom font sizes: Unknown Object (Differential Revision).
May 12 2016, 11:42 PM · Differential
epriestley created T10959: Hard-coded diff line height interacts poorly with large custom font sizes.
May 12 2016, 11:35 PM · Differential
epriestley added a revision to T4292: Implement repository replication: Unknown Object (Differential Revision).
May 12 2016, 11:24 PM · Restricted Project, Diffusion
epriestley closed T10940: Enrolling an existing device in a repository cluster has surprising effects and inconsistent severity as Resolved by committing Restricted Diffusion Commit.
May 12 2016, 10:51 PM · Diffusion, Clusters
epriestley added a revision to T10940: Enrolling an existing device in a repository cluster has surprising effects and inconsistent severity: Unknown Object (Differential Revision).
May 12 2016, 9:31 PM · Diffusion, Clusters
epriestley moved T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API from The Queue to Paused on the Prioritized board.

Moving this to "Paused" since we're waiting on feedback / deployment / bug reports / things to catch on fire.

May 12 2016, 7:32 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley moved T5187: Make "Upload File" dialog have a vanilla file upload control from Preflight to The Queue on the Prioritized board.
May 12 2016, 7:31 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley moved T10939: Support for OWNERS files from Preflight to The Queue on the Prioritized board.
May 12 2016, 7:31 PM · Prioritized, Restricted Project, Owners
epriestley added a comment to T10694: Improve behavior of context for inline comments in mail.
  • Patches from metamta.differential.inline-patches should be formatted more nicely in HTML mail at HEAD.
  • metamta.differential.unified-comment-context has been removed and we now raise setup guidance about it.
  • The View Revision button is functional locally, but waiting on design once @chad gets back from vacation next week, since my version of it looks a lot like I designed it (D15884).
  • Swapping HTML mail to become the default is ready (D15885) but waiting on the button and maybe a few other designey tweaks we want to consider.
  • There's an hour or so of time across all of that which I haven't tabulated yet, but I'll settle it up once those changes actually land.
May 12 2016, 7:22 PM · Prioritized, Restricted Project, Differential, Mail
epriestley closed T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments as Resolved by committing Restricted Diffusion Commit.
May 12 2016, 7:13 PM · Prioritized, Restricted Project, Remarkup, Mail
epriestley closed T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments, a subtask of T992: Send rich HTML mail bodies without impacting reply handling functionality, as Resolved.
May 12 2016, 7:13 PM · Differential, Mail
epriestley closed T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments, a subtask of T10694: Improve behavior of context for inline comments in mail, as Resolved.
May 12 2016, 7:13 PM · Prioritized, Restricted Project, Differential, Mail
epriestley moved T5000: Using Differential with plain Git, without requiring Arc from Backlog to Preflight on the Prioritized board.
May 12 2016, 6:57 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Differential, Arcanist
epriestley added a project to T5000: Using Differential with plain Git, without requiring Arc: Prioritized.

We're prioritizing the research to estimate how much work this is so we can possibly eventually prioritize it, so this is going into the queue, but don't read too much into it.

May 12 2016, 6:57 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Differential, Arcanist
epriestley added a comment to T10694: Improve behavior of context for inline comments in mail.

@epriestley Thats good to know. Also, will this change include formatting the Change Details section of emails? That one is currently a blob of visually unparseable text even in HTML emails.

May 12 2016, 5:55 PM · Prioritized, Restricted Project, Differential, Mail
epriestley added a revision to T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments: Unknown Object (Differential Revision).
May 12 2016, 5:51 PM · Prioritized, Restricted Project, Remarkup, Mail
epriestley placed T6616: Typeahead uses locale-specific comparison up for grabs.
May 12 2016, 5:31 PM · Typeahead, PHUI
epriestley moved T5187: Make "Upload File" dialog have a vanilla file upload control from Backlog to Preflight on the Prioritized board.
May 12 2016, 4:51 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley added a project to T5187: Make "Upload File" dialog have a vanilla file upload control: Prioritized.
May 12 2016, 4:51 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley added a comment to T5187: Make "Upload File" dialog have a vanilla file upload control.

Sure. I'd estimate this is 1-2 hours of work if we develop a patch ourselves and 2-3 hours of work if we work with @matmarex to make his patch suitable for inclusion and maintenance in the upstream. Which would you prefer?

May 12 2016, 4:42 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley moved T10939: Support for OWNERS files from Backlog to Preflight on the Prioritized board.
May 12 2016, 4:37 PM · Prioritized, Restricted Project, Owners
epriestley added a project to T10939: Support for OWNERS files: Prioritized.

(I'm just getting this into the preflight column for communication purposes since there's a slot reserved, we won't start work on this until we have an explicit confirmation.)

May 12 2016, 4:37 PM · Prioritized, Restricted Project, Owners
epriestley added a comment to T5187: Make "Upload File" dialog have a vanilla file upload control.

(If that answer isn't particularly satisfying, maybe see discussion starting here: T7820#172877.)

May 12 2016, 4:31 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley added a comment to T5187: Make "Upload File" dialog have a vanilla file upload control.

We haven't seen much interest in this from outside WMF, so there are probably several hundred tasks ahead of it on our natural roadmap.

May 12 2016, 4:25 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley added a comment to Q388: Should Differential notify you on inline comments submitted with no additional actions being taken?.

Ignore my answer, I misunderstood your question. This is not expected. File a bug with reproduction instructions.

May 12 2016, 4:19 PM
epriestley marked Q388: Should Differential notify you on inline comments submitted with no additional actions being taken? (Answer 376) as hidden.
May 12 2016, 4:18 PM
epriestley added Q388: Should Differential notify you on inline comments submitted with no additional actions being taken? (Answer 376).
May 12 2016, 4:17 PM
epriestley closed T10958: Dead Link at Diviner as Resolved by committing Restricted Diffusion Commit.
May 12 2016, 3:30 PM · Documentation, Diviner, Bug Report
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 12 2016, 3:29 PM · Diffusion (v3)
epriestley added a comment to T10958: Dead Link at Diviner.

Thanks!

May 12 2016, 3:20 PM · Documentation, Diviner, Bug Report
epriestley claimed T10958: Dead Link at Diviner.
May 12 2016, 3:20 PM · Documentation, Diviner, Bug Report
epriestley added a revision to T10958: Dead Link at Diviner: Unknown Object (Differential Revision).
May 12 2016, 3:19 PM · Documentation, Diviner, Bug Report
epriestley added a comment to T4292: Implement repository replication.

T10748 is moving into production, which is the last major new piece here. Remaining cleanup work I plan to do in this phase:

May 12 2016, 3:17 PM · Restricted Project, Diffusion
epriestley added a comment to T10751: Make Phabricator Highly Available.

I think this is the current state of the world. I'm planning to tackle the three major issues noted below (observed repository versioning, repository lock granularity, device enrollment behavior) and then try to wind down this phase, move all this followup work to a new "make clustering more powerful" sort of task, and then plan where to go from there based on which goals are most important (scalability vs multi-region vs read-only vs hg/svn vs drydock vs whatever crops up as installs actually deploy this stuff).

May 12 2016, 3:12 PM · Restricted Project, Infrastructure, Prioritized
epriestley closed T10955: Changing tags doesn't seem possible on repositories any more? as Resolved by committing Restricted Diffusion Commit.
May 12 2016, 2:17 PM · Diffusion, Bug Report
epriestley closed T10860: After an inconsistent cluster repository write, consider just ignoring the lock, a subtask of T4292: Implement repository replication, as Resolved.
May 12 2016, 2:10 PM · Restricted Project, Diffusion
epriestley closed T10860: After an inconsistent cluster repository write, consider just ignoring the lock as Resolved.

Going any farther than this risks some inconsistency / data loss and we haven't managed to break this yet, so I'm going to consider this sufficiently robust until we see evidence otherwise.

May 12 2016, 2:10 PM · Clusters, Diffusion
epriestley added a comment to T10957: When logged in through an external auth provider, user is invited to re-create his account.

They can link their accounts in Settings → External Accounts.

May 12 2016, 2:09 PM · Auth, Bug Report
epriestley added a revision to T10751: Make Phabricator Highly Available: Unknown Object (Differential Revision).
May 12 2016, 1:56 PM · Restricted Project, Infrastructure, Prioritized
epriestley added a revision to T10955: Changing tags doesn't seem possible on repositories any more?: Unknown Object (Differential Revision).
May 12 2016, 1:26 PM · Diffusion, Bug Report
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 12 2016, 1:26 PM · Diffusion (v3)
epriestley added a comment to T10955: Changing tags doesn't seem possible on repositories any more?.

It's on an invisible page <_< >_>

May 12 2016, 1:17 PM · Diffusion, Bug Report
epriestley claimed T10955: Changing tags doesn't seem possible on repositories any more?.
May 12 2016, 1:17 PM · Diffusion, Bug Report
epriestley closed T10957: When logged in through an external auth provider, user is invited to re-create his account as Invalid.

This is expected. This is a security feature, not a bug. Just because you have a Phabricator user account named joe does not mean you have authority over the LDAP user account named joe, and vice versa. In many cases LDAP and Phabricator user account names differ. Users must prove they have control over external accounts by linking them before they can use those external accounts to access Phabricator.

May 12 2016, 1:16 PM · Auth, Bug Report
epriestley closed I3 Development of making callsigns optional / flexible.
May 12 2016, 1:31 AM · Diffusion
epriestley added a comment to I3 Development of making callsigns optional / flexible.

Callsigns have been optional for a while now so I'm going to close this. See T4245 for context and followups.

May 12 2016, 1:31 AM · Diffusion
epriestley added a comment to T4245: Make repository URIs slightly prettier.

Callsigns have been optional for some time (roughly since D15305 in February 2016, although there were a trickle of bugs after that).

May 12 2016, 1:11 AM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley renamed T4245: Make repository URIs slightly prettier from Make repository callsigns optional or more flexible to Make repository URIs slightly prettier.
May 12 2016, 1:06 AM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a revision to T10751: Make Phabricator Highly Available: Unknown Object (Differential Revision).
May 12 2016, 12:03 AM · Restricted Project, Infrastructure, Prioritized

May 11 2016

epriestley added a comment to T10751: Make Phabricator Highly Available.

T10748 is wrapping up, and repositories now show cluster status in the new "Storage" panel of the new UI:

May 11 2016, 11:46 PM · Restricted Project, Infrastructure, Prioritized
epriestley updated the task description for T10922: Upgrading: New Repository UI, APIs, and URI management.
May 11 2016, 11:21 PM · Diffusion (v3), Installing & Upgrading
epriestley added a comment to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.

I think this is substantially complete now. There will probably still be a trickle of issues as this gets more use and T10923 has some stuff that didn't get fully addressed here, but everything I've been tracking is in reasonable shape as far as I'm aware.

May 11 2016, 11:10 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley closed T10930: Exception in editengine for Paste as Resolved by committing Restricted Diffusion Commit.
May 11 2016, 10:35 PM · ApplicationEditor, Bug Report
epriestley closed T10952: Cannot edit pastes, if you want to keep the content as Resolved by committing Restricted Diffusion Commit.
May 11 2016, 10:35 PM · Paste, Bug Report
epriestley added a revision to T10930: Exception in editengine for Paste: Restricted Differential Revision.
May 11 2016, 10:34 PM · ApplicationEditor, Bug Report