Page MenuHomePhabricator
Feed Advanced Search

May 8 2016

epriestley added a comment to T10933: You Shall Not Pass: Unknown Object (Repository).

The difference with our interface : I have not installed "http git" only ssh git

May 8 2016, 9:16 PM · Diffusion, Bug Report
epriestley updated the task description for T10923: Diffusion API/URI Errata.
May 8 2016, 9:01 PM · Diffusion (v3)
epriestley added a comment to T10933: You Shall Not Pass: Unknown Object (Repository).

I cannot change the Space by default

May 8 2016, 9:01 PM · Diffusion, Bug Report
epriestley added a comment to T10933: You Shall Not Pass: Unknown Object (Repository).

I can't reproduce this. Here are the repository policies:

May 8 2016, 9:00 PM · Diffusion, Bug Report
epriestley added a comment to T10751: Make Phabricator Highly Available.

T10748, which provides the new cluster management UI for repositories, is nearing completion. This makes cluster setup more manageable and at least provides a pathway forward for Almanac stuff in the future, although it does not yet make Almanac / service management explicitly selectable when creating a repository (for now, new repositories allocate on a random open service).

May 8 2016, 4:13 PM · Restricted Project, Infrastructure, Prioritized
epriestley added a comment to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.

We hit a couple of minor issues (e.g. D15856, D15865) in the last few days, but this seems to be working in production.

May 8 2016, 4:05 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley closed T10921: Phabricator and ImageTragick as Resolved.

We don't appear to be affected directly and I've discussed this in the changelog now, so I'm going to close this out as I think there's no action remaining on our side. Let us know if anyone has questions, etc.

May 8 2016, 3:59 PM · Macros, Security
epriestley edited the content of Changelog.
May 8 2016, 3:59 PM
epriestley created 2016 Week 19 (Early May).
May 8 2016, 3:58 PM

May 7 2016

epriestley renamed T4752: Daemons may not have permission to remove files from local disk storage engine from Daemons may have permission to remove files from local disk storage engine to Daemons may not have permission to remove files from local disk storage engine.
May 7 2016, 1:17 PM · Files
epriestley removed a project from T7593: Allow administrators to disable files to prevent "l33t w4r3z" abuse cases: Facebook.
May 7 2016, 1:15 PM · Abuse, Files
epriestley renamed T8788: Allow querying for files by name from / Allow querying for files by ø to Allow querying for files by name.
May 7 2016, 1:15 PM · Contributor Onboarding, Files
epriestley updated subscribers of T8476: Rename `phabricator_repository` database.
May 7 2016, 1:14 PM · Restricted Project, Database, Diffusion
epriestley removed a project from T8476: Rename `phabricator_repository` database: Clusters.
May 7 2016, 1:14 PM · Restricted Project, Database, Diffusion
epriestley added a comment to T10694: Improve behavior of context for inline comments in mail.

A very specific example of my confusion is the decision to place the link to the revision first in the mockup on T10283, and how it contrasts with the stated problem of triage efficiency:

May 7 2016, 1:04 AM · Prioritized, Restricted Project, Differential, Mail
epriestley added a comment to T10694: Improve behavior of context for inline comments in mail.

(I think this is broadly similar to the original discussion on T10283, which also framed problems in terms of efficiency but also appeared to enable every inefficient/low-signal option available.)

May 7 2016, 12:32 AM · Prioritized, Restricted Project, Differential, Mail
epriestley added a comment to T10694: Improve behavior of context for inline comments in mail.

As a thought experiment, if we sent one email per inline comment like GitHub does (and just repeated the author information several times in the body or something), I think that would technically satisfy all the points you raise:

May 7 2016, 12:22 AM · Prioritized, Restricted Project, Differential, Mail
epriestley added a comment to T10694: Improve behavior of context for inline comments in mail.

This feedback is also sort of hard for me to understand.

May 7 2016, 12:17 AM · Prioritized, Restricted Project, Differential, Mail

May 6 2016

epriestley added a comment to T10694: Improve behavior of context for inline comments in mail.

Is metamta.can-send-as-user not configured in your environment? My expectation is that the mail comes "From" the user writing all the text in the mail, which makes it clear who they are. I expect that this information is normally prominent in the UI of most mail clients.

May 6 2016, 11:48 PM · Prioritized, Restricted Project, Differential, Mail
epriestley added a comment to T10931: Changing mysql.implementation setting doesn't work.

Haha, alright. You might be able to add it to conf/local/local.json manually as a workaround, but I'm not sure if that'll work or not.

May 6 2016, 10:40 PM · Setup, Database, Bug Report
epriestley added a comment to T10923: Diffusion API/URI Errata.

After that action phabricator redirects to the main repo page. Is that expected?

May 6 2016, 10:00 PM · Diffusion (v3)
epriestley added a comment to T10931: Changing mysql.implementation setting doesn't work.

AphrontMySQLDatabaseConnectionBase was renamed but I plan to remove this option anyway.

May 6 2016, 9:57 PM · Setup, Database, Bug Report
epriestley added a comment to T10694: Improve behavior of context for inline comments in mail.

We iterated on the design a bit and ended up here:

May 6 2016, 8:00 PM · Prioritized, Restricted Project, Differential, Mail
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 6 2016, 7:38 PM · Diffusion (v3)
epriestley added a revision to T10694: Improve behavior of context for inline comments in mail: Unknown Object (Differential Revision).
May 6 2016, 6:50 PM · Prioritized, Restricted Project, Differential, Mail
epriestley added a revision to T10694: Improve behavior of context for inline comments in mail: Unknown Object (Differential Revision).
May 6 2016, 5:54 PM · Prioritized, Restricted Project, Differential, Mail
epriestley added a revision to T10694: Improve behavior of context for inline comments in mail: Unknown Object (Differential Revision).
May 6 2016, 5:34 PM · Prioritized, Restricted Project, Differential, Mail
epriestley added Q384: Where does one configure arcanist commit rules (Answer 375).
May 6 2016, 4:40 PM
epriestley added a comment to T10694: Improve behavior of context for inline comments in mail.

@jcarrillo7, something in that vein will split out of T1460 eventually but we don't have a specific plan for it yet. I don't intend to address it as part of this task.

May 6 2016, 4:17 PM · Prioritized, Restricted Project, Differential, Mail
epriestley created T10929: Remarkup block rules rely on sort stability.
May 6 2016, 3:12 PM · Remarkup
epriestley closed T10928: Remote branches of git mirror are deleted as Resolved by committing Restricted Diffusion Commit.
May 6 2016, 3:04 PM · Bug Report
epriestley added a revision to T10928: Remote branches of git mirror are deleted: Unknown Object (Differential Revision).
May 6 2016, 2:59 PM · Bug Report
epriestley added a comment to T10928: Remote branches of git mirror are deleted.

This is expected, and consistent with git's own definition of "mirror". The exact command we use is:

May 6 2016, 2:44 PM · Bug Report
epriestley closed T7030: Application mail body sections are not consistently marked up, a subtask of T992: Send rich HTML mail bodies without impacting reply handling functionality, as Resolved.
May 6 2016, 12:43 AM · Differential, Mail
epriestley closed T7030: Application mail body sections are not consistently marked up as Resolved.

Inline comments are fixed after D15850.

May 6 2016, 12:43 AM · Mail
epriestley closed T9593: Counterexample header is incorrectly colored in email, a subtask of T992: Send rich HTML mail bodies without impacting reply handling functionality, as Resolved.
May 6 2016, 12:41 AM · Differential, Mail
epriestley closed T9593: Counterexample header is incorrectly colored in email as Resolved.

I think I fixed this in D15847:

May 6 2016, 12:41 AM · Remarkup, Mail
epriestley added a revision to T10694: Improve behavior of context for inline comments in mail: Unknown Object (Differential Revision).
May 6 2016, 12:39 AM · Prioritized, Restricted Project, Differential, Mail
dgoldstein awarded T1022: arc patch fails to properly apply a patch which changes a symlink to a real file a Like token.
May 6 2016, 12:31 AM · Arcanist

May 5 2016

epriestley closed T10927: Can't load data from reposorities: 403 as Resolved.

D15856 appears to have fixed this

May 5 2016, 11:48 PM · Diffusion, Bug Report
epriestley added a revision to T10927: Can't load data from reposorities: 403: Unknown Object (Differential Revision).
May 5 2016, 11:19 PM · Diffusion, Bug Report
epriestley closed T6027: Way to edit which column a task is in from the task itself as Resolved.

This isn't the most thrilling UI but seems to get the job done. T10912 covers one minor followup issue.

May 5 2016, 7:54 PM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
epriestley closed T7031: Blockquote formatting in HTML mail could be improved, a subtask of T992: Send rich HTML mail bodies without impacting reply handling functionality, as Resolved.
May 5 2016, 7:35 PM · Mail, Differential
epriestley closed T7031: Blockquote formatting in HTML mail could be improved as Resolved by committing Restricted Diffusion Commit.
May 5 2016, 7:34 PM · Mail
epriestley added a revision to T10694: Improve behavior of context for inline comments in mail: Unknown Object (Differential Revision).
May 5 2016, 7:28 PM · Prioritized, Restricted Project, Differential, Mail
epriestley added a revision to T7031: Blockquote formatting in HTML mail could be improved: Unknown Object (Differential Revision).
May 5 2016, 7:28 PM · Mail
epriestley added a comment to T10694: Improve behavior of context for inline comments in mail.

This is getting somewhere functionally; we're going to iterate on the design a bit more internally.

May 5 2016, 6:55 PM · Prioritized, Restricted Project, Differential, Mail
epriestley added a revision to T10694: Improve behavior of context for inline comments in mail: Unknown Object (Differential Revision).
May 5 2016, 6:09 PM · Prioritized, Restricted Project, Differential, Mail
epriestley added a revision to T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments: Unknown Object (Differential Revision).
May 5 2016, 5:49 PM · Prioritized, Restricted Project, Remarkup, Mail
epriestley added a revision to T10694: Improve behavior of context for inline comments in mail: Unknown Object (Differential Revision).
May 5 2016, 5:49 PM · Prioritized, Restricted Project, Differential, Mail
epriestley added a comment to T10694: Improve behavior of context for inline comments in mail.

Spacing/padding is definitely pretty iffy in Mail.app, at least.

May 5 2016, 4:40 PM · Prioritized, Restricted Project, Differential, Mail
epriestley updated the task description for T10923: Diffusion API/URI Errata.
May 5 2016, 3:40 PM · Diffusion (v3)
epriestley added a comment to T10923: Diffusion API/URI Errata.

My early-morning logic went something like "it's still there on disk so...".

May 5 2016, 3:40 PM · Diffusion (v3)
epriestley added a revision to T10694: Improve behavior of context for inline comments in mail: Unknown Object (Differential Revision).
May 5 2016, 11:57 AM · Prioritized, Restricted Project, Differential, Mail
epriestley added a subtask for T10694: Improve behavior of context for inline comments in mail: T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments.
May 5 2016, 10:01 AM · Prioritized, Restricted Project, Differential, Mail
epriestley added a parent task for T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments: T10694: Improve behavior of context for inline comments in mail.
May 5 2016, 10:01 AM · Prioritized, Restricted Project, Remarkup, Mail
epriestley added a comment to T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments.

That seems to be doing something fairly reasonable in my client, yell if it looks funky somewhere else:

May 5 2016, 10:00 AM · Prioritized, Restricted Project, Remarkup, Mail
epriestley added a comment to T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments.
f($v, "v"); /* ! */
May 5 2016, 9:56 AM · Prioritized, Restricted Project, Remarkup, Mail
epriestley updated the task description for T10923: Diffusion API/URI Errata.
May 5 2016, 9:41 AM · Diffusion (v3)
epriestley added a revision to T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments: Unknown Object (Differential Revision).
May 5 2016, 2:01 AM · Prioritized, Restricted Project, Remarkup, Mail
epriestley added a revision to T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments: Unknown Object (Differential Revision).
May 5 2016, 1:40 AM · Prioritized, Restricted Project, Remarkup, Mail
epriestley added a revision to T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments: Unknown Object (Differential Revision).
May 5 2016, 1:28 AM · Prioritized, Restricted Project, Remarkup, Mail
epriestley added a revision to T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments: Unknown Object (Differential Revision).
May 5 2016, 12:55 AM · Prioritized, Restricted Project, Remarkup, Mail
epriestley added a comment to T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments.

I think this isn't really too bad. The major issue is that we can't use stylesheets in email because Gmail doesn't support them, so we need to emit markup with inline style attributes.

May 5 2016, 12:33 AM · Prioritized, Restricted Project, Remarkup, Mail
epriestley added a comment to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.

This is now live in HEAD of master, and deployed to secure. Here's phabricator/ on this install:

May 5 2016, 12:15 AM · Prioritized, Restricted Project, Diffusion (v3), Feature Request

May 4 2016

epriestley updated the task description for T10922: Upgrading: New Repository UI, APIs, and URI management.
May 4 2016, 11:45 PM · Diffusion (v3), Installing & Upgrading
epriestley created T10923: Diffusion API/URI Errata.
May 4 2016, 11:45 PM · Diffusion (v3)
epriestley closed T10366: General support for multiple URIs for a repository as Resolved.

I'm going to call this resolved now -- there are still substantial rough edges with this and the rest of T10748, but we're running on the new code and everything else should mostly be UI stuff. T10922 has general guidance and I'll open an errata task to track cleanup shortly.

May 4 2016, 11:32 PM · Diffusion (v3), Restricted Project, Feature Request
epriestley closed T10366: General support for multiple URIs for a repository, a subtask of T4292: Implement repository replication, as Resolved.
May 4 2016, 11:32 PM · Restricted Project, Diffusion
epriestley closed T10366: General support for multiple URIs for a repository, a subtask of T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API, as Resolved.
May 4 2016, 11:32 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley closed T10366: General support for multiple URIs for a repository, a subtask of T5406: Offer read-only copy of a externally hosted repository via Diffusion clone url (https/ssh), as Resolved.
May 4 2016, 11:32 PM · Diffusion (v3)
epriestley closed T10366: General support for multiple URIs for a repository, a subtask of T4705: Add an "Optional Display URI" for remote repositories in Diffusion, as Resolved.
May 4 2016, 11:32 PM · Restricted Project, Diffusion (v3)
epriestley closed T10366: General support for multiple URIs for a repository, a subtask of T8831: make `arc which` use mirrors, as Resolved.
May 4 2016, 11:32 PM · Restricted Project, Diffusion (v3), Arcanist
epriestley closed T10366: General support for multiple URIs for a repository, a subtask of T7516: Add git clone url to conduit repository.query, as Resolved.
May 4 2016, 11:32 PM · Restricted Project, Diffusion (v3), Conduit
epriestley added a revision to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API: Unknown Object (Differential Revision).
May 4 2016, 11:30 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley closed T4039: Prevent a repository from being set to the same "local path" as some other repository as Resolved.

D15837 appears to have deployed cleanly here.

May 4 2016, 11:15 PM · Restricted Project, Diffusion
epriestley moved T10922: Upgrading: New Repository UI, APIs, and URI management from Backlog to v3 on the Diffusion board.
May 4 2016, 10:25 PM · Diffusion (v3), Installing & Upgrading
epriestley created T10922: Upgrading: New Repository UI, APIs, and URI management.
May 4 2016, 10:18 PM · Diffusion (v3), Installing & Upgrading
epriestley claimed T10917: Build Glorious High-Security Notification/Audit Infrastructure.
May 4 2016, 9:46 PM · Auth, Prioritized, Security, Feature Request
epriestley moved T10917: Build Glorious High-Security Notification/Audit Infrastructure from Backlog to The Queue on the Prioritized board.
May 4 2016, 9:46 PM · Auth, Prioritized, Security, Feature Request
epriestley renamed T10917: Build Glorious High-Security Notification/Audit Infrastructure from Send email when an SSH key is added for a user to Build Glorious High-Security Notification/Audit Infrastructure.
May 4 2016, 9:45 PM · Auth, Prioritized, Security, Feature Request
epriestley added a comment to T10917: Build Glorious High-Security Notification/Audit Infrastructure.

And I think the mail notifications are also largely reasonable, I just don't want to hack this one mail notification in and call it a day since this I think this should be approached more broadly (covering all high-security actions, not just SSH) and deeply (SMS, mail, transactions).

May 4 2016, 8:53 PM · Auth, Prioritized, Security, Feature Request
epriestley added a comment to T10917: Build Glorious High-Security Notification/Audit Infrastructure.

My only idea would be converting actions surrounding SSH key management to transactions, which you're not explicitly stating here, but if we were to do that we would be able to use internal infa we have that reacts to transactions, and send email when a key is added.

May 4 2016, 8:42 PM · Auth, Prioritized, Security, Feature Request
epriestley created T10921: Phabricator and ImageTragick.
May 4 2016, 6:43 PM · Macros, Security
epriestley added a comment to T10402: Add a client setup check to detect that the browser is using HTTPS but Phabricator does not recognize it.

Some things we can do easily here:

May 4 2016, 4:19 PM · Setup
epriestley added a comment to T10919: Websocket notification not working anymore after upgrade from 2016 week 15 to 2016 week 18 (stable branch).

I suppose we can trust X-Forwarded-Proto for the purposes of raising a setup issue, although I'm not sure if that would help here, since I think the header usually won't be set if you use nginx to terminate SSL instead of, say, an ELB.

May 4 2016, 3:13 PM · Bug Report
epriestley added a comment to T6522: "Commit's branches contains" condition is not re-evaluated for commits in multiple branches.

We're extremely unlikely to pursue any changes where 99% of the time it works great and 1% of the time a user shows up here wanting to kill us, so arguments in the vein of "it would work for me and other reasonable users who know what they're doing", while likely true, has very weak persuasive power.

May 4 2016, 2:51 PM · Diffusion (v3), Restricted Project, Restricted Project, Herald
epriestley added a comment to T10916: subtask inheritance is maybe not convenient in preponderance of cases?.

You can see which fields are copied in Edit Task → Configure Form → Using HTTP Parameters and scrolling down to "Template Objects". On this install, these fields are currently copied:

May 4 2016, 2:42 PM · Restricted Project, Feature Request
epriestley added a comment to T10919: Websocket notification not working anymore after upgrade from 2016 week 15 to 2016 week 18 (stable branch).

I suspect you may not be setting $_SERVER['HTTPS'] so Phabricator believes you are connecting over HTTP. It looks for a client using the http protocol, fails to find one (only https is available), and does not emit a websocket setup instruction.

May 4 2016, 2:35 PM · Bug Report
epriestley added a comment to T6522: "Commit's branches contains" condition is not re-evaluated for commits in multiple branches.

A branch or tag can be moved from a very old commit to a new commit, and then re-run rules on a large amount of repository history.

May 4 2016, 2:27 PM · Diffusion (v3), Restricted Project, Restricted Project, Herald
epriestley added a comment to T10917: Build Glorious High-Security Notification/Audit Infrastructure.

Broadly, there are a class of "security" changes which are really policy compliance changes. For example, it's common for large enterprises to have a password requirement like this:

May 4 2016, 2:04 PM · Auth, Prioritized, Security, Feature Request
epriestley added a comment to T6522: "Commit's branches contains" condition is not re-evaluated for commits in multiple branches.
for (commit in commits_between(ref.old_commit, ref.new_commit)) {
May 4 2016, 1:15 PM · Diffusion (v3), Restricted Project, Restricted Project, Herald
epriestley added a comment to T10917: Build Glorious High-Security Notification/Audit Infrastructure.

I've generally been hesitant about making Phabricator send these emails because I'm not sure how valuable they are in practice, and a lot of users hate email (see T9161). If an attacker gains access to an instance even briefly, I think it's likely much of the damage is done before most users will be able to respond (in particular, a targeted attack can virtually guarantee you receive the email at a time when you are likely to be asleep). By its nature, this mitigation is a reactive one with a potentially long reaction time.

May 4 2016, 12:07 PM · Auth, Prioritized, Security, Feature Request
salvian awarded T10751: Make Phabricator Highly Available a Like token.
May 4 2016, 3:10 AM · Restricted Project, Infrastructure, Prioritized

May 3 2016

epriestley added a revision to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API: Unknown Object (Differential Revision).
May 3 2016, 10:44 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley added a revision to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API: Unknown Object (Differential Revision).
May 3 2016, 9:04 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley added a revision to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API: Unknown Object (Differential Revision).
May 3 2016, 8:12 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley added a revision to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API: Unknown Object (Differential Revision).
May 3 2016, 8:07 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley added a revision to T4039: Prevent a repository from being set to the same "local path" as some other repository: Unknown Object (Differential Revision).
May 3 2016, 7:40 PM · Restricted Project, Diffusion
epriestley closed T10913: herald "Commit Hook: Commit Content" triggers on "git push --tags" as Resolved.

Per F1256292, presuming resolved until more details surface about what's up.

May 3 2016, 7:36 PM · Herald, Bug Report