Page MenuHomePhabricator
Feed Advanced Search

Mar 30 2016

yelirekim updated Q353: How do I get a non-block-based custom remarkup rule to work fine in phabricator? from to How do I get a non-block-based custom remarkup rule to work fine in phabricator?.
Mar 30 2016, 8:10 PM
yelirekim awarded D12198: Added ESLint Support a The World Burns token.
Mar 30 2016, 11:57 AM

Mar 29 2016

yelirekim added a comment to T10691: Support GitHub-like forking of repositories.

I think that "forking" is the right answer here.

Mar 29 2016, 6:05 PM · Restricted Project, Diffusion, Feature Request
yelirekim added a comment to T10691: Support GitHub-like forking of repositories.

It's not rewriting an existing published branch, we don't permit that, it's just publishing a branch that you've accumulated a bunch of things on as you've been iterating for some period of time. You're not done with it by and stretch of the imagination, and it's been sitting on your machine too long for you to not push it somewhere.

Mar 29 2016, 5:58 PM · Restricted Project, Diffusion, Feature Request
yelirekim created T10691: Support GitHub-like forking of repositories.
Mar 29 2016, 5:24 PM · Restricted Project, Diffusion, Feature Request

Mar 6 2016

yelirekim added a comment to D15420: Improve Drydock errors for empty commits and missing changes.

So that was our "foolproof" method of totally nuking and resetting the contents of a workspace before leasing it out again, and ironically, it does work all of the time, unless there is nothing to change about it.

Mar 6 2016, 11:53 PM
yelirekim added a comment to D15420: Improve Drydock errors for empty commits and missing changes.

we've been wondering for about a month now why on earth this would happen when no error output is produced

Mar 6 2016, 11:50 PM
yelirekim added a comment to D15420: Improve Drydock errors for empty commits and missing changes.

IT EXITS WITH A 1

Mar 6 2016, 11:46 PM

Mar 3 2016

yelirekim closed T10367: Index the contents of comments left on content for searching as Invalid.

./bin/search index --force --all fixed this,.but i'm confused how some random tasks weren't indexed and some were

Mar 3 2016, 7:46 PM · Search, Bug Report (Needs Information)

Feb 26 2016

epriestley awarded T9614: Require "Can Edit" permission on a build plan to pause or abort corresponding builds a Baby Tequila token.
Feb 26 2016, 7:32 PM · Harbormaster (v3), Restricted Project

Feb 25 2016

yelirekim awarded D15347: Introduce idxv(), like idx() a Mountain of Wealth token.
Feb 25 2016, 8:10 PM
yelirekim added a comment to T10452: Provide more flexible management over disabling/changing ldap user accounts.

Probably a really quick partial remedy to the fallout (not root cause) is just exploring ways to make it super obvious to people that they shouldn't be interacting with disabled accounts.

Feb 25 2016, 6:50 PM · Restricted Project, LDAP, Auth, Feature Request
yelirekim added a comment to T10452: Provide more flexible management over disabling/changing ldap user accounts.

To explain the hairiness of this a little better in our case, the actual "migration" procedure looks like this:

Feb 25 2016, 6:41 PM · Restricted Project, LDAP, Auth, Feature Request
yelirekim created T10452: Provide more flexible management over disabling/changing ldap user accounts.
Feb 25 2016, 6:28 PM · Restricted Project, LDAP, Auth, Feature Request
yelirekim added a comment to D15346: Store Almanac "service types" instead of "service classes".

I'm following these because I've frankensteined the existing working-copy and hosts blueprints into one megablueprint, mainly because we run one build per machine, and we run a lot of them.

Feb 25 2016, 5:07 PM
yelirekim added inline comments to D15345: Allow Almanac bindings to be disabled and unused interfaces to be removed.
Feb 25 2016, 5:03 PM

Feb 24 2016

yelirekim awarded T10444: Ever make a mistake? Catch it before its too late.?? a The World Burns token.
Feb 24 2016, 3:25 PM

Feb 17 2016

yelirekim closed Q314: Why does coverage information include the "branch"? as resolved.
Feb 17 2016, 12:47 PM
yelirekim added a comment to D14803: Display coverage information in the diffusion browse UI.

Also Q314: Why does coverage information include the "branch"?

Feb 17 2016, 1:17 AM
yelirekim updated Q314: Why does coverage information include the "branch"? from to Why does coverage information include the "branch"?.
Feb 17 2016, 1:16 AM
yelirekim added a comment to D14803: Display coverage information in the diffusion browse UI.

Normally I would say that I want to do it myself, but if you're willing to clean it up right now, go for it.

Feb 17 2016, 1:10 AM
yelirekim added inline comments to D14803: Display coverage information in the diffusion browse UI.
Feb 17 2016, 1:09 AM

Feb 16 2016

yelirekim added a comment to T10367: Index the contents of comments left on content for searching.
ft_stopword_file = /opt/phabricator/phabricator/resources/sql/stopwords.txt
ft_min_word_len = 3
ft_boolean_syntax=' |-><()~*:""&^'
Feb 16 2016, 10:12 PM · Search, Bug Report (Needs Information)
yelirekim added a comment to T10367: Index the contents of comments left on content for searching.

ok so that was the exact phrase that when searched didn't show up, it works fine here

Feb 16 2016, 10:08 PM · Search, Bug Report (Needs Information)
yelirekim added a comment to T10367: Index the contents of comments left on content for searching.

Notes on setting up Vagrant with libvirt support

Feb 16 2016, 10:07 PM · Search, Bug Report (Needs Information)
yelirekim added a comment to T10367: Index the contents of comments left on content for searching.

I think we were using strings that were too long when checking this out on our production install.

Feb 16 2016, 10:04 PM · Search, Bug Report (Needs Information)
yelirekim added a comment to T10367: Index the contents of comments left on content for searching.

I can't close this task to spite myself.

Feb 16 2016, 10:04 PM · Search, Bug Report (Needs Information)
peplin awarded T10367: Index the contents of comments left on content for searching a Like token.
Feb 16 2016, 10:02 PM · Search, Bug Report (Needs Information)
yelirekim created T10367: Index the contents of comments left on content for searching.
Feb 16 2016, 9:59 PM · Search, Bug Report (Needs Information)
yelirekim created P1945 A still not quite right idea.
Feb 16 2016, 1:43 AM
yelirekim created P1944 A not quite right idea.
Feb 16 2016, 1:38 AM
yelirekim closed Q311: How dangerous is this edit engine extension? as resolved.
Feb 16 2016, 1:24 AM

Feb 15 2016

epriestley awarded T10361: Images uploaded to new polls have their visibility set to "only the uploader" a Doubloon token.
Feb 15 2016, 11:20 PM · Bug Report
yelirekim created T10361: Images uploaded to new polls have their visibility set to "only the uploader".
Feb 15 2016, 11:09 PM · Bug Report
yelirekim awarded D15275: Give Owners real view and edit policies a Baby Tequila token.
Feb 15 2016, 8:03 PM
yelirekim created T10360: Provide actual policy support to Owners.
Feb 15 2016, 4:48 PM · Owners, Feature Request
yelirekim added a comment to Q311: How dangerous is this edit engine extension? (Answer 328).

(apologies if this recently changed, I'm a few weeks behind master)

Feb 15 2016, 4:39 PM
yelirekim added a comment to Q311: How dangerous is this edit engine extension? (Answer 328).
mysql> show create table owners_package\G
*************************** 1. row ***************************
       Table: owners_package
Create Table: CREATE TABLE `owners_package` (
  `id` int(10) unsigned NOT NULL AUTO_INCREMENT,
  `phid` varbinary(64) NOT NULL,
  `name` varchar(128) CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci NOT NULL,
  `originalName` varchar(255) COLLATE utf8mb4_bin NOT NULL,
  `description` longtext COLLATE utf8mb4_bin NOT NULL,
  `primaryOwnerPHID` varbinary(64) DEFAULT NULL,
  `auditingEnabled` tinyint(1) NOT NULL DEFAULT '0',
  `mailKey` binary(20) NOT NULL,
  `status` varchar(32) COLLATE utf8mb4_bin NOT NULL,
  PRIMARY KEY (`id`),
  UNIQUE KEY `key_phid` (`phid`)
) ENGINE=InnoDB AUTO_INCREMENT=4 DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin
1 row in set (0.00 sec)
Feb 15 2016, 4:38 PM
yelirekim added a comment to Q311: How dangerous is this edit engine extension? (Answer 328).

Yeah, we have some packages which are generated by another application, and some which are generated by users, I wanted to lock the field only when the package was generated by the other application, this is a simplified version of the actual extension in place.

Feb 15 2016, 4:26 PM
yelirekim updated Q311: How dangerous is this edit engine extension? from to How dangerous is this edit engine extension?.
Feb 15 2016, 3:53 PM
yelirekim created P1943 Edit Engine Extension.
Feb 15 2016, 3:50 PM

Feb 5 2016

yelirekim awarded T9789: Make it easier to write custom transaction types a Doubloon token.
Feb 5 2016, 9:00 AM · Modernization, Transactions
yelirekim added a comment to D14803: Display coverage information in the diffusion browse UI.

Can I do anything to make this more appealing or land-able or attention worthy?

Feb 5 2016, 8:30 AM
yelirekim added a comment to T9010: Allow badges to have any Font Awesome icon.

Can I get clarification on philosophical opposition to this? Is it leaking abstraction of the "icon" interface to the end user?

Feb 5 2016, 8:28 AM · Badges

Feb 2 2016

yelirekim updated the test plan for D14803: Display coverage information in the diffusion browse UI.
Feb 2 2016, 12:52 AM
yelirekim updated the diff for D14803: Display coverage information in the diffusion browse UI.

Moving bar rendering to a specialized coverage bar view

Feb 2 2016, 12:49 AM

Feb 1 2016

yelirekim committed rPd41aaba2a184: Fix coverage line index lookup in diffusion browser (authored by yelirekim).
Fix coverage line index lookup in diffusion browser
Feb 1 2016, 7:21 PM
yelirekim closed D15156: Fix coverage line index lookup in diffusion browser by committing rPd41aaba2a184: Fix coverage line index lookup in diffusion browser.
Feb 1 2016, 7:21 PM
yelirekim retitled D15156: Fix coverage line index lookup in diffusion browser from to Fix coverage line index lookup in diffusion browser.
Feb 1 2016, 7:13 PM

Jan 25 2016

yelirekim retitled D15112: Use correct transaction types when creating diffs from to Use correct transaction types when creating diffs.
Jan 25 2016, 6:25 AM
yelirekim created T10214: Daemons try and fail to publish transactions for newly created diffs.
Jan 25 2016, 6:20 AM · Bug Report

Jan 10 2016

yelirekim added a comment to T9828: Make migrating files less scary.

The error output was not from the script, it was just errors. I think I remember looking into this a long while ago and it's because the migrate script (incl dry run) actually reads all of the files. The act of reading the file is what generated the error. I should have described this a little better than "dry run shows some files are going to fail", and instead described it as "dry run shows errors for some of the files".

Jan 10 2016, 11:37 AM · Restricted Project, Files

Jan 6 2016

yelirekim awarded D14853: Don't show self-subscribes in feed or mail a Evil Spooky Haunted Tree token.
Jan 6 2016, 5:42 AM

Dec 18 2015

yelirekim added a comment to T6777: Arcanist creates a branch when --nobranch is specified.

FWIW, we have a script that uses arc patch --nobranch to "graft" someone else's working tree into your own working tree. We suppressed arc patch output entirely after enough people complained about "all of the branches its making".

Dec 18 2015, 7:32 AM · Arcanist

Dec 17 2015

yelirekim added a comment to D14803: Display coverage information in the diffusion browse UI.

This isn't quite done, I'm putting it up to ask for some ideas. I've got all of the data that we would need funneled into DiffusionLastModifiedController:: renderColumns but had one particular question about how to proceed. Should we render coverage for each file in this same column? If so, how can we differentiate per-file coverage UI elements from per-directory UI elements?

Dec 17 2015, 3:55 AM
yelirekim added a task to D14803: Display coverage information in the diffusion browse UI: T9524: Show aggregate subdirectory coverage in Diffusion browse views.
Dec 17 2015, 3:52 AM
yelirekim added a revision to T9524: Show aggregate subdirectory coverage in Diffusion browse views: D14803: Display coverage information in the diffusion browse UI.
Dec 17 2015, 3:52 AM · Diffusion, Restricted Project
yelirekim retitled D14803: Display coverage information in the diffusion browse UI from to Display coverage information in the diffusion browse UI.
Dec 17 2015, 3:52 AM

Dec 14 2015

yelirekim awarded T9980: Give administrators better tools for managing Conduit API changes a Grey Medal token.
Dec 14 2015, 12:50 PM · Conduit
yelirekim archived P1907 test.
Dec 14 2015, 3:54 AM
yelirekim updated the title for P1907 test from untitled to test.
Dec 14 2015, 3:54 AM

Nov 23 2015

yelirekim created T9828: Make migrating files less scary.
Nov 23 2015, 2:31 AM · Restricted Project, Files

Nov 19 2015

yelirekim added a comment to T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier.

We can leave this at "reduced expected incidence rate to < 1/3k" and I'll come back here if it happens again if you don't have any more obvious ideas.

Nov 19 2015, 2:55 AM · Harbormaster, Drydock
yelirekim added a comment to T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier.

Oh I lied, checked the old logs, this error was present the last two times it occurred, but not present when it happened this evening.

Nov 19 2015, 2:51 AM · Harbormaster, Drydock
yelirekim added a comment to T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier.

This perfectly recreates the symptoms, except it generates an error in the daemon log:

Nov 19 2015, 2:49 AM · Harbormaster, Drydock
yelirekim added a comment to T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier.

DAO's prefixed CISubmitQueue are in their own database. There has never been any problems with referential integrity / never seen anything in the database that would indicate we'd written records incorrectly. But you may be right about the tasks being written before the plan is written. I suspect that would cause errors though, I can try to reproduce that first in order to rule out our specifics being the problem.

Nov 19 2015, 2:13 AM · Harbormaster, Drydock
yelirekim added a comment to T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier.

Let me post the whole block, it didn't seem relevant:

Nov 19 2015, 2:10 AM · Harbormaster, Drydock
yelirekim updated the task description for T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier.
Nov 19 2015, 2:07 AM · Harbormaster, Drydock
yelirekim updated the task description for T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier.
Nov 19 2015, 2:06 AM · Harbormaster, Drydock
yelirekim updated the task description for T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier.
Nov 19 2015, 2:04 AM · Harbormaster, Drydock
yelirekim created T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier.
Nov 19 2015, 2:03 AM · Harbormaster, Drydock

Nov 10 2015

yelirekim created T9755: Have conduit call logs actually log the caller.
Nov 10 2015, 5:22 PM · Conduit
yelirekim added Q209: Is it possible to update Differential dependencies from Conduit? (Answer 245).
Nov 10 2015, 12:02 PM

Nov 8 2015

yelirekim created T9735: Fix `paste.create` conduit method in the wake of edit engine support.
Nov 8 2015, 10:28 AM · ApplicationEditor, Paste

Nov 6 2015

yelirekim updated Q209: Is it possible to update Differential dependencies from Conduit? from to Is it possible to update differential dependencies from conduit.
Nov 6 2015, 10:39 PM · Differential

Oct 30 2015

yelirekim renamed T9672: Make it possible to modify or disable differential's "next step" property from Make it possible to modify or disable diffusion's "next step" property to Make it possible to modify or disable differential's "next step" property.
Oct 30 2015, 12:21 AM · Custom Fields, Differential
yelirekim created T9672: Make it possible to modify or disable differential's "next step" property.
Oct 30 2015, 12:18 AM · Custom Fields, Differential

Oct 26 2015

yelirekim awarded Q179: How do you configure an Almanac based Drydock resource a Mountain of Wealth token.
Oct 26 2015, 10:35 AM · Drydock

Oct 25 2015

yelirekim added a comment to T9631: Don't crash when users fail to specify additional working copies.

Yeah it's busted by default including newly created steps

Oct 25 2015, 9:21 PM
yelirekim added a comment to T9492: Make WorkingCopy resources more powerful and flexible.

if you have a many-minutes-long build process anyway maybe shaving startup time from 2 minutes to 2 seconds doesn't really matter

Oct 25 2015, 9:08 PM · Restricted Project, Drydock
yelirekim added a comment to T9631: Don't crash when users fail to specify additional working copies.

I did do at least this to try to get this to disappear:

Oct 25 2015, 8:56 PM
yelirekim created T9631: Don't crash when users fail to specify additional working copies.
Oct 25 2015, 8:35 PM
yelirekim created T9630: Support submodules in Drydock working copies.
Oct 25 2015, 8:28 PM
yelirekim awarded Q191: How can I fix this? a Like token.
Oct 25 2015, 8:22 PM

Oct 23 2015

yelirekim awarded T9308: Pholio new revision a Yellow Medal token.
Oct 23 2015, 8:26 PM · Pholio
yelirekim added a comment to T9525: Provide a reasonable general use logo.

I'll put them into rotation and report back on A/B results.

Oct 23 2015, 7:26 PM · Public & Media Relations
yelirekim added a comment to T9525: Provide a reasonable general use logo.

I replaced the existing logo with the one you provided some time ago. It has not been met with universal fanfare as I would have expected given the level of artistry displayed.

Oct 23 2015, 7:23 PM · Public & Media Relations

Oct 22 2015

yelirekim added a comment to T9614: Require "Can Edit" permission on a build plan to pause or abort corresponding builds.

I thought Phabricator was an adventure game, that sounds an awful lot like RTS.

Oct 22 2015, 8:30 PM · Harbormaster (v3), Restricted Project
yelirekim added a comment to T9614: Require "Can Edit" permission on a build plan to pause or abort corresponding builds.

"out of the box" support would look something like: if you triggered the action that created this build, only you have control over stopping it (or admins). If an application started the build (eg, global herald rule in response to a commit), only admins have control.

Oct 22 2015, 8:21 PM · Harbormaster (v3), Restricted Project
yelirekim added a comment to T9614: Require "Can Edit" permission on a build plan to pause or abort corresponding builds.

We're already waist deep into modifying DB records in Harbormaster that we probably shouldn't be, any expanded control over policies there at all should enable our other custom apps to make it do what we like.

Oct 22 2015, 8:20 PM · Harbormaster (v3), Restricted Project
yelirekim created T9614: Require "Can Edit" permission on a build plan to pause or abort corresponding builds.
Oct 22 2015, 7:55 PM · Harbormaster (v3), Restricted Project

Oct 20 2015

yelirekim added a comment to T9524: Show aggregate subdirectory coverage in Diffusion browse views.

I'm ~1 week away from actually having our ducks in a row so we can merge upstream, would expect to land this right about then. Not sure if workboard implies some kind of scheduling?

Oct 20 2015, 1:27 PM · Diffusion, Restricted Project

Oct 18 2015

yelirekim claimed T9524: Show aggregate subdirectory coverage in Diffusion browse views.
Oct 18 2015, 11:14 PM · Diffusion, Restricted Project

Oct 15 2015

yelirekim added a comment to Q177: Is it possible to provide the `--nounit` flag to `arc diff` by default?.

Yeah it works for us to just kill it in arc unit for now, we're stuck a few weeks behind master for the time being so an upstream fix wouldn't help us immediately anyways.

Oct 15 2015, 3:46 AM · Arcanist
yelirekim added a comment to Q177: Is it possible to provide the `--nounit` flag to `arc diff` by default?.

So I guess yes? You're saying implement this in the test engine?

Oct 15 2015, 3:37 AM · Arcanist
yelirekim added a comment to Q177: Is it possible to provide the `--nounit` flag to `arc diff` by default?.

We have our own build step which just runs arc unit --everything --coverage --ugly in a working copy and then deals with the exit code and json returned.

Oct 15 2015, 3:36 AM · Arcanist
yelirekim updated Q177: Is it possible to provide the `--nounit` flag to `arc diff` by default? from Is it possible to provide the `--nounit` flag to `arc unit` by default? to Is it possible to provide the `--nounit` flag to `arc diff` by default?.
Oct 15 2015, 3:19 AM · Arcanist
yelirekim updated Q177: Is it possible to provide the `--nounit` flag to `arc diff` by default? from to Is it possible to provide the `--nounit` flag to `arc unit` by default?.
Oct 15 2015, 3:18 AM · Arcanist

Oct 13 2015

yelirekim awarded D14266: Rough cut of DrydockRepositoryOperation a Baby Tequila token.
Oct 13 2015, 4:40 PM

Oct 12 2015

yelirekim created T9551: Strip strange characters out of project hashtags, or support parsing strange hashtag characters in other contexts.
Oct 12 2015, 3:54 PM · Prioritized, Projects