Differential D15275

Give Owners real view and edit policies
ClosedPublic
Actions

Authored by epriestley on Feb 15 2016, 7:44 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 8, 11:37 PM

	Unknown Object (File)
	Sat, Apr 6, 8:56 PM

	Unknown Object (File)
	Mon, Apr 1, 11:45 AM

	Unknown Object (File)
	Sun, Mar 31, 8:04 PM

	Unknown Object (File)
	Fri, Mar 29, 7:16 AM

	Unknown Object (File)
	Mar 5 2024, 3:26 PM

	Unknown Object (File)
	Mar 5 2024, 11:42 AM

	Unknown Object (File)
	Mar 5 2024, 11:42 AM

Subscribers

None

Tokens

"Baby Tequila" token, awarded by yelirekim.

Details

Reviewers

Maniphest Tasks

T10360: Provide actual policy support to Owners

Commits

Restricted Diffusion Commit
rP71ee97d74f73: Give Owners real view and edit policies

Summary

Fixes T10360. In modern code, most of the meat is automatic.

Test Plan

Edited view policy and edit policy from web UI.
Viewed package, saw policy badge in header.
Tried to edit a package as a user without permission, got appropriate disabled states and errors.
Changed policies via Conduit.
Tried to view a package as a user without permission.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36854.Feb 15 2016, 7:44 PM

epriestley retitled this revision from to Give Owners real view and edit policies.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10360: Provide actual policy support to Owners.

chad accepted this revision.Feb 15 2016, 7:55 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Feb 15 2016, 7:55 PM

Closed by commit rP71ee97d74f73: Give Owners real view and edit policies (authored by epriestley, committed by epriestley). · Explain WhyFeb 15 2016, 7:56 PM

This revision was automatically updated to reflect the committed changes.

yelirekim awarded a token.Feb 15 2016, 8:03 PM

epriestley mentioned this in D21850: Remove obsolete, policy-violating "owners.query" API method.May 31 2022, 5:43 PM

epriestley mentioned this in rP3052ed14849c: Remove obsolete, policy-violating "owners.query" API method.May 31 2022, 5:44 PM

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20160215.owners.policy.1.sql

2 lines

20160215.owners.policy.2.sql

2 lines

20160215.owners.policy.3.sql

2 lines

20160215.owners.policy.4.sql

2 lines

src/

__phutil_library_map__.php

4 lines

applications/

owners/

application/

PhabricatorOwnersApplication.php

15 lines

capability/

PhabricatorOwnersDefaultEditCapability.php

12 lines

PhabricatorOwnersDefaultViewCapability.php

16 lines

controller/

PhabricatorOwnersDetailController.php

6 lines

PhabricatorOwnersPathsController.php

3 lines

editor/

PhabricatorOwnersPackageTransactionEditor.php

3 lines

storage/

PhabricatorOwnersPackage.php

22 lines

Diff 36855

resources/sql/autopatches/20160215.owners.policy.1.sql

Loading...

resources/sql/autopatches/20160215.owners.policy.2.sql

Loading...

resources/sql/autopatches/20160215.owners.policy.3.sql

Loading...

resources/sql/autopatches/20160215.owners.policy.4.sql

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/owners/application/PhabricatorOwnersApplication.php

Loading...

src/applications/owners/capability/PhabricatorOwnersDefaultEditCapability.php

Loading...

src/applications/owners/capability/PhabricatorOwnersDefaultViewCapability.php

Loading...

src/applications/owners/controller/PhabricatorOwnersDetailController.php

Loading...

src/applications/owners/controller/PhabricatorOwnersPathsController.php

Loading...

src/applications/owners/editor/PhabricatorOwnersPackageTransactionEditor.php

Loading...

src/applications/owners/storage/PhabricatorOwnersPackage.php

Loading...