Paths

Table of Contentst

Differential D15346

Store Almanac "service types" instead of "service classes"
ClosedPublic
Actions

Authored by epriestley on Feb 25 2016, 2:05 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jan 21, 9:38 AM

	Unknown Object (File)
	Sat, Jan 18, 4:38 AM

	Unknown Object (File)
	Fri, Jan 17, 10:13 PM

	Unknown Object (File)
	Fri, Jan 17, 8:08 PM

	Unknown Object (File)
	Fri, Dec 27, 4:57 PM

	Unknown Object (File)
	Fri, Dec 27, 3:10 PM

	Unknown Object (File)
	Tue, Dec 24, 6:59 PM

	Unknown Object (File)
	Tue, Dec 24, 3:40 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T10449: Almanac v2 (Unprototype)

Commits

Restricted Diffusion Commit
rP7d4b323da2bd: Store Almanac "service types" instead of "service classes"

Summary

Ref T10449. Currently, we store classes (like "AlmanacClusterRepositoryServiceType") in the database.

Instead, store types (like "cluster.repository").

This is a small change, but types are a little more flexible (they let us freely reanme classes), a little cleaner (fewer magic strings in the codebase), and a little better for API usage (they're more human readable).

Make this minor usability change now, before we unprototype.

Also make services searchable by type.

Also remove old Almanac API endpoints.

Test Plan

Ran migration, verified all data migrated properly.
Created, edited, rebound, and changed properties of services.
Searched for services by service type.
Reviewed available Conduit methods.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37005.Feb 25 2016, 2:05 PM

epriestley retitled this revision from to Store Almanac "service types" instead of "service classes".

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10449: Almanac v2 (Unprototype).

Herald added a subscriber: yelirekim. · View Herald TranscriptFeb 25 2016, 2:05 PM

epriestley updated this object.Feb 25 2016, 2:07 PM

@yelirekim, if it's helpful, API impact probably doesn't affect you, but:

AlmanacServiceQuery->withServiceClasses(...) becomes withServiceTypes(...).
Pass XServiceType::SERVICETYPE instead of "XServiceType".
Any extension service types need a SERVICETYPE constant (you probably (?) don't have any).
almanac.* API endpoints have moved (you probably (?) don't use these).

Add some API support for Phacility use cases.

Additional API updates, primiarily for Phacility use cases.

chad accepted this revision.Feb 25 2016, 4:59 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Feb 25 2016, 4:59 PM

I'm following these because I've frankensteined the existing working-copy and hosts blueprints into one megablueprint, mainly because we run one build per machine, and we run a lot of them.

I suspect this is abnormal, and is going to break in bad ways at some point.

We'll probably support that kind of thing upstream at some point, I just didn't want to add five different kinds of limits in the first iteration.

Closed by commit rP7d4b323da2bd: Store Almanac "service types" instead of "service classes" (authored by epriestley, committed by epriestley). · Explain WhyFeb 26 2016, 2:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20160225.almanac.2.stype.sql

2 lines

20160225.almanac.3.stype.php

30 lines

src/

__phutil_library_map__.php

8 lines

applications/

almanac/

conduit/

AlmanacConduitAPIMethod.php

AlmanacQueryDevicesConduitAPIMethod.php

AlmanacQueryServicesConduitAPIMethod.php

controller/

AlmanacServiceEditController.php

26 lines

AlmanacServiceViewController.php

2 lines

query/

AlmanacServiceQuery.php

24 lines

AlmanacServiceSearchEngine.php

15 lines

servicetype/

AlmanacClusterDatabaseServiceType.php

2 lines

AlmanacClusterRepositoryServiceType.php

2 lines

AlmanacCustomServiceType.php

2 lines

AlmanacDrydockPoolServiceType.php

2 lines

AlmanacServiceType.php

8 lines

storage/

AlmanacProperty.php

40 lines

AlmanacService.php

56 lines

typeahead/

AlmanacServiceDatasource.php

6 lines

AlmanacServiceTypeDatasource.php

43 lines

config/

check/

PhabricatorRepositoriesSetupCheck.php

4 lines

diffusion/

controller/

DiffusionRepositoryCreateController.php

4 lines

drydock/

blueprint/

DrydockAlmanacServiceHostBlueprintImplementation.php

8 lines

repository/

storage/

PhabricatorRepository.php

2 lines

Diff 37016

resources/sql/autopatches/20160225.almanac.2.stype.sql

Loading...

resources/sql/autopatches/20160225.almanac.3.stype.php

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/almanac/conduit/AlmanacConduitAPIMethod.php

Loading...

src/applications/almanac/conduit/AlmanacQueryDevicesConduitAPIMethod.php

Loading...

src/applications/almanac/conduit/AlmanacQueryServicesConduitAPIMethod.php

Loading...

src/applications/almanac/controller/AlmanacServiceEditController.php

Loading...

src/applications/almanac/controller/AlmanacServiceViewController.php

Loading...

src/applications/almanac/query/AlmanacServiceQuery.php

Loading...

src/applications/almanac/query/AlmanacServiceSearchEngine.php

Loading...

src/applications/almanac/servicetype/AlmanacClusterDatabaseServiceType.php

Loading...

src/applications/almanac/servicetype/AlmanacClusterRepositoryServiceType.php

Loading...

src/applications/almanac/servicetype/AlmanacCustomServiceType.php

Loading...

src/applications/almanac/servicetype/AlmanacDrydockPoolServiceType.php

Loading...

src/applications/almanac/servicetype/AlmanacServiceType.php

Loading...

src/applications/almanac/storage/AlmanacProperty.php

Loading...

src/applications/almanac/storage/AlmanacService.php

Loading...

src/applications/almanac/typeahead/AlmanacServiceDatasource.php

Loading...

src/applications/almanac/typeahead/AlmanacServiceTypeDatasource.php

Loading...

src/applications/config/check/PhabricatorRepositoriesSetupCheck.php

Loading...

src/applications/diffusion/controller/DiffusionRepositoryCreateController.php

Loading...

src/applications/drydock/blueprint/DrydockAlmanacServiceHostBlueprintImplementation.php

Loading...

src/applications/repository/storage/PhabricatorRepository.php

Loading...