Fix coverage line index lookup in diffusion browser
d41aaba2a184
Actions

Description

Fix coverage line index lookup in diffusion browser

Summary: I believe this got clobbered in rP8b6edaa4e238a809fe78e6d14ad0705545f8179f. This index doesn't seem to be present in the line dictionary and we're now relying on $line_index for the current position.

Test Plan:
before

Screen Shot 2016-02-01 at 2.05.12 PM.png (1×2 px, 438 KB)

after

Screen Shot 2016-02-01 at 2.05.51 PM.png (1×2 px, 354 KB)

Reviewers: Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D15156

Details

Provenance

yelirekim	Authored on Feb 1 2016, 7:04 PM
yelirekim	Pushed on Feb 1 2016, 7:21 PM

Reviewer

Blessed Reviewers

Differential Revision

D15156: Fix coverage line index lookup in diffusion browser

Parents

rPf5c686d6a4c5: Swap charts from gRaphael to D3

Branches

Unknown

Tags

Unknown

Build Status

Buildable 10434
Build 12749: Run Core Tests

Event Timeline

yelirekim committed rPd41aaba2a184: Fix coverage line index lookup in diffusion browser (authored by yelirekim).Feb 1 2016, 7:19 PM

Harbormaster completed building B10434: rPd41aaba2a184: Fix coverage line index lookup in diffusion browser.Feb 1 2016, 7:21 PM

• pmoreau mentioned this in T10259: fetch log crashes when using IP v6 (http), fetch fails.Feb 1 2016, 8:53 PM

Changes (1)

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBrowseController.php

rPd41aaba2a184

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php