Differential D15420

Improve Drydock errors for empty commits and missing changes
ClosedPublic
Actions

Authored by epriestley on Mar 6 2016, 11:37 PM.

Details

Reviewers

chad

Maniphest Tasks

T10093: When builds fail because the staging area was not pushed, make the cause clear

Commits

Restricted Diffusion Commit
rP19eee427adb3: Improve Drydock errors for empty commits and missing changes

Summary

Ref T10093. Show better errors when a commit fails because it has already been merged and when a fetch fails because the ref isn't present in the remote.

Test Plan

Screen Shot 2016-03-06 at 3.27.56 PM.png (595×1 px, 91 KB)

Screen Shot 2016-03-06 at 3.32.13 PM.png (515×1 px, 96 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37174.Mar 6 2016, 11:37 PM

epriestley retitled this revision from to Improve Drydock errors for empty commits and missing changes.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10093: When builds fail because the staging area was not pushed, make the cause clear.

Herald added a subscriber: yelirekim. · View Herald TranscriptMar 6 2016, 11:37 PM

IT EXITS WITH A 1

wut

ill exit u with a 1 buddy

we've been wondering for about a month now why on earth this would happen when no error output is produced

'git fetch %s && '.
'git checkout --force -B %s %s && '.
'git reset --hard %s && '.
'git clean -f -f -d -x',

amazing

So that was our "foolproof" method of totally nuking and resetting the contents of a workspace before leasing it out again, and ironically, it does work all of the time, unless there is nothing to change about it.

michaeljs1990 added a subscriber: michaeljs1990.Mar 7 2016, 12:25 AM