Page MenuHomePhabricator

Improve Drydock errors for empty commits and missing changes
ClosedPublic

Authored by epriestley on Mar 6 2016, 11:37 PM.

Details

Summary

Ref T10093. Show better errors when a commit fails because it has already been merged and when a fetch fails because the ref isn't present in the remote.

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Improve Drydock errors for empty commits and missing changes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

we've been wondering for about a month now why on earth this would happen when no error output is produced

'git fetch %s && '.
'git checkout --force -B %s %s && '.
'git reset --hard %s && '.
'git clean -f -f -d -x',

amazing

So that was our "foolproof" method of totally nuking and resetting the contents of a workspace before leasing it out again, and ironically, it does work all of the time, unless there is nothing to change about it.

chad edited edge metadata.

noidea

This revision is now accepted and ready to land.Mar 7 2016, 4:32 AM
This revision was automatically updated to reflect the committed changes.