Page MenuHomePhabricator

Fix coverage line index lookup in diffusion browser
ClosedPublic

Authored by yelirekim on Feb 1 2016, 7:13 PM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPd41aaba2a184: Fix coverage line index lookup in diffusion browser
Summary

I believe this got clobbered in rP8b6edaa4e238a809fe78e6d14ad0705545f8179f. This index doesn't seem to be present in the line dictionary and we're now relying on $line_index for the current position.

Test Plan

before


after

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

yelirekim updated this revision to Diff 36591.Feb 1 2016, 7:13 PM
yelirekim retitled this revision from to Fix coverage line index lookup in diffusion browser.
yelirekim updated this object.
yelirekim edited the test plan for this revision. (Show Details)
epriestley accepted this revision.Feb 1 2016, 7:17 PM
epriestley added a reviewer: epriestley.

Thanks!

This revision is now accepted and ready to land.Feb 1 2016, 7:17 PM

(I added you to Blessed Committers so you should be able to land it yourself.)

This revision was automatically updated to reflect the committed changes.