Fix coverage line index lookup in diffusion browser
ClosedPublic
Actions

Authored by yelirekim on Feb 1 2016, 7:13 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPd41aaba2a184: Fix coverage line index lookup in diffusion browser

Summary

I believe this got clobbered in rP8b6edaa4e238a809fe78e6d14ad0705545f8179f. This index doesn't seem to be present in the line dictionary and we're now relying on $line_index for the current position.

Test Plan

before

Screen Shot 2016-02-01 at 2.05.12 PM.png (1×2 px, 438 KB)

after

Screen Shot 2016-02-01 at 2.05.51 PM.png (1×2 px, 354 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

yelirekim updated this revision to Diff 36591.Feb 1 2016, 7:13 PM

yelirekim retitled this revision from to Fix coverage line index lookup in diffusion browser.

yelirekim updated this object.

yelirekim edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 1 2016, 7:13 PM

Herald added a subscriber: epriestley. · View Herald Transcript

Thanks!

This revision is now accepted and ready to land.Feb 1 2016, 7:17 PM

(I added you to Blessed Committers so you should be able to land it yourself.)

Closed by commit rPd41aaba2a184: Fix coverage line index lookup in diffusion browser (authored by yelirekim, committed by yelirekim). · Explain WhyFeb 1 2016, 7:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBrowseController.php

2 lines

Diff 36592

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Fix coverage line index lookup in diffusion browserClosedPublicActions