Page MenuHomePhabricator
Feed Advanced Search

Mar 16 2016

epriestley added a comment to T10601: Scale retina images when they are used in a mock.

We could also maybe do something ridiculous like assume it's @2x if both dimensions are even, but M1461 has a 2X image with an odd height (1717px!) so that probably won't get us very far ignoring all the false positives for 400x300px images and such.

Mar 16 2016, 6:45 PM · Pholio, Feature Request
epriestley added a comment to T10601: Scale retina images when they are used in a mock.

I think this is reasonable to build as:

Mar 16 2016, 6:44 PM · Pholio, Feature Request
epriestley added a revision to T10604: Allow application code to stream request data: Unknown Object (Differential Revision).
Mar 16 2016, 6:06 PM · Diffusion (v3), Restricted Project
epriestley added a comment to T10605: Implement setOriginalText() and setReplacementText() in RuboCop driver.

Assuming this mode does not exist, the clearest pathway forward is for you or someone else to:

Mar 16 2016, 6:03 PM · Lint, Feature Request
epriestley added a comment to T10605: Implement setOriginalText() and setReplacementText() in RuboCop driver.

Does RuboCop actually have a mode where it emits errors and replacement text?

Mar 16 2016, 5:59 PM · Lint, Feature Request
epriestley added a revision to T10264: git clone using http hangs after update: Unknown Object (Differential Revision).
Mar 16 2016, 5:51 PM · Bug Report, Diffusion
epriestley added a revision to T10604: Allow application code to stream request data: Unknown Object (Differential Revision).
Mar 16 2016, 5:51 PM · Diffusion (v3), Restricted Project
epriestley created T10604: Allow application code to stream request data.
Mar 16 2016, 5:46 PM · Diffusion (v3), Restricted Project
epriestley closed T10603: Make AuthTemporaryTokens suitable for use as LFS tokens, a subtask of T7789: Support Git Large File Storage, as Resolved.
Mar 16 2016, 4:35 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley closed T10603: Make AuthTemporaryTokens suitable for use as LFS tokens as Resolved by committing Restricted Diffusion Commit.
Mar 16 2016, 4:34 PM · Auth
r0bbie awarded T7789: Support Git Large File Storage a Like token.
Mar 16 2016, 4:12 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a revision to T7789: Support Git Large File Storage: Unknown Object (Differential Revision).
Mar 16 2016, 2:51 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley closed T10588: PhabricatorWorkerActiveTask continuously reports connection error in logs as Resolved.
Mar 16 2016, 2:49 PM · Installing & Upgrading, Bug Report
epriestley added a comment to T10254: Assign projects to spaces.

There is not, and never will be. Associated projects never affect policies, so there is no possibility to make them start affecting policies. I'm not sure what's unclear about this.

Mar 16 2016, 2:21 PM · Restricted Project, Spaces, Projects, Feature Request
epriestley added a comment to T10601: Scale retina images when they are used in a mock.

That one might be better to merge here, since it's probably impossible (at least, in the general case) but this talks about some things we can do in the general case.

Mar 16 2016, 2:20 PM · Pholio, Feature Request
epriestley added a revision to T10603: Make AuthTemporaryTokens suitable for use as LFS tokens: Unknown Object (Differential Revision).
Mar 16 2016, 2:11 PM · Auth
epriestley added a revision to T10603: Make AuthTemporaryTokens suitable for use as LFS tokens: Unknown Object (Differential Revision).
Mar 16 2016, 1:56 PM · Auth
epriestley added a comment to T10254: Assign projects to spaces.

By design, changing projects never affects policies. See the documentation here:

Mar 16 2016, 1:52 PM · Restricted Project, Spaces, Projects, Feature Request
epriestley added a comment to T10588: PhabricatorWorkerActiveTask continuously reports connection error in logs.

@jlvillapalos, can you shed some light on why you didn't include that information in the first place or how we could improve the process?

Mar 16 2016, 1:49 PM · Installing & Upgrading, Bug Report
epriestley closed T10530: Exception: Cursor "11972" does not identify a valid object in query "DiffusionCommitQuery". as Resolved.

bin/remove destroy gives you a huge scary red skull-and-crossbones ASCII art for good reason, and you're accepting that issues like this may occur when you confirm the prompt.

Mar 16 2016, 1:40 PM · Audit, Diffusion, Bug Report
epriestley added a revision to T10603: Make AuthTemporaryTokens suitable for use as LFS tokens: Unknown Object (Differential Revision).
Mar 16 2016, 1:26 PM · Auth
epriestley added a revision to T10603: Make AuthTemporaryTokens suitable for use as LFS tokens: Unknown Object (Differential Revision).
Mar 16 2016, 1:14 PM · Auth
epriestley added a revision to T10603: Make AuthTemporaryTokens suitable for use as LFS tokens: Unknown Object (Differential Revision).
Mar 16 2016, 12:37 PM · Auth
epriestley added a revision to T10603: Make AuthTemporaryTokens suitable for use as LFS tokens: Unknown Object (Differential Revision).
Mar 16 2016, 12:24 PM · Auth
epriestley changed the edit policy for T10603: Make AuthTemporaryTokens suitable for use as LFS tokens.
Mar 16 2016, 12:18 PM · Auth
epriestley changed the edit policy for T7789: Support Git Large File Storage.
Mar 16 2016, 12:18 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley created T10603: Make AuthTemporaryTokens suitable for use as LFS tokens.
Mar 16 2016, 12:15 PM · Auth
epriestley added a comment to T5214: Add Conduit API methods for workboards.

T10599 asks for column move APIs, which are adjacent to this.

Mar 16 2016, 11:49 AM · Restricted Project, Conduit, Maniphest, Workboards
epriestley updated subscribers of T5214: Add Conduit API methods for workboards.
Mar 16 2016, 11:49 AM · Restricted Project, Conduit, Maniphest, Workboards
epriestley merged task T10599: Conduit - 「maniphest.edit 」when changing column, always throw「Validation errors」 into T5214: Add Conduit API methods for workboards.
Mar 16 2016, 11:49 AM · Bug Report
epriestley added a comment to T10599: Conduit - 「maniphest.edit 」when changing column, always throw「Validation errors」.

This transaction can only create a task into a column, it can't move a task. That's why the documentation says "Create into a workboard column.".

Mar 16 2016, 11:48 AM · Bug Report
epriestley added a comment to T10601: Scale retina images when they are used in a mock.

I don't think we can detect this automatically -- a, say, web-ready PNG from Photoshop generally won't have DPI information, as far as I know.

Mar 16 2016, 11:46 AM · Pholio, Feature Request
epriestley added a comment to T3167: Use full names in Conpherence messages.

We are vanishingly unlikely to revisit this decision. If this is important to your organization, you should look into forking the codebase to provide the functionality you are interested in.

Mar 16 2016, 11:40 AM · Conpherence
epriestley added Q338: How can I edit the documentation? (Answer 344).
Mar 16 2016, 11:36 AM
ofbeaton awarded T6703: Allow multiple copies of the same auth provider type a Like token.
Mar 16 2016, 2:21 AM · Auth
epriestley added a comment to T6703: Allow multiple copies of the same auth provider type.

You can "Award Token".

Mar 16 2016, 2:21 AM · Auth
Krenair awarded T6703: Allow multiple copies of the same auth provider type a Love token.
Mar 16 2016, 2:19 AM · Auth
epriestley closed T10597: Custom Project query results in . url which nginx blocks as Resolved.

We'll consider adding a setup issue if we see other users having issues with this. Previously, we haven't, so we presume users having or uncommenting these blocks in the wild to be very rare.

Mar 16 2016, 2:05 AM · Bug Report

Mar 15 2016

epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

Interesting (and weird). Thanks for the update -- and good luck figuring things out.

Mar 15 2016, 8:54 PM · Infrastructure
epriestley closed T4210: arc diff --create failed to create revision as Resolved.

I'm not immediately able to get --create to bring up a template with "Differential Revision". Here's what I tried:

Mar 15 2016, 6:51 PM · Arcanist
epriestley added a comment to T4210: arc diff --create failed to create revision.

I think we should ideally try to be more clear about the issue when the user passes --create, even if something in range says "Differential Revision: Whatever". That said "a little bit before I look at it" has been like two years now. Let me spend like 5 minutes on it and if it's a big mess we can just write it off.

Mar 15 2016, 6:40 PM · Arcanist
epriestley added a comment to T10588: PhabricatorWorkerActiveTask continuously reports connection error in logs.

The issue you're experiencing is because you're out of date.

Mar 15 2016, 5:02 PM · Installing & Upgrading, Bug Report
epriestley added a comment to T10262: Scramble file secrets when attached objects change their view policies.

In some cases, the effects of the theater can be mitigated issue-by-issue. For example, we may be able to write caching/rendering logic in Javascript to mitigate the performance impact on lightboxes and Pholio. We may be able to attach images directly to email. There may be a workaround for the Safari issue, or we may be able to do preview rendering partially in Javascript. With Quicksand, we can also increase the "hit rate" of client-side Javascript caches, at the cost of additional complexity.

Mar 15 2016, 4:33 PM · Restricted Project, Restricted Project, Wikimedia, Files
epriestley added a comment to T10262: Scramble file secrets when attached objects change their view policies.

I'm strongly resistant to that, see T8227.

Mar 15 2016, 4:00 PM · Restricted Project, Restricted Project, Wikimedia, Files
tvl awarded T7652: Reverse Proxy - cookie issue a Like token.
Mar 15 2016, 3:58 PM · Setup
epriestley added a comment to T10593: test.

(That was a race, not me separately correcting the status, if it wasn't obvious.)

Mar 15 2016, 3:50 PM · Bug Report
epriestley added a comment to T10593: test.

Truly, we have closed this task.

Mar 15 2016, 3:50 PM · Bug Report
epriestley added a comment to T10591: viewing D8084 on this install results in InvalidArgumentException.

That is a cool looking bug.

Mar 15 2016, 3:50 PM · Bug Report
epriestley changed the status of T10593: test from Invalid to Spite.
Mar 15 2016, 3:49 PM · Bug Report
epriestley closed T10591: viewing D8084 on this install results in InvalidArgumentException as Resolved by committing Restricted Diffusion Commit.
Mar 15 2016, 3:19 PM · Bug Report
epriestley closed T10590: Improve usability of autocomplete Textfields without Javascript as Wontfix.

We do not support disabling Javascript and have no plans to improve Phabricator for users who intentionally disable Javascript. These users should enable Javascript if they want to use Phabricator.

Mar 15 2016, 3:18 PM · Feature Request
epriestley added a revision to T10591: viewing D8084 on this install results in InvalidArgumentException: Unknown Object (Differential Revision).
Mar 15 2016, 3:17 PM · Bug Report
epriestley added a comment to T10589: Create useable search experience for Maniphest.

by default, all search terms should be AND'ed instead of OR'ed

Mar 15 2016, 1:21 PM · Feature Request
epriestley added a comment to T10488: support https.blindly-trust-domains in phabricator.

For completeness, note that this opens up a sliver of a DNS rebinding SSRF attack window (see T6755 and T6755#103700 in particular).

Mar 15 2016, 12:53 PM · Restricted Project
epriestley added a comment to T7789: Support Git Large File Storage.

Before I forget:

Mar 15 2016, 12:29 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a parent task for T4369: Phabricator HTTP repository hosting has fairly severe scalability limits: T7789: Support Git Large File Storage.
Mar 15 2016, 12:26 PM · Diffusion (v3), Restricted Project
epriestley added a subtask for T7789: Support Git Large File Storage: T4369: Phabricator HTTP repository hosting has fairly severe scalability limits.
Mar 15 2016, 12:26 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to T7789: Support Git Large File Storage.

Adjacent work:

Mar 15 2016, 12:26 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley updated subscribers of T4369: Phabricator HTTP repository hosting has fairly severe scalability limits.
Mar 15 2016, 12:26 PM · Diffusion (v3), Restricted Project
epriestley merged task T9739: Git push failure over HTTP for large commit (74MB) into T4369: Phabricator HTTP repository hosting has fairly severe scalability limits.
Mar 15 2016, 12:26 PM · Diffusion, Git
epriestley added a comment to T7789: Support Git Large File Storage.

Various notes from prototyping:

Mar 15 2016, 12:17 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to T2383: Run PHP environment checks from CLI.

T10586 is likely a second case (similar to T7248) of a user without mysql or mysqli.

Mar 15 2016, 11:47 AM · Setup
epriestley updated subscribers of T2383: Run PHP environment checks from CLI.
Mar 15 2016, 11:47 AM · Setup
epriestley merged task T10586: Call to undefined function mysql_real_escape_string() into T2383: Run PHP environment checks from CLI.
Mar 15 2016, 11:47 AM · Setup, Bug Report
epriestley added a comment to T10586: Call to undefined function mysql_real_escape_string().

T9640 is tracking PHP7 compatibility. We haven't extensively tested Phabricator on PHP7 yet, but I believe several users are running it without any issues. We're happy to fix issues you encounter with PHP7 if you report them.

Mar 15 2016, 11:46 AM · Setup, Bug Report
epriestley added a comment to T10586: Call to undefined function mysql_real_escape_string().

Is that output from the version of PHP with a problem, or from PHP 5.6.17?

Mar 15 2016, 11:13 AM · Setup, Bug Report
epriestley closed T10587: test as Spite.
Mar 15 2016, 9:51 AM · Database
epriestley added a comment to T10575: Support project tags on Passphrase credentials.

You should be able to do "Visible To: Members of X" already (or use Spaces, even). Tags wouldn't affect visibility.

Mar 15 2016, 2:14 AM · Projects, Passphrase, Feature Request

Mar 14 2016

epriestley added a comment to T10559: Lease Working Copy Hangs on lease failure, but should fail.

(I think that title edit is accurate, let me know if I misunderstood.)

Mar 14 2016, 11:58 PM · Drydock, Bug Report
epriestley renamed T10559: Lease Working Copy Hangs on lease failure, but should fail from Lease Working Copy Hangs to Lease Working Copy Hangs on lease failure, but should fail.
Mar 14 2016, 11:57 PM · Drydock, Bug Report
epriestley added a comment to T5568: Support `.arcunit`, similar to `.arclint`.

@asteinlein, sorry, I missed your earlier question.

Mar 14 2016, 11:51 PM · Unit, Arcanist
epriestley added a comment to T10586: Call to undefined function mysql_real_escape_string().

This probably isn't directly related to PHP7.

Mar 14 2016, 9:40 PM · Setup, Bug Report
epriestley changed the edit policy for Changelog.
Mar 14 2016, 9:25 PM
epriestley edited the content of Changelog.
Mar 14 2016, 9:18 PM
epriestley added a comment to T10586: Call to undefined function mysql_real_escape_string().

Can you show me the output of this command on your system?

Mar 14 2016, 8:33 PM · Setup, Bug Report
epriestley added a comment to T10584: Allow users to amend revisions they don't own, without commandeering them.

It took 6 months before I got my first patch accepted in gerrit.

Mar 14 2016, 6:08 PM · Differential
epriestley added a comment to T10584: Allow users to amend revisions they don't own, without commandeering them.

Maybe notable is that these use cases seem to be completely different from the use cases discussed in D14104 (where "lightweight diffs are probably a plurality, if not majority"). There is also some possible overlap with T6008.

Mar 14 2016, 2:24 PM · Differential
epriestley added a comment to T10584: Allow users to amend revisions they don't own, without commandeering them.

Here's a general outline of a workflow which might satisfy everything without creating the "stomp all over new hires" tension that I want to avoid:

Mar 14 2016, 2:13 PM · Differential
epriestley added a comment to T10584: Allow users to amend revisions they don't own, without commandeering them.

Here's my best effort to summarize downstream use cases for this by reading through https://phabricator.wikimedia.org/T121751 -- let me know if I'm misunderstanding, missing, or misrepresenting anything:

Mar 14 2016, 2:04 PM · Differential
epriestley added a comment to T10584: Allow users to amend revisions they don't own, without commandeering them.

To provide some background and context, we added Commandeer in D2257 to deal with use cases like this:

Mar 14 2016, 12:53 PM · Differential
epriestley added a revision to T10584: Allow users to amend revisions they don't own, without commandeering them: Unknown Object (Differential Revision).
Mar 14 2016, 12:24 PM · Differential
epriestley created T10584: Allow users to amend revisions they don't own, without commandeering them.
Mar 14 2016, 12:24 PM · Differential
• Instinct64 awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Mar 14 2016, 11:49 AM · Workboards (v3), Restricted Project
epriestley awarded T10577: Table of contents on unattached diff view lost a margin a Pterodactyl token.
Mar 14 2016, 3:25 AM · Differential

Mar 13 2016

epriestley closed T10580: People Invites 'Advanced Search' is not very advanced. as Wontfix.

This isn't a bug, there are just no fields available.

Mar 13 2016, 10:32 PM · People, Bug Report
epriestley added a comment to T10576: Wrong highlighting for manually uploaded diff.

I didn't purge the cache here, but here's an updated version of the original diff without the rendering error:

Mar 13 2016, 4:53 PM · XHPAST, Differential, Bug Report
epriestley closed T10576: Wrong highlighting for manually uploaded diff as Resolved.
Mar 13 2016, 4:50 PM · XHPAST, Differential, Bug Report
epriestley added a comment to T10575: Support project tags on Passphrase credentials.

(I did half a diff on tags-on-credentials yesterday but Passphrase uses a couple of unique elements (like a "password" control) that don't currently have field support in EditEngine, so conversion wasn't entirely straightfoward.)

Mar 13 2016, 4:48 PM · Projects, Passphrase, Feature Request
epriestley renamed T10575: Support project tags on Passphrase credentials from Folders or tags for Projects to Support project tags on Passphrase credentials.
Mar 13 2016, 4:47 PM · Projects, Passphrase, Feature Request
epriestley added a comment to T10575: Support project tags on Passphrase credentials.

His reply was sent to everyone on this task (you, me, and himself).

Mar 13 2016, 4:46 PM · Projects, Passphrase, Feature Request
epriestley claimed T10576: Wrong highlighting for manually uploaded diff.
Mar 13 2016, 2:31 PM · XHPAST, Differential, Bug Report
epriestley added a comment to T10578: Provide 'Sort by Points' option in workboards.

This is made difficult by the nature of dragging cards into sorted positions on workboards: if you drag a card between a 5-point task and an 11-point task, we need to give it some number of points between 5 and 11, break the sort order of the column, or fling the card to the correct position in the column, which may be offscreen. Currently, in the simpler case of priority sorts, users don't seem to expect any of these behaviors, and all of these interactions are confusing to some users (today, we change priority).

Mar 13 2016, 2:29 PM · Workboards (v3), Feature Request
epriestley added a comment to T10576: Wrong highlighting for manually uploaded diff.

Thanks, that test case was very helpful.

Mar 13 2016, 2:17 PM · XHPAST, Differential, Bug Report
epriestley added a revision to T10576: Wrong highlighting for manually uploaded diff: Unknown Object (Differential Revision).
Mar 13 2016, 2:07 PM · XHPAST, Differential, Bug Report
epriestley created T10577: Table of contents on unattached diff view lost a margin.
Mar 13 2016, 12:54 PM · Differential
epriestley added a comment to T10575: Support project tags on Passphrase credentials.

Being rude isn't a good way to attract people to a product.

Mar 13 2016, 12:51 PM · Projects, Passphrase, Feature Request

Mar 12 2016

epriestley added a comment to T10575: Support project tags on Passphrase credentials.

or through Pholio

Mar 12 2016, 9:46 PM · Projects, Passphrase, Feature Request
epriestley edited the content of Changelog.
Mar 12 2016, 7:31 PM
epriestley edited the content of Changelog.
Mar 12 2016, 7:31 PM
epriestley edited the content of 2016 Week 11 (Mid March).
Mar 12 2016, 7:31 PM