Page MenuHomePhabricator
Feed Advanced Search

Jun 9 2015

joshuaspence awarded T8479: PHPExcel requires XMLWriter Extension a Pterodactyl token.
Jun 9 2015, 8:02 AM · Maniphest
joshuaspence created T8481: Storing secret file in paste.
Jun 9 2015, 7:19 AM · Passphrase, Paste

Jun 8 2015

joshuaspence created T8477: `./bin/storage probe` truncate table names.
Jun 8 2015, 9:09 PM · Infrastructure
joshuaspence added a comment to T8473: Garbage collect old notifications.

On our install, this data is ~250MB.

Jun 8 2015, 9:08 PM · Notifications
joshuaspence triaged T8476: Rename `phabricator_repository` database as Low priority.
Jun 8 2015, 9:06 PM · Restricted Project, Database, Diffusion
joshuaspence created T8476: Rename `phabricator_repository` database.
Jun 8 2015, 9:05 PM · Restricted Project, Database, Diffusion
joshuaspence created T8475: Clean up remnants of old Differential hunk storage.
Jun 8 2015, 9:01 PM · Infrastructure, Restricted Project, Differential
joshuaspence added a comment to T8474: Fix linter severity customization.

I started working on this in D13094, but it's nowhere near finished.

Jun 8 2015, 8:58 PM · Lint
epriestley awarded T8474: Fix linter severity customization a Haypence token.
Jun 8 2015, 8:57 PM · Lint
joshuaspence claimed T8474: Fix linter severity customization.
Jun 8 2015, 8:48 PM · Lint
joshuaspence triaged T8474: Fix linter severity customization as Normal priority.
Jun 8 2015, 8:48 PM · Lint
joshuaspence created T8474: Fix linter severity customization.
Jun 8 2015, 8:48 PM · Lint
joshuaspence added a project to T8468: No conpherence user documentation: Documentation.
Jun 8 2015, 8:39 PM · Documentation, Conpherence
joshuaspence added a comment to T8462: Move object destruction to taskmaster daemons.

I don't, but it maybe stops bad things from happening in cases where destruction takes a bad time? I was destroying a Diviner book and it took a long time so I ^Ced it and ran it again with --trace. I wasn't too worried in this case because Diviner books don't utilize a lot of infrastructure. But for other objects, this could be problematic maybe?

Jun 8 2015, 8:04 PM · Infrastructure, Daemons
joshuaspence created T8462: Move object destruction to taskmaster daemons.
Jun 8 2015, 2:45 AM · Infrastructure, Daemons
joshuaspence closed T8433: Destroying a Diviner book is very slow as Resolved by committing Restricted Diffusion Commit.
Jun 8 2015, 1:30 AM · Diviner

Jun 7 2015

joshuaspence added a comment to T8454: User approval not working.

The approval queue is fixed, but it still doesn't log in the new user correctly:

Jun 7 2015, 11:02 AM · People

Jun 5 2015

joshuaspence created T8454: User approval not working.
Jun 5 2015, 11:28 PM · People
joshuaspence added a comment to T8376: Develop Spaces (v1).

Thanks, good explanation.

Jun 5 2015, 11:12 PM · Prioritized, Policy, Wikimedia, Spaces
joshuaspence added a comment to T8376: Develop Spaces (v1).

What's the difference between putting something in a space and setting the visibility of an object to "members of some project"?

Jun 5 2015, 10:56 PM · Prioritized, Policy, Wikimedia, Spaces
joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Jun 5 2015, 11:03 AM · libphutil, Arcanist
joshuaspence updated subscribers of T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges.
Jun 5 2015, 10:42 AM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
joshuaspence merged task T8435: How to get all commits attached to a task via conduit into T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges.
Jun 5 2015, 10:42 AM · Conduit
joshuaspence added a revision to T8433: Destroying a Diviner book is very slow: Unknown Object (Differential Revision).
Jun 5 2015, 7:51 AM · Diviner
joshuaspence created T8433: Destroying a Diviner book is very slow.
Jun 5 2015, 12:05 AM · Diviner

Jun 4 2015

joshuaspence closed T7458: Diviner should integrate with main search, a subtask of T4558: Make Diviner useful for third-parties, as Resolved.
Jun 4 2015, 10:07 PM · Diviner
joshuaspence closed T7458: Diviner should integrate with main search as Resolved by committing Restricted Diffusion Commit.
Jun 4 2015, 10:07 PM · Diviner
joshuaspence created T8430: Support emoticons.
Jun 4 2015, 9:45 PM · Restricted Project, Remarkup
joshuaspence added a comment to T4245: Make repository URIs slightly prettier.

Can we get a fund initiative for making Fund work like Kickstarter? :P

Jun 4 2015, 9:43 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
joshuaspence closed T8401: Unable to query Diviner atoms by PHID as Resolved by committing Restricted Diffusion Commit.
Jun 4 2015, 9:23 PM · Diviner
joshuaspence added a revision to T8401: Unable to query Diviner atoms by PHID: Unknown Object (Differential Revision).
Jun 4 2015, 9:04 PM · Diviner
joshuaspence added a comment to T8401: Unable to query Diviner atoms by PHID.

@epriestley, could we simply invert the logic of DivinerAtomQuery so that it returns undocumentable atoms by default (and add withExcludeUndocumentable(true) to all existing callsites?

Jun 4 2015, 8:53 PM · Diviner
joshuaspence created T8415: Transaction requires a handle that it did not load.
Jun 4 2015, 7:33 AM · Transactions
joshuaspence added a comment to T8401: Unable to query Diviner atoms by PHID.

https://secure.phabricator.com/differential/diff/31781/ seems to fix this, although I doubt this is the correct solution.

Jun 4 2015, 7:31 AM · Diviner
joshuaspence added a comment to T8401: Unable to query Diviner atoms by PHID.

Adding PhutilArgumentParser and --trace gives me the following output:

Jun 4 2015, 7:21 AM · Diviner

Jun 3 2015

joshuaspence added a project to T8404: Running the cpplint linter through arcanist no longer works: Lint.
Jun 3 2015, 11:29 PM · Lint, Arcanist
joshuaspence created T8401: Unable to query Diviner atoms by PHID.
Jun 3 2015, 9:08 PM · Diviner
joshuaspence added a revision to T4558: Make Diviner useful for third-parties: Unknown Object (Differential Revision).
Jun 3 2015, 1:19 PM · Diviner
joshuaspence added a project to T8396: projects autofill text box: Typeahead.
Jun 3 2015, 1:16 PM · Typeahead
joshuaspence added a project to T8397: application context is ignored: Maniphest.
Jun 3 2015, 1:16 PM · Maniphest
joshuaspence added a comment to T8380: Queueing search indexers is very slow.

Looks like --background is six times faster though: https://secure.phabricator.com/xhprof/profile/PHID-FILE-zy56ub2hhqqmrsgelvdl/

Jun 3 2015, 12:00 AM · Search

Jun 2 2015

joshuaspence added a revision to T8042: PhutilUnitTestEngine can't execute a single test path: Unknown Object (Differential Revision).
Jun 2 2015, 9:16 PM · Arcanist
joshuaspence added a comment to T8380: Queueing search indexers is very slow.

Here's a profile: https://secure.phabricator.com/xhprof/profile/PHID-FILE-6qploks2cyzbwune3vki/

Jun 2 2015, 8:57 PM · Search
joshuaspence closed T8379: ArcanistFormattedStringXHPASTLinterRule fails as Resolved by committing Restricted Diffusion Commit.
Jun 2 2015, 12:13 PM · Lint, XHPAST
joshuaspence added a revision to T8379: ArcanistFormattedStringXHPASTLinterRule fails: Unknown Object (Differential Revision).
Jun 2 2015, 12:06 PM · Lint, XHPAST
joshuaspence added a comment to T8165: Investigate high CPU usage.

cache.png (469×1 px, 54 KB)

Jun 2 2015, 12:02 PM · Performance
joshuaspence added a comment to T8379: ArcanistFormattedStringXHPASTLinterRule fails.

The same thing applies to ArcanistDuplicateKeysInArrayXHPASTLinterRule.

Jun 2 2015, 8:50 AM · Lint, XHPAST
joshuaspence closed T8383: User reporting empty comment-action dropdown as Invalid.

Nevermind, this was some weird local issue.

Jun 2 2015, 7:59 AM · Differential
joshuaspence added a comment to T8383: User reporting empty comment-action dropdown.

OK. Apparently it also happens on this install as well.

Jun 2 2015, 6:55 AM · Differential
joshuaspence added a comment to T8383: User reporting empty comment-action dropdown.

This happens in Maniphest as well.

Jun 2 2015, 6:53 AM · Differential
joshuaspence added a comment to T8383: User reporting empty comment-action dropdown.

The user's user agent string is Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.81 Safari/537.36

Jun 2 2015, 6:52 AM · Differential
joshuaspence created T8383: User reporting empty comment-action dropdown.
Jun 2 2015, 6:51 AM · Differential
joshuaspence added a comment to T8165: Investigate high CPU usage.

I turned on XHPROF sampling and grabbed some data:

Jun 2 2015, 6:23 AM · Performance
joshuaspence added a comment to T8380: Queueing search indexers is very slow.

Sorta... My issue isn't that indexing ElasticSearch is slow, rather my issue is that queueing tasks into the daemons seems to be slow (this shouldn't be touching ElasticSearch, also I believe this issue existed when we were using MySQL indexes as well).

Jun 2 2015, 2:54 AM · Search
joshuaspence added a comment to T8380: Queueing search indexers is very slow.

It might be worth noting that I am running the ./bin/search index command on the same machine that is running our daemons.

Jun 2 2015, 12:38 AM · Search
joshuaspence created T8380: Queueing search indexers is very slow.
Jun 2 2015, 12:38 AM · Search

Jun 1 2015

joshuaspence claimed T8379: ArcanistFormattedStringXHPASTLinterRule fails.
Jun 1 2015, 9:43 PM · Lint, XHPAST
joshuaspence created T8379: ArcanistFormattedStringXHPASTLinterRule fails.
Jun 1 2015, 9:42 PM · Lint, XHPAST
joshuaspence placed T8331: phlog can be improved up for grabs.

Having a look at this and I can't actually remember what the issue is.

Jun 1 2015, 1:17 PM · Infrastructure
joshuaspence closed T7603: Remove the deprecated "Repositories" application as Resolved by committing Restricted Diffusion Commit.
Jun 1 2015, 5:40 AM · Repositories, Diffusion
avivey awarded T8370: Index "TODO" comments and other references present in source code a Like token.
Jun 1 2015, 4:42 AM · Transactions, Diffusion
joshuaspence added a comment to T4558: Make Diviner useful for third-parties.

Diviner updates over Conduit would be awesome!

Jun 1 2015, 2:16 AM · Diviner
joshuaspence created T8370: Index "TODO" comments and other references present in source code.
Jun 1 2015, 2:15 AM · Transactions, Diffusion
joshuaspence added a comment to T4558: Make Diviner useful for third-parties.

(There's also a uri.source in Books which should probably get an implicit value if the repository is set but uri.source is not.)

Jun 1 2015, 2:10 AM · Diviner
joshuaspence added a comment to T8345: Add task tabs for "Mentions" and "Merged".

Yeah, it definitely is a weaker relationship than the current "blocking tasks" relationship. FWIW, I think that JIRA has a "related issue" field (I could be wrong, I've never actually used JIRA).

Jun 1 2015, 2:08 AM · Restricted Project, FreeBSD, Maniphest
joshuaspence added a comment to T4558: Make Diviner useful for third-parties.

Some things that are maybe worthwhile (in addition to the blocked tasks):

Jun 1 2015, 2:05 AM · Diviner
joshuaspence added subtasks for T4558: Make Diviner useful for third-parties: T823: Add image support to Diviner, T6310: Parameters description is not Remarkuped, T5792: Allow Diviner documentation to be generated with Harbormaster + Drydock, T7101: Allow creating links to books, T8311: Allow Diviner to import documentation.
Jun 1 2015, 1:57 AM · Diviner
joshuaspence added a parent task for T8311: Allow Diviner to import documentation: T4558: Make Diviner useful for third-parties.
Jun 1 2015, 1:57 AM · Diviner
joshuaspence added a parent task for T5792: Allow Diviner documentation to be generated with Harbormaster + Drydock: T4558: Make Diviner useful for third-parties.
Jun 1 2015, 1:57 AM · Harbormaster, Diviner
joshuaspence added a parent task for T7101: Allow creating links to books: T4558: Make Diviner useful for third-parties.
Jun 1 2015, 1:57 AM · Diviner
joshuaspence added a parent task for T823: Add image support to Diviner: T4558: Make Diviner useful for third-parties.
Jun 1 2015, 1:57 AM · Diviner
joshuaspence added a parent task for T6310: Parameters description is not Remarkuped: T4558: Make Diviner useful for third-parties.
Jun 1 2015, 1:57 AM · Remarkup, Diviner
joshuaspence added a revision to T4558: Make Diviner useful for third-parties: Unknown Object (Differential Revision).
Jun 1 2015, 1:35 AM · Diviner
joshuaspence added a comment to T8345: Add task tabs for "Mentions" and "Merged".

If it were to be automagic, there should at least be a way to remove related tasks... For example, someone might say This is related to T123 and receive a reply of No, this is a separate issue. In this case, we should be able to remove T123 from the "automagic related tasks" field.

Jun 1 2015, 1:34 AM · Restricted Project, FreeBSD, Maniphest
joshuaspence added a revision to T7458: Diviner should integrate with main search: Unknown Object (Differential Revision).
Jun 1 2015, 1:32 AM · Diviner
joshuaspence added a comment to T8352: Link Diviner books to repositories.

Would it be valuable to record the repositoryPHID for DivinerLiveSymbol / DivinerLiveAtom as well? Furthermore, are you able to explain the distinction between these two classes.

Jun 1 2015, 12:30 AM · Diviner

May 31 2015

joshuaspence added a comment to T2614: Show Arcanist project in Differential's list of revisions.

T7604 removes the "Arcanist Project" field, but we could show the repository instead.

May 31 2015, 8:41 AM · Differential
joshuaspence awarded T2683: Improve the performance of Diffusion browse views a Manufacturing Defect? token.
May 31 2015, 6:41 AM · Diffusion
joshuaspence awarded T2794: Implement Phage (like Hypershell) a Love token.
May 31 2015, 6:20 AM · Phage, Infrastructure
joshuaspence edited projects for T2806: Document fetchmail/procmail as inbound mail options, added: Documentation, Mail; removed Maniphest, Diviner.
May 31 2015, 6:04 AM · Mail, Documentation
joshuaspence updated subscribers of T8238: Formally support side-band change handoff in external repositories.

@hach-que, this is what you were asking about in IRC.

May 31 2015, 3:42 AM · Restricted Project, Restricted Project, Diffusion, Harbormaster
joshuaspence added a revision to T8156: Linter failures don't provide relevant stacktraces: Unknown Object (Differential Revision).
May 31 2015, 2:44 AM · Arcanist, Lint
joshuaspence updated the task description for T8366: Task references in a code block creates a transaction.
May 31 2015, 2:32 AM · Transactions
joshuaspence updated the task description for T8366: Task references in a code block creates a transaction.
May 31 2015, 2:32 AM · Transactions
joshuaspence added a comment to T8366: Task references in a code block creates a transaction.

I've changed the test plan of D13066 now, but here is the original text that triggered the transaction being created:

May 31 2015, 2:13 AM · Transactions
joshuaspence created T8366: Task references in a code block creates a transaction.
May 31 2015, 2:04 AM · Transactions
joshuaspence added a revision to T8042: PhutilUnitTestEngine can't execute a single test path: Unknown Object (Differential Revision).
May 31 2015, 2:01 AM · Arcanist
joshuaspence added a comment to T8363: Include reply action ("!action") hints in outbound email.

The issue is that I always forget to learn how to use this functionality until I want to respond to an email and then its too late.

May 31 2015, 1:28 AM · llvm, Restricted Project, Mail

May 30 2015

joshuaspence added a subtask for T4558: Make Diviner useful for third-parties: T8364: Remarkup isn't rendered.
May 30 2015, 7:41 AM · Diviner
joshuaspence added a parent task for T8364: Remarkup isn't rendered: T4558: Make Diviner useful for third-parties.
May 30 2015, 7:41 AM · Diviner
joshuaspence created T8364: Remarkup isn't rendered.
May 30 2015, 7:41 AM · Diviner
joshuaspence claimed T3626: Detection of language for some file types isn't good.
May 30 2015, 6:37 AM · Customer Impact, Restricted Project, Differential
joshuaspence added a revision to T8352: Link Diviner books to repositories: Unknown Object (Differential Revision).
May 30 2015, 12:08 AM · Diviner

May 29 2015

joshuaspence created T8363: Include reply action ("!action") hints in outbound email.
May 29 2015, 11:31 PM · llvm, Restricted Project, Mail
joshuaspence added a comment to T8348: `arc download` doesn't support chunked downloads.

I have no idea why this works through the web UI...

May 29 2015, 10:58 PM · Restricted Project, Files, Arcanist
joshuaspence added a comment to T8007: Commit was associated with unrelated diff.

This happened again today (for my own future reference, see D20770 on our install).

May 29 2015, 12:16 PM · Differential, Diffusion
joshuaspence added a subtask for T4558: Make Diviner useful for third-parties: T7458: Diviner should integrate with main search.
May 29 2015, 11:51 AM · Diviner
joshuaspence added a parent task for T7458: Diviner should integrate with main search: T4558: Make Diviner useful for third-parties.
May 29 2015, 11:51 AM · Diviner
joshuaspence claimed T7458: Diviner should integrate with main search.
May 29 2015, 11:51 AM · Diviner
joshuaspence added a subtask for T4558: Make Diviner useful for third-parties: T8352: Link Diviner books to repositories.
May 29 2015, 11:50 AM · Diviner