Page MenuHomePhabricator

Task references in a code block creates a transaction
Open, Needs TriagePublic

Description

See D13066#136978. In my test plan, the text Fixes T8042 appeared in a code block. This caused a transaction to be added to revision, which was not expected.

Event Timeline

joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added a subscriber: joshuaspence.

I've changed the test plan of D13066 now, but here is the original text that triggered the transaction being created:

> echo '{"ids": [1]}' | arc --conduit-uri='http://phabricator.local' call-conduit differential.getrevisiontransactions{"error":null,"errorMessage":null,"response":{"1":[{"revisionID":"1","transactionPHID":"PHID-XACT-DREV-3ky27dskqgm7olm","transactionType":"core:comment","oldValue":null,"newValue":null,"comments":"test","authorPHID":"PHID-USER-t2codh7fptz7kambtqja","dateCreated":"1432872808"},{"revisionID":"1","transactionPHID":"PHID-XACT-DREV-vatzg7h2wgqtgvf","transactionType":"core:customfield","oldValue":null,"newValue":"Added some unit tests.","comments":null,"authorPHID":"PHID-USER-t2codh7fptz7kambtqja","dateCreated":"1432872777"},{"revisionID":"1","transactionPHID":"PHID-XACT-DREV-cu4o5tmapyjm7hy","transactionType":"core:customfield","oldValue":null,"newValue":"Fixes T8042. Changes the way that `PhutilUnitTestEngine` discovers unit tests. In particular, if you only modify a single test case then there is no reason to run all other test cases within the same directory (which is the current behavior).","comments":null,"authorPHID":"PHID-USER-t2codh7fptz7kambtqja","dateCreated":"1432872777"},{"revisionID":"1","transactionPHID":"PHID-XACT-DREV-t4comgio46ldswu","transactionType":"core:customfield","oldValue":"","newValue":"Allow PhutilUnitTestEngine to execute tests from a single path","comments":null,"authorPHID":"PHID-USER-t2codh7fptz7kambtqja","dateCreated":"1432872777"},{"revisionID":"1","transactionPHID":"PHID-XACT-DREV-r7it7bs5wemd5o3","transactionType":"differential:update","oldValue":null,"newValue":"PHID-DIFF-uv2jmbypa3imjeggh3hl","comments":null,"authorPHID":"PHID-USER-t2codh7fptz7kambtqja","dateCreated":"1432872777"}]}}