See P1793. The exception information should by doing phlog($ex) is not very useful and can be improved. Some discussion in IRC (https://secure.phabricator.com/chatlog/channel/6/?at=201457).
Description
Description
Revisions and Commits
Revisions and Commits
| rPHU libphutil | |||
| D13150 | rPHU4a0e1b47a584 Improve the stack traces from phlog($exception) | ||
Related Objects
Related Objects
- Mentioned In
- T8372: Resource cache
- Mentioned Here
- P1793 (An Untitled Masterwork)
Event Timeline
Comment Actions
I think it was that phlog($ex) gives us the stack trace of the phlog() call, but if we have to pick one stack trace, the stack trace of the exception is more useful.
Given that we now do OK stuff for proxy/aggregate exceptions, maybe the best trace would be:
$proxy = new PhutilProxyException('phlog', $ex);
$trace = PhutilErrorHandler::getExceptionTrace($proxy);I think that will give us a reasonable combined trace that helps identify both stacks.