Page MenuHomePhabricator

ArcanistFormattedStringXHPASTLinterRule fails
Closed, ResolvedPublic

Description

D13031 changed the criteria for strings which can be evaluated statically. As a result, ArcanistFormattedStringXHPASTLinterRule now fails (throws an exception) on the following text:

printf("  % {$width}d  %s\n", $idx + 1, $line);

A simple solution would be to revert rPHUa9e581f6488fd7db83d4c02edee64db9b1cd3ef9, but maybe we can just fix this somehow.

Revisions and Commits

Restricted Differential Revision

Event Timeline

joshuaspence claimed this task.
joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added projects: XHPAST, Lint.
joshuaspence added a subscriber: joshuaspence.

The same thing applies to ArcanistDuplicateKeysInArrayXHPASTLinterRule.

joshuaspence added a revision: Restricted Differential Revision.Jun 2 2015, 12:06 PM
joshuaspence closed this task as Resolved by committing Restricted Diffusion Commit.Jun 2 2015, 12:13 PM
joshuaspence added a commit: Restricted Diffusion Commit.