Page MenuHomePhabricator
Feed Advanced Search

Apr 28 2015

epriestley closed T7976: Nested ol's are hard to parse visually as Resolved.

Presumably resolved.

Apr 28 2015, 5:38 PM · Remarkup
epriestley awarded T7444: Code block header styling a Orange Medal token.
Apr 28 2015, 5:30 PM · Design, Remarkup
epriestley added a comment to T7444: Code block header styling.

Nice, I like that.

Apr 28 2015, 5:30 PM · Design, Remarkup
epriestley added a comment to T7935: Give calendar events real invitee lists.

I think invitees are complex enough that we probably don't want to use edges to store them. Edges are good for simple relationships (like a user subscribing to an object) but not as good for more complex relationships. Invitees are likely to have a lot of state eventually (required/optional, invited/attending/declined, maybe annotations like "Speaker" for a talk, "Co-Host" for a party, or "Bringing Salad" vs "Bringing Desert" for a potluck, maybe tracking who invited you, and so on).

Apr 28 2015, 5:29 PM · Calendar
epriestley added a comment to T7975: Calendar icons show through dialogs.

From elsewhere, I think it's so that they're visible in dialogs (like "Edit Task" from a workboard with a custom date field).

Apr 28 2015, 4:33 PM · Calendar
epriestley closed T7972: Starting with 7f43cde, DiffusionRequest resolveRefs fails (only cached entries work) as Resolved by committing Restricted Diffusion Commit.
Apr 28 2015, 3:56 PM · Diffusion
epriestley claimed T7972: Starting with 7f43cde, DiffusionRequest resolveRefs fails (only cached entries work).
Apr 28 2015, 3:07 PM · Diffusion
epriestley closed T7971: large file upload OOMs as Resolved.

Yeah, this should be fixed at HEAD for most workflows, see:

Apr 28 2015, 3:06 PM · Files
epriestley added a revision to T7972: Starting with 7f43cde, DiffusionRequest resolveRefs fails (only cached entries work): Unknown Object (Differential Revision).
Apr 28 2015, 3:03 PM · Diffusion
epriestley added a comment to T4131: Store LDAP domain as credential source for LDAP external accounts.

escalate from that to any other account

Apr 28 2015, 2:44 PM · Auth, Security
epriestley added a comment to T7971: large file upload OOMs.

Are you at HEAD?

Apr 28 2015, 2:27 PM · Files
epriestley added a comment to T4131: Store LDAP domain as credential source for LDAP external accounts.

No -- you point Phabricator at the new LDAP server by using a compromised administrative account and going to Auth → LDAP and changing ldap.mycompany.com to ldap.evil.com.

Apr 28 2015, 2:23 PM · Auth, Security
epriestley added a revision to T3165: Provide Search in Conpherence: Unknown Object (Differential Revision).
Apr 28 2015, 1:45 PM · Conpherence (v4)
epriestley added a revision to T3165: Provide Search in Conpherence: Unknown Object (Differential Revision).
Apr 28 2015, 11:24 AM · Conpherence (v4)

Apr 27 2015

epriestley added a comment to T3165: Provide Search in Conpherence.

Yep, thanks!

Apr 27 2015, 11:41 PM · Conpherence (v4)
epriestley claimed T6038: Design some kind of PHUITagChainView.
Apr 27 2015, 10:49 PM · Design
epriestley added a comment to T7963: Wiki heading CSS emphasizes sub-headings over headings.

See T4213 for discussion of themes/skinning, and an explanation of why we don't expose CSS/HTML as an API.

Apr 27 2015, 10:27 PM · Restricted Project
epriestley added a comment to T7963: Wiki heading CSS emphasizes sub-headings over headings.

I think our use cases are pretty much the same, the documents are just laid out a bit differently.

Apr 27 2015, 10:10 PM · Restricted Project
epriestley added a comment to T7963: Wiki heading CSS emphasizes sub-headings over headings.

I do think the weight and blackness of the subheadings can overwhelm headings a bit, for instance on the Changelog:

Apr 27 2015, 10:00 PM · Restricted Project
epriestley triaged T7961: In Herald, don't offer Fields and Actions from uninstalled applications to users writing rules as Wishlist priority.
Apr 27 2015, 8:49 PM · Applications, Herald
epriestley reopened T7484: Lock is not locked by this process as "Open".

Not sure this is fixed yet.

Apr 27 2015, 5:27 PM · Restricted Project, Daemons
epriestley closed T6958: Make cause/resolution for PhutilLockException during repository import more clear as Resolved by committing Restricted Diffusion Commit.
Apr 27 2015, 5:25 PM · Daemons
epriestley closed T7484: Lock is not locked by this process as Resolved by committing Restricted Diffusion Commit.
Apr 27 2015, 5:25 PM · Restricted Project, Daemons
epriestley created T7960: Jumping to symbols from Differential doesn't work well on mobile.
Apr 27 2015, 5:22 PM · Symbols, Mobile, Differential
btrahan awarded T7955: Publish feed events from Calendar a Piece of Eight token.
Apr 27 2015, 5:16 PM · Transactions, Calendar
epriestley added a comment to T7959: Mercurial doesn't store HTTP passwords in config anymore.

Example working hgrc:

Apr 27 2015, 4:19 PM · Diffusion, Mercurial
epriestley created T7959: Mercurial doesn't store HTTP passwords in config anymore.
Apr 27 2015, 4:16 PM · Diffusion, Mercurial
epriestley closed T7915: Logged out search dropdown... unneeded? as Resolved by committing Restricted Diffusion Commit.
Apr 27 2015, 3:15 PM · Search
epriestley added a comment to T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads).

I think hg branches just picks one head to show when there are multiple heads of a branch. For example, if you're on rev 9 and hg up 8, then make a commit (creating a second local branch head for default), the hg branches command still shows only one head, even though your working copy has multiple open heads of the branch.

Apr 27 2015, 2:51 PM · Diffusion
epriestley added a comment to T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads).

I'm guessing hg heads -c will also show them.

Apr 27 2015, 2:44 PM · Diffusion
epriestley added a comment to T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads).

Does hg log --rev 'head()' give you the other heads?

Apr 27 2015, 2:41 PM · Diffusion
epriestley added a comment to T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads).

I think this is in mostly reasonable shape now, but let us know if there are still issues.

Apr 27 2015, 2:32 PM · Diffusion
epriestley added a revision to T6958: Make cause/resolution for PhutilLockException during repository import more clear: Unknown Object (Differential Revision).
Apr 27 2015, 2:22 PM · Daemons
epriestley added a revision to T7484: Lock is not locked by this process: Unknown Object (Differential Revision).
Apr 27 2015, 2:22 PM · Restricted Project, Daemons
epriestley added a subtask for T6004: When moving a wiki page with subpages prompt to also move subpages: T5166: Expand the BulkJob tool.
Apr 27 2015, 1:35 PM · Phriction
epriestley added a parent task for T5166: Expand the BulkJob tool: T6004: When moving a wiki page with subpages prompt to also move subpages.
Apr 27 2015, 1:35 PM · Restricted Project, Phacility, Daemons
epriestley added a comment to T7915: Logged out search dropdown... unneeded?.

We can eventually add some sort of temporary preferences for logged-out users to make this sticky for them.

Apr 27 2015, 12:41 PM · Search
epriestley added a revision to T7915: Logged out search dropdown... unneeded?: Unknown Object (Differential Revision).
Apr 27 2015, 12:40 PM · Search
epriestley added a comment to T5464: Use ApplicationTransactions in Calendar.

I made that explicit in T7955, although we probably need to let you name events (T7953) first or the stories are going to be pretty iffy.

Apr 27 2015, 11:07 AM · Calendar, Transactions
epriestley added a parent task for T5464: Use ApplicationTransactions in Calendar: T7957: Implement mail in Calendar, with reply handling.
Apr 27 2015, 11:03 AM · Calendar, Transactions
epriestley added subtasks for T7957: Implement mail in Calendar, with reply handling: T5464: Use ApplicationTransactions in Calendar, T7956: Support commenting on Calendar events.
Apr 27 2015, 11:03 AM · Calendar
epriestley added a parent task for T7956: Support commenting on Calendar events: T7957: Implement mail in Calendar, with reply handling.
Apr 27 2015, 11:03 AM · Calendar
epriestley created T7957: Implement mail in Calendar, with reply handling.
Apr 27 2015, 11:02 AM · Calendar
epriestley created T7956: Support commenting on Calendar events.
Apr 27 2015, 11:02 AM · Calendar
epriestley added a subtask for T7955: Publish feed events from Calendar: T5464: Use ApplicationTransactions in Calendar.
Apr 27 2015, 11:00 AM · Transactions, Calendar
epriestley added a parent task for T5464: Use ApplicationTransactions in Calendar: T7955: Publish feed events from Calendar.
Apr 27 2015, 11:00 AM · Calendar, Transactions
epriestley added a subtask for T7955: Publish feed events from Calendar: T7953: Give calendar events names.
Apr 27 2015, 11:00 AM · Transactions, Calendar
epriestley added a parent task for T7953: Give calendar events names: T7955: Publish feed events from Calendar.
Apr 27 2015, 11:00 AM · Calendar
epriestley added a parent task for T7955: Publish feed events from Calendar: T7926: Modernize Calendar Infrastructure.
Apr 27 2015, 11:00 AM · Transactions, Calendar
epriestley added a subtask for T7926: Modernize Calendar Infrastructure: T7955: Publish feed events from Calendar.
Apr 27 2015, 11:00 AM · Calendar
epriestley removed a subtask for T5464: Use ApplicationTransactions in Calendar: T7955: Publish feed events from Calendar.
Apr 27 2015, 10:59 AM · Calendar, Transactions
epriestley removed a parent task for T7955: Publish feed events from Calendar: T5464: Use ApplicationTransactions in Calendar.
Apr 27 2015, 10:59 AM · Transactions, Calendar
epriestley created T7955: Publish feed events from Calendar.
Apr 27 2015, 10:59 AM · Transactions, Calendar
epriestley closed T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads) as Resolved by committing Restricted Diffusion Commit.
Apr 27 2015, 10:51 AM · Diffusion
epriestley closed T6160: Don't show closed branches of mercurial repository as Resolved by committing Restricted Diffusion Commit.
Apr 27 2015, 10:51 AM · Mercurial, Diffusion

Apr 26 2015

epriestley closed T7480: Allow editing the name of a file as Resolved by committing Restricted Diffusion Commit.
Apr 26 2015, 10:30 PM · Files
epriestley added a parent task for T5464: Use ApplicationTransactions in Calendar: T7953: Give calendar events names.
Apr 26 2015, 9:36 PM · Transactions, Calendar
epriestley added a subtask for T7953: Give calendar events names: T5464: Use ApplicationTransactions in Calendar.
Apr 26 2015, 9:36 PM · Calendar
epriestley created T7953: Give calendar events names.
Apr 26 2015, 9:36 PM · Calendar
epriestley added a comment to T5464: Use ApplicationTransactions in Calendar.

ApplicationTransactions is the infrastructure component which creates edit logs, supports comments, and enables a lot of additional features for free or nearly-free. The major components are:

Apr 26 2015, 9:20 PM · Transactions, Calendar
epriestley added a comment to T7945: Support Edges in Calendar.
  • Create a new autopatch similar to resources/sql/autopatches/20141104.almanac.3.edge.sql to add the edge tables to Calendar.
  • Create a PhabricatorCalendarSchemaSpec similar to AlmanacSchemaSpec so Phabricator knows the table is supposed to exist.
Apr 26 2015, 9:09 PM · Calendar
epriestley added a comment to T7928: Give Calendar events the "E" Monogram.

Here are some pointers on approaching this:

Apr 26 2015, 9:05 PM · Calendar
epriestley added a comment to T7924: Unprototype Calendar (v1).

Most of this is blocked by T5464, which is large and complex. A reasonable implementation path which might make sense overall while letting you ease into things without tackling T5464 right away is:

Apr 26 2015, 9:00 PM · Restricted Project, Prioritized, Calendar
epriestley closed T7497: "Create Application" should be greyed out if not allowed by policy as Resolved by committing Restricted Diffusion Commit.
Apr 26 2015, 7:51 PM · OAuthServer
epriestley closed T7499: "New Build Plan" should be greyed out if not allowed by policy as Resolved by committing Restricted Diffusion Commit.
Apr 26 2015, 7:45 PM · Policy, Harbormaster
epriestley added a comment to T7499: "New Build Plan" should be greyed out if not allowed by policy.

It should setDisabled() + setWorkflow(); the former will grey it out (T7507 already had that part). Overall behavior should be the same.

Apr 26 2015, 7:21 PM · Policy, Harbormaster
epriestley closed T7493: Buttons are not consistently greyed out in Passphrase as Resolved by committing Restricted Diffusion Commit.
Apr 26 2015, 7:17 PM · Passphrase
epriestley closed T7507: Should return to previous page after clicking "OK" as Resolved by committing Restricted Diffusion Commit.
Apr 26 2015, 7:01 PM · Policy
epriestley added a comment to T1460: Add "Done" link to an inline comment.

See T7447.

Apr 26 2015, 6:05 PM · User Delight, Differential
epriestley updated subscribers of T7447: Bring inline comments forward across revision updates.

@asteinlein, this is the task for porting comments across diffs.

Apr 26 2015, 6:05 PM · Prioritized, Differential
epriestley placed T6856: Make Project Images that match Typeahead choices up for grabs.
Apr 26 2015, 5:58 PM · Design, Projects
epriestley placed T3578: Unbeta Ponder up for grabs.
Apr 26 2015, 5:58 PM · Ponder
epriestley edited the content of Changelog.
Apr 26 2015, 5:48 PM
epriestley edited the content of Changelog.
Apr 26 2015, 5:41 PM
epriestley edited the content of Changelog.
Apr 26 2015, 5:40 PM
epriestley edited the content of Changelog.
Apr 26 2015, 5:37 PM
epriestley edited the content of Changelog.
Apr 26 2015, 5:35 PM
epriestley edited the content of Changelog.
Apr 26 2015, 5:28 PM
epriestley edited the content of Changelog.
Apr 26 2015, 5:27 PM
epriestley edited the content of Changelog.
Apr 26 2015, 5:22 PM
epriestley edited the content of Changelog.
Apr 26 2015, 5:19 PM
epriestley edited the content of Changelog.
Apr 26 2015, 5:15 PM
epriestley created 2015-04 April.
Apr 26 2015, 3:03 PM
epriestley triaged T5045: Use Calendar to Display Query Results as Wishlist priority.
Apr 26 2015, 2:28 PM · Calendar
epriestley moved T7951: Write a "Calendar User Guide" and link it in the application from Backlog to Unprototype (v1) on the Calendar board.
Apr 26 2015, 2:28 PM · Calendar
epriestley closed T7918: Maniphest filters with `allProjects` in the URL no longer work as Resolved by committing Restricted Diffusion Commit.
Apr 26 2015, 2:15 PM · Maniphest
epriestley closed T7894: Give more specific error when git clone fails as Resolved by committing Restricted Diffusion Commit.
Apr 26 2015, 2:15 PM · Diffusion
epriestley added a revision to T7894: Give more specific error when git clone fails: Unknown Object (Differential Revision).
Apr 26 2015, 2:09 PM · Diffusion
epriestley created T7951: Write a "Calendar User Guide" and link it in the application.
Apr 26 2015, 1:47 PM · Calendar
epriestley moved T7943: Make "Cancel Event" disable events from Backlog to Unprototype (v1) on the Calendar board.
Apr 26 2015, 1:42 PM · Calendar
epriestley moved T7944: Add Conduit support to Calendar from Backlog to Future Work (v2+) on the Calendar board.
Apr 26 2015, 1:42 PM · Conduit, Calendar
epriestley moved T7945: Support Edges in Calendar from Backlog to Unprototype (v1) on the Calendar board.
Apr 26 2015, 1:42 PM · Calendar
epriestley moved T7946: Implement PhabricatorTokenReceiverInterface on CalendarEvent from Backlog to Unprototype (v1) on the Calendar board.
Apr 26 2015, 1:42 PM · Calendar
epriestley moved T7947: Implement PhabricatorFlaggableInterface in Calendar from Backlog to Unprototype (v1) on the Calendar board.
Apr 26 2015, 1:42 PM · Flags, Calendar
epriestley moved T7948: Implement PhabricatorMentionableInterface on CalendarEvent from Backlog to Unprototype (v1) on the Calendar board.
Apr 26 2015, 1:42 PM · Calendar
epriestley moved T7949: Implement PhabricatorApplicationTransactionInterface on CalendarEvent from Backlog to Unprototype (v1) on the Calendar board.
Apr 26 2015, 1:42 PM · Calendar
epriestley moved T7950: Support Projects in Calendar from Backlog to Unprototype (v1) on the Calendar board.
Apr 26 2015, 1:42 PM · Calendar
epriestley created T7950: Support Projects in Calendar.
Apr 26 2015, 1:38 PM · Calendar
epriestley added a parent task for T5464: Use ApplicationTransactions in Calendar: T7949: Implement PhabricatorApplicationTransactionInterface on CalendarEvent.
Apr 26 2015, 1:37 PM · Transactions, Calendar
epriestley added a subtask for T7949: Implement PhabricatorApplicationTransactionInterface on CalendarEvent: T5464: Use ApplicationTransactions in Calendar.
Apr 26 2015, 1:37 PM · Calendar