Page MenuHomePhabricator
Create Task
Maniphest T7928

Give Calendar events the "E" Monogram
Closed, ResolvedPublic
Actions

Description

Maniphest tasks are identified with "monograms", like T123. Other major objects in other systems use other letters (D for Differential revisions, F for files, etc). See Object Monograms for a full list.

Calendar has "E" reserved for it, but the UI doesn't reflect that. Particularly, these things should be supported:

  • The main URI for an event should be /E123.
  • The crumbs for an event should end in > E123.
  • The page title for an event should be E123 Event Name.
  • Typing E123 in remarkup should link to the event.
  • Typing {E123} should embed a longer reference to the event.
  • Typing E123 in global search should jump to the event.
  • Mail about the event should identify it with E123.

Note that "E" used to mean "Conpherence Thread". We've mostly moved that to "Z" to let Calendar have "E", but there may be some remnants kicking around.

Revisions and Commits

rP Phabricator
D12581rP3b226e8fb330 Calendar event monograms, part 4. Typing E{id} makes the object available in…
D12580rP75408d1381f0 Calendar event monograms, part 3. Remarkup for calendar event monograms.
D12579rP5b56aa3c6d2a Calendar event monograms, part 2. Calendar event monogram should appear in…
D12578rP7a9c1ea0b4ff Calendar event monograms, part 1. Event default URL should be install/E{id}…

Related Objects
Search...

StatusAssignedTask
 OpenepriestleyT7924 Unprototype Calendar (v1)
 ResolvedlpriestleyT7925 Calendar v1 Errata
 ResolvedlpriestleyT7926 Modernize Calendar Infrastructure
 ResolvedlpriestleyT7927 Use ApplicationSearch in Calendar
 ResolvedlpriestleyT7934 Remove "Create Event" from Calendar left nav
 ResolvedlpriestleyT7933 In list views, Calendar events link to months but should link to event detail pages
 ResolvedlpriestleyT7941 Figure out what non-list Calendar views we're going to support
 ResolvedlpriestleyT4393 Implement "Daily/Weekly" Calendar Mock
 ResolvedlpriestleyT8104 Viewer should be notified if viewed "day view" or "month view" is out of the selected query range.
ResolvedlpriestleyT8085 Multi-day events are not being drawn on Calendar day view.
 ResolvedlpriestleyT8108 Day view should be a saved query
 ResolvedlpriestleyT8114 Day view should show the day starting at 8am
 ResolvedlpriestleyT8021 Implement "All Day" events
 ResolvedchadT4392 Implement "Month" calendar mock
 ResolvedlpriestleyT8176 Users should be able to choose when their week starts, on a Monday, Sunday, or any other day.
ResolvedlpriestleyT8177 Leading and trailing days on a month view should display corresponding events, unless explicitly scoped out of the query range.
 ResolvedlpriestleyT8178 Calendar day view should show day view above the event preview sidebar on mobile.
 ResolvedlpriestleyT8184 Add week numbers to Calendar month view
 ResolvedlpriestleyT8185 Week of "today" should show a blue bar across the bottom of the row.
 ResolvedlpriestleyT8186 Re-style weekends in Calendar month view.
 ResolvedepriestleyT8187 Calendar month view event names should be capped at some width and have no text wrap.
ResolvedlpriestleyT8188 Daily lists of event in Calendar month view should also show the time an event starts.
 ResolvedlpriestleyT8189 Only Calendar month view events that viewer is invited to should be displayed in color.
 ResolvedlpriestleyT8190 Reduce min-height on mobile month days
 ResolvedlpriestleyT8191 Month day event tooltips should show start and end time only
 ResolvedchadT2898 Redesign Calendar for responsive layouts
 ResolvedlpriestleyT7943 Make "Cancel Event" disable events
 ResolvedlpriestleyT7928 Give Calendar events the "E" Monogram

Event Timeline

epriestley created this task.Apr 26 2015, 5:20 AM
epriestley assigned this task to lpriestley.
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Calendar.
epriestley added a subscriber: epriestley.
epriestley mentioned this in T7933: In list views, Calendar events link to months but should link to event detail pages.Apr 26 2015, 5:29 AM
epriestley added a parent task: T7933: In list views, Calendar events link to months but should link to event detail pages.
epriestley moved this task from Backlog to Unprototype (v1) on the Calendar board.Apr 26 2015, 6:01 AM
epriestley added a parent task: T7943: Make "Cancel Event" disable events.Apr 26 2015, 6:16 AM
epriestley mentioned this in T7924: Unprototype Calendar (v1).Apr 26 2015, 9:00 PM
epriestley added a comment.Apr 26 2015, 9:05 PM

Here are some pointers on approaching this:

The main URI for an event should be /E123.

Mostly this will involve changing the route in PhabricatorCalendarApplication, but you may have to hunt down some things which generate links to the old URI.

The crumbs for an event should end in > E123.
The page title for an event should be E123 Event Name.

Both just changes to the detail page controller.

Typing E123 in remarkup should link to the event.
Typing {E123} should embed a longer reference to the event.

Implement PhabricatorCalendarEventRemarkupRule, like DifferentialRemarkupRule. Return it from getRemarkupRules() in PhabricatorCalendarApplication (see similar example in Differential).

Typing E123 in global search should jump to the event.

Implement canLoadNamedObject() + loadNamedObjects() in PhabricatorCalendarEventPHIDType. You can look at DifferentialRevisionPHIDType for an example.

Mail about the event should identify it with E123.

This will happen later, after T5464.

lpriestley added a revision: D12578: Calendar event monograms, part 1. Event default URL should be install/E{id} instead of install/calendar/view/{id}.Apr 27 2015, 5:38 PM
lpriestley mentioned this in T7953: Give calendar events names.Apr 27 2015, 6:22 PM

The page title for an event should be E123 Event Name.

Calendar events don't seem to have names right now (unless I'm missing something?). Left a comment here, T7953, to remember to cover it when names do exist.

lpriestley added a revision: D12579: Calendar event monograms, part 2. Calendar event monogram should appear in the object crumbs and page titles..Apr 27 2015, 6:50 PM
lpriestley added a revision: D12580: Calendar event monograms, part 3. Remarkup for calendar event monograms..Apr 27 2015, 9:04 PM
lpriestley added a commit: rP7a9c1ea0b4ff: Calendar event monograms, part 1. Event default URL should be install/E{id}….Apr 27 2015, 9:26 PM
lpriestley added a commit: rP5b56aa3c6d2a: Calendar event monograms, part 2. Calendar event monogram should appear in….
lpriestley added a commit: rP75408d1381f0: Calendar event monograms, part 3. Remarkup for calendar event monograms..
lpriestley added a revision: D12581: Calendar event monograms, part 4. Typing E{id} makes the object available in global search..Apr 27 2015, 10:19 PM
lpriestley closed this task as Resolved by committing rP3b226e8fb330: Calendar event monograms, part 4. Typing E{id} makes the object available in….Apr 27 2015, 10:31 PM
lpriestley added a commit: rP3b226e8fb330: Calendar event monograms, part 4. Typing E{id} makes the object available in….
Phabricator · Built by Phacility