Page MenuHomePhabricator
Feed Advanced Search

Apr 13 2015

epriestley reassigned T7815: Conpherence threads ordering messed up; perf maybe too bad now too? from epriestley to btrahan.

Looks like you've got the other half of this.

Apr 13 2015, 7:42 PM · ApplicationSearch, Conpherence
epriestley added a revision to T7815: Conpherence threads ordering messed up; perf maybe too bad now too?: Unknown Object (Differential Revision).
Apr 13 2015, 7:33 PM · ApplicationSearch, Conpherence
epriestley added a comment to T7815: Conpherence threads ordering messed up; perf maybe too bad now too?.

Oh, well the "upside down" part at least.

Apr 13 2015, 7:31 PM · ApplicationSearch, Conpherence
epriestley claimed T7815: Conpherence threads ordering messed up; perf maybe too bad now too?.

yeah this is 100% me

Apr 13 2015, 7:31 PM · ApplicationSearch, Conpherence
epriestley closed Restricted Maniphest Task, a subtask of T3569: Make Phrequent somewhat usable, as Resolved.
Apr 13 2015, 7:00 PM · Phrequent
epriestley closed T7809: Advanced search with Order 'Date Updated' is not possible as Resolved by committing Restricted Diffusion Commit.
Apr 13 2015, 7:00 PM · Phriction
epriestley added a comment to T7811: Phacility Cluster: Apache exited on repo001.phacility.net.
  • I manually removed the restart from the logrotate script. I'll make that part of deployment when I make other deployment changes.
  • I pruned a handful of obviously-not-in-service test/demo instances and restarted the daemons to terminate their associated daemon processes, which gave us some additional headroom.
  • I manually configured 16GB of swap on the ephemeral drive. Depending on how that goes, I'll make that part of deployment. I'm not yet sure if we're better off or worse off with swap, but it's conceivable that swap may be a good fit for this workload.
Apr 13 2015, 6:10 PM · Phacility
epriestley added a revision to T7811: Phacility Cluster: Apache exited on repo001.phacility.net: Unknown Object (Differential Revision).
Apr 13 2015, 5:46 PM · Phacility
epriestley added a comment to T7811: Phacility Cluster: Apache exited on repo001.phacility.net.

I also issued a 24 hour service credit to all instances, as this was a significant unplanned service disruption.

Apr 13 2015, 5:33 PM · Phacility
epriestley added a comment to T7812: "MySQL server has gone away" when restoring a backup, needed larger packet size, undocumented.

Users might encounter this before we have a chance to run any setup checks. Probably worth adding a note to the backup/restore docs.

Apr 13 2015, 5:27 PM · Documentation
epriestley claimed T7811: Phacility Cluster: Apache exited on repo001.phacility.net.
Apr 13 2015, 5:21 PM · Phacility
epriestley added a comment to T7811: Phacility Cluster: Apache exited on repo001.phacility.net.

I think the chain of events was:

Apr 13 2015, 5:19 PM · Phacility
epriestley added a comment to T5095: Workboards looks weird when there's an unresolved setup issue.

This is also an issue in Conpherence, see T7566.

Apr 13 2015, 4:05 PM · Workboards
epriestley added a comment to T7566: Implement "Rooms" in Conpherence.

See T5095 , approximately.

Apr 13 2015, 4:04 PM · Wikimedia, Conpherence
epriestley added a comment to T7566: Implement "Rooms" in Conpherence.

Do you not see this?

Apr 13 2015, 3:43 PM · Wikimedia, Conpherence
epriestley added a comment to T7566: Implement "Rooms" in Conpherence.

Click "Search" in the left menu from within Conpherence, at the top.

Apr 13 2015, 3:27 PM · Wikimedia, Conpherence
epriestley added a comment to T7811: Phacility Cluster: Apache exited on repo001.phacility.net.

It looks like logrotate restarted Apache (by default, it does this weekly to rotate logs) and it failed to come back up (which is catastrophically bad).

Apr 13 2015, 3:00 PM · Phacility
epriestley created T7811: Phacility Cluster: Apache exited on repo001.phacility.net.
Apr 13 2015, 2:48 PM · Phacility
epriestley added a comment to T731: Allow revisions to have alternate acceptance conditions.

We plan to address every open task in Maniphest, yes.

Apr 13 2015, 2:31 PM · Restricted Project, Restricted Project, Differential
epriestley added a revision to T7809: Advanced search with Order 'Date Updated' is not possible: Unknown Object (Differential Revision).
Apr 13 2015, 2:22 PM · Phriction
epriestley added a comment to T7809: Advanced search with Order 'Date Updated' is not possible.

This is fixed by D12360.

Apr 13 2015, 2:22 PM · Phriction

Apr 12 2015

epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Unknown Object (Differential Revision).
Apr 12 2015, 11:49 PM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Unknown Object (Differential Revision).
Apr 12 2015, 11:29 PM · Typeahead, Infrastructure
epriestley added a revision to T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges: Unknown Object (Differential Revision).
Apr 12 2015, 11:29 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
epriestley added a revision to T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges: Unknown Object (Differential Revision).
Apr 12 2015, 11:02 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Unknown Object (Differential Revision).
Apr 12 2015, 11:02 PM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Unknown Object (Differential Revision).
Apr 12 2015, 10:34 PM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Unknown Object (Differential Revision).
Apr 12 2015, 9:21 PM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Unknown Object (Differential Revision).
Apr 12 2015, 8:28 PM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Unknown Object (Differential Revision).
Apr 12 2015, 8:04 PM · Typeahead, Infrastructure
epriestley updated subscribers of T7410: Allow a project's workboard to be disabled so that tagged tasks no longer show meaningless "(Backlog)".
Apr 12 2015, 7:45 PM · Projects, Wikimedia, Workboards
epriestley merged task T7808: Guests can create a workboard for a project into T7410: Allow a project's workboard to be disabled so that tagged tasks no longer show meaningless "(Backlog)".
Apr 12 2015, 7:45 PM · Policy, Projects
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Unknown Object (Differential Revision).
Apr 12 2015, 6:55 PM · Typeahead, Infrastructure
epriestley updated subscribers of T5116: Amazon SES mailer does not allow specifying endpoint.
Apr 12 2015, 12:09 PM · Mail
epriestley merged task T7807: Unable to set region of Amazon SES into T5116: Amazon SES mailer does not allow specifying endpoint.
Apr 12 2015, 12:09 PM · Mail
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Unknown Object (Differential Revision).
Apr 12 2015, 3:59 AM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Unknown Object (Differential Revision).
Apr 12 2015, 3:35 AM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Unknown Object (Differential Revision).
Apr 12 2015, 3:20 AM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Unknown Object (Differential Revision).
Apr 12 2015, 3:04 AM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Unknown Object (Differential Revision).
Apr 12 2015, 2:41 AM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Unknown Object (Differential Revision).
Apr 12 2015, 2:29 AM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Unknown Object (Differential Revision).
Apr 12 2015, 2:10 AM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Unknown Object (Differential Revision).
Apr 12 2015, 2:02 AM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Unknown Object (Differential Revision).
Apr 12 2015, 1:45 AM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Unknown Object (Differential Revision).
Apr 12 2015, 1:40 AM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Unknown Object (Differential Revision).
Apr 12 2015, 12:52 AM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Unknown Object (Differential Revision).
Apr 12 2015, 12:24 AM · Typeahead, Infrastructure

Apr 11 2015

epriestley added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

Anyway, this is somewhere in the 4-8 hour range and I don't think it needs to block on T7805. If T7805 happens first, that might reduce the estimate here by unearthing some of the common technical debt.

Apr 11 2015, 9:49 PM · Prioritized, FreeBSD, User Delight, Wikimedia, Maniphest
epriestley added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

Yeah, that could work. The v0 dropdowns don't feel too awful to me, just a bit clunky.

Apr 11 2015, 9:45 PM · Prioritized, FreeBSD, User Delight, Wikimedia, Maniphest
epriestley added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

That is, I think you still need to make a distinct "relationship type" choice somewhere along this workflow or we'll just end up with an unusable mess of a dialog at the end, especially because objects will probably eventually be able to have multiple different relationships to the same object (I think revisions already can: they can both "revert" and "depend on" another revision, although this doesn't make a huge amount of logical sense).

Apr 11 2015, 9:41 PM · Prioritized, FreeBSD, User Delight, Wikimedia, Maniphest
epriestley added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

I'm still blocking D8685 for no particular reason, that might be a good place to start. I think grouping the menu up probably makes more sense -- at least as a starting point -- than trying to build a unified object relationship dialog (which feels hard to get right, offhand).

Apr 11 2015, 9:36 PM · Prioritized, FreeBSD, User Delight, Wikimedia, Maniphest
epriestley added a comment to T7711: Formalize Paid Prioritization?.

Thinking about it, I imagine we'll never actually bill above an estimate (at least, without some kind of confirmation/approval first based on new information). We should possibly just make that explicit, although I'd like to keep things as simple as possible and there's already a remedy available: don't pay us.

Apr 11 2015, 9:21 PM
epriestley renamed T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects from Build JIRA-like "Namespaces" for putting global, default-deny walls around groups of unprivileged users to Implement top-level "Spaces" that provide policy isolation to groups of objects.
Apr 11 2015, 9:02 PM · Spaces, Policy, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

I don't expect this to meaningfully impact performance unless we end up with a really fancy animation when cards fly around.

Apr 11 2015, 8:49 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T4828: Suggest/propose possible duplicates when creating a new task.

If we did T7805 first and got a generic ApplicationSearch endpoint out of it, I'd be open to writing this as an extension CustomField and then disavowing all knowledge of it. The results UI wouldn't be custom, but maybe that's fine. We might need to pay down some infrastructure debt to let installs put this immediately underneath the "Title" field, I think a couple of the fields are still hard-coded.

Apr 11 2015, 8:46 PM · Maniphest, Wikimedia
epriestley added a comment to T4863: Allow Workboard Cards to be customized for display.

I think there are two major product questions:

Apr 11 2015, 8:42 PM · Projects, Workboards, Wikimedia
epriestley added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

Can we just change "Select" into two buttons "Blocks" and "Blocking" (or whatever language, those hurt my head)

Apr 11 2015, 8:39 PM · Prioritized, FreeBSD, User Delight, Wikimedia, Maniphest
epriestley added a comment to T7703: Policy checks may execute incompletely for non-viewers.

This seems structurally correct but is a lot of work.

Apr 11 2015, 8:23 PM · Policy, Herald, Flags
epriestley edited subtasks for T6183: Allow any user to watch projects, added: T7703: Policy checks may execute incompletely for non-viewers; removed: T4411: Adding a CC to a Maniphest Task should give View rights for that user.
Apr 11 2015, 8:20 PM · Wikimedia, Projects
epriestley removed a parent task for T4411: Adding a CC to a Maniphest Task should give View rights for that user: T6183: Allow any user to watch projects.
Apr 11 2015, 8:20 PM · Wikimedia, Policy
epriestley added a parent task for T7703: Policy checks may execute incompletely for non-viewers: T6183: Allow any user to watch projects.
Apr 11 2015, 8:20 PM · Policy, Herald, Flags
epriestley added a comment to T6183: Allow any user to watch projects.

Looking at this again, it's actually less problematic to change than I originally believed.

Apr 11 2015, 8:20 PM · Wikimedia, Projects
epriestley added a comment to T7703: Policy checks may execute incompletely for non-viewers.

Project watchers are affected in the same way; see T6183.

Apr 11 2015, 8:19 PM · Policy, Herald, Flags
epriestley renamed T7703: Policy checks may execute incompletely for non-viewers from Flagged Unknown Object to Policy checks may execute incompletely for non-viewers.
Apr 11 2015, 8:18 PM · Policy, Herald, Flags
epriestley added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

@chad, do you have any clever design ideas on this? The best thing I can come up with is sticking a dropdown in the dialog, but that feels really clunky and hard to use to me.

Apr 11 2015, 7:48 PM · Prioritized, FreeBSD, User Delight, Wikimedia, Maniphest
epriestley added a comment to T3670: Add subprojects.

I think this is roughly in the 30-60 hour range, but it's blocked by T4100 which is a large, highly-connected infrastructure task, so we can't prioritize it until that's complete. We should have a better idea of exactly what's involved here after that's finished. I'm working on T4100 now, other priorities permitting.

Apr 11 2015, 7:39 PM · KDE, Projects (v3), Restricted Project, FreeBSD, Wikimedia
epriestley updated subscribers of T4828: Suggest/propose possible duplicates when creating a new task.

I'm not totally opposed to pursuing this, but this is mostly a product question since I don't immediately see a great way to surface it in the UI. We can just dump it at the bottom of the "Create Task" screen under the preview, but I worry it will be hard to spot and use if you have to scroll all the way down the page. @chad, do you have thoughts on this in general?

Apr 11 2015, 7:36 PM · Maniphest, Wikimedia
epriestley added a comment to T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.

Very roughly I'd guess this is somewhere in the 80-120 hour range. D9204 is a very bare-bones technical implementation which attempts to show that the feature is possible, but this needs a great deal of product and integration work on top of that.

Apr 11 2015, 7:27 PM · Spaces, Policy, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

I'd guess the simple version (just a "something on this workboard has changed" notification) is about 2 hours of work, and needs to happen first anyway.

Apr 11 2015, 7:24 PM · Workboards (v3), User Delight, Wikimedia
johnny-bit awarded T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects a Love token.
Apr 11 2015, 7:24 PM · Spaces, Policy, Wikimedia
bobek awarded T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects a Like token.
Apr 11 2015, 4:30 PM · Spaces, Policy, Wikimedia
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Unknown Object (Differential Revision).
Apr 11 2015, 4:08 PM · Typeahead, Infrastructure
epriestley closed T7601: Herald edit log bypasses policy checks as Resolved by committing Restricted Diffusion Commit.
Apr 11 2015, 3:50 PM · Herald
epriestley added a comment to T7805: Use ApplicationSearch in the ObjectSelector dialog.
  • Using ApplicationSearch here is roughly 8 hours of work.
  • We'd like to ship that first and see how it feels, but if we need to provide separate ordering/filtering for queries in this dialog vs queries in general that's probably 2-3 hours.
Apr 11 2015, 3:40 PM · Restricted Project, Restricted Project, ApplicationSearch
epriestley updated subscribers of T7805: Use ApplicationSearch in the ObjectSelector dialog.
Apr 11 2015, 3:37 PM · Restricted Project, Restricted Project, ApplicationSearch
epriestley merged task T4002: The "Edit Dependencies" dialog should use the saved search architecture into T7805: Use ApplicationSearch in the ObjectSelector dialog.
Apr 11 2015, 3:37 PM · Maniphest
epriestley added a comment to T7805: Use ApplicationSearch in the ObjectSelector dialog.

Ah, thanks! I'm just going to merge that here since I think this is more complete than that one, now.

Apr 11 2015, 3:37 PM · Restricted Project, Restricted Project, ApplicationSearch
epriestley added a comment to T7732: Convoluted flow when locked out of account with only one auth provider.

It looks like we also have access to id here, which is probably (but not necessarily) the same value:

Apr 11 2015, 3:31 PM · Restricted Project, Auth
qgil awarded T7566: Implement "Rooms" in Conpherence a Love token.
Apr 11 2015, 12:40 PM · Wikimedia, Conpherence
epriestley added a project to T7805: Use ApplicationSearch in the ObjectSelector dialog: ApplicationSearch.
Apr 11 2015, 9:44 AM · Restricted Project, Restricted Project, ApplicationSearch
epriestley added a comment to T7805: Use ApplicationSearch in the ObjectSelector dialog.

We'd like to make that dropdown show your custom queries instead of a hard-coded list of fairly arbitrary defaults. (I think there's some discussion of that somewhere, but I wasn't immediately able to dig it up, and I don't think we have a task filed yet.)

Apr 11 2015, 9:43 AM · Restricted Project, Restricted Project, ApplicationSearch
epriestley added a comment to T7706: arc diff --update only uses first line of commit message.

This is 1-2 hours of work.

Apr 11 2015, 9:31 AM · Restricted Project, Restricted Project, Arcanist
epriestley added a comment to T7732: Convoluted flow when locked out of account with only one auth provider.
  • Fixing the most general problem here (T2549) is in the 20-40 hour range.
  • Fixing just T6707 is about 1 hour.
  • This could also possibly be avoided if Google has permanent primary account identifiers now (instead of email addresses), assuming that both Google accounts were really the same account and they weren't recognized as such because we use email addresses as a primary identifier. I vaguely recall this being an issue when I wrote the integration originally, but Google was evolving auth a lot around that time and there might be a more durable identifier we can use now. This is ~1 hour to check and 2-4 hours to implement if something suitable is available. This problem likely wouldn't be possible with most other OAuth providers, which do have durable identifiers (e.g., user IDs).
  • We don't need to use the username as an input to any of the auth hashing, so we could remove the "changing usernames logs you out" interaction. This happens only because all the hashes invalidate, not because there's any fundamental security goal served by invalidating sessions. This is probably 3-6 hours of work.
Apr 11 2015, 9:27 AM · Restricted Project, Auth
epriestley added a comment to T7776: Loading delta between two diffs in Differential can result in diffs for large files failing to load.

This is probably 2-3 hours of work at the outside, but I'd have to spend 30 minutes poking around with a profiler to be sure. There's a small chance it's more involved, but I believe we're just doing something needlessly inefficient when computing diffs-of-diffs and that there's nothing fundamentally hard or involved here.

Apr 11 2015, 9:18 AM · Restricted Project, Restricted Project, Differential

Apr 10 2015

epriestley edited the content of Paid Prioritization.
Apr 10 2015, 11:39 PM
epriestley closed T7711: Formalize Paid Prioritization? as Resolved.

Formalized here:

Apr 10 2015, 11:22 PM
epriestley added a comment to T7804: Implement an "Acting User" Herald condition.

Do they have "Send me an email" Herald actions? Herald is now stronger than notification preferences, after T7731.

Apr 10 2015, 11:18 PM · Restricted Project, Herald, Mail
epriestley created Paid Prioritization.
Apr 10 2015, 11:15 PM
epriestley claimed T7711: Formalize Paid Prioritization?.

I'm going to clean this up a little bit and publish it as policy and we can see where it goes. It's possible that there are essentially zero customers who are authorized to spend $150/hr without going through a contract/approval process, in which case I'll have wasted a couple of hours, but if we convert even one protracted contract negotiation over to this reduced overhead system it pays for itself immediately.

Apr 10 2015, 10:22 PM
epriestley added a comment to T7788: Support public Phriction pages.

We're potentially open to adding limited-access accounts but haven't seen much demand yet (so we aren't sure what they should look like) and there isn't a really a bright line between "limited access" and "full access" that we can identify offhand.

Apr 10 2015, 10:18 PM · Phacility Support
epriestley added a comment to T4245: Make repository URIs slightly prettier.

We can prioritize this immediately, I'll follow up in a private thread.

Apr 10 2015, 7:03 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Unknown Object (Differential Revision).
Apr 10 2015, 5:33 PM · Typeahead, Infrastructure
epriestley added a revision to T7601: Herald edit log bypasses policy checks: Unknown Object (Differential Revision).
Apr 10 2015, 5:33 PM · Herald
epriestley closed T7788: Support public Phriction pages as Resolved.

Presuming this is resolved, but let us know if you still have questions.

Apr 10 2015, 5:23 PM · Phacility Support
epriestley closed T7689: Load handles just-in-time as Resolved by committing Restricted Diffusion Commit.
Apr 10 2015, 5:18 PM · Typeahead
epriestley closed T7689: Load handles just-in-time, a subtask of T7688: Move token rendering into TypeaheadDatasource, as Resolved.
Apr 10 2015, 5:18 PM · Typeahead
epriestley closed T7802: Provide (or increase visibility of) some Maniphest documentation as Wontfix.

The task title has a "title" attribute so that you can see the entire title if the title is very long and gets truncated because you resize your screen to be too narrow to show the entire title.

Apr 10 2015, 5:08 PM · Maniphest
epriestley added a comment to T7802: Provide (or increase visibility of) some Maniphest documentation.

interface for commands is using images everywhere, instead of text

Apr 10 2015, 4:31 PM · Maniphest
epriestley added a comment to T7795: UNRECOVERABLE FATAL ERROR <<< Call to a member function getName() when using Conpherence.

No rush on swapping the handle stuff over, I figure we'll do that a piece at a time as it makes sense, sort of like the processRequest() -> handleRequest(AphrontRequest $request) change.

Apr 10 2015, 4:30 PM · Conpherence
epriestley created T7803: Implement a composite query which unifies cursor paging across subqueries.
Apr 10 2015, 4:29 PM · Typeahead, Infrastructure