Page MenuHomePhabricator

arc diff --update only uses first line of commit message
Open, Needs TriagePublic

Description

Suppose you like to write elaborate commit messages, and are committing to a branch that already has a corresponding phabricator review (created with arc diff --create). arc diff --update DXXXXX will start with a default message consisting of only the first line of each new commit, meaning any detailed explanations you wrote in a commit message are lost unless you rewrite them or go copy them from the commit log.

Ideally arc diff --update should by default preserve the full commit message

Event Timeline

dgoldstein raised the priority of this task from to Needs Triage.
dgoldstein updated the task description. (Show Details)
dgoldstein added a project: Arcanist.
dgoldstein added a subscriber: dgoldstein.

This is 1-2 hours of work.

I think the major question is just what we do if we hit a bunch of lengthy, multi-paragraph messages with remarkup in them. We'll often get a hard-to-read result if we just format them as a list. Best I can come up with offhand is to separate them with "---" so we generate a divider (and maybe make those dividers look a little nicer).

angie added a project: Restricted Project.May 20 2015, 5:14 PM
eadler added a project: Restricted Project.Aug 5 2016, 5:23 PM