Page MenuHomePhabricator
Feed Advanced Search

Apr 11 2015

epriestley removed a parent task for T4411: Adding a CC to a Maniphest Task should give View rights for that user: T6183: Allow any user to watch projects.
Apr 11 2015, 8:20 PM · Wikimedia, Policy
epriestley added a parent task for T7703: Policy checks may execute incompletely for non-viewers: T6183: Allow any user to watch projects.
Apr 11 2015, 8:20 PM · Policy, Herald, Flags
epriestley added a comment to T7703: Policy checks may execute incompletely for non-viewers.

Project watchers are affected in the same way; see T6183.

Apr 11 2015, 8:19 PM · Policy, Herald, Flags
epriestley renamed T7703: Policy checks may execute incompletely for non-viewers from Flagged Unknown Object to Policy checks may execute incompletely for non-viewers.
Apr 11 2015, 8:18 PM · Policy, Herald, Flags
qgil added a comment to T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.

Thank you, that was fast. We'll see.

Apr 11 2015, 7:39 PM · Spaces, Policy, Wikimedia
epriestley added a comment to T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.

Very roughly I'd guess this is somewhere in the 80-120 hour range. D9204 is a very bare-bones technical implementation which attempts to show that the feature is possible, but this needs a great deal of product and integration work on top of that.

Apr 11 2015, 7:27 PM · Spaces, Policy, Wikimedia
qgil added a comment to T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.

Would you be able to give a rough estimate for paid prioritization of this task?

Apr 11 2015, 7:16 PM · Spaces, Policy, Wikimedia

Apr 7 2015

cspeckmim added a comment to T4136: Project options shown in Policy control should be smarter and more powerful.

One small addition: Having the ability to assign a meaningful name to custom policies would be beneficial even without the ability to re-use elsewhere. Right now when viewing policies of items, I have a lot of "Custom Policy" displayed in summaries, properties, etc.

Apr 7 2015, 9:06 PM · Projects, Policy
cspeckmim added a comment to T4136: Project options shown in Policy control should be smarter and more powerful.

Having an ability to name and save custom policies would be useful - in my organization we need to allow administrators access to some things in order to help with troubleshooting or general management. My current options are:

  1. Re-create custom policy for items which allow Project + Admins
  2. Create new Project that includes members of both Project + Admins
Apr 7 2015, 9:03 PM · Projects, Policy
epriestley added a revision to T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects: Restricted Differential Revision.
Apr 7 2015, 12:27 PM · Spaces, Policy, Wikimedia
• nagym718 removed a revision from T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects: Restricted Differential Revision.
Apr 7 2015, 9:50 AM · Spaces, Policy, Wikimedia

Apr 2 2015

epriestley closed T7712: Files via email (some) seem not to set author or to mirror "normal" task policy as Resolved by committing Restricted Diffusion Commit.
Apr 2 2015, 8:41 PM · Policy, Wikimedia, Maniphest
epriestley added a revision to T7712: Files via email (some) seem not to set author or to mirror "normal" task policy: Restricted Differential Revision.
Apr 2 2015, 2:15 AM · Policy, Wikimedia, Maniphest

Apr 1 2015

epriestley claimed T7712: Files via email (some) seem not to set author or to mirror "normal" task policy.
Apr 1 2015, 11:40 PM · Policy, Wikimedia, Maniphest

Mar 30 2015

• sshannin added a comment to T7703: Policy checks may execute incompletely for non-viewers.

To your question @chad (although it seems like the clarity is not needed anymore), it just flags any newly created diff.

Mar 30 2015, 11:27 PM · Policy, Herald, Flags
epriestley triaged T7703: Policy checks may execute incompletely for non-viewers as Normal priority.
Mar 30 2015, 11:12 PM · Policy, Herald, Flags

Mar 22 2015

epriestley assigned T7507: Should return to previous page after clicking "OK" to lpriestley.
Mar 22 2015, 12:06 PM · Policy

Mar 21 2015

epriestley reassigned T7499: "New Build Plan" should be greyed out if not allowed by policy from joshuaspence to lpriestley.
Mar 21 2015, 11:56 AM · Policy, Harbormaster

Mar 17 2015

epriestley updated subscribers of T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.
Mar 17 2015, 3:29 PM · Spaces, Policy, Wikimedia

Mar 15 2015

witrin added a comment to T4136: Project options shown in Policy control should be smarter and more powerful.

What would be the best way to handle archived projects in this control?

Mar 15 2015, 6:44 PM · Projects, Policy
epriestley updated subscribers of T4136: Project options shown in Policy control should be smarter and more powerful.
Mar 15 2015, 6:21 PM · Projects, Policy

Mar 8 2015

epriestley added a comment to T7507: Should return to previous page after clicking "OK".

The expected behavior is for the dialog to use a workflow. In general, disabled actions should use a workflow so that dialogs show on the same page when the actions are clicked.

Mar 8 2015, 11:04 AM · Policy
chad edited projects for T7507: Should return to previous page after clicking "OK", added: Policy; removed PHUI.
Mar 8 2015, 6:01 AM · Policy
joshuaspence added a project to T7499: "New Build Plan" should be greyed out if not allowed by policy: Policy.
Mar 8 2015, 1:18 AM · Policy, Harbormaster

Mar 2 2015

epriestley closed T7095: Allow adding Policies to Custom Fields as Wontfix.

We don't plan to implement this in the foreseeable future. If you need extremely granular control over field permissions, we recommend considering other software which is better suited to heavier process-oriented workflows.

Mar 2 2015, 4:32 PM · Custom Fields, Policy

Mar 1 2015

epriestley added a parent task for T6502: Policy to define who can move cards in a workboard: T7410: Allow a project's workboard to be disabled so that tagged tasks no longer show meaningless "(Backlog)".
Mar 1 2015, 2:31 PM · Projects, Wikimedia, Policy, Workboards

Feb 18 2015

chad closed T7317: Can't view other subscribers while logged out as Resolved by committing Restricted Diffusion Commit.
Feb 18 2015, 7:11 PM · Policy, Maniphest
chad added a revision to T7317: Can't view other subscribers while logged out: Restricted Differential Revision.
Feb 18 2015, 7:07 PM · Policy, Maniphest
Krenair created T7317: Can't view other subscribers while logged out.
Feb 18 2015, 5:43 PM · Policy, Maniphest
chad added a project to T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects: Spaces.
Feb 18 2015, 4:47 PM · Spaces, Policy, Wikimedia
chad added a project to T7312: allow ANDing (or negating) rules in custom policies: Policy.
Feb 18 2015, 4:43 PM · Policy

Feb 14 2015

chad updated subscribers of T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.
Feb 14 2015, 9:12 PM · Spaces, Policy, Wikimedia
chad merged task T7262: Is there a way to list all objects a user can access? into T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.
Feb 14 2015, 9:12 PM · Policy
chad added a comment to T7262: Is there a way to list all objects a user can access?.

T3820 is the main task we feels solves this problem, and it has the added benefit it solves a problem a lot of installs would like to see. Not sure with T3820 if this is worth pursuing. Going to merge this in so at least it can be referenced (and we know to make it clear in Spaces who has access to what).

Feb 14 2015, 9:11 PM · Policy
dmorissette added a comment to T6332: Set visible/editable fields to first project policy by default when creating new tasks.

@ralph.van.etten: No we did not end up doing it, but if we do we will post here for sure.

Feb 14 2015, 5:02 PM · Maniphest, Policy
ralph.van.etten added a comment to T7262: Is there a way to list all objects a user can access?.

We are considering giving clients access to our phabricator and I want to check if the permissions/policies are set up correctly. They do not need to see everything in our phabricator.
They way I am doing this now is to login as an user with similar permissions and then just click around and see what I can access. But even then I can't be 100% sure there isn't an object somewhere with the wrong permissions.

Feb 14 2015, 7:31 AM · Policy
joshuaspence renamed T7262: Is there a way to list all objects a user can access? from Is there a way to list all objects an user can access? to Is there a way to list all objects a user can access?.
Feb 14 2015, 3:05 AM · Policy
joshuaspence added a project to T7262: Is there a way to list all objects a user can access?: Policy.
Feb 14 2015, 3:05 AM · Policy

Feb 13 2015

ralph.van.etten added a comment to T6332: Set visible/editable fields to first project policy by default when creating new tasks.

@dmorissette: I would be interested in the patch you describe. Is it available somewhere?

Feb 13 2015, 12:10 PM · Maniphest, Policy
ralph.van.etten added a comment to T6860: Allow creation of parameterized application policies.

In our installation, we have it so that if you make a task attached to a project, it sets the default visibility to that project.

Feb 13 2015, 10:24 AM · Policy

Feb 3 2015

btrahan closed T7094: Clean up T603 as Resolved by committing Restricted Diffusion Commit.
Feb 3 2015, 9:53 PM · Policy
btrahan added a revision to T7094: Clean up T603: Restricted Differential Revision.
Feb 3 2015, 9:14 PM · Policy
btrahan added a revision to T7094: Clean up T603: Restricted Differential Revision.
Feb 3 2015, 8:27 PM · Policy
btrahan added a revision to T7094: Clean up T603: Restricted Differential Revision.
Feb 3 2015, 8:23 PM · Policy
btrahan added a revision to T7094: Clean up T603: Restricted Differential Revision.
Feb 3 2015, 8:20 PM · Policy
epriestley added a comment to T7094: Clean up T603.

#1: For drydock, I'd switch it to a Query with an omnipotent user -- we can only reasonably do the checks when users create the blueprints, since systems like Drydock, Almanac, Harbormaster and Instances don't act as a real user when running background tasks. Like with Harbormaster, we'll just prevent you from creating things that affect stuff you can't act on in the first place. Drydock will have high default barriers to creation, anyway.

Feb 3 2015, 8:13 PM · Policy
btrahan added a comment to T7094: Clean up T603.

Assuming my last revision makes it through, just four issues remain... @epriestley - I've provided some details... Can you let me know what you want me to do for these last four?

Feb 3 2015, 8:05 PM · Policy
btrahan added a revision to T7094: Clean up T603: Restricted Differential Revision.
Feb 3 2015, 8:02 PM · Policy
btrahan added a revision to T7094: Clean up T603: Restricted Differential Revision.
Feb 3 2015, 7:51 PM · Policy
btrahan added a revision to T7094: Clean up T603: Restricted Differential Revision.
Feb 3 2015, 7:37 PM · Policy

Feb 2 2015

btrahan added a revision to T7094: Clean up T603: Restricted Differential Revision.
Feb 2 2015, 10:39 PM · Policy
btrahan added a revision to T7094: Clean up T603: Restricted Differential Revision.
Feb 2 2015, 10:12 PM · Policy
btrahan added a revision to T7094: Clean up T603: Restricted Differential Revision.
Feb 2 2015, 9:58 PM · Policy
btrahan added a revision to T7094: Clean up T603: Restricted Differential Revision.
Feb 2 2015, 9:56 PM · Policy

Feb 1 2015

• sameep.agarwal added a comment to T7095: Allow adding Policies to Custom Fields.

Thank you Chad, for taking this up. I am trying to understand the code, and attempting to implement this functionality.

Feb 1 2015, 4:33 PM · Custom Fields, Policy
chad renamed T7095: Allow adding Policies to Custom Fields from Allow adding custom policies to custom fields to Allow adding Policies to Custom Fields.
Feb 1 2015, 3:06 AM · Custom Fields, Policy

Jan 31 2015

chad added a comment to T7095: Allow adding Policies to Custom Fields.

It's our general recommendation to installs that have such specialized needs to use a software product better suited to the task.

Jan 31 2015, 6:32 AM · Custom Fields, Policy
chad raised the priority of T7095: Allow adding Policies to Custom Fields from Normal to Needs Triage.
Jan 31 2015, 6:23 AM · Custom Fields, Policy
chad renamed T7095: Allow adding Policies to Custom Fields from Allow adding custom policies to custom fields. to Allow adding custom policies to custom fields.
Jan 31 2015, 6:23 AM · Custom Fields, Policy
chad edited projects for T7095: Allow adding Policies to Custom Fields, added: Policy, Custom Fields; removed Maniphest.
Jan 31 2015, 6:22 AM · Custom Fields, Policy
Krenair added a comment to T6802: "Custom policy" for editing/viewing does not link to details.

Also if you press 'Custom Policy' for visibility below the title of things like Pastes, it doesn't provide a very useful message.

Jan 31 2015, 12:16 AM · Design, Policy

Jan 30 2015

btrahan added a revision to T7094: Clean up T603: Restricted Differential Revision.
Jan 30 2015, 11:46 PM · Policy
btrahan added a revision to T7094: Clean up T603: Restricted Differential Revision.
Jan 30 2015, 11:14 PM · Policy
btrahan added a revision to T7094: Clean up T603: Restricted Differential Revision.
Jan 30 2015, 11:04 PM · Policy
btrahan added a revision to T7094: Clean up T603: Restricted Differential Revision.
Jan 30 2015, 10:47 PM · Policy
btrahan added a revision to T7094: Clean up T603: Restricted Differential Revision.
Jan 30 2015, 10:35 PM · Policy
btrahan added a revision to T7094: Clean up T603: Restricted Differential Revision.
Jan 30 2015, 7:46 PM · Policy
btrahan added a revision to T7094: Clean up T603: Restricted Differential Revision.
Jan 30 2015, 7:05 PM · Policy
btrahan created T7094: Clean up T603.
Jan 30 2015, 5:37 PM · Policy

Jan 27 2015

cspeckmim added a comment to T7048: File uploaded through Mockup is not given the associated visibility/policies which the Mockup is created with..

Thank you for clarifying and sorry for the erroneous report. It was not immediately apparent to me that the header had this additional policy information. The behavior now makes sense; I had just been confused when setting the mockup policy and seeing a different one on the actual file object.

Jan 27 2015, 12:48 AM · Policy, Pholio
epriestley closed T7048: File uploaded through Mockup is not given the associated visibility/policies which the Mockup is created with. as Resolved.

If you click the policy for an object (in the header), it will explain any special policy rules that apply to the object. Here are the rules for files:

Jan 27 2015, 12:45 AM · Policy, Pholio
cspeckmim added a comment to T7048: File uploaded through Mockup is not given the associated visibility/policies which the Mockup is created with..

This is confusion over the policy.

Jan 27 2015, 12:40 AM · Policy, Pholio
epriestley added a comment to T7048: File uploaded through Mockup is not given the associated visibility/policies which the Mockup is created with..

Expectation is:

Jan 27 2015, 12:21 AM · Policy, Pholio

Jan 26 2015

chad added projects to T7048: File uploaded through Mockup is not given the associated visibility/policies which the Mockup is created with.: Pholio, Policy.
Jan 26 2015, 11:50 PM · Policy, Pholio

Jan 12 2015

nateguchi2 added a comment to T6860: Allow creation of parameterized application policies.

In our installation, we have it so that if you make a task attached to a project, it sets the default visibility to that project.

Jan 12 2015, 1:14 PM · Policy
joshuaspence added a comment to T6726: Files can recursively depend on one another, needing infinite policy checks.

Haha cool, just tested this out on my dev install and it maxes out the CPU on my VM.

Jan 12 2015, 11:07 AM · Files, Policy

Jan 11 2015

fabe added a revision to T4411: Adding a CC to a Maniphest Task should give View rights for that user: Restricted Differential Revision.
Jan 11 2015, 5:01 PM · Wikimedia, Policy

Jan 9 2015

epriestley closed T6594: Logged-out users can not access "View Raw" in comment dropdown menus, a subtask of T4830: Applications with Public permissions requiring users to login, as Resolved.
Jan 9 2015, 2:47 PM · People, Policy, Facts

Jan 8 2015

fabe added a revision to T4411: Adding a CC to a Maniphest Task should give View rights for that user: Restricted Differential Revision.
Jan 8 2015, 1:20 PM · Wikimedia, Policy

Jan 5 2015

epriestley added a parent task for T5681: Allow applications to provide custom policy rules: T6306: Add a "members of associated projects" visibility setting to repositories.
Jan 5 2015, 6:06 PM · FreeBSD, Policy

Jan 4 2015

epriestley added a comment to T6860: Allow creation of parameterized application policies.

I wasn't able to find previous discussion of this immediately -- it was buried in T5135. I updated the description to provide some context.

Jan 4 2015, 4:30 PM · Policy
epriestley added a parent task for T6860: Allow creation of parameterized application policies: T5135: Allow to change defaults for Passphrase "Visible To" and "Editable By" policies.
Jan 4 2015, 4:28 PM · Policy
epriestley added a subtask for T6860: Allow creation of parameterized application policies: T4100: Support query parameterization in typeaheads.
Jan 4 2015, 4:28 PM · Policy
epriestley renamed T6860: Allow creation of parameterized application policies from maniphest lacks secure policy setting for creation of new tasks to Allow creation of parameterized application policies.
Jan 4 2015, 4:28 PM · Policy

Jan 3 2015

joshuaspence closed T6849: With policies like "'Users A, B, C' and 'Administrators'", the 'Administrators' part is ignored as Resolved.

Closed by commit rPb3e196b69400.

Jan 3 2015, 12:52 PM · Policy
joshuaspence added a revision to T6849: With policies like "'Users A, B, C' and 'Administrators'", the 'Administrators' part is ignored: Restricted Differential Revision.
Jan 3 2015, 1:06 AM · Policy

Jan 2 2015

epriestley added a comment to T6849: With policies like "'Users A, B, C' and 'Administrators'", the 'Administrators' part is ignored.

Jan 2 2015, 9:20 PM · Policy
joshuaspence claimed T6849: With policies like "'Users A, B, C' and 'Administrators'", the 'Administrators' part is ignored.
Jan 2 2015, 9:18 PM · Policy
epriestley added a comment to T6849: With policies like "'Users A, B, C' and 'Administrators'", the 'Administrators' part is ignored.

@joshuaspence, feel free to steal this -- I'll probably get to it today but am not actively working on it.

Jan 2 2015, 9:16 PM · Policy
epriestley claimed T6849: With policies like "'Users A, B, C' and 'Administrators'", the 'Administrators' part is ignored.

I'm going to diff out a forward-fix once I dig through everything else in my queue.

Jan 2 2015, 5:44 PM · Policy
chad added a comment to T6849: With policies like "'Users A, B, C' and 'Administrators'", the 'Administrators' part is ignored.

Did you want to keep this around or OK to close?

Jan 2 2015, 5:16 PM · Policy
epriestley added a comment to T6849: With policies like "'Users A, B, C' and 'Administrators'", the 'Administrators' part is ignored.

I've reverted rP8b756 in rP7c4de, so updating should fix this.

Jan 2 2015, 2:40 PM · Policy
Krenair added a project to T6849: With policies like "'Users A, B, C' and 'Administrators'", the 'Administrators' part is ignored: Policy.
Jan 2 2015, 2:32 PM · Policy

Dec 30 2014

joshuaspence closed T6825: Return a 403 instead of a 404 when unable to view an object as Invalid.

Nevermind, on trying to replicate this I think I mistyped the URL. Although I'm not sure that I agree with a 200.

Dec 30 2014, 1:34 AM · Policy
epriestley added a comment to T6825: Return a 403 instead of a 404 when unable to view an object.

We return HTTP 200 with an explicit message:

Dec 30 2014, 12:58 AM · Policy
joshuaspence created T6825: Return a 403 instead of a 404 when unable to view an object.
Dec 30 2014, 12:31 AM · Policy

Dec 29 2014

fabe added a revision to T4411: Adding a CC to a Maniphest Task should give View rights for that user: Restricted Differential Revision.
Dec 29 2014, 11:22 AM · Wikimedia, Policy

Dec 25 2014

Krenair added a comment to T6787: Clarify UI for Objects with a non-default Policy.

I assume this task just covers visibility policy?

Dec 25 2014, 10:47 PM · Design, Policy, Wikimedia
Krenair added a comment to T6807: Edit Project page shows to logged in users but not logged out users despite public visibility.

Thank you! I'm wondering if it should be renamed for users who can't actually edit anything. Should I make a new task?

Dec 25 2014, 10:42 PM · Policy, Projects

Dec 23 2014

epriestley closed T6807: Edit Project page shows to logged in users but not logged out users despite public visibility as Resolved.

Closed by commit rPf35a38b086ab.

Dec 23 2014, 6:00 PM · Policy, Projects