Page MenuHomePhabricator

File uploaded through Mockup is not given the associated visibility/policies which the Mockup is created with.
Closed, ResolvedPublic

Description

  1. Create new Pholio Mockup
  2. Attach file to Pholio Mockup form
  3. Set visibility of Pholio Mockup to a Project
  4. Save Mockup
  5. Browse Files application to newly uploaded file.
  6. The newly uploaded file will have visibility/policy set to uploader and not to the Project set in Pholio Mockup form.

Event Timeline

cspeckmim raised the priority of this task from to Needs Triage.
cspeckmim updated the task description. (Show Details)
cspeckmim added a subscriber: cspeckmim.

Expectation is:

  • Visibility is set to uploader.
  • "Attached" tab lists mock.
  • Effective visibility is uploader + users who can view the mock.

Are you seeing behavior contrary to this?

What actual issue are you running into? Inability to see images, or just confusion over the policy?

This is confusion over the policy.

During creation of a mockup I set the visibility to Project Test. As part of this form I also upload a file. After saving the mockup, navigating through the Files application I see the newly created file and check it's visibility policy. The policy is set to me (my name). I would expect it to be set to Project Test. As it happens I'm the only member of Project Test, but I would not expect the policy for the file to resolve to me. If in the future I add more people to the Project would I need to modify the file in order for the members to see it?

I haven't yet tested this with others as it's the end of the day and the setup I noticed this on is supposed to remain private until a later time.

epriestley claimed this task.

If you click the policy for an object (in the header), it will explain any special policy rules that apply to the object. Here are the rules for files:

Screen_Shot_2015-01-26_at_4.41.12_PM.png (454×1 px, 63 KB)

Note the third rule:

Files attached to objects are visible to any users who can see those objects.

This covers files that are part of mocks, files that are dragged-and-dropped into comments, etc. You can view all the objects a file is attached to by clicking the "Attached" tab on the file detail page.

Everything here is working as expected, and the policies will apply as you expect them to. Users who are later added to the project will be able to see the mock (because they're project members) and thus able to see the file (because the file is attached to the mock).

Thank you for clarifying and sorry for the erroneous report. It was not immediately apparent to me that the header had this additional policy information. The behavior now makes sense; I had just been confused when setting the mockup policy and seeing a different one on the actual file object.