Page MenuHomePhabricator
Feed Advanced Search

Sep 30 2014

epriestley updated subscribers of T6207: Add a "Can Use Herald Rules" application permission.

I discussed the WMF situation in particular in more detail with @rush898 on IRC, and it looks like T6211 is a good path forward for the "security" case.

Sep 30 2014, 2:39 PM · Restricted Project, Policy, Herald
epriestley created T6211: Make Herald rule execution order explicitly defined.
Sep 30 2014, 2:37 PM · Herald, Wikimedia

Sep 29 2014

qgil added a comment to T6207: Add a "Can Use Herald Rules" application permission.

Today:

  • Users with access to the Phabricator host can destroy the rule with bin/remove destroy Hxxx.
  • You can deactivate the rule by disabling the user's account.
Sep 29 2014, 7:42 PM · Restricted Project, Policy, Herald
epriestley added a comment to T6207: Add a "Can Use Herald Rules" application permission.

How about this:

Sep 29 2014, 7:35 PM · Restricted Project, Policy, Herald
epriestley added a comment to T6207: Add a "Can Use Herald Rules" application permission.

We're unlikely to expand the role of administrative power here, administrators intentionally have very little power. See:

Sep 29 2014, 7:30 PM · Restricted Project, Policy, Herald
qgil created T6207: Add a "Can Use Herald Rules" application permission.
Sep 29 2014, 6:47 PM · Restricted Project, Policy, Herald

Sep 24 2014

chad updated subscribers of T655: Integrate CustomField into Herald.
Sep 24 2014, 4:19 PM · Custom Fields, Herald

Sep 19 2014

ite-klass updated subscribers of T5194: Create documentation on how to implement a custom Herald action.

Any update on this? @20after4 are you still working on this?

Sep 19 2014, 8:14 AM · Documentation, Herald

Sep 8 2014

epriestley added a subtask for T5529: Clear Flags on Accept: T5307: UX for taking actions with search results.
Sep 8 2014, 6:35 PM · Flags
epriestley added a comment to T5274: Herald Rules - Trigger when Diff content contains.

There's no technical barrier to implementing this, it just won't work some of the time since we don't have the context. I'm generally a bit skeptical about the value of these rules, but reasonable use cases aren't totally unthinkable. T5029 may make it practical more of the time.

Sep 8 2014, 6:10 PM · Herald
epriestley added a subtask for T5274: Herald Rules - Trigger when Diff content contains: T5029: Fill in missing context for low-context diffs against tracked repositories.
Sep 8 2014, 6:09 PM · Herald
epriestley renamed T5788: Support "Commit is a merge" in Herald "Commit" (post-commit) rules from Add "number of commit parents" as a field for Herald commit rules to Support "Commit is a merge" in Herald "Commit" (post-commit) rules.
Sep 8 2014, 5:47 PM · Diffusion, Herald
sophiebits added a comment to T5788: Support "Commit is a merge" in Herald "Commit" (post-commit) rules.

Correct.

Sep 8 2014, 5:47 PM · Diffusion, Herald
epriestley added a comment to T5788: Support "Commit is a merge" in Herald "Commit" (post-commit) rules.

We already have "Commit is a merge" for pre-commit. But I think you wanted it for post-commit?

Sep 8 2014, 5:46 PM · Diffusion, Herald

Sep 5 2014

jacobwalker0814 created T6040: Differential: Log Herald Changes of Blocking Reviewer Status.
Sep 5 2014, 3:18 PM · Differential, Herald

Sep 3 2014

btrahan closed T4754: "Accepted Differential Revision exists" Herald field is fairly meaningless as Resolved.

Closed by commit rP2f4addc67113.

Sep 3 2014, 10:24 PM · Herald, Differential, Diffusion
btrahan updated subscribers of T5162: Add Herald action value for content creator / author.

◀ Merged tasks: T6030.

Sep 3 2014, 8:02 PM · Herald
epriestley closed T6025: Accepted differential revision Herald rule not catching as a duplicate.

✘ Merged into T4754.

Sep 3 2014, 12:51 PM · Herald
epriestley updated subscribers of T4754: "Accepted Differential Revision exists" Herald field is fairly meaningless.

◀ Merged tasks: T6025.

Sep 3 2014, 12:51 PM · Herald, Differential, Diffusion
mbishopim3 created T6025: Accepted differential revision Herald rule not catching.
Sep 3 2014, 11:01 AM · Herald

Aug 29 2014

btrahan added a revision to T4754: "Accepted Differential Revision exists" Herald field is fairly meaningless: Restricted Differential Revision.
Aug 29 2014, 11:48 PM · Herald, Differential, Diffusion
epriestley updated subscribers of T5274: Herald Rules - Trigger when Diff content contains.

◀ Merged tasks: T5983.

Aug 29 2014, 1:57 AM · Herald
epriestley closed T5983: Allow Herald to match on any file content as a duplicate.

✘ Merged into T5274.

Aug 29 2014, 1:57 AM · Herald

Aug 28 2014

hach-que created T5983: Allow Herald to match on any file content.
Aug 28 2014, 2:36 AM · Herald

Aug 25 2014

chad triaged T5889: Allow herald rules to act on existence of auditors as Normal priority.
Aug 25 2014, 4:36 PM · Restricted Project, Audit, Herald
epriestley added a comment to T4754: "Accepted Differential Revision exists" Herald field is fairly meaningless.

The rule should identify closed revisions:

Aug 25 2014, 3:36 PM · Herald, Differential, Diffusion
hach-que added a comment to T4754: "Accepted Differential Revision exists" Herald field is fairly meaningless.

It does, but the revision is already in a closed status, so it doesn't count when performing the rule (or at least it didn't when we started using it). The exact sequence is something like this:

Aug 25 2014, 3:21 PM · Herald, Differential, Diffusion
epriestley added a comment to T4754: "Accepted Differential Revision exists" Herald field is fairly meaningless.

Does the cherry-pick not have "Differential Revision: ..." in the commit message?

Aug 25 2014, 1:06 PM · Herald, Differential, Diffusion
hach-que added a comment to T4754: "Accepted Differential Revision exists" Herald field is fairly meaningless.

It'd be nice if this could detect based on the commit content (hashing it), rather than explicitly only allowing one commit per accepted revision.

Aug 25 2014, 12:54 PM · Herald, Differential, Diffusion
epriestley assigned T4754: "Accepted Differential Revision exists" Herald field is fairly meaningless to btrahan.

Let's make this check the state the revision had before we acted on it:

Aug 25 2014, 12:05 AM · Herald, Differential, Diffusion

Aug 24 2014

epriestley added a subtask for T5039: Allow custom email addresses to file tickets against a project: T5952: Move object creation email address configuration to applications.
Aug 24 2014, 11:59 PM · Herald, Mail, Maniphest

Aug 22 2014

epriestley updated subscribers of T5854: User reporting Herald claims it triggered a build plan, but buildable and plan are nowhere to be found.

◀ Merged tasks: T4897.

Aug 22 2014, 8:12 PM · Herald, Harbormaster
epriestley closed T4897: Apply Build Plan potentially not working for commits? as a duplicate.

✘ Merged into T5854.

Aug 22 2014, 8:12 PM · Herald, Harbormaster
kparal added a comment to T5947: regression: notifications are not received at ticket creation.

Thanks, we'll try it.

Aug 22 2014, 2:28 PM · Herald
epriestley closed T5947: regression: notifications are not received at ticket creation as Resolved.

This should be fixed by 0b5fcb3 (Jul 26), which came a few days after the version you upgraded to (Jul 21). If you upgrade past that and still have issues, let us know.

Aug 22 2014, 1:23 PM · Herald
kparal added a comment to T5947: regression: notifications are not received at ticket creation.

If needed, I'll hang around in #phabricator during central European working hours.

Aug 22 2014, 8:58 AM · Herald
kparal created T5947: regression: notifications are not received at ticket creation.
Aug 22 2014, 8:57 AM · Herald

Aug 16 2014

swisspol added a comment to T5162: Add Herald action value for content creator / author.

I realize I'm still missing a piece: I thought you could do that in Herald but apparently not: adding a comment to a task when a rule matches. This would be needed to not just blindly re-assign the task to the author but also add some context.

Aug 16 2014, 3:31 PM · Herald
swisspol added a comment to T5162: Add Herald action value for content creator / author.

Very interesting, thanks much @epriestley.

Aug 16 2014, 3:12 PM · Herald
epriestley added a comment to T5039: Allow custom email addresses to file tickets against a project.

You should also be able to put #project in the email body now I think, but that's not really the same use case.

Aug 16 2014, 12:07 PM · Herald, Mail, Maniphest
epriestley added a project to T5039: Allow custom email addresses to file tickets against a project: Herald.

Tentatively, my plan for this is just to let you set several "bugs" addresses, and then use Herald rules to do all the routing. We already have "is newly created" and "content source", so we'd just have to add "receiving email address", and then you could write a rule like:

Aug 16 2014, 12:06 PM · Herald, Mail, Maniphest
epriestley added a comment to T5162: Add Herald action value for content creator / author.

This can be built as a custom Herald action (which will eventually be documented; see T5194). Drop this in src/extensions/ and then the "Reassign to author" action should be available in "Global" Maniphest Herald rules.

Aug 16 2014, 11:59 AM · Herald
epriestley added a subtask for T5162: Add Herald action value for content creator / author: T4100: Support query parameterization in typeaheads.
Aug 16 2014, 11:45 AM · Herald
epriestley added subtasks for T4484: Show Herald effects on objects in object transaction logs: T5604: Properly integrate Maniphest with Subscribers, T4896: Move Audit to ApplicationTransactions.
Aug 16 2014, 11:27 AM · Support Impact, Herald
epriestley added a comment to T4484: Show Herald effects on objects in object transaction logs.
  • Maniphest projects should work now.
  • Maniphest CCs won't work until T5604.
  • Diffusion is mostly updated but the initial interaction still isn't (T4896).
  • Haven't touched Pholio, this is still an easy fix that we just haven't gotten around to.
Aug 16 2014, 11:26 AM · Support Impact, Herald

Aug 15 2014

cburroughs created T5889: Allow herald rules to act on existence of auditors.
Aug 15 2014, 8:22 PM · Restricted Project, Audit, Herald

Aug 14 2014

CanadianBadass added a comment to T5878: Allow 'condition' to be blank/null in Herald.

Couldn't you just have "Always" as default then? Not having to do an extra action is always better than forcing your users to do so.

Aug 14 2014, 4:07 AM · Herald
epriestley closed T5878: Allow 'condition' to be blank/null in Herald as Wontfix.

Use an "Always" condition.

Aug 14 2014, 3:11 AM · Herald
CanadianBadass created T5878: Allow 'condition' to be blank/null in Herald.
Aug 14 2014, 2:11 AM · Herald