Page MenuHomePhabricator

Allow 'condition' to be blank/null in Herald
Closed, WontfixPublic

Description

When I first created a Herald Rule, I simply wanted a build plan to run on Harbormaster when a commit happens in one of our git repositories in Diffusion. The problem is, I added the trigger object to be triggered on commit, then added the action to run my build plan; I left the condition empty since I didn't need a condition.

I tested this, and much to my dismay, it didn't build on commit. After asking around, it appears that this only works if you have a condition and since my condition was empty, it didn't match. As a front-end developer, this is an extremely weird behavior. I didn't add anything nor did I even click or touch the condition part. Herald definitely needs to add the possibility of no conditions as a default.

Event Timeline

CanadianBadass assigned this task to epriestley.
CanadianBadass raised the priority of this task from to Needs Triage.
CanadianBadass updated the task description. (Show Details)
CanadianBadass added a project: Herald.
CanadianBadass added a subscriber: CanadianBadass.

Use an "Always" condition.

Couldn't you just have "Always" as default then? Not having to do an extra action is always better than forcing your users to do so.