Paths

Table of Contentst

Differential D19316

Remove dead "Service Lock" code from Almanac
ClosedPublic
Actions

Authored by epriestley on Apr 9 2018, 5:11 PM.

Tags

None

Referenced Files

	F15422024: D19316.diff
	Sat, Mar 22, 4:46 AM

	F15421959: D19316.id46219.diff
	Sat, Mar 22, 4:01 AM

	F15421902: D19316.id46221.diff
	Sat, Mar 22, 3:16 AM

	F15419964: D19316.id.diff
	Fri, Mar 21, 10:09 AM

	F15417186: D19316.diff
	Thu, Mar 20, 3:52 PM

	F15387398: D19316.id46219.diff
	Sat, Mar 15, 2:19 AM

	F15334984: D19316.diff
	Sat, Mar 8, 1:32 PM

	F15302887: D19316.diff
	Wed, Mar 5, 11:24 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T12414: Implement Almanac edit endpoints in Conduit
T13120: Plans: 2018 Week 15 Bonus Content

Commits

rP168021170218: Remove dead "Service Lock" code from Almanac

Summary

Depends on D19315. Ref T13120. Ref T12414. See PHI145. See PHI473. I want to move Almanac services to ModularTransactions but ran into this old piece of dead/unused code along the way.

Long ago, Almanac services could be individually "locked", but this didn't really work out very well. It was replaced by "Can Manage Cluster Services" in D15339 and prior changes, but not all of the old "Lock" code got cleaned up.

I don't expect to restore this feature, so clean it up now.

Test Plan

Grepped for AlmanacServiceTransaction::TYPE_LOCK, TYPE_LOCK, etc.
Grepped for updateServiceLock(), no callsites.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 9 2018, 5:11 PM

Harbormaster completed remote builds in B20043: Diff 46219.Apr 9 2018, 5:12 PM

epriestley requested review of this revision.Apr 9 2018, 5:12 PM

amckinley accepted this revision.Apr 9 2018, 5:12 PM

This revision is now accepted and ready to land.Apr 9 2018, 5:12 PM

Closed by commit rP168021170218: Remove dead "Service Lock" code from Almanac (authored by epriestley). · Explain WhyApr 9 2018, 6:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

almanac/

management/

AlmanacManagementWorkflow.php

16 lines

storage/

AlmanacServiceTransaction.php

12 lines

Diff 46221

src/applications/almanac/management/AlmanacManagementWorkflow.php

Loading...

src/applications/almanac/storage/AlmanacServiceTransaction.php

Loading...