Page MenuHomePhabricator
Differential D19324

Edit Interfaces in Almanac with EditEngine
ClosedPublic
Actions

Authored by epriestley on Apr 10 2018, 1:17 PM.
Tags
None
Referenced Files
F18799050: D19324.diff
Fri, Oct 17, 10:58 AM
F18780267: D19324.id.diff
Sun, Oct 12, 5:14 AM
F18725197: D19324.diff
Tue, Sep 30, 4:54 AM
F18721339: D19324.diff
Mon, Sep 29, 8:56 PM
F18509539: D19324.id.diff
Sep 5 2025, 3:27 AM
F18502618: D19324.diff
Sep 4 2025, 10:33 PM
F18417258: D19324.id.diff
Aug 30 2025, 11:33 AM
F18405584: D19324.diff
Aug 29 2025, 11:36 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T12414: Implement Almanac edit endpoints in Conduit
T13120: Plans: 2018 Week 15 Bonus Content
Commits
rP6ccf35f9a256: Edit Interfaces in Almanac with EditEngine
Summary

Depends on D19323. Ref T13120. Ref T12414.

Move editing to modern stuff and fix some implementation errors from D19323 (mostly copy/paste stuff).

Test Plan
  • Created and edited interfaces.
  • Tried to create/edit an interface with a bogus/empty address/port, got errors.
  • Tried to create an interface on a bogus device, got an error.
  • Tried to create an interface on a device I could not edit, got an error.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 10 2018, 1:17 PM
Harbormaster completed remote builds in B20054: Diff 46230.Apr 10 2018, 1:19 PM
epriestley requested review of this revision.Apr 10 2018, 1:19 PM
epriestley added a child revision: D19325: Use Interface transactions, not Device transactions, to destroy Interfaces.Apr 10 2018, 1:28 PM
amckinley accepted this revision.Apr 10 2018, 4:01 PM
amckinley added inline comments.
src/applications/almanac/editor/AlmanacInterfaceEditEngine.php
136

No need to cast to int here?

This revision is now accepted and ready to land.Apr 10 2018, 4:01 PM
epriestley added inline comments.Apr 10 2018, 4:51 PM
src/applications/almanac/editor/AlmanacInterfaceEditEngine.php
136

It ultimately gets forced into an int in the validation/transaction layers before being written anywhere.

Closed by commit rP6ccf35f9a256: Edit Interfaces in Almanac with EditEngine (authored by epriestley). · Explain WhyApr 11 2018, 5:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 46265

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/almanac/controller/AlmanacInterfaceEditController.php

Loading...
View Options

src/applications/almanac/editor/AlmanacInterfaceEditEngine.php

Loading...
View Options

src/applications/almanac/xaction/AlmanacInterfaceAddressTransaction.php

Loading...
View Options

src/applications/almanac/xaction/AlmanacInterfaceDeviceTransaction.php

Loading...
View Options

src/applications/almanac/xaction/AlmanacInterfaceNetworkTransaction.php

Loading...
View Options

src/applications/almanac/xaction/AlmanacInterfacePortTransaction.php

Loading...
Phabricator · Built by Phacility