Page MenuHomePhabricator

Edit Interfaces in Almanac with EditEngine
ClosedPublic

Authored by epriestley on Apr 10 2018, 1:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 29, 2:59 AM
Unknown Object (File)
Feb 27 2024, 4:00 AM
Unknown Object (File)
Feb 24 2024, 5:06 PM
Unknown Object (File)
Feb 15 2024, 7:42 PM
Unknown Object (File)
Feb 6 2024, 3:34 PM
Unknown Object (File)
Jan 3 2024, 2:00 PM
Unknown Object (File)
Dec 27 2023, 12:45 PM
Unknown Object (File)
Dec 21 2023, 11:48 PM
Subscribers
None

Details

Summary

Depends on D19323. Ref T13120. Ref T12414.

Move editing to modern stuff and fix some implementation errors from D19323 (mostly copy/paste stuff).

Test Plan
  • Created and edited interfaces.
  • Tried to create/edit an interface with a bogus/empty address/port, got errors.
  • Tried to create an interface on a bogus device, got an error.
  • Tried to create an interface on a device I could not edit, got an error.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/applications/almanac/editor/AlmanacInterfaceEditEngine.php
136

No need to cast to int here?

This revision is now accepted and ready to land.Apr 10 2018, 4:01 PM
src/applications/almanac/editor/AlmanacInterfaceEditEngine.php
136

It ultimately gets forced into an int in the validation/transaction layers before being written anywhere.

This revision was automatically updated to reflect the committed changes.