Page MenuHomePhabricator

Add skeleton code for Almanac Interfaces to have real transactions
ClosedPublic

Authored by epriestley on Apr 10 2018, 12:57 PM.
Tags
None
Referenced Files
F13046239: D19323.diff
Thu, Apr 18, 7:58 AM
Unknown Object (File)
Wed, Apr 3, 1:21 PM
Unknown Object (File)
Sat, Mar 30, 4:40 PM
Unknown Object (File)
Sat, Mar 30, 4:40 PM
Unknown Object (File)
Sat, Mar 30, 4:40 PM
Unknown Object (File)
Fri, Mar 29, 6:39 PM
Unknown Object (File)
Feb 24 2024, 4:41 PM
Unknown Object (File)
Dec 27 2023, 12:45 PM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19322. Ref T13120. Ref T12414.

Currently, AlmanacDevice has a bit of a beast of a TYPE_INTERFACE transaction that fully creates a complex Interface object. This isn't very flexible or consistent, and Interfaces are complex enough to reasonably have their own object behaviors (for example, they have their own PHIDs).

The complexity of this transaction makes modularizing AlmanacDevice transactions tricky. To simplify this, move Interface toward having its own set of normal transactions.

This change just adds some reasonable-looking transactions; it doesn't actually hook them up in the UI or make them reachable. I'll test that they actually work as I swap the UI over.

We may also have some code using the TYPE_INTERFACE transaction in Phacility support stuff, so that may need to wait a week to actually phase out.

Test Plan

Ran bin/storage upgrade and arc liberate. This code isn't reachable yet.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Apr 10 2018, 12:57 PM
amckinley added inline comments.
src/applications/almanac/xaction/AlmanacInterfaceNetworkTransaction.php
21–22

renderOldValue()/renderNewValue()

This revision is now accepted and ready to land.Apr 10 2018, 3:58 PM
This revision was automatically updated to reflect the committed changes.