Page MenuHomePhabricator

Narrowly fix web UI fatal for "almanac.service.edit" Conduit API method
ClosedPublic

Authored by epriestley on Apr 9 2018, 4:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 3, 5:19 PM
Unknown Object (File)
Mon, Apr 1, 1:36 AM
Unknown Object (File)
Sat, Mar 30, 4:49 PM
Unknown Object (File)
Sat, Mar 30, 4:39 PM
Unknown Object (File)
Sat, Mar 30, 4:39 PM
Unknown Object (File)
Sat, Mar 30, 4:39 PM
Unknown Object (File)
Sat, Mar 30, 4:39 PM
Unknown Object (File)
Sun, Mar 24, 9:37 PM
Subscribers
None

Details

Summary

See T13120. See T12414. See PHI145. See PHI473. Almanac services require a type before they can do anything, and EditEngine currently builds one with no type. We then fatal when trying to do mundane things like generate documentation.

Instead, build a generic but complete Service for documentation generation in the web UI. This is similar to the previous Drydock Blueprint change from D18849 (or some earlier diff in that series).

(You still probably can't use this method to create a service; I'll fix that in the next change.)

Test Plan
  • Viewed "almanac.service.edit" in the web UI.
    • Before: immediate fatal ("No Almanac service type "" exists!").
    • After: Page works. No claims about the method doing anything useful.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable