Page MenuHomePhabricator

Modularize Almanac Namespace transactions
ClosedPublic

Authored by epriestley on Apr 10 2018, 11:51 AM.
Tags
None
Referenced Files
F14397815: D19320.diff
Sun, Dec 22, 12:08 PM
Unknown Object (File)
Mon, Dec 9, 6:29 PM
Unknown Object (File)
Mon, Dec 9, 6:29 PM
Unknown Object (File)
Mon, Dec 9, 6:24 PM
Unknown Object (File)
Mon, Dec 9, 5:49 PM
Unknown Object (File)
Mon, Dec 9, 2:39 AM
Unknown Object (File)
Thu, Dec 5, 5:27 PM
Unknown Object (File)
Thu, Dec 5, 11:51 AM
Subscribers
None

Details

Summary

Depends on D19318. Ref T13120. Ref T12414. Move transactions for Almanac Namespaces ("name" is the only meaningful one) to ModularTransactions.

Test Plan
  • Created a new namespace.
  • Edited a namespace.
  • Tried to choose no name, an invalid name, a duplicate name, and a name in a namespace I can't edit; got appropriate errors.
  • Grepped for AlmanacNamespaceTransaction::TYPE_NAME.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable